13:00:05 <HenryG> #startmeeting neutron_db
13:00:06 <openstack> Meeting started Mon Aug 18 13:00:05 2014 UTC and is due to finish in 60 minutes.  The chair is HenryG. Information about MeetBot at http://wiki.debian.org/MeetBot.
13:00:07 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
13:00:09 <openstack> The meeting name has been set to 'neutron_db'
13:00:37 <HenryG> I have no specific agenda for today, so ...
13:00:39 <HenryG> #topic Open discussion
13:01:31 <salv-orlando> so akamyshnikova has this patch with a -2 for mark.
13:01:47 <salv-orlando> I have briefly discussed the issue with him last week and we should converge for a consensus today.
13:01:59 <HenryG> salv-orlando: Thanks!
13:02:00 <salv-orlando> I mean assuming that I find 30 minutes to talk with mark
13:02:13 <akamyshnikova> salv-orlando, great to hear that!
13:02:33 <salv-orlando> then we have another bit coming up which is removal of conditional logic for all migrations from havana to icehouse for which akamyshnikova’s patch is a requirement
13:02:36 <salv-orlando> then we’re done
13:03:02 <salv-orlando> assuming this elephant patch is approved: https://review.openstack.org/#/c/112732/
13:03:22 <salv-orlando> and no I’ve though about ways to split it but none made sense
13:03:27 <HenryG> salv-orlando: Yes, I have been trying to review that, but I keep falling asleep :)
13:03:39 <jlibosva> ah, so I'm not the only one. good
13:03:47 <salv-orlando> and also it not super hard to review if you consider most of it is old migrations being removed
13:03:55 <akamyshnikova> I'll take a look at it
13:04:05 <salv-orlando> I suggest just to check that no migration past havana has been removed
13:04:12 <HenryG> salv-orlando: It's not hard, just boring
13:04:28 <salv-orlando> rest assured that writing that code was even more boring
13:04:38 <salv-orlando> I feel asleep several times while doing it
13:05:20 <salv-orlando> anyway then we don’t have anything major re: migrations, with the exception of a few bug fixes already under review
13:05:23 <salv-orlando> is that correct?
13:05:50 <HenryG> Yes, essentially
13:06:01 <akamyshnikova> I'll check this with my test with synchronization this may help
13:06:29 <HenryG> There are a couple of things that make some impact though
13:06:49 <HenryG> 1) clean autogenerate
13:06:57 <HenryG> 2) migration unit tests
13:07:26 <HenryG> So if we can get those in we will be in very good shape
13:08:21 <akamyshnikova> I've done update of my changes, so there is two changes for merging that testing is based on
13:09:22 <HenryG> Thanks akamyshnikova
13:09:37 <salv-orlando> HenryG: clean autogenearate has merged hasn’t it?
13:09:50 <HenryG> salv-orlando: Not quite
13:09:52 <jlibosva> this one https://review.openstack.org/#/c/108700/ ?
13:10:07 <HenryG> #link https://review.openstack.org/108700
13:10:09 <jlibosva> salv-orlando: there was a conflict in HEAD file
13:10:35 <salv-orlando> HenryG:, jlibosva sorry I was confused with “removal of schema autogeneration"
13:10:36 <HenryG> And the dependent patch
13:10:55 <salv-orlando> which btw saw henry’s 9-month effort finally come to a conclusion
13:11:45 <HenryG> salv-orlando: Yeah, that was a relief. (And that one has has surprisingly little backlash over the weekend)
13:12:38 <HenryG> So FYI the schema is now always built from migrations only.
13:13:40 <HenryG> And so the 1) and 2) items above are quite urgent
13:14:13 <HenryG> The patch series for 2) starts at  https://review.openstack.org/109253
13:14:54 <HenryG> One more quick thing while we have salv-orlando's attention ...
13:15:03 <salv-orlando> #1 is not a big deal. Should merge soon. We need to start reviewing #2 and I’ll try to get attention from one more core
13:16:08 <HenryG> thanks salv-orlando
13:16:35 <HenryG> salv-orlando: about https://review.openstack.org/108690
13:17:52 <salv-orlando> HenryG: honestly I need to look back at my plugin’s code. But since it’s passing the tests I think it’s fine...
13:18:02 <salv-orlando> so I’ll go for the extreme approach
13:18:43 <salv-orlando> I’ve approved the patch. So if now the NSX plugin breaks it’s up to me to fix it and you’re not held up anymore.
13:19:12 <HenryG> salv-orlando: very noble and brave of you. Thanks!
13:19:24 <akamyshnikova> salv-orlando, thanks!
13:19:38 <salv-orlando> HenryG: as I’ve seen it has passed CI it’s mostly recognizing I was nagging about nothing.
13:20:42 <HenryG> salv-orlando: Sure, and as akamyshnikova pointed out, if a PK record is ever null then you should have seen errors before anyway
13:21:14 <HenryG> salv-orlando: So hopefully the change is a no-op
13:22:31 <HenryG> I can't think of anything else for today. The floor is open.
13:24:59 <HenryG> Thanks everyone!
13:25:11 <HenryG> #endmeeting