18:02:32 <SumitNaiksatam> #startmeeting networking_policy
18:02:32 <tbachman> SumitNaiksatam:  hi!
18:02:33 <openstack> Meeting started Thu Mar 16 18:02:32 2017 UTC and is due to finish in 60 minutes.  The chair is SumitNaiksatam. Information about MeetBot at http://wiki.debian.org/MeetBot.
18:02:34 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
18:02:34 <igordcard> hi SumitNaiksatam tbachman annak rkukura
18:02:37 <openstack> The meeting name has been set to 'networking_policy'
18:02:52 <SumitNaiksatam> #info agenda https://wiki.openstack.org/wiki/Meetings/GroupBasedPolicy#March_16th.2C_9th.2C_2nd_2017
18:03:00 <SumitNaiksatam> igordcard: hi
18:03:18 <igordcard> hi SumitNaiksatam I have time today :)
18:03:20 <SumitNaiksatam> #topic QoS patch
18:03:23 <SumitNaiksatam> #link https://review.openstack.org/#/c/426436
18:03:29 <SumitNaiksatam> igordcard: :-) thanks
18:03:41 <SumitNaiksatam> igordcard: unfortunately we have not yet merged this patch
18:03:56 <SumitNaiksatam> i noticed that ash responded on the review, but i did not get a chance to look closely myself
18:04:15 <SumitNaiksatam> igordcard: do you think what he suggested is feasible or is the reason for the failures?
18:04:29 <igordcard> point 1) is fine, that had already been corrected but then I restored an earlier patchset
18:04:49 <igordcard> point 2) is what I'm investigating now, I haven't yet fully understood
18:05:07 <igordcard> this is what I'm struggling a bit with
18:05:12 <igordcard> "Chain gets deleted as part of update ptg operation between pre and post commit call, which deletes service targets(few pts in this ptg) created by plumber."
18:05:50 <SumitNaiksatam> igordcard: right
18:06:04 <igordcard> #link http://logs.openstack.org/36/426436/4/check/gate-group-based-policy-dsvm-nfp-ubuntu-xenial-nv/c1b6dd3/logs/q-svc.txt.gz?level=ERROR#_2017-02-02_21_12_07_834
18:06:06 <SumitNaiksatam> i am not sure how that is related to your patch, but what he says is correct
18:06:43 <SumitNaiksatam> igordcard: okay, but why is that related to your changes?
18:07:06 <SumitNaiksatam> oh this one: self._disassociate_qosp_from_pt
18:07:16 <SumitNaiksatam> the PT doesnt exist
18:07:26 <SumitNaiksatam> perhaps ignore in this case?
18:07:47 <igordcard> SumitNaiksatam: because it is a Service Target (I don't really know what they are) ?
18:07:50 <igordcard> SumitNaiksatam: that PT
18:08:18 <SumitNaiksatam> igordcard: the service targets are special PTs created by the plumber for the network services
18:08:40 <igordcard> SumitNaiksatam: because for other PTs I expect all of them to stay there by the end of the operation
18:08:42 <SumitNaiksatam> igordcard: so then you can actually skip a PT if its a service_target
18:09:09 <SumitNaiksatam> igordcard: i believe the issue is that in this case the plumber is deleting the service_target?
18:09:25 <SumitNaiksatam> before you make the self._disassociate_qosp_from_pt ?
18:10:19 <igordcard> SumitNaiksatam: I believe that is ash's point but I haven't look further
18:10:26 <igordcard> #link http://logs.openstack.org/36/426436/4/check/gate-group-based-policy-dsvm-nfp-ubuntu-xenial-nv/c1b6dd3/logs/q-svc.txt.gz?#_2017-02-02_21_12_07_834
18:10:31 <igordcard> with non-ERROR lines
18:11:09 <SumitNaiksatam> igordcard: okay, i will confirm if you can always skip disassociating from the service_target
18:11:31 <SumitNaiksatam> in general i am wondering why you are even getting a reference to that if the PT is already deleted
18:11:34 <igordcard> SumitNaiksatam: are service targets nfp-only?
18:11:42 <SumitNaiksatam> igordcard: not NFP only
18:11:48 <SumitNaiksatam> igordcard: but service chain only
18:11:56 <igordcard> SumitNaiksatam: the PT is expected to be there, as I got a list of PTs associated to the PTG beforehand
18:12:07 <SumitNaiksatam> igordcard: hmmm
18:12:17 <igordcard> SumitNaiksatam: and the mapping to qos policies is from the PT
18:12:17 <SumitNaiksatam> igordcard: okay let me look at this further
18:12:27 <SumitNaiksatam> igordcard: okay
18:12:38 <SumitNaiksatam> i will investigate further
18:12:53 <igordcard> SumitNaiksatam: NSP is associated to PTG, but the mapping is actually done between the PTG's PTs and the qos policies
18:13:09 <SumitNaiksatam> igordcard: right, got it
18:13:32 <SumitNaiksatam> igordcard: okay, lets cirle back on this offline, i will dig into it
18:14:03 <SumitNaiksatam> i was really hoping to have gotten this merged by now, because we are getting close to merging the newton patches
18:14:23 <igordcard> SumitNaiksatam: but the mapping PT-QoS isn't persisted... it is created on the PT's neutron port
18:14:28 <SumitNaiksatam> igordcard: i know you are leading a few other initiatives as well, so many thanks for spending the time on this!
18:14:38 <SumitNaiksatam> igordcard: okay
18:15:22 <igordcard> SumitNaiksatam: I'll try to dedicate some time still today and test a few things now that I know about the service targets
18:15:30 <SumitNaiksatam> igordcard: okay that will be great
18:15:44 <igordcard> I was on vacation for most of this week and tomorrow is bank holiday here
18:16:01 <SumitNaiksatam> igordcard: oh okay, no worries, hope you had a good vacation :-)
18:16:30 <igordcard> SumitNaiksatam: not a leisure vacation :( but wasn't bad
18:16:31 * tbachman has to run
18:16:48 <SumitNaiksatam> igordcard: :-)
18:16:55 <SumitNaiksatam> okay moving on
18:16:58 <SumitNaiksatam> #topic Newton Sync
18:17:12 <SumitNaiksatam> so, there are several patches here
18:17:24 <SumitNaiksatam> #link https://review.openstack.org/#/q/topic:newton-sync
18:17:31 <SumitNaiksatam> rkukura: thanks for the last round of reviews
18:17:52 <SumitNaiksatam> as i mentioned offline, there is one test which fails occassionally, but i think we can ignore that for now
18:17:53 <rkukura> no problem - your commit message was really helpful!
18:18:10 <SumitNaiksatam> rkukura: okay, i didnt imagine that anyone would actually ready it :-P
18:18:15 <SumitNaiksatam> *read
18:19:07 <rkukura> I should have pointed out a couple nits in it as evidence ;)
18:19:24 <SumitNaiksatam> :-)
18:20:08 <SumitNaiksatam> typos in the commit message :-)
18:20:27 <rkukura> So I only had a couple nits and questions on the main sync patch - nothing major
18:20:48 <SumitNaiksatam> rkukura: yeah, i havent read through those but i will after this meeting and respond
18:21:11 <rkukura> ok
18:21:28 <SumitNaiksatam> rkukura: i didnt delete some of the revisit comments because i did not spend time investigating those
18:21:53 <rkukura> those were related to notifications, so I don’t think they apply anymore
18:22:03 <SumitNaiksatam> okay
18:22:38 <rkukura> I’m not sure any updates will be needed, so we need to get another reviewer looking at it ASAP
18:22:45 <SumitNaiksatam> rkukura: okay
18:22:51 <SumitNaiksatam> i just read all your comments
18:23:06 <SumitNaiksatam> could do any update, but nothing seems critically wrong
18:23:26 <SumitNaiksatam> other than that i think the cli, ui, heat patches should be good as is
18:24:04 <rkukura> I will [re]-review those - any reason we need to more the main patch before those?
18:24:16 <SumitNaiksatam> oh wait, seems annak’s CLI patch went into merge conflict since we merged kent’s patch, darn!
18:24:48 <SumitNaiksatam> rkukura: well, as long as we are going to merge the main patch soon enough, it shoud be okay
18:25:22 <SumitNaiksatam> if we merge those before the main patch, then i can update the main patch to remove the pointer to the gerrit reviews and restore the original main branch references
18:25:32 <rkukura> right
18:25:56 <SumitNaiksatam> so yeah, i am fine either way, less work if we merge those first
18:26:23 <SumitNaiksatam> annak: if you can take a quick look at the merge conflict on the CLI patch it will be good, else i can take a look at it a little later
18:26:43 <SumitNaiksatam> on -> in
18:27:13 <SumitNaiksatam> #topic Service Chaining and NFP patches
18:27:17 <SumitNaiksatam> songole is not here
18:27:22 <SumitNaiksatam> and there are a ton of patches here
18:27:31 <SumitNaiksatam> unfortunately i havent found the time to review
18:27:35 <SumitNaiksatam> will do so shortly
18:27:42 <SumitNaiksatam> #topic Open Discussion
18:27:58 <SumitNaiksatam> rkukura: igordcard annak: anything else for today?
18:28:10 <rkukura> nothing from me
18:28:45 <SumitNaiksatam> okay, thanks all for attending, back to the newton-sync :-)
18:28:46 <SumitNaiksatam> bye
18:28:56 <SumitNaiksatam> #endmeeting