18:32:13 #startmeeting Networking FWaaS 18:32:14 Meeting started Wed Mar 11 18:32:13 2015 UTC and is due to finish in 60 minutes. The chair is SumitNaiksatam. Information about MeetBot at http://wiki.debian.org/MeetBot. 18:32:15 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 18:32:17 The meeting name has been set to 'networking_fwaas' 18:32:23 Hi All 18:32:39 SridarK_, Hi 18:32:40 #info metting agenda https://wiki.openstack.org/wiki/Meetings/FWaaS#Agenda_for_Next_Meeting 18:32:47 SridarK_: hi 18:32:59 SumitNaiksatam: vishwanathj: Hi 18:33:06 hello sridar 18:33:12 badveli: hi 18:33:54 anyone wanting to share anything upfront? 18:35:04 ok 18:35:09 #topic Bugs and Docs 18:35:17 i dont believe this has changed since last week 18:35:42 we had one critical gate breaking issue show up during the week 18:35:44 #link https://bugs.launchpad.net/neutron/+bug/1428907 18:35:46 Launchpad bug 1428907 in neutron "FWaaS: Fix UT breakage in neutron-fwaas" [Undecided,Fix committed] - Assigned to Sumit Naiksatam (snaiksat) 18:35:59 that was fixed 18:36:05 SumitNaiksatam: yes, thx for that 18:36:10 np 18:36:11 SumitNaiksatam, Thanks for fixing it 18:36:23 thanks to some of the work done by pc_m in vpnaas on this front as well 18:36:34 +1 18:36:34 it made it easier to ramp up on the issue 18:36:57 the reason i brought this up is because we dont have co-gating with neutron 18:37:59 so changes on neutron can potentially break us 18:38:01 FYI: dougwig is working on pinning LBaaS to a specific Neutron hash. Looking to copying what he does, in the VPN repo. 18:38:41 Big question will be how to automate the update of that hash, so we don't have to frequently/manually do it. 18:38:56 pc_m: good point 18:39:17 pc_m: do you know if we are going to run a services’ specific gate job in neutron? 18:39:23 at least that was the plan earlier 18:39:56 SumitNaiksatam: Not sure. Seems like that is what they need to do, to be able to qualify a commit for use in *aaS. 18:40:08 pc_m: yeah 18:40:50 i also want to bring up temptest test, and pc_m will need your input, but lets do that as a separate topic 18:40:53 Having a neutorn library in PyPI would solve a bunch of the issues, but that's a way off. 18:40:58 SridarK_: badveli anything more on bugs? 18:41:07 pc_m: true 18:41:08 SumitNaiksatam: nothing from me 18:41:12 we had a similar issue for varmour ut 18:41:18 badveli: okay 18:41:23 SumitNaiksatam: Glad to help 18:41:26 i have made no progress on #link https://bugs.launchpad.net/openstack-api-site/+bug/1425658 18:41:28 Launchpad bug 1425658 in openstack-api-site "FWaaS needs WADL doc to be available in the API reference" [High,Confirmed] - Assigned to Sumit Naiksatam (snaiksat) 18:41:50 so if anyone wants to jump in, please feel free, otherwise i will follow up on this soon 18:42:04 SumitNaiksatam: I'm really interested in what you guys do there. I'll need to do the same for VPN 18:42:04 i had the patch 18:42:46 https://review.openstack.org/#/c/161424/ 18:43:22 i will rebase again 18:43:48 pc_m: sure 18:44:15 badveli: sure, give us a heads up when you do 18:44:16 okay moving on 18:44:24 ok, thanks sumit 18:44:25 badveli: sorry i have not had a chance yet - will do so soon 18:44:33 thanks sridark 18:45:01 sorry to late! 18:45:15 yushiro: no worries, thanks for joining, i know its a really odd time for you 18:45:16 #topic Firewall Router Association 18:45:28 SridarK_: seems like you made great progress 18:45:39 +1 18:45:43 SridarK_: its great to see that you have the DB upgrade script in there as well 18:46:07 pc_m: yushiro thanks for your review on SridarK_’s patch 18:46:11 SumitNaiksatam: yes - i think most things are done to the best of my knowledge (i am always afraid of jinxing myself) 18:46:16 sure np 18:46:33 pc_m: particularly keeping us honest with the oslo changes/requirements! 18:46:37 SumitNaiksatam: yes +1 thanks to pc_m and yushiro and urself for all the comments 18:46:39 :) 18:47:36 SumitNaiksatam, you are welcome. 18:47:43 SumitNaiksatam: need to resolve vendor implications with badveli: 18:47:56 SridarK_: ah i was just about to ask 18:47:58 we are okay on Freescale, vyatta 18:48:05 SridarK_: at this point are you blocked at anything? 18:48:10 and intel folks are also ok 18:48:31 SumitNaiksatam: not really - will close on these to ensure that there is no issue there 18:48:44 Also itsuro had some comments on the CLI 18:49:02 SridarK_: okay 18:49:08 is itsuro here? 18:49:19 SumitNaiksatam: but i think we will cover the usability aspects on the CLI patch 18:49:38 SumitNaiksatam: and i will clarify that we are good on the server side of things 18:50:08 SridarK_: okay good 18:50:19 SumitNaiksatam: other than that i am just doing more testing 18:50:34 SumitNaiksatam: i will cover pc_m and ur comments soon 18:51:22 Also vishwanathj: & absubram: have made great progress on the related Horizon patch 18:51:39 SridarK_: yeah i was coming to that 18:51:48 ok sorry i will shut up 18:51:51 vishwanathj: absubram: thanks so much for jumping all over that 18:52:06 SumitNaiksatam: yes a huge +1 18:52:15 SridarK_: oh no worries, i just wanted to make sure that your patch is discussed, it gets the time and attention :-) 18:52:19 SumitNaiksatam, SridarK_, absubram, thaks for the opportunity 18:52:23 :-) 18:52:51 vishwanathj: are you good so far? 18:53:45 I will still need some expert consultation from absubram, majority of the work is done, there are some bugs related to widgets showing up in GUI 18:54:05 I am sure we will be able to get through them 18:54:09 so here is my proposed course of action - 18:55:21 SumitNaiksatam, go ahead 18:55:40 if SridarK_ can post the devstack local.conf, the rest of us can go ahead and try the cli, horizon 18:55:56 SumitNaiksatam: will do 18:56:05 there is nothing new needed 18:56:10 vishwanathj: how are you functionally testing horizon? 18:56:26 we can go with q-fwaas and pull the patch in 18:56:29 thats all 18:56:57 I have some sort of testplan 18:56:58 I am only testing for the appearance of widgets in UI for now, once all the widgets appear as expected, I can use SridarK's patch with devstack 18:57:01 SridarK_: okay, nice 18:57:09 vishwanathj: good 18:57:14 Will get that out a little later today 18:57:40 SridarK_: can i request you try out a new devstack install, just so that the rest of the team know for sure that the instructions work? 18:57:44 There were 2 enhancements that absubram, SridarK_ and I talked about yesterday and am having issues with those getting displayed 18:57:53 SridarK_: or perhaps request shweta 18:57:54 SumitNaiksatam: sounds good will do that 18:58:06 SumitNaiksatam: she just got one up now 18:58:16 and was able to do basic stuff 18:58:26 but i will take that action item 18:58:31 SridarK_: sweet, perhpas she can post the instructions? 18:58:41 SumitNaiksatam: ok will do so 18:58:50 vishwanathj: ok, lets take that discussion offline 18:59:06 ok 18:59:41 vishwanathj: absubram: sorry i have not had a chance to follow up on the patch, i wanted to first test out in devstack before going to the code 19:00:13 ok 19:01:05 i dont see any activity on the CLI patch, but thats probably because i have put it in WIP: https://review.openstack.org/#/c/158118/ 19:01:21 yup 19:01:36 is it ready to be reviewed or still in WIP 19:01:47 vishwanathj: its ready to be reviewed 19:02:08 @SumitNaiksatam, SridarK_: I see i was mentioned :). I just brought up a new devstack setup and was able to successfully create a firewall with Sridar's code. I will post out instructions once i am able to test more commands. 19:02:09 currently reviewing SridarK_ 's patch, will review yours once I am done with his 19:02:15 actually it was always ready, but i put it into WIP because the server patch was not there :-) 19:02:23 ok 19:02:31 shwetaap: thanks and thanks for helping 19:02:38 shwetaap: great, thanks stopping by! ;-) 19:02:44 sure! 19:03:12 shwetaap: no really, thanks on behalf of the team here for agreeing to jump in at a short notice 19:03:38 SumitNaiksatam: she offered on 10 mins notice - so really appreciate that 19:03:43 happy to help out! 19:03:53 +1 19:03:54 shwetaap is helping SridarK_ out with the end to end testing 19:03:56 SumitNaiksatam, thank you for your information about CLI patch. I will review it. 19:04:17 yushiro: great thanks much 19:04:35 SridarK_: vishwanathj shwetaap: thanks for all the updates on this topic 19:04:40 SridarK_: anything more to discuss? 19:04:45 on this topic 19:04:49 SumitNaiksatam: no i am done thx 19:05:00 I had a question related to a patch related to Sridar's https://review.openstack.org/#/c/161881/ 19:05:27 Do I need to get this reviewed and approved prior to 19th of March as well? 19:05:50 This patch is dependent on SridarK_ patch getting approved 19:06:02 vishwanathj: ideally yes 19:06:10 and impacts our Brocade vyatta vendor code 19:06:17 vishwanathj: i am happy to include that 19:06:34 SridarK_: yeah that might be another option 19:06:40 SridarK_, that would be great, thanks 19:06:45 vishwanathj: it can be fixed in SridarK_’s patch 19:06:48 thanks SridarK_ ! 19:06:54 vishwanathj: when i first pinged - that was my intent to make sure if there is a piece to go in - would need u to bless it and i will pick it up 19:07:09 vishwanathj: no worries at all 19:07:17 SridarK_, I understand now, will sync up with you offline 19:07:24 one more thing 19:07:27 ok moving on 19:07:33 #topic FWaaS functional testing gate 19:07:46 #link https://review.openstack.org/161415 19:07:52 was merged 19:07:55 so yay on that! 19:08:04 SumitNaiksatam: oh wow 19:08:11 i did not realize that 19:08:25 and again big thanks to pc_m, it was a breeze based on his documentation 19:08:32 though i still had to bug him 19:08:36 :) 19:08:40 cool 19:08:41 pc_m: yes thanks 19:09:01 this wil enable us to actually make some changes if needed easily 19:09:07 Glad it is helping out 19:09:18 (the instructions) 19:09:21 and the neutron-fwaas patch is in review: 19:09:23 #link https://review.openstack.org/#/c/161479/ 19:09:42 vishwanathj: thanks for catching the commit message faux pas 19:09:52 SumitNaiksatam: fwaas guys to buy lunch or dinner for pc_m at Vancouver 19:10:08 SridarK_: that has already been taken as an action item@ 19:10:17 :-) 19:10:20 sweet! 19:10:32 at this rate it might have to be both, lunch and dinner 19:10:38 :) 19:10:54 sounds good! 19:10:58 +1 19:11:19 we need to get the neutron-fwaas patch merged (after i fix the commit message) 19:11:31 and then subsequently start adding functional tests 19:11:53 we would need the entire team to chip in with some tests 19:12:02 so speak up if you want to volunteer 19:12:21 SumitNaiksatam: this also has the Mar 19 deadline 19:12:28 let me finish my horizon effort and then I can chip in 19:12:33 SridarK_: good question, i dont know 19:12:39 SumitNaiksatam: if my patches see some light - i can help for sure 19:12:40 vishwanathj: sweet! 19:12:47 SridarK_: nice 19:12:56 one test per person is also good :-) 19:13:01 :-) 19:13:53 and while on that - the tempest tests seem to have merged in neutron 19:14:20 so now our patches will be voted on from here 19:14:53 SridarK_: i am not sure i understood that comment 19:15:18 pc_m: do you know if there is a requirement to move the tempest test out of tempest and into *aaS repos as well? 19:15:24 SumitNaiksatam: Do you know the review for that? 19:15:41 sorry - once we have this set up with tests - on a patch the tests are picked from neutron_fwaas and not tempest repo 19:16:18 SumitNaiksatam: My understand was they were going to move tests from tempest and get them working in Neutron, and then we (the *aaS owners) can move the *aaS ones to our repos. 19:16:47 pc_m: okay, i was looking at #link https://github.com/openstack/neutron/commit/b649712c9d0b8547cf851e2185bc72128ca8e948 19:17:00 SridarK_: yeah, along those lines 19:17:20 SumitNaiksatam: thanks! 19:17:25 SumitNaiksatam: ok thx 19:17:57 pc_m: if you do hear about an urgent need for *aaS to do this, please let us know 19:18:06 will do 19:18:07 pc_m: i do believe lbaas is going after this right away 19:18:25 SumitNaiksatam: Yeah I think so. VPN only has one module. 19:18:35 pc_m: okay 19:19:02 Need to figure out the procedure as need to move the git history. I think they have a script from Doug. 19:19:09 so in general, this is another place where we people in the team to chip in with moving the tempest tests to the neutron-fwaas repo 19:19:29 pc_m: yes, seems like that script is being referenced in the commit message 19:20:14 so we will need someone to shepherd this change 19:20:50 i wish i could tell you what exactly needs to be done, but this is a bit new to me too 19:21:33 by default, if no one picks up this item, it falls in my plate, but that is risky because i might drop the plate! 19:21:42 anyway, we can follow up on this offline 19:21:52 anything more to discuss on the gate? 19:22:07 okay moving on 19:22:23 #topic Service Objects 19:22:27 badveli: over to you 19:22:34 yes sumit 19:22:55 i am also investigating the tempest part 19:23:10 for my unit tests 19:23:15 badveli: okay good 19:23:25 badveli: anything to discuss on the service objects patches? 19:23:45 is only neutron patch sufficient as of now? 19:23:53 badveli: not sure 19:24:54 badveli: in general since the patches were posted recently, and given the rush with the other items, you might see less review activity 19:25:14 badveli: i am hoping not, but if you do, that would be the reason 19:26:01 we have 4 mins 19:26:18 badveli: anything specific you wanted to discuss with the team with regards to those patches? 19:26:36 ok thanks sumit, but if we know exactly what the reviewers are looking for, during spec review there were questions about the generality 19:26:37 badveli: a good place to ask your earlier question would be the neutron team meeting since that patch is in neutron 19:26:46 badveli: true 19:27:04 if nothing else is needed i can concentrate on the neutron patch 19:27:29 with the time i can spent 19:27:46 of my interest 19:28:18 badveli: okay 19:28:28 #topic Open Discussion 19:28:36 yamahata, is the intel team planning to get the Intel CI to vote for the McAfee NGFW driver patch? 19:28:39 we did not discuss vendor patches 19:28:46 Yes. 19:28:48 vishwanathj: right on the cue 19:28:56 It is taking time though. 19:29:08 yamahata: great, that way we can make progress with the patch 19:29:08 We are getting close 19:29:19 vishwanathj: did you have any outstanding comments on that patch? 19:29:36 SumitNaiksatam: we should also our CI voting soon 19:29:56 that was the only comment that came to my mind now, I had put off the review waiting for their CI to vote 19:30:20 vishwanathj: perhaps good to do the review anyway (to the extent you can) 19:30:27 ok 19:30:52 ok, we are out of time 19:30:58 any parting thoughts for today? 19:31:11 get SridarK_ patch merged soon 19:31:19 vishwanathj: yay to that!! :-) 19:31:29 alrighty, thanks everyone for your time today 19:31:29 :-) 19:31:37 thanks all 19:31:38 bye 19:31:40 bye 19:31:43 back to the patches and the reviews! 19:31:45 bye all! 19:31:45 bye 19:31:46 bye 19:31:51 #endmeeting