17:02:52 #startmeeting Murano Bug Scrub 17:02:53 Meeting started Mon Jun 2 17:02:52 2014 UTC and is due to finish in 60 minutes. The chair is tnurlygayanov. Information about MeetBot at http://wiki.debian.org/MeetBot. 17:02:54 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 17:02:57 The meeting name has been set to 'murano_bug_scrub' 17:03:26 i'm on a phone call but i'll be keeping an eye on this 17:03:27 o/ 17:03:29 ok, we have many new issues 17:03:57 hi 17:04:13 tnurlygayanov: where should we look for a list of bugs to be scrubbed? 17:04:22 so, we can discuss all issues assigned to the next milestone and after that discuss all new issues and assign/change the statuses 17:04:56 ok 17:05:19 suppose, we start with https://launchpad.net/murano/+milestone/juno-1 ? 17:05:20 ok, let's review all bugs, whih assigned to the next milestone: https://launchpad.net/murano/+milestone/juno-1 17:05:58 tsufiev, yes :) 17:06:23 so, we have 36 bugs for this mailstone 17:07:05 and only 10 from this list have status 'Fix Commited/Fix Released' 17:07:29 https://bugs.launchpad.net/murano/+bug/1311534 - with High priority 17:07:48 this is assigned to Sergey 17:08:12 sergmelikyan, do you plan to fix it in juno-1? 17:08:13 it was reported by me, and i'm not sure whether it is already fixed or not 17:08:48 there were a lot of issues with integration, maybe it was a consequence of some other bug... 17:09:25 tsufiev, yes, probably, need to recheck and update the description of this issue, now it is unclear 17:09:45 let's leave it as is for now. tnurlygayanov: will you try to reproduce it? 17:09:58 tnurlygayanov, no, this will not be fixed in juno-1, since we need to redesign statuses 17:10:01 yes, I will try to reproduce it 17:10:15 so... 17:10:37 this issue has High priority... 17:11:01 ok, le'ts move this issue to the next milestone, I hope this is not blocker for our release. 17:11:26 tnurlygayanov: cool, assign it on yourself then please 17:11:45 ok 17:11:50 next issue is https://bugs.launchpad.net/murano/+bug/1314106 17:12:38 sjmc7, you are the assignee 17:13:04 i'l lget this done in juno.1 17:13:04 sjmc7, any comments? :) do you plan to fix it in juno-1 release? 17:13:15 ok, cool 17:13:22 everything is ok with this issue 17:13:22 if we make environment names unique within a tenant it will fix it 17:14:00 the next one: https://bugs.launchpad.net/murano/+bug/1314180 17:14:27 sjmc7 , katyafervent2: today we discussed this issue with slagun 17:14:45 he is agreed with this idea 17:15:09 i'd mark 1314180 as "want' fix" because we're moving this functionality to the python-muranoclient 17:15:22 ativelkov: what do you think? 17:15:49 ruhe: I agree, this should not be done in manage 17:16:21 IMO, manage should do only the DB migrations 17:16:26 ok, status was chaged and I add your comments to this issue 17:16:35 does python-muranoclient import-package handle 'owned' properly? 17:16:36 tnurlygayanov: already 17:16:43 tsufiev: yes 17:16:55 ok, then won't fix indeed :) 17:16:59 as it uses the API, which natively sets the owner to the current user 17:17:10 tsufiev: even if it didn't, it should be much easier to do in python client, since it has all the needed context 17:17:31 ok, next issue is https://bugs.launchpad.net/murano/+bug/1318095 17:17:40 it is unassigned 17:17:44 ruhe, just checked whether we had to reformulate that one 17:18:33 funny one :) 17:18:38 1318095 needs volunteers 17:18:58 http://comics.soup.io/post/87788721/PNG-vs-JPG :))) 17:19:15 looks like we have hardcoded file type for logo? 17:19:39 ruhe, ok, what about 'fruit' tag? 17:19:55 *for this issue? 17:20:03 tnurlygayanov: description says that package definition had .png while actual file was .jpeg 17:20:14 yes 17:20:27 tnurlygayanov: i wouldn't mark high priority bug as a low-hanging-fruit 17:20:30 afair, the pakcage validation enforces png 17:20:34 the right solution is to validate package at the import stage 17:21:05 It should be done, and, I think, it is done 17:21:13 so, who can fix it? 17:21:24 tnurlygayanov: let's just leave it as is. i hope we'll find volunteers later 17:21:36 hm.. ok. 17:21:44 however if you import the package with manage.py, then no validation will be run 17:21:50 i think we can fix this one 17:21:55 at least validate the image 17:22:05 So, what should be the correct fix for it? 17:22:10 ativelkov: i'm going to remove the import logic from manage.py soon 17:22:13 It is validated, I believe\ 17:22:29 where we can, we should not allow invalid packages 17:22:54 https://github.com/stackforge/murano/blob/master/murano/packages/application_package.py#L163 17:23:02 This is the validation for PNG 17:23:15 ok, I will add these comments to this issue 17:23:20 next one: https://bugs.launchpad.net/murano/+bug/1321318 17:24:09 This issue related to issue with not-unique stack names for env 17:24:16 it is unasigned too 17:24:20 AFAIK it is fixed already 17:24:22 yes 17:24:23 yeah - this is related to stack name duplication 17:24:27 cool 17:24:35 It duplicates the issue on me 17:24:38 slagun, fix? 17:24:41 and there is a fix waiting for review 17:24:46 Will it work with python-heatclient from master branch? 17:25:03 https://review.openstack.org/#/c/96174/ 17:25:08 That is not the issue of python-client 17:25:24 https://bugs.launchpad.net/murano/+bug/1324094 17:25:28 ok, marked as duplicate for 1314106 17:25:54 is it ok? 17:26:11 why 1314106? 17:26:21 which id is correct? 17:26:36 1314094 17:26:44 1324094 17:27:09 hm, ok 17:27:40 next issue https://bugs.launchpad.net/murano/+bug/1267737 17:27:48 unassigned too 17:28:01 looks like it is not critical 17:28:15 yep, not critical at all 17:28:27 tsufiev, so, should we fix it in juno-1? 17:28:36 do we have time for it in j-2? 17:28:46 * j-1 i meant 17:28:46 tnurlygayanov, no need to hurry 17:28:59 I am sure we have lots or much more important UI fixes 17:29:02 i wouldn't call this one a bug. this one deserves a whole blueprint :) 17:29:05 and this is not a bug, imho 17:29:12 ruhe +1 ) 17:29:41 'won't fix'? 17:29:43 tsufiev: would you please transfer this idea to a blueprint? 17:29:51 yes, looks like a small blueprint 17:30:11 https://blueprints.launchpad.net/murano/+spec/separate-muranodashboard-config we have one already 17:30:16 so let's approve this fix https://review.openstack.org/#/c/95102/ 17:30:39 katyafervent2: with a -1 from tsufiev? :) 17:30:39 if we moved 1267737 for j-2 17:31:10 please, read comments and do not ignore patches with -1, but this is a separate story) 17:31:18 it is -1, not -2 17:31:23 tnurlygayanov: i think you can close 1267737 with a comment about corresponding BP 17:31:29 i'll close my eyes while you're approving it :) 17:31:39 ruhe, ok, thank you 17:32:27 what's next? 17:32:40 https://bugs.launchpad.net/murano/+bug/1285024 17:33:25 iyozhikov, ping 17:33:33 iyozhikov, what abou this issue? 17:34:05 one more bug, which lloks like a bp 17:34:22 / looks 17:34:32 tnurlygayanov: i think this bug is for Fuel, not for Murano 17:35:09 I will descuss this issue with Igor personaly. go to the next 17:35:14 as I know Fuel use syslog daemon, without any additional set-up dashboard should use the same logger as used by horizon 17:35:15 and i think that i've asked iyozhikov already to move this bug-report to Fuel space 17:35:51 next is https://bugs.launchpad.net/murano/+bug/1285624 17:36:07 dteselkin, what about this issue? 17:36:12 I'll check it and fix in next few days 17:36:22 As I'm currently working on MsSQL 17:36:25 cool 17:36:43 next https://bugs.launchpad.net/murano/+bug/1311755 17:37:24 hm, we already moved this bug from previous release to juno-1 17:37:36 oo, this was me 17:37:56 we absolutely need to make sure the engine can report errors back to the API 17:38:09 yes, it is important 17:38:13 especially since at the moment, the heat and murano records can be inconsistent 17:38:39 * ruhe rised importance to high 17:39:25 I am not sure that we will fix this during juno-1. We have only 10 days left 17:39:48 we need to at least have a good idea of how to handle it 17:39:56 This was fixed. At least partially. If unhandled exception occurs during deployment API receives notification 17:39:57 i.e. through the RPC path 17:40:41 slagun, yeah, it is mentioned in comments to the issue. We need to redesign a little bit this part of interaction between API and Engine 17:40:59 slagun, how do you think - you can fix this during juno-1? 17:41:05 slagun, could you please write the comments to this bug about this fix and how we can implement this is in future? 17:41:09 as part of debuggability initiative? 17:42:07 What exactly is left to do in that bug? 17:42:38 slagun looks like we don't know 17:42:55 Add error state for environment? And rewrite part of the code that is responsible for sending notifications in case of exception. 17:42:55 and we should perform some investigation on this 17:42:59 Me either. Need to think on that 17:43:43 slagun: will you please take an AI to work on this bug to figure out next steps? 17:43:46 slagun, https://github.com/stackforge/murano/blob/master/murano/common/engine.py#L73 17:44:02 so, ok, I will add the comments to the description of this issue 17:44:03 ok 17:44:49 slagun: thank you! 17:45:21 slagun, I will assign this issue to you and will keep juno-1 mailstone 17:45:46 next https://bugs.launchpad.net/bugs/1316786 17:45:56 unassigned too 17:46:35 looks like it is problem with Murano PL 17:46:49 there is a BP for that 17:46:58 thats part of what I'm doing 17:47:05 Yep, I would not say it is a bug 17:47:17 but there is a lot of room for improvement, sure 17:47:21 so, can you please send the lin to bp and I will close this issue? 17:47:50 No need to closing issue, I believe, we may track them in parallel. 17:48:02 https://blueprints.launchpad.net/murano/+spec/muranopl-stack-traces? 17:48:09 Otherwise BP need to be updated with details from this issue 17:48:16 ok 17:48:16 it's not a bug in the true sense of the term, but it makes debugging issues extremely difficult 17:48:25 Give me a minute to find 17:48:31 so, I can't edit this bp 17:48:46 https://blueprints.launchpad.net/murano/+spec/throw-correct-exception 17:48:57 i cna link to it 17:49:07 ok, thank you! 17:49:42 next issue https://bugs.launchpad.net/murano/+bug/1325371 17:50:31 katyafervent2: that's probably yours 17:50:56 ok 17:51:02 assigned. 17:51:14 next https://bugs.launchpad.net/murano/+bug/1286085 17:51:27 I suggest to move it to another mailstone 17:51:45 katyafervent2: do you think that you can handle it in juno-1? 17:51:57 because we have many other critical issues 17:52:06 tnurlygayanov: +1 17:52:33 ruhe, not sure, but let's keep it for j-1 17:52:45 ok, next one https://bugs.launchpad.net/murano/+bug/1292009 17:53:13 katyafervent2, what about this issue? 17:53:30 IMHO this is invalid 17:53:34 do we have an agreement on this one? sergmelikyan and katyafervent2 had several heated discussions about this bug :) 17:53:35 the importance is Low.. 17:54:12 Murano ids have nothing to do with GUID format 17:54:15 I want to fix it too 17:54:43 seems like we need more time to discuss our approach with IDs 17:54:47 This should not be changed 17:54:51 ruhe, I am not sure :) We need to re-discuss it again :) There should be distinctive approach to each usage of ID generation. 17:55:05 I don't know, I guess we agreed that we will not change anything 17:55:57 let's create another meeting for that discussion?) 17:56:05 :) 17:56:05 katyafervent2: +1 17:56:20 so, let's discuss it on the separate meeting :) 17:56:40 all comments were added 17:56:43 i don't think we need a separate meeting for this. we can take it to ML or to our weekly meeting 17:56:54 next one https://bugs.launchpad.net/murano/+bug/1295573 17:58:03 looks like a no-critical bug with API responces statuses 17:58:30 sergmelikyan, do you have time to fix it in juno-1? 17:59:40 sure 18:00:09 hm... looks like this is the end of our meeting today... because it is 10 PM in Moscow. We can continue tomorrow 18:00:36 tnurlygayanov: can we? we'll have weekly meeting at the same time 18:01:37 what if we will continue our bug scrub meeting before the weekly meeting? at 16:00 UTC? (comunity meeting will be at 17:00-18:00 UTC) 18:01:43 sjmc7: will you guys be able to join at 4PM UTC? 18:01:51 i guess it's very early for you 18:01:57 hm 18:02:00 when 18:02:02 tomorow 18:02:09 i willtry 18:02:16 sjmc7: tomorrow, 4PM UTC 18:02:26 or we can move it to another day 18:03:14 How many bugs are left to triage? 18:03:25 May be we can continue today? 18:03:35 sergmelikyan: uh oh 18:03:50 sergmelikyan: what about life? :) 18:04:05 sergmelikyan we need to dicuss also all 'new' bugs 18:04:12 sergmelikyan: more then a half 18:05:08 ok, what about the 4 June, 5:00-6:00PM UTC? 18:06:04 (the same time as todays meeting) 18:06:14 + 18:06:14 tnurlygayanov: i'd say 4:00-6:00 PM UTC 18:06:24 we obviously need more time 18:06:42 ruhe, ok, I agree. 18:07:04 ah, dang it. we have internall meeting till 5-30PM UTC 18:08:15 ok. let's agree on 4:00 to 6:00PM 18:08:24 ok 18:08:29 Thanks for the meeting! 18:08:42 bye 18:08:58 #endmeeting