17:03:11 #startmeeting murano 17:03:13 Meeting started Tue Jun 24 17:03:11 2014 UTC and is due to finish in 60 minutes. The chair is ruhe. Information about MeetBot at http://wiki.debian.org/MeetBot. 17:03:14 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 17:03:16 o/ 17:03:17 The meeting name has been set to 'murano' 17:03:19 o/ 17:03:33 hi there 17:03:39 o/ 17:03:53 ativelkov, sergmelikyan: i see you were sitting on the edge of the chair waiting for the meeting to start :) 17:03:57 o/ 17:04:01 hi 17:04:04 hello 17:04:09 :) 17:04:10 Hi 17:04:17 hi everyone! 17:04:18 Hi 17:04:22 #link https://wiki.openstack.org/wiki/Meetings/MuranoAgenda#Agenda 17:04:23 ruhe: that's called just-in-time driving ) 17:04:40 #topic action items review 17:04:52 katyafervent to investigate how unit testing is done in Django (and perhaps use that approach for muranodashboard unit testing); consult with drupalmonkey if needed 17:05:07 Hi guys 17:05:28 and according to discussion we had yesterday with sjmc7 investigation already started 17:05:30 hi 17:05:55 there are a lot of tools to test Django applications 17:06:22 ruhe - the openstack_dashboard helpers give a lot of functionality 17:06:27 i don't think we should reinvent the wheel 17:06:31 @ruhe @katyafervent yes, i'm about to commit some test code for muranodashboard that sjmc7 and i worked on 17:06:34 such as https://docs.djangoproject.com/en/1.7/topics/testing/tools/ and http://effectivedjango.com/forms.html 17:06:46 sjmc7: agree 17:07:03 katyafervent: seems like drupalmonkey outperformed you here ;) 17:07:19 we just need to create a test plan or smth like that to define what areas should be tested 17:07:36 test ALL the things! 17:07:59 drupalmonkey, should we split muranodashboard into 2 parts, as horizon :)? 17:08:15 ok. drupalmonkey it would be nice a have a blueprint with a brief description of your plan 17:08:55 we're not planning to write exhaustive tests for existing functionality - this was just to make a start 17:09:02 we should cover views, forms and probably templates 17:09:59 Does anybody have something to add on that topic? 17:10:03 sjmc7: ok. if it's just a start 17:10:09 ruhe: there was a nice plan - test ALL:) 17:10:36 retroactively writing tests is not usually very helpful; it makes more sense to add them as new code is written 17:10:44 i want to get some examples in place 17:10:47 to make that easier 17:10:59 sjmc7, drupalmonkey: thanks for starting this! 17:11:25 next AI: akuznetsova_ create a document explaining how to run, debug and fix selenium tests 17:11:33 akuznetsova_: ping 17:11:38 Yes 17:11:54 akuznetsova_: did you create that document? 17:12:01 I did, I update articles in wiki 17:12:15 can you share the link? 17:12:19 akuznetsova_: will you port this document to developer documentation? 17:12:27 Not yet 17:13:22 akuznetsova_: can you share link to the document? 17:13:23 where it has to be? In murano.readthedocs? 17:14:14 yes. you'll need to send a patch to stackforge/murano. we keep developer docs here http://git.openstack.org/cgit/stackforge/murano/tree/doc/source 17:15:52 #link https://wiki.openstack.org/wiki/Murano/TestsDocumentation 17:16:09 Yes, that' s it 17:16:12 that's where documentation for running selenium tests is published for now ^^ 17:16:35 #action port instructions to run selenium tests to murano developer docs 17:16:42 let's move to the next topic 17:17:02 #topic state of "improve testing" 17:17:24 i kept this item in the agenda to discuss how everyone feels about our current progress 17:18:24 for instance, one of the most important items - "run real deployment tests in CI" is not finished yet 17:18:52 for me is hard to say, had no chance to spent much time writing tests - buy I support our decision to bundle any change with tests 17:18:53 sergey murashov promised that it should work starting from tomorrow :) 17:18:59 *but 17:19:49 sjmc7: Hi. I have a small demo around CF integration. 17:19:55 sergmelikyan: right. and since we already have a base for API tests and for DB migration, we need to enforce every patch affecting those components to have corresponding tests 17:19:59 sjmc7: Are you interested to see it? 17:20:12 gokrokve - yes, but probably not today 17:20:29 sjmc7: Cool. Ping me once you are ready. 17:21:04 sjmc7: since you started this initiative (improve testing), what do you think about our current state in testing? 17:21:15 i keep finding broken things :) 17:21:31 i think if we start making sure there are tests with new code, that's a good direction 17:22:01 +! 17:22:03 +1 17:24:25 i hope everyone said "+1" in their mind. finding broken things is dissapointing 17:25:04 let's move to the next topic 17:25:07 #topic post-deploy information 17:25:14 #link https://blueprints.launchpad.net/murano/+spec/post-deployment-information 17:25:16 i only added this today, so apologies 17:25:48 this can be a short discussion if anyone has initial questions or problems, but otherwise can talk about it later 17:26:18 this one looks like a very good addition from user experience perspective 17:26:57 yeah.. i think we have to do something to make it a bit more user-friendly 17:27:06 stanlagun: did you have a chance to look at this BP? 17:27:24 +1 ащк щгезгеы 17:27:31 now we deployment history, may be it should be extended somehow 17:27:31 +1 for outputs 17:27:34 Sorry 17:27:36 ruhe, not yet. Thanks for pointing out 17:27:43 gokrokve, I don 17:27:52 We have something like that in Tomcat app 17:27:56 't think that we need something so explicit 17:28:20 Via reporter Tomcat shows somethig like app available http://ip:port/folder 17:28:25 We can map template + data model + yaql expressions 17:28:34 I agree that we need something more explicit 17:28:51 i don't really mind how we do it. i would prefer it to be more than just a brief message in the reporter 17:29:03 Agree 17:29:20 sjmc7, your bp and that one https://blueprints.launchpad.net/murano/+spec/dynamic-fields-on-service-details might target the same Component page 17:29:22 Most ambigious and hard part is how to show this to the user 17:29:30 i'll put some more detail in the BP then we can argue about it 17:29:33 What to do in multi-app envs 17:29:57 display all of the information, sergmelikyan 17:30:04 tsufiev - i hadn't seen that 17:30:12 but yeah, maybe some crossver 17:30:14 We can also add HOT output auto render in Murano app which consist of only HOT. 17:30:41 i'll put some more detail in the BP, then we can argue about it 17:31:04 sjmc7, but it's ok to have think about it from the over side 17:31:11 ? 17:31:39 sjmc7, sure! 17:32:00 just pit my comments in https://blueprints.launchpad.net/murano/+spec/post-deployment-information 17:32:05 *put 17:32:22 sjmc7, the BP I mentioned is more about how that info is shown (in terms of code), while yours is more about UX 17:33:35 we've been asked to provide the behavior 17:33:49 so, it seems that everyone agrees on direction (i'm going to set direction=approved) and we need more time to agree on definition (specfication) 17:34:08 sjmc7: do you need this to be done in juno? 17:34:27 ruhe - probably, yes. we'll do it if we need to do it 17:34:35 sjmc7: i'll rephrase. to what milestone would you like to target this BP? 17:34:55 probably j3 for now 17:34:59 ok 17:35:27 anything else on this topic? 17:36:16 #topic current state of error handling for engine 17:36:46 this one is proposed by sjmc7 17:37:24 yeah... there are still some cases where exceptions are not clear from deoployments. i wasnt's ure if stanlagun is still working on this or if i should file individual bugs 17:37:43 I think it is ok to create specific bugs, Stan is working on exceptions while covering MuranoPL and Engine with tests, but all found places may be fixed right know 17:37:54 k 17:38:02 I'm working on it. Most of exceptoins in DSL code will be improved alongside commits with tests 17:38:04 *now 17:38:29 But we can't be sure that you will not miss something - so opening bugs is okey 17:38:50 i think ) 17:38:54 i agree, it'll be helpful to track those problems in bugs 17:39:06 I suggest wait several days and then start creating bugs for what is missing 17:39:51 stanlagun: how much is "several"? :) 17:40:28 till this weekend 17:41:26 ok, sound like a good plan 17:42:30 #agreed start filing bugs for engine errors starting from the next week 17:42:45 anything else on this topic? 17:43:37 #topic open discussion 17:43:43 I wanted to discuss https://bugs.launchpad.net/murano/+bug/1319404 I was hoping to get consensus on "services" vs "applications" vs "components" 17:43:44 Launchpad bug 1319404 in murano "Use 'applications' instead of 'services' in the environment description" [Medium,Confirmed] 17:45:07 ankurrr: by the way. i wanted to reply on your question from yesterday. i've included DB sync instructions in the commit message. to populate DB you'll need to run "murano-db-manage upgrade" 17:45:47 ruhe: ah, yes. I ended up in the docs yesterday and was able to run murano-db-manage. thanks 17:46:00 ankurrr, we decided to leave services in env description to reduce amount of changes that going to break backward compatibility. I think we need to start working on specification for v2 API and freeze changes in current one. 17:46:17 ankurrr, afaik, 'services' was dropped because it reminded of windows 17:46:42 I think we can finish specification in J cycle and start implementing in K 17:47:03 sergmelikyan tsufiev: ok, but should we keep services, or should we change to "applications" or "components"? 17:47:07 sergmelikyan, agree, easier to start from scratch than to redo a lot of things in current api 17:47:15 tsufiev, yep, 'services' is part of terminology from previous era :) 17:47:24 is this no longer a bug then? 17:47:51 and maybe just change it in v2? 17:47:55 sjmc7, maybe change milestone to K? 17:48:04 for me services reminds on SOA applications, web-services etc, not Windows 17:48:21 tsufiev, I think we don't have an issue with changing many things by itself, current API is public one, we can't just change it 17:49:18 Even with v2 API implemented we are going to have 2 cycles deprecation period 17:49:42 And ideally support v1 even further 17:49:43 in V2 there will be no predefined name in API because it must match that in MuranoPL (currently "applications") 17:50:00 so that means we'd need to maintain some sort of backward compatibility even if we did change it 17:50:01 sergmelikyan, agree, 'you can not just rename it' :) 17:50:06 I guess we can rename everything at least in dashboard from servicies to applications 17:50:15 V1 and V2 can work in parallel. Like in Heat 17:50:28 stanlagun, +1 17:50:37 So let's refocus on original question :) 17:50:39 katyafervent, wasn't that already done? 17:50:50 ruhe, what is your suggestion? ) 17:51:02 *to original question 17:51:53 sorry, i was distracted by a very dramatic game, Urugway - Italy 17:51:54 * sergmelikyan did not practiced English enough since summit :( 17:52:10 ruhe, they going to loose 17:52:35 both of them? 17:52:52 No, one of the team ) But I don't know which one 17:53:00 ok. this ticket should be marked as not a bug 17:53:04 and it can get reworked in v2 17:53:13 or wont fix or something 17:53:18 ok, sounds good 17:53:31 sjmc7: thanks for summarizing it :) 17:54:12 tsufiev, not everywhere, inside code we still have services 17:54:25 #agreed close 1319404 as won't fix and work on it in v2 api 17:54:38 anything else for today? 17:56:12 one more minute to close the meeting 17:57:18 thanks everyone for attending this meeting 17:57:41 #endmeeting