15:01:14 #startmeeting mistral 15:01:15 Meeting started Mon Jun 4 15:01:14 2018 UTC and is due to finish in 60 minutes. The chair is d0ugal. Information about MeetBot at http://wiki.debian.org/MeetBot. 15:01:16 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 15:01:19 The meeting name has been set to 'mistral' 15:01:22 Who is around today? 15:01:28 here 15:01:34 opetrenko_: Hey 15:01:45 pgaxatte: did you manage to answer your question? 15:01:59 what question? 15:02:27 d0ugal: I think so :) I used "openstack workflow execution update -s CANCELLED" 15:02:48 opetrenko_: How to stop a running execution 15:02:52 pgaxatte: yup, that is correct 15:03:10 We should document that and/or make a more obvious way to do it. 15:04:16 yeah it feels like I'm just setting a flag somewhere in DB and that this command will not actively stop anything 15:04:20 but it seems it does 15:04:38 New topic for new documentation 15:05:01 Probably we should ask as much people as we can, what do they need in docs 15:05:09 also I noticed the execution delete does not work in this case 15:05:23 and the --force just returns an error 15:05:58 pgaxatte: In what case? What was the error? 15:06:04 opetrenko_: Agreed, it would be good to get feedback. 15:06:19 openstack workflow execution delete --force 5022e724-e582-4394-9b06-2271b0ea1fa5 15:06:19 Unknown argument: "force" 15:06:19 Unable to delete the specified execution(s). 15:06:28 the workflow was still running 15:06:45 pgaxatte: Which version are you using? --force is quite new. 15:07:08 Yeah, because now There is only my opinion about what should be in it, but we can find minimal required topic for everyone 15:07:10 opetrenko_: I added the Mistral core reviewers to your patch to try and get more eyes on it. 15:07:36 3.14.0 for openstack cli, 3.5.0 for mistralclient and 5.2.2 for mistral infra 15:07:54 well, thats cool but not really 15:08:08 we need opinion from other users 15:08:10 pgaxatte: So you have --force in mistralclient, but not in mistral server. 15:08:24 d0ugal, reading back my terminal, I got the exact same error without --force 15:08:25 opetrenko_: Yes, of course, but it is a start. 15:08:55 pgaxatte: Right, I guess you have hit a bug somewhere. I would check the mistral logs for errors 15:10:47 opetrenko_: I don't have a good way to contact users and get their feedback. 15:12:25 d0ugal: the bug is client-side since I don't give the --force but it still appears in the URL called 15:12:38 pgaxatte: aha, damn 15:12:46 that is bad 15:13:08 pgaxatte: If you downgrade to mistralclient 3.4.0 that will solve it 15:13:22 I'm going to open a bug for this, we need a fix. Other people will hit this soon 15:14:12 by the way, the execution delete, is just supposed to remove it from the database like the expiration processus would do, right? 15:14:29 pgaxatte: yup 15:14:34 if the workflow is still running, would it kill it? 15:14:42 pgaxatte: but the expiration wont delete running workflows 15:14:44 pgaxatte: yes 15:14:53 ok 15:15:24 there is no automatic expiration of any kind for a running workflow? 15:15:33 pgaxatte: No, I don't believe so 15:15:46 https://bugs.launchpad.net/mistral/+bug/1775027 15:15:48 Launchpad bug 1775027 in Mistral "Execution deletion doesn't work if you use mistralclient 3.5.0 with Queens or earlier" [Critical,Confirmed] 15:16:47 I'll take a look into this bug tomorrow. 15:17:03 I suspect some of my colleagues will hit it soon :) 15:17:10 pgaxatte: ^ 15:17:47 d0ugal, ok great :) 15:18:02 I think I found it 15:18:06 Toure Dunnon proposed openstack/mistral-extra master: Add Ansible actions to Mistral https://review.openstack.org/514360 15:19:55 d0ugal: https://git.openstack.org/cgit/openstack/python-mistralclient/tree/mistralclient/api/v2/executions.py#n122 15:20:41 pgaxatte: yup, exactly 15:21:06 pgaxatte: If you like you can propose a fix - we just need to make sure the parameter isn't included unless it is set to true. 15:21:11 force is always included in the url parameters 15:21:21 exactly 15:21:27 I can try to submit that :) 15:21:31 Great 15:21:36 If you don't get a chance I can do it tomorrow 15:30:42 Pierre Gaxatte proposed openstack/python-mistralclient master: Fix force parameter being always added to URL in execution delete https://review.openstack.org/572136 15:32:47 d0ugal: let me know if the fix is ok with you, if needed I can take another look tomorrow 15:33:19 pgaxatte: I think that looks pretty good. 15:33:35 i tried running tox but it fails even on master 15:33:41 I'll try and get apetrich to review it too - he worked on this feature. 15:33:46 pgaxatte: oh, what error? 15:34:26 oh nevermind, I wasn't on master, just a test branch :D 15:35:16 lol 15:36:02 sometimes your cool prompt on zsh is just too long and you don't see the important info :D 15:36:52 I am running the tests locally. 15:38:01 d0ugal: gotta go, I'll read your comments tomorrow if any. Bye! 15:42:27 Sure 15:49:44 I'm going to end things a little early 15:50:00 Thanks all, hopefully we can continue discussing the documentation and get more input over time. 15:50:03 #endmeeting