08:04:05 #startmeeting mistral 08:04:06 Meeting started Fri May 25 08:04:05 2018 UTC and is due to finish in 60 minutes. The chair is d0ugal. Information about MeetBot at http://wiki.debian.org/MeetBot. 08:04:07 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 08:04:10 The meeting name has been set to 'mistral' 08:04:25 It is the Friday office hour! :) 08:04:27 Who is around? 08:04:29 https://etherpad.openstack.org/p/mistral-office-hours 08:05:09 rakhmerov, apetrich, bobh, mcdoker181818: PING! :) 08:05:24 o/ 08:05:35 Morning folks 08:14:32 We have no "NEW" bugs 08:14:38 but we do have one "UNDECIDED" - https://bugs.launchpad.net/mistral/+bug/1772897 08:14:39 Launchpad bug 1772897 in Mistral "Event-triggered workflows fail on start" [Undecided,Confirmed] 08:15:51 I have never actually used the event trigger stuff to start workflows. How does it work? 08:29:45 d0ugal: AFAIU, it listens on rabbit notifications, and trigger workflows from them 08:30:05 therve: thanks, I'll try and grep for that 08:30:14 brb 08:30:33 https://github.com/openstack/mistral/blob/master/mistral/event_engine/default_event_engine.py#L268 is the meat 08:31:25 Probably none should use this :) 08:37:13 therve: Why not? 08:37:23 I guess nobody does if that bug is valid... 08:43:35 Dougal Matthews proposed openstack/mistral master: Fix the call to start_workflow from events triggers https://review.openstack.org/570535 08:44:04 I guess that might fix it ^ 08:48:41 d0ugal, I agree with the solution. but there's no test to know if that will work, right? 08:49:22 apetrich: Just wondering that :) waiting for tox to finish. 08:50:05 Well, there is a crappy mock test 08:50:09 but that doesn't verify anything 08:50:21 I was about to mention it 08:50:22 :) 08:51:05 Dougal Matthews proposed openstack/mistral master: Fix the call to start_workflow from events triggers https://review.openstack.org/570535 08:51:38 apetrich: see ^ 08:51:56 * apetrich wonders how are still getting those errors related to that parameter 08:52:05 lol 08:52:19 is that still wfexecution_id thing right? 08:52:45 it is 08:52:50 :) that was fast 08:52:54 yeah 08:53:12 thanks I'm happy with that 08:53:24 Really? 08:53:26 lol 08:53:38 happy enough that the fix is valid 08:55:58 brb 08:56:07 I am going to end the meeting, but I'll still be around (in 5 mins) 08:56:10 #endmeeting