04:00:39 <samP> #startmeeting masakari
04:00:40 <openstack> Meeting started Tue May  8 04:00:39 2018 UTC and is due to finish in 60 minutes.  The chair is samP. Information about MeetBot at http://wiki.debian.org/MeetBot.
04:00:41 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
04:00:43 <openstack> The meeting name has been set to 'masakari'
04:00:45 <niraj_singh> Hi
04:00:47 <tpatil> Hi
04:00:53 <samP> Hi all..
04:00:53 <lkwan__> hi
04:01:01 <Dinesh_Bhor> Hi
04:01:10 <samP> Let's start
04:01:28 <samP> #topic High priority items
04:01:40 <samP> (1) Change the meeting time
04:02:11 <lkwan__> It will be nice if the meeting can be started 1 hour earlier?
04:02:12 <samP> we had a mail discussion to change the meeting time to 03:00 UTC.
04:02:35 <tpatil> +1
04:02:53 <samP> lkwan__: I am OK with that, much earlier also possible
04:02:56 <samP> +1
04:03:00 <lkwan__> +1+1
04:03:02 <sagara> +1
04:03:31 <lkwan__> 03:00 UTC is fine
04:04:08 <samP> seems like most of us are OK with 03:00UTC which is 12:00 JST
04:04:43 <samP> I will propose the patch for this, and you still may put your comment that
04:05:00 <samP> Any High priority items?
04:05:20 <samP> Otherwise, let's go to BUG/Patches discussion
04:05:31 <lkwan__> status of openstacksdk?
04:05:48 <samP> lkwan__: let's talk about that in next topic
04:05:56 <lkwan__> np
04:06:12 <samP> #topic Critical Bugs and Patches
04:06:40 <samP> OK, openstacksdk released new version..
04:06:57 <tpatil> 0.13.0 is released
04:06:57 <samP> which will fix most of our problems
04:07:24 <lkwan__> is the type we are waiting for is there?
04:07:38 <tpatil> We will need to update patch https://review.openstack.org/#/c/546492/14/requirements.txt to use the new version
04:07:39 <patchbot> patch 546492 - masakari-monitors - [WIP] Update for upcoming openstacksdk changes to ...
04:08:40 <tpatil> But IMO, we need 0.130.0 for both  lower constraints and regular test jobs
04:09:11 <samP> current lower is openstacksdk===0.11.2
04:09:26 <tpatil> lower constraints jobs : https://review.openstack.org/#/c/555823/, should also use 0.13.0
04:09:27 <patchbot> patch 555823 - masakari-monitors - add lower-constraints job
04:11:12 <samP> tpatil: humm.. #555823 this should update
04:12:00 <samP> I will discuss this with rkhonjo/takahara about #546492
04:12:12 <tpatil> samP: OK
04:13:07 <Dinesh_Bhor> I think openstack BOT job will propose the patch for bumping openstacksdk version in masakari-monitors if its not already proposed then
04:13:49 <tpatil> Dinesh_Bhor: it will not becoz openstacksdk is not included in requirements.txt of masakari-monitors
04:14:03 <samP> Dinesh_Bhor: really? does it update to latest version?
04:14:19 <samP> tpatil: same understanding here
04:14:21 <Dinesh_Bhor> tpatil: ohh
04:14:22 <tpatil> openstacksdk library is added in above patch 546492
04:14:22 <patchbot> https://review.openstack.org/#/c/546492/ - masakari-monitors - [WIP] Update for upcoming openstacksdk changes to ...
04:14:40 <Dinesh_Bhor> Yes, correct. Then we need to update it manually.
04:14:58 <samP> Dinesh_Bhor: tpatil: thanks
04:15:00 <lkwan__> how about this... https://review.openstack.org/#/c/536668/
04:15:00 <patchbot> patch 536668 - masakari-monitors - Change masakari service-type from 'ha' to 'instanc...
04:16:09 <Dinesh_Bhor> lkwan__: I will confirm about this once we have newer openstacksdk in masakari-monitors
04:16:16 <samP> lkwan__: I agree with tpatil's comment on this..
04:16:58 <lkwan__> Just want to make it clear... will the new sdk fix this https://bugs.launchpad.net/python-masakariclient/+bug/1756047
04:17:00 <openstack> Launchpad bug 1756047 in python-masakariclient "masakari command failed due to os-service-type1.2.0" [Critical,Confirmed]
04:17:06 <samP> Let's fix #546492 and see whether we still need 536668
04:18:09 <tpatil> lkwan__: Yes, it will fix this issue though I haven't yet tested it by myself
04:20:16 <samP> OK then, let's review and merge #546492 asap, then we can confirm does it fix bug/1756047.
04:20:44 <samP> I will update #546492 after this meeting.
04:21:05 <tpatil> samP: Ok, Thanks
04:21:41 <samP> I would like to fix this sdk issue assp and release a new version of masakariclient
04:22:27 <samP> Any other bugs or patches to discuss?
04:22:45 <lkwan__> same one.. it will be nice if some of us can review https://review.openstack.org/#/c/534958/
04:22:46 <patchbot> patch 534958 - masakari-monitors - Introspective Instance Monitoring through QEMU Gue...
04:23:19 <lkwan__> Ken and Greg are waiting for some replies the status
04:23:39 <lkwan__> and I communicated that mid May is the target date.
04:23:45 <lkwan__> is the date still ok?
04:24:04 <samP> lkwan__: sure, I will put my comments today.
04:24:45 <tpatil> samP: First we will need to merge the specs : https://review.openstack.org/#/c/469070/
04:24:45 <patchbot> patch 469070 - masakari-specs - Introspective instance monitoring.
04:24:51 <lkwan__> thanks, I will be on irc tomorrow and follow up as much as possible.
04:25:01 <samP> tpatil: correct
04:25:29 <tpatil> lkwan__: I have started reviewing the implementation
04:26:16 <tpatil> lkwan__: I have one request, is it possible to split this single patch?
04:26:40 <samP> lkwan__: thanks for spec update. I will take a one last look and approve it.
04:27:17 <samP> Dinesh_Bhor: thanks for spc fix
04:27:25 <lkwan__> taptil, any suggestion how to split?
04:27:46 <lkwan__> the main part is qemu_utils.py
04:30:30 <lkwan__> it is not that big and I will try to be irc tomorrow to answer questions if this help.
04:30:57 <tpatil> Maybe you can split it into 3 patches, #1: basic service related code including config options, #2: monitoring instances, #3: sending notifications
04:32:10 <samP> lkwan__: that's really helpful. thanks
04:33:16 <lkwan__> taptil, I will put comments on the README. For the 3 parts you mentioned... so that you can read it easier.
04:35:11 <samP> I will put my comment on current patch. As tpatil suggest it is easy to review if you split this patch, however let see how it goes.
04:35:42 <tpatil> lkwan__: I will appreciate if you can split the patches but if you don't have time, I'm ok to review this single patch, the only concern is it will take lot of time for review.
04:36:09 <samP> lkwan__: Just one question, have you already test this?
04:36:13 <lkwan__> yes
04:36:33 <lkwan__> many times
04:36:39 <lkwan__> and very stable
04:36:45 <samP> lkwan__: great..thanks
04:36:48 <lkwan__> the notification is very simple
04:37:14 <lkwan__> but it is within the same file, then why it is very hard to split it out
04:37:21 <lkwan__> just one function for notification
04:37:29 <tpatil> Are you filtering instances based on metadata as mentioned in specs?
04:37:47 <lkwan__> yes
04:38:05 <lkwan__> we only listen to those with qemu
04:38:22 <lkwan__> and filter them out
04:39:24 <tpatil> I couldn't find it in the code, I will take a closer look later.
04:40:03 <lkwan__> _hasQemuGuestAgent function
04:40:14 <lkwan__> on qemu_utils.py
04:40:40 <lkwan__> based on whether this is a sock or not
04:42:07 <tpatil> Ok, Thanks
04:42:39 <samP> lkwan__: tpatil: thanks
04:43:08 <samP> lkwan__: we might contact you for more details, on IRC or dev-ml
04:43:36 <lkwan__> yes... will be on IRC to answer questions.
04:44:00 <samP> lkwan__: thanks.
04:44:00 <lkwan__> if I am taking a break.. for the time difference... I will indicate as well
04:44:32 <samP> lkwan__: sure.. thanks
04:45:01 <lkwan__> thanks samP , tpatil,  Dinesh and others.
04:45:08 <samP> Any other bugs/patches to discuss?
04:45:11 <samP> lkwan__: NP
04:45:52 <samP> If any bring the at the end of this meeting..
04:46:00 <samP> #topic Discussion points
04:46:11 <samP> (1) Horizon Plugin
04:46:39 <samP> Sice sdk is fixed, we can move on with this, right?
04:47:02 <samP> Ah, need it on requirements?
04:47:25 <niraj_singh> yes
04:48:31 <samP> niraj_singh: OK, understand. Let's fix python client first..
04:48:44 <samP> (2) recovery method customization
04:48:52 <niraj_singh> yes. i waiting for that.
04:49:03 <niraj_singh> i/i am
04:49:31 <tpatil> samP: We are planning to use openstacksdk instead of masakariclient
04:49:48 <tpatil> Need to fix ray review comment given on patch : https://review.openstack.org/#/c/543870/4/requirements.txt
04:49:48 <patchbot> patch 543870 - masakari-dashboard - Add segment panel
04:50:15 <tpatil> samP: recovery method customization, working on specs
04:50:21 <samP> tpatil: ah...yes. thanks.. we don't need to use masakariclient
04:50:22 <niraj_singh> ok
04:51:10 <samP> then can we bump the sdk version for dashboard and check?
04:51:43 <samP> tpatil: thanks for working on recovery method customization spec
04:52:16 <tpatil> samP: Yes, it's working with the new sdk version. niraj_singh will do the needful and upload patches for review
04:53:11 <samP> tpatil: niraj_singh: thanks. I will review once updated the patch.
04:53:23 <niraj_singh> yes, i will do this today.
04:53:29 <samP> niraj_singh: thanks
04:53:41 <samP> (3) Ansible support for Masakari
04:53:58 <niraj_singh> Repo created for masakari ansible plugin
04:53:58 <niraj_singh> https://github.com/openstack/openstack-ansible-os_masakari/
04:54:30 <samP> great !!
04:54:37 <samP> niraj_singh: Thanks
04:54:45 <niraj_singh> "masakari-monitors" and "pacemaker and corosync" services are installed in my env. Not tested yet.
04:55:10 <niraj_singh> Currentlly working on the tests for the first commit https://review.openstack.org/#/c/566538/
04:55:11 <patchbot> patch 566538 - openstack-ansible-os_masakari - Add Maskari base jobs
04:55:23 <niraj_singh> It include masakari-appi and masakari-engine
04:55:31 <lkwan__> will that be including the client ?
04:55:42 <tpatil> samP: we will contact cluster labs community to find out how to install pacemaker and corosync
04:56:00 <samP> niraj_singh: got it. Do you find any useful Ansible role for pacemaker and coro?
04:56:08 <samP> tpatil: niraj_singh: got it.
04:56:08 <tpatil> lkwan__: you mean python-masakariclient
04:56:16 <lkwan__> yes
04:56:27 <niraj_singh> yes. https://github.com/mrlesmithjr/ansible-pacemaker
04:57:12 <tpatil> lkwan__: Yes, it will be installed automatically as it's a dependency in masakari-monitor
04:57:31 <niraj_singh> samP: we can use this for now.
04:57:38 <samP> niraj_singh: great.. looks like some thing nice..
04:57:56 <niraj_singh> samP: thanks
04:58:01 <samP> niraj_singh: np
04:58:07 <lkwan__> my understanding is that masakari can be used not only limited to openstack but other cluster?
04:58:22 <samP> Great... anything else?
04:58:40 <samP> lkwan__: ??
04:58:47 <lkwan__> np, next time
04:58:58 <samP> we only have 2mins left
04:59:07 <lkwan__> nothing else.
04:59:41 <samP> lkwan__: please mail or discuss next time or discuss it on #openstack-masakari
04:59:44 <samP> lkwan__: sorry
04:59:57 <samP> Let's finish today's meeting.
05:00:02 <samP> Thank you everyone
05:00:07 <samP> #endmeeting