15:00:50 <gouthamr> #startmeeting manila
15:00:51 <openstack> Meeting started Thu Mar  4 15:00:50 2021 UTC and is due to finish in 60 minutes.  The chair is gouthamr. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:52 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:54 <openstack> The meeting name has been set to 'manila'
15:00:58 <dviroel> o/
15:00:59 <carloss> o/
15:01:05 <almir-okato> hi
15:01:05 <haixin> o/
15:01:05 <ecsantos> o/
15:01:08 <vhari> hi
15:01:26 <disap> o/
15:01:36 <tbarron> hi
15:01:40 <felipe_rodrigues> o/
15:01:45 <gouthamr> courtesy ping: ganso vkmc lseki carloss tbarron felipe_rodrigues
15:02:04 <gouthamr> hello everyone, welcome to our second meeting for the day :)
15:02:14 <vhari> :)
15:02:16 <vkmc> o/
15:02:23 <gouthamr> #topic Announcements
15:02:51 <gouthamr> Next week is feature freeze week
15:03:00 <gouthamr> #link http://lists.openstack.org/pipermail/openstack-discuss/2021-March/020760.html ([release] Release countdown for week R-6 Mar 01 - Mar 05)
15:03:38 <haixin> yes, so i need review about my patch:https://review.opendev.org/c/openstack/manila/+/765975 thanks
15:04:17 <gouthamr> ack haixin
15:04:44 <carloss> I'll review it soon :)
15:04:47 <haixin> thank you, gouthamr
15:04:48 <gouthamr> we'd be requesting a release of python-manilaclient for wallaby on 11th March, and merging any feature changes into manila
15:05:00 <gouthamr> and manila-ui
15:05:32 <gouthamr> we'll talk about some of those changes in a bit
15:06:22 <gouthamr> but, thanks to dviroel, we have some new deadlines chalked up for the upcoming release
15:06:32 <gouthamr> #link https://releases.openstack.org/xena/schedule.html (Xena project schedule)
15:07:08 <dviroel> :)
15:07:42 <gouthamr> The Project Technical Gathering for the Xena release is going to be in the second week on that schedule
15:07:56 <gouthamr> April 19-23, 2021
15:08:03 <gouthamr> #link http://lists.openstack.org/pipermail/openstack-discuss/2021-March/020778.html
15:08:40 <gouthamr> #link https://april2021-ptg.eventbrite.com/ (PTG Registration)
15:09:25 <gouthamr> i'm hoping you can all register and attend this virtual event, we are yet to sign up for slots and plan topics
15:09:40 <gouthamr> #link https://etherpad.opendev.org/p/xena-ptg-manila-planning (Manila Xena PTG Planning etherpad)
15:09:43 <haixin> i will register it
15:09:59 <gouthamr> thanks haixin
15:10:21 <gouthamr> you can put your irc nick down on the etherpad, and bookmark it to add topics in the coming weeks
15:10:49 <haixin> ok,
15:12:17 <gouthamr> it's also election time in OpenStack land
15:12:24 <gouthamr> #link http://lists.openstack.org/pipermail/openstack-discuss/2021-March/020797.html ([all][elections][ptl][tc] Combined PTL/TC March 2021 Election Season_
15:13:09 <gouthamr> if you wish to nominate yourself for PTL/TC, this is your cue :) the nomination period ends on March 09 2021
15:13:56 <gouthamr> that's all i had in terms of announcements today
15:14:00 <gouthamr> does anyone else have any?
15:15:29 <gouthamr> then lets dive right in, no new topics have been added to the meeting page, so we'll check on the feature freeze items
15:15:33 <gouthamr> #topic Reviews needing feedback
15:15:42 <gouthamr> #link https://etherpad.opendev.org/p/manila-wallaby-review-focus (Wallaby cycle review focus etherpad)
15:15:48 <gouthamr> how are we doing?
15:16:34 <gouthamr> not too shabby, but there's a lot on that etherpad
15:16:40 <dviroel> yep
15:16:43 <gouthamr> lets go down the list
15:16:45 <gouthamr> support min/max share size limited by share_type
15:16:50 <gouthamr> #link https://review.opendev.org/c/openstack/manila/+/765975
15:17:39 <dviroel> i'll try to review this one asap
15:17:41 * tbarron will review that one too
15:17:47 <carloss> +1
15:17:54 <gouthamr> ack ty dviroel tbarron carloss - more the merrier :)
15:17:56 <haixin> See if there is any room for improvement, thanks
15:18:23 <gouthamr> thanks for your patience with this haixin
15:19:05 <gouthamr> haixin: could you sign up to review some of the changes on that etherpad? we could use your help
15:19:18 <vkmc> already has a +1 from Dina, thanks disap ++
15:19:45 <haixin> ok, i will review other patch by my free time, i will.
15:19:45 <gouthamr> alright, next one:
15:19:49 <gouthamr> thanks haixin
15:20:20 <gouthamr> #link https://review.opendev.org/q/topic:%2522secure-rbac%2522+status:open+project:openstack/manila (Secure RBAC)
15:20:29 <gouthamr> #link https://etherpad.opendev.org/p/manila-wallaby-secure-rbac (Secure RBAC review tracker)
15:20:51 <gouthamr> this one has a lot, ty for your reviews dviroel carloss
15:21:18 <carloss> anytime, gouthamr :)
15:21:24 <gouthamr> some of those changes need a refresh, but the ones in the first set on the etherpad should be ready
15:21:39 <dviroel> ack
15:21:49 <gouthamr> and there are open bugs for some of the flaws
15:22:34 <gouthamr> for example: system member and reader roles will not work as expected with the default policy
15:22:43 <gouthamr> #link https://bugs.launchpad.net/manila/+bug/1917504 (Context checks in the db layer prevent default RBAC from working correctly)
15:22:44 <openstack> Launchpad bug 1917504 in OpenStack Shared File Systems Service (Manila) "Context checks in the db layer prevent default RBAC from working correctly" [Undecided,New]
15:24:05 <gouthamr> there's a workaround for that bug, however, i do hope we can fix it in the wallaby timeframe
15:25:56 <gouthamr> when you turn on the new defaults, you may see that project admins have permissions in some of the APIs to do cross project stuff - these are rough edges we hope to trim
15:26:08 <gouthamr> good thing is that we have growing test coverage
15:26:21 <gouthamr> however, i'm not sure we'll get everything working by next week
15:27:37 <gouthamr> since there's a known and feasible workaround (see the bug notes on LP #1917504)
15:27:39 <openstack> Launchpad bug 1917504 in OpenStack Shared File Systems Service (Manila) "Context checks in the db layer prevent default RBAC from working correctly" [Undecided,New] https://launchpad.net/bugs/1917504
15:28:01 <gouthamr> i still think we can merge these secure defaults, and keep chipping away at this
15:29:04 <gouthamr> i do plan to suggest in the release notes that enforce_scope and enforce_new_defaults are going to be experimental in the wallaby cycle
15:29:37 <gouthamr> and we'll take backports for any flaws we may find after as test coverage keeps increasing
15:29:59 <gouthamr> there's some good patterns for tempest testing elsewhere which we may take a look at and borrow ideas from
15:31:08 <gouthamr> next up on that list was OSProfiler
15:31:22 <gouthamr> everything for this change has merged in manila/python-manilaclient
15:31:44 <gouthamr> #link https://review.opendev.org/c/openstack/manila/+/762725 (Add share server limits)
15:32:04 <gouthamr> i owe you a review here, carloss - will do today
15:32:12 <carloss> thanks, gouthamr!
15:32:25 <carloss> there are some stuff that must be discussed in the last comments me and carthaca added
15:32:35 <carloss> so having some more opinions would help us a lot
15:32:42 <gouthamr> sure, do we want to do that now?
15:33:21 <carloss> I guess we can take the discussion to the change and it will grant us more time to go over some more items from the review focus list
15:34:08 <gouthamr> sure, works
15:34:12 <gouthamr> #link https://review.opendev.org/c/openstack/manila/+/768590 (Zadara Share Driver)
15:34:35 <gouthamr> thanks dviroel carloss vkmc for comments on this, looks like the latest change is passing CI
15:35:05 <gouthamr> we perhaps look today and see if we can merge this?
15:35:16 <dviroel> agree
15:35:25 <gouthamr> good stuff
15:35:29 <carloss> +1
15:35:34 <gouthamr> #link https://review.opendev.org/c/openstack/manila/+/768816 (New Quota control for per share size limit)
15:36:02 <gouthamr> this one is carloss and myself, the previous comments about microversioning this change have been made
15:36:33 <gouthamr> no other major concerns, i'd like to test it a bit more
15:37:04 <carloss> yeah, I'll review this too
15:37:29 <gouthamr> cool - lets chat on #openstack-manila or on the review, carloss
15:37:36 <gouthamr> #link https://review.opendev.org/q/topic:%22bp%252Fadd-security-service-in-use-share-networks%22+(status:open%20OR%20status:merged) (Add security service update for in-use share networks)
15:38:03 <gouthamr> #link https://review.opendev.org/c/openstack/manila-image-elements/+/775242 (Add OpenLDAP to manila-docker-container)
15:38:42 <gouthamr> ecsantos: o/ the lower constraints job is failing on your change
15:39:20 <gouthamr> ecsantos: i saw you were trying to fix that job a while ago
15:39:29 <gouthamr> i think we should just remove the job from this repository
15:39:53 <dviroel> yep, we might need to do that
15:39:55 <gouthamr> we don't make any releases for manila-image-elements, and don't promise coinstallability of any sort - its not a service that you install anywhere
15:40:43 <dviroel> gouthamr: i can help ecsantos to propose the removal of this job
15:41:01 <gouthamr> so i guess the lower-constraints file and the job got added at some point inadvertently, and since the requirements files are up to our satisfaction, we can drop the lower-contsraints.txt and the job from the zuul manifest
15:41:08 <gouthamr> dviroel: thank you dviroel
15:41:19 <dviroel> ++
15:41:50 <ecsantos> ++
15:42:25 <gouthamr> regarding the rest of this set of patches, we had a pretty cool collaborative review session yesterday
15:42:32 <gouthamr> #link https://youtu.be/uvIkE1JmQw8 (Security Service Updates - Wallaby Collaborative Code Review - 3rd Mar 2021)
15:43:14 <dviroel> this one has more likes that the rbac one :)
15:43:22 * gouthamr what!
15:43:52 <dviroel> lol
15:44:30 <gouthamr> there's some good discussion captured on the review as well as on
15:44:45 <gouthamr> #link https://etherpad.opendev.org/p/security-service-update-collab-review (wallaby security service update collab review)
15:45:29 <gouthamr> so i'd like folks to sign up to review this
15:46:37 <gouthamr> i feel all alone - given that carloss/dviroel cleverly wrote up the whole change to avoid review duties
15:47:15 <dviroel> lol
15:47:21 <gouthamr> #link https://review.opendev.org/c/openstack/manila/+/775038 ([NetApp] Add support for FPolicy native mode)
15:47:29 <carloss> lol
15:47:58 <gouthamr> passing ci, and is a change isolated to the netapp driver
15:48:21 <gouthamr> should be a good one to review as well, how's it looking carloss felipe_rodrigues ?
15:49:00 <dviroel> carloss is also working on QA'ing this feature for us
15:49:32 <dviroel> felipe_rodrigues: can you take a look again in this fpolicy feature? when you have some time
15:49:35 <carloss> yep, I'll post results of the QA in the change. I have performed the review internally in the past, but I'll take a look on it again :)
15:49:55 <gouthamr> good stuff, isn't something we can test via tempest except expect no regressions
15:50:11 <gouthamr> thanks carloss
15:50:32 <carloss> my pleasure :)
15:50:45 <gouthamr> #link https://review.opendev.org/c/openstack/manila/+/741560 ([CephFS] Create share from snapshot)
15:50:45 <dviroel> we still don't have internal tempest tests to provide the outputs, we should have them only after FF
15:51:04 <gouthamr> #link https://review.opendev.org/c/openstack/manila/+/775268 (create_share/delete_share)
15:51:09 <gouthamr> #link https://review.opendev.org/c/openstack/manila/+/775278 (extend_share/shrink_share)
15:51:58 <gouthamr> dviroel: ack, good to know you're testing it well!
15:52:23 <gouthamr> vkmc plans to have a collab review session to go over these changes
15:52:44 <vkmc> yes, I'll see the details of the session on the mailing list today :D
15:52:59 <gouthamr> thanks vkmc
15:53:07 <gouthamr> this ceph gate change is also necessary:
15:53:13 <gouthamr> #link https://review.opendev.org/c/openstack/devstack-plugin-ceph/+/777232 (Update ceph default version to octopus)
15:54:32 <gouthamr> #link https://review.opendev.org/c/openstack/manila-ui/+/767017 (Manila-UI)
15:55:53 <gouthamr> disap has a new patchset today, but would benefit from reviews
15:56:49 <gouthamr> cool, that's all the changes we are tracking
15:56:54 <gouthamr> and that's a lot
15:57:19 <gouthamr> so if there's anything else that's missing here, do holler - or add it to the etherpad so we don't forget
15:58:22 <gouthamr> thanks everyone for your hard work on these changes, and for every review. i firmly believe every review matters, so if you have some time, please do take a look at any of these open changes and add your comments
15:59:41 <gouthamr> sorry we couldn't get to bugs today, vhari
16:00:01 <gouthamr> we'll definitely talk more about it next week, since we'll have a bug squash in two weeks
16:00:02 <vhari> gouthamr, np
16:00:18 <gouthamr> we're at the top of the hour - it was good to sync on all these reviews
16:00:21 <vhari> gouthamr, ack ty.. good discussions ^^
16:00:28 <gouthamr> thank you all for attending! :)
16:00:33 <gouthamr> see you on #openstack-manila
16:00:37 <gouthamr> #endmeeting