15:00:47 <gouthamr> #startmeeting manila
15:00:48 <openstack> Meeting started Thu Feb 20 15:00:47 2020 UTC and is due to finish in 60 minutes.  The chair is gouthamr. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:49 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:51 <openstack> The meeting name has been set to 'manila'
15:00:59 <dviroel> o/
15:01:01 <lseki> o/
15:01:08 <tbarron> hi
15:01:15 <gouthamr> courtesy ping: xyang toabctl ganso vkmc amito jgrosso carloss
15:01:20 <vkmc> o/
15:01:25 <maaritamm> o/
15:01:27 <carloss> hey :)
15:01:27 <vhari> hi
15:01:48 <gouthamr> hello \o/
15:01:52 <andrebeltrami> o/
15:02:12 <gouthamr> Let's get started, we've what i see to be a short agenda today:
15:02:30 <gouthamr> https://wiki.openstack.org/wiki/Manila/Meetings#Next_meeting
15:02:31 <gouthamr> First off
15:02:35 <gouthamr> #topic Announcements
15:02:48 * gouthamr ..exciting..
15:02:51 <gouthamr> #link http://lists.openstack.org/pipermail/openstack-discuss/2020-February/012677.html (OpenStack Discuss ML post/proposal)
15:03:05 <gouthamr> i know many of you have already looked and responded, thank you for that
15:03:36 <amito> o/
15:03:38 <gouthamr> you're all kind to give me a rather quick turnaround :)
15:04:19 <tbarron> I think we're just excited by the proposal :)
15:05:11 <gouthamr> so lets not let this linger on the ML any longer... we don't have responses from 3 core reviewers (and we'll get to that in just a minute)
15:05:43 <gouthamr> i'd like to formally welcome vkmc and carloss to the maintainers team, thank you for everything you do for this project
15:05:49 <lseki> 🎉
15:05:55 <tbarron> +1000
15:05:58 <dviroel> carlos++
15:06:01 <dviroel> vkmc:++
15:06:26 <carloss> thanks! :)
15:06:27 <gouthamr> i hope you continue to mentor and grow this community, it's your problem now on the paper
15:07:00 <vkmc> <3 thanks folks, you are so great, hope to be able to fulfill expectations
15:07:06 <vhari> +1000 (y)
15:07:24 <vkmc> gouthamr, always, it's so exciting to be able to bring talented people like maaritamm to our team
15:07:34 <gouthamr> great, i'll throw around some zen for the occasion:
15:07:37 <gouthamr> "Before enlightenment, chop wood, carry water. After enlightenment, chop wood, carry water."
15:07:48 <vkmc> you are an amazing team for them to give their first steps
15:08:26 <gouthamr> that makes /me very happy - that was our stated goal around here!
15:08:31 <vkmc> zorilla high five o/
15:08:41 <vhari> \o/
15:08:43 <carloss> o/
15:08:48 <amito> o/
15:08:50 <tbarron> o/
15:08:52 * gouthamr notes that vkmc looked up how many digits gorillas have on their limbs
15:08:59 <vkmc> hahah yes I did that
15:09:27 <tbarron> I prefer a zorilla limb lift to a tail lift.
15:10:02 <tbarron> But we have our defenses if needed.
15:10:24 <gouthamr> i'll be in touch with you vkmc and carloss and give you an overview of do's and don'ts - you're probably familiar with 99% of them
15:10:43 <gouthamr> that's all i had in terms of new announcements
15:11:12 <gouthamr> We *just* completed Milestone-2
15:11:21 <gouthamr> #link https://releases.openstack.org/ussuri/schedule.html (Ussuri Release Schedule)
15:11:36 <gouthamr> please keep your work items in sync with the release schedule
15:11:47 <gouthamr> any body got anything else?
15:12:30 <gouthamr> alright ..
15:12:34 <gouthamr> #topic Core team removals
15:13:18 <gouthamr> we have a few inactive cores that have expressed to be removed or haven't responded to my request to re-confirm their involvement
15:13:33 <gouthamr> i'd like to discuss removing them, with your approval
15:14:01 <gouthamr> bswartz and zhongjun have been focussed on other things for a while
15:14:26 <gouthamr> bswartz expressed to us that he'd no longer have time to review changes actively, and would like to be taken off
15:14:59 * gouthamr doesn't want to be blamed - it's been a while, and thought bswartz'd change his mind
15:15:01 <gouthamr> :P
15:15:37 <gouthamr> i'd like to thank both of them for their immense contribution to manila, and tell them they can return to their role whenever
15:15:48 <tbarron> +1
15:16:02 <dviroel> +1
15:16:05 <carloss> +1
15:16:48 <gouthamr> #chair tbarron
15:16:49 <openstack> Current chairs: gouthamr tbarron
15:16:58 <gouthamr> my network is acting up a bit, just in case ^
15:17:10 <vkmc> +1
15:17:19 <vhari> +1
15:17:45 <gouthamr> cool, ty - i'll take them off the list
15:18:36 <gouthamr> i'd like to reiterate what i said in the ML posts regarding the maintainers
15:18:38 * tbarron prepares to mix things up ...
15:18:39 <gouthamr> If you're interested in helping us maintain Manila by being part of
15:18:39 <gouthamr> the manila core maintainer team, please reach out to me or any of the
15:18:39 <gouthamr> current maintainers, we would love to work with you and help you grow
15:18:39 <gouthamr> into that role!
15:19:08 <gouthamr> moving on..
15:19:12 <gouthamr> #topic Tracking our work
15:19:39 <gouthamr> we're past M-2, all specifications have been merged at this point
15:19:48 <dviroel> \o/
15:19:50 <gouthamr> i'd just like us to look at some reviews
15:20:09 <gouthamr> #link https://review.opendev.org/#/c/701108/ (Add uuid for tests)
15:20:52 <gouthamr> ^ this patch conforms manila-tempest-tests to a guideline from the tempest project
15:21:21 <gouthamr> i'd like some more eyes on this...
15:21:52 <gouthamr> when this change merges, we need to be aware that every test must have a unique UUID
15:22:44 <tbarron> So we'd need to generate a uuid and add a decorator line for each test case?
15:23:26 <gouthamr> yes
15:23:27 <tbarron> each *new* test case
15:23:43 <gouthamr> yes, and i believe there is some tooling to do this automatically
15:24:03 <tbarron> maybe we can get liron to document that
15:24:15 <gouthamr> +1
15:24:20 <tbarron> the tooling or whatever the new requirement would be
15:25:02 <vkmc> maybe there is something already done, I'm aware this (uuids) is being used by main tempest so there should be something we can re utilize
15:25:04 <tbarron> to me if that's the burden in order to conform to align with the other tempest plugins and core tempest it doesn't seem too burdensome
15:25:58 <tbarron> s/to conform to align/to align/
15:26:04 <gouthamr> sure, the benefit seems to be for those that want to use our tempest tests
15:26:22 <gouthamr> as certification/validation against releases
15:26:37 <gouthamr> and different installations of manila
15:27:18 <gouthamr> i think we can make check_uuids run as a gerrit hook, and do the work for us - if that's not what some script somewhere does
15:27:32 <tbarron> I'd argue that there is some benefit to manila just in aligning and not being a one-off.  It's like driving on the same side of the road as others even though by
15:27:46 <tbarron> itself there may not be a compelling reason to switch sides.
15:28:37 <gouthamr> sure ty, please review this, and share your concerns on the change..
15:28:38 <tbarron> Though some might argue for a policy of "Manila Exceptionalism" :)
15:29:38 <gouthamr> not exceptionalism, but, we haven't taken everything that's come our way for good reasons that it doesn't conform to the direction of the project
15:30:22 <gouthamr> this one may not be one of those - i just wish there was a test somewhere that'd fail when requirements are hoisted upon test plugins
15:30:54 <gouthamr> nevertheless, we're glad someone wants to fill this gap!
15:31:12 <gouthamr> #link https://review.opendev.org/#/c/707577/ (Add functional tests for OSC)
15:31:22 <gouthamr> ^ speaking of testing - maaritamm has been busy
15:32:12 <gouthamr> this is a good patch to get in as we continue to add more OSC coverage - please take the time to review this one
15:32:38 <gouthamr> #link https://review.opendev.org/#/c/688227/ ([Unity] Manage/unmanage share server/share/snap)
15:33:10 <gouthamr> ^ this (and the next couple of patches) have been around for a bit
15:33:49 <dviroel> their CI is passing now
15:33:57 <tbarron> maaritamm: thanks for adding those functional tests!
15:34:16 <gouthamr> dviroel carloss - you're in the best place to review this since you implemented the feature, along with your driver impl
15:34:17 <dviroel> but without enabling manage/unmanage tests
15:34:47 <gouthamr> dviroel: oh, please ask for those to be run..
15:34:59 <carloss> yep... will take a look on it soon
15:35:19 <dviroel> gouthamr: remember asking this before...
15:35:35 <gouthamr> dviroel: it's alright if they want to run them manually and post the results on the patch - sometimes special casing in CIs to handle unmerged changes may be hard..
15:36:17 <gouthamr> dviroel: ack - pl note that with a -1 then; i'll follow up
15:36:24 <gouthamr> #link https://review.opendev.org/#/c/687108/ (Add api-ref for share network subnets)
15:36:27 <gouthamr> #link https://review.opendev.org/#/c/697111/ (Update admin guide for share network subnets change)
15:36:39 <gouthamr> ^ Doc changes - easy reviews :)
15:36:40 <dviroel> gouthamr: ack
15:36:49 <carloss> yep
15:36:54 <carloss> there is one more, I think
15:36:56 <carloss> https://review.opendev.org/#/q/topic:bug/1843953
15:37:25 <gouthamr> ah, didn't see that ty carloss
15:37:32 <carloss> yw :)
15:37:41 <gouthamr> #link https://review.opendev.org/#/c/688412/ (Add user guide for share network subnets)
15:38:09 <gouthamr> that's all the reviews i wanted attention on - anyone else got any?
15:38:53 <gouthamr> okay, let's move on to our next segment
15:38:56 <gouthamr> #topic Bugs (vhari)
15:39:13 <vhari> o/
15:39:15 <gouthamr> Czarina is a thing, no?
15:39:32 <vhari> :D
15:39:48 <gouthamr> Tsarina or tsaritsa is the title of a female autocratic ruler of Bulgaria, Serbia or Russia.
15:39:59 <vhari> well if you're ready, gotta few ones for ya'll :)
15:40:03 <gouthamr> lol :) sorry vhari
15:40:17 <vhari> haha
15:40:28 <tbarron> or US
15:40:29 <gouthamr> #link: https://etherpad.openstack.org/p/manila-bug-triage-pad-new (Bug Triage etherpad)
15:40:33 <vhari> me no rule but nag
15:40:37 <tbarron> definition is out of date
15:40:43 <vhari> so here goes 1st one
15:40:45 <vhari> https://bugs.launchpad.net/manila/+bug/1863298
15:40:46 <openstack> Launchpad bug 1863298 in Manila "manila manage OverQuota - no good way out" [Undecided,New]
15:41:08 <vhari> new one - needs a bit of tlc attention
15:41:12 <tbarron> carthacs is trapped ^^^
15:41:17 <tbarron> carthaca
15:42:39 <gouthamr> option (C) is a samuel colt invention
15:42:58 <dviroel> he suggests check the quota earlier, but we use the share size  got from back end
15:43:44 <dviroel> another exceptions could change the share to a manage_error state.
15:43:46 <carthaca> yep, that is the hard part
15:44:20 <gouthamr> we could allow the quota to go over...
15:44:30 <gouthamr> and log it, rather than raise an exception
15:44:52 <gouthamr> this would prevent any new creation
15:45:40 <carthaca> what just comes to my mind.. maybe I should unmanage as the opposite of manage and not delete?
15:46:20 <gouthamr> carthaca: yes, the safe way to recover from this situation would be to reset-state and unmanage
15:47:40 <gouthamr> you may not *need* to reset state too
15:47:56 <dviroel> should we consider a different deletion for manage_error shares?
15:49:29 <gouthamr> yes, that can work too - drivers probably a chance to rollback
15:50:06 <gouthamr> let's not evolve the solution here, but, let's look for an owner and have them propose solutions that we can discuss
15:50:06 <dviroel> like rolling back the share renamed on the back end
15:50:45 <gouthamr> dviroel: whatever they change on the original share
15:50:53 <dviroel> gouthamr: yes
15:51:08 <gouthamr> dviroel: might be harder to implement, we got to work through it
15:51:18 <gouthamr> is anyone interested to take a look?
15:52:05 <gouthamr> *crickets*
15:52:19 <dviroel> gouthamr: o/
15:52:25 * vhari assigns bug  to crickets
15:52:31 <gouthamr> dviroel: ty
15:52:32 <vhari> :)
15:52:59 <gouthamr> dviroel would probably like cricket
15:53:27 <vhari> ^^ done
15:53:29 <dviroel> gouthamr: maybe, looks fun
15:53:32 <dviroel> =)
15:53:38 <carthaca> dviroel: thx
15:53:41 <gouthamr> dviroel: please toggle the buttons, and assign a target milestone, i'll follow up
15:53:59 <dviroel> gouthamr: ack
15:54:07 <dviroel> carthaca: yw
15:54:18 <vhari> gouthamr, guess we're almost out of time so moar bugs next time
15:54:21 <gouthamr> thanks for reporting this carthaca, sorry you had to go through the pain
15:54:29 <vhari> ty all
15:54:40 <gouthamr> vhari: ack, thank you!
15:54:50 <vhari> yw
15:54:51 <gouthamr> #topic Open Discussion
15:55:52 <gouthamr> alright everyone, thank you for participating
15:56:06 <carloss> thanks gouthamr
15:56:12 <gouthamr> see you on #openstack-manila
15:56:17 <gouthamr> #endmeeting