15:00:09 <tbarron> #startmeeting manila
15:00:10 <openstack> Meeting started Thu Aug  1 15:00:09 2019 UTC and is due to finish in 60 minutes.  The chair is tbarron. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:11 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:13 <openstack> The meeting name has been set to 'manila'
15:00:17 <amito> yo. o/
15:00:19 <lseki> hi
15:00:21 <jgrosso> hi
15:00:27 <carloss> hi o/
15:00:34 <tbarron> courtesy ping:  gouthamr xyang toabctl bswartz ganso erlon tpsilva vkmc amito jgrosso dviroel lseki carloss
15:00:42 <dviroel> o/
15:00:43 <xyang> hi
15:01:02 <tbarron> lets wait a couple minutes
15:01:17 <bswartz> .o/
15:01:19 <vkmc> o/
15:02:27 <tbarron> ok, let's get started
15:02:29 <tbarron> hi all!
15:02:43 <tbarron> Agenda
15:02:50 <tbarron> #link https://wiki.openstack.org/wiki/Manila/Meetings
15:03:00 <vhariria> o/
15:03:02 <tbarron> #topic announcements
15:03:12 <gouthamr> o/
15:03:22 * tbarron doesn't notice vhariria and gouthamr sneaking in
15:03:29 <tbarron> #chair gouthamr
15:03:30 <openstack> Current chairs: gouthamr tbarron
15:03:35 <tbarron> #chair bswarts
15:03:36 <openstack> Warning: Nick not in channel: bswarts
15:03:37 <openstack> Current chairs: bswarts gouthamr tbarron
15:03:38 <bswartz> o_O
15:03:48 <gouthamr> who dat
15:03:51 <bswartz> Don't throw a chair at me
15:03:52 <tbarron> I'm in a hackfest so if for some reason I'm disconnected ...
15:04:12 <gouthamr> are they hacking the network tbarron?
15:04:16 <tbarron> or get tied up by others here ...
15:04:42 <tbarron> gouthamr: no, but I'm not on my reliable home DSL internet connection and anything could happen
15:06:03 <tbarron> I don't have particular announcements
15:06:07 <tbarron> Anyone else?
15:06:19 <ganso> hello
15:06:26 <tbarron> ganso: hey!
15:06:38 <tbarron> Anyone have any announcements ....
15:08:32 <gouthamr> .
15:09:05 <gouthamr> tbarron ?
15:09:09 <tbarron> gouthamr: did you have one?
15:09:17 <tbarron> sorry, diverted a minute
15:09:26 <tbarron> back
15:09:34 <gouthamr> tbarron: heh, no.. you went silent for too long, so i poked you with a stick
15:09:42 <tbarron> oyuch
15:09:44 <tbarron> ouch
15:09:49 <gouthamr> :)
15:09:56 <tbarron> #topic python3 functional jobs
15:10:17 <tbarron> so we finally got all the first party jobs running under python3, merged
15:10:31 <tbarron> #link https://review.opendev.org/#/c/671031/
15:10:40 <tbarron> thanks to those who helped get this done
15:10:46 * bswartz fires the confetti cannon
15:10:53 <tbarron> :)
15:11:00 <bswartz> Woohoo py3
15:11:10 <tbarron> where are we on third-party job python3 mighration
15:11:18 <tbarron> any progress to report?
15:11:37 <gouthamr> #success openstack-manila's test jobs are all python3-default. There's one python-2 functional test job that will be retired in the U release
15:11:45 <tbarron> gouthamr: ty
15:11:57 * gouthamr that should have worked?
15:12:05 <bswartz> Python 2 will be retired officially 1 Jan 2020
15:12:33 <tbarron> bout time
15:12:50 <tbarron> OK, I'm going to check every week on 3rd party job progress
15:13:01 <tbarron> #topic our work - reviews
15:13:20 <gouthamr> hey can we go back to the previous topic
15:13:36 <tbarron> gouthamr: yes
15:13:45 <tbarron> #topic python 3 migration progress
15:13:47 <gouthamr> i had to add a note about using the devstack plugin for manila-tempest-plugin...
15:14:17 <gouthamr> #link: https://review.opendev.org/#/c/673377/
15:15:14 <gouthamr> ^ third party CI maintainers, we're going to stop installing manila-tempest-plugin as part of manila's devstack setup... please enable manila-tempest-plugin's devstack plugin in your CI manifests
15:15:34 <carloss> ok
15:15:47 <tbarron> gouthamr: so this a TODO but not actually required in order to start running under py3, right?
15:15:53 <gouthamr> when you do, please also set a local.conf variable: MANILA_INSTALL_TEMPEST_PLUGIN_SYSTEMWIDE=False, so you won't see a deprecation message in the logs
15:16:24 <lseki> ack
15:16:24 <tbarron> but you might as well do both while you are in there
15:16:56 <gouthamr> tbarron: yes, but without this, you'll have two separate installations of the plugin, and one of the installs can be under python2...
15:17:16 <tbarron> lseki: carloss I know you folks have to do this for Cinder as well so thanks in advance for your work in this area.
15:17:25 <tbarron> gouthamr: ack, so simpler just to do it now
15:18:44 <gouthamr> yep
15:18:47 <gouthamr> #link: https://opendev.org/openstack/manila/src/commit/25506de0e477afc3bd499847530f76bb3f9e7635/playbooks/legacy/manila-tempest-minimal-dsvm-lvm/run.yaml#L34
15:18:53 <gouthamr> that's how you'd do it ^
15:19:20 <tbarron> anything else on this topic?
15:19:31 <carloss> ack gouthamr ... I've documented it, we should
15:19:41 <carloss> We should do it soon*
15:19:42 <sfernand> hi
15:19:50 <gouthamr> thanks carloss lseki!
15:19:58 <carloss> gouthamr: yw
15:20:12 <sfernand> we from netapp are working to finish the migration to py37. Probably it will be running soon.
15:20:25 <tbarron> sfernand: hi, and thanks for the update!
15:20:29 <tbarron> sfernand: good news
15:20:34 <gouthamr> ack sfernand..
15:21:15 <tbarron> #topic Our work -- some outstanding reviews
15:21:36 <tbarron> #link https://review.opendev.org/#/c/657775/ - Infortrend driver
15:21:46 <tbarron> Lots of good review activity on this one.
15:22:04 <tbarron> Seems close to merging ....
15:22:15 <tbarron> Anyone have comments or discussion of this one?
15:23:26 <tbarron> #link https://review.opendev.org/#/c/664269/ Nexent refactor
15:23:33 <tbarron> Nexenta
15:23:50 <tbarron> We need some reviewers other than just gouthamr on this one
15:23:59 <tbarron> Unfortunately it's pretty big.
15:24:20 <tbarron> gouthamr may be able to give you some guidance/areas of focus
15:24:34 <tbarron> in the interests of not just having to do everything himself :)
15:24:54 <tbarron> amito: I think you are going to take a look?
15:26:15 <tbarron> We have about one month till feature freeze deadline so let's avoid last-minute reviews on this one.
15:26:42 <tbarron> The contributors have done a lot of work but review is needed to ensure that it integrates well into manila.
15:27:27 <gouthamr> +1
15:27:35 <tbarron> #link https://review.opendev.org/#/c/647538/ remove keystoneclient dependency
15:28:10 <tbarron> vkmc: you got some good comments from cmurphy - do you want to address them in this review, or in a followup?
15:28:17 <amito> Sorry I was on a phone call
15:28:40 <tbarron> amito: no problem, I signed you up for some work
15:28:44 <tbarron> :)
15:28:45 <amito> Yes I'll take a look
15:28:51 <tbarron> amito: thanks!
15:29:16 <tbarron> vkmc may be doing several things at once as well
15:30:15 <tbarron> #link https://review.opendev.org/#/c/650986/ fix pagination performance issue
15:30:42 <tbarron> carloss: looks like you fixed the pylint issues
15:30:55 <carloss> yep :)
15:30:57 <tbarron> carloss: the test coverage difference is insignificatnt
15:31:06 <tbarron> carloss: i'll look again  today then
15:31:30 <tbarron> it looked good to me otherwise, probably this is close to merge
15:31:36 <tbarron> anyone have concerns?
15:32:00 <tbarron> gouthamr: I see you as a reviewer on there so in your copious spare time take a look again.
15:32:08 <gouthamr> nope, have been ignoring that patch for some reason
15:32:11 <gouthamr> will take a look
15:32:31 <tbarron> #link https://review.opendev.org/#/q/topic:bp/share-network-multiple-subnets+(status:open+OR+status:merged)
15:33:33 <dviroel> :)
15:33:49 <tbarron> zuul still doesn't like the pending patches, but carloss dviroel do you have comments, etc. you want to share?
15:34:29 <carloss> I'm fixing the unit tests that are failing
15:34:45 <carloss> I'll have a new PS with all fixed soon :)
15:35:05 <tbarron> carloss: great, you'll probably get more serious reviews at that point
15:35:27 <tbarron> though we should be looking anyways, I've just been distracted with other matters.
15:35:43 <tbarron> Any other reviews that people want to hightlight?
15:36:04 <tbarron> ok
15:36:08 <tbarron> #topic Bugs
15:36:13 <tbarron> jgrosso you are up
15:36:26 <jgrosso> thanks tbarron
15:36:36 <jgrosso> I have no new bugs for today, reached out to some people directly or awaiting responses to some questions I had asked , thanks vkmc, tbarron, and gouthamr for answering some direct questions
15:37:00 <jgrosso> will have more for you next time
15:37:57 <tbarron> jgrosso: cool, ty
15:38:07 <jgrosso> tbarron your welcome
15:38:09 <tbarron> #topic open discussion
15:38:33 <gouthamr> do we treat this one as a new driver? https://review.opendev.org/#/c/673948/
15:39:39 <tbarron> i'll defer to those who have been involved in manila longer than I to remember precedents
15:40:09 <tbarron> If a driver adds DHSS=true capability after new driver deadline is that considered as if it were a new driver?
15:40:18 <tbarron> do we have precedents?
15:40:38 <tbarron> gouthamr: bswartz ganso xyang ^^^ ?
15:40:57 <bswartz> That's a gray area
15:41:01 <gouthamr> i dunno, certainly needs new CI - it's not just any normal capability
15:41:13 <amito> makes sense
15:41:17 <tbarron> this change isn't that big so if we don't have precedents then the main question will be ^^^^
15:41:20 <gouthamr> our test suite is designed with only one driver mode in mind
15:41:23 <bswartz> I'd say it's not a new driver but it's a big review and yes, there are CI requirements
15:41:49 <xyang> maybe that is a new feature rather than a new driver
15:42:20 <tbarron> the submitter needs to be showing us that they have CI coverage with DHSS=True and that the tests pass
15:42:36 <tbarron> I'll just put a remark in there to that effect.
15:42:39 <gouthamr> DHSS=False is being added in this case, yes
15:43:03 <tbarron> yes, I stated it the other way around
15:43:28 <tbarron> and going trom True only to False as well shouldn't be that big a deal
15:43:52 <tbarron> let's just see how this one plays out in terms of test coverage/CI
15:44:40 <tbarron> like any other review submitted about a month before feature freeze we cannot guarantee sufficient
15:44:51 <tbarron> review bandwidth that it will merge this cycle.
15:45:01 <tbarron> We'll see how it goes.
15:45:20 <tbarron> Other open discussion topics?
15:46:29 <tbarron> I'll give a report next week on an aspect of this hackfest, manila-csi and OpenStack K8s integration
15:46:38 <tbarron> maybe point to some demo stuff
15:46:46 <tbarron> but today just a teaser
15:46:53 <tbarron> Anyone else?
15:47:14 <bswartz> Who's hackfest is this?
15:47:23 <tbarron> it's a redhat thing
15:47:30 <bswartz> NetApp does things called hackathons
15:47:37 <tbarron> but the stuff I'm talking about isn't secret :)
15:47:37 <bswartz> And there is one this week (probably coincidence)
15:48:15 <tbarron> bswartz: feel free to share NetApp hackathon results pertaining to manila or more general openstack type stuff anytime .... :)
15:48:36 <tbarron> OK, thanks everyone!!
15:48:47 <tbarron> See you on #openstack-manila
15:48:49 <dviroel> tks!
15:48:50 <gouthamr> ty tbarron!
15:48:53 <tbarron> #endmeeting