09:00:36 <jakeyip> #startmeeting magnum
09:00:36 <opendevmeet> Meeting started Wed Jan 31 09:00:36 2024 UTC and is due to finish in 60 minutes.  The chair is jakeyip. Information about MeetBot at http://wiki.debian.org/MeetBot.
09:00:36 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
09:00:36 <opendevmeet> The meeting name has been set to 'magnum'
09:00:46 <jakeyip> Agenda:
09:00:48 <jakeyip> #link https://etherpad.opendev.org/p/magnum-weekly-meeting
09:00:50 <jakeyip> #topic Roll Call
09:00:52 <jakeyip> o/
09:01:53 <mnasiadka> o/
09:02:47 <jakeyip> #topic Reviews for discussion
09:03:27 <jakeyip> mnasiadka: dalees has a spec for control plane resize up at https://review.opendev.org/c/openstack/magnum-specs/+/905281
09:03:39 <jakeyip> also have a change too
09:04:08 <jakeyip> I think spec is pretty reasonable, can you give it a once over and merge it if you don't have any objections?
09:04:26 <jakeyip> for the change, there are some things to work on, so that can continue
09:04:59 <mnasiadka> For me it's ok, just the Implementation section is empty and looks weird :)
09:05:08 <mnasiadka> but I guess nobody reads those
09:05:56 <jakeyip> hm yeah the formatting is off
09:06:50 <mnasiadka> I just +w'ed, dalees can follow up
09:07:13 <jakeyip> I'll see if dalees is ok with updating formatting
09:08:13 <jakeyip> ok next
09:08:33 <jakeyip> improve driver discovery implementation
09:08:43 <jakeyip> #link https://review.opendev.org/c/openstack/magnum/+/907297
09:09:12 <jakeyip> finally got some code up. not totally happy with it, there are a few edge cases I can think of
09:10:23 <jakeyip> but will be grateful if you can take a look
09:11:41 <opendevreview> Merged openstack/magnum-specs master: Propose control plane resize feature.  https://review.opendev.org/c/openstack/magnum-specs/+/905281
09:11:48 <mnasiadka> will do after the meeting
09:11:54 <jakeyip> thanks
09:13:18 <jakeyip> #topic ClusterAPI
09:13:40 <jakeyip> so CAPI driver will happen after the improve driver discovery implementation is merged
09:13:51 <jakeyip> see ^^^
09:13:54 <jakeyip> tagging for easy search
09:15:16 <jakeyip> sorry this took so long. and this will be priority for feature freeze.
09:15:46 <jakeyip> I don't think I have much to add... you have any question mnasiadka ?
09:22:21 <mnasiadka> No, first day after winter holiday, my brain is not online yet :)
09:22:45 <jakeyip> there's also a couple of reviews for cilium which touches validation which the driver change will impact, I will take a look at those and have a think about it
09:23:10 <jakeyip> cool, I don't want to stress you too much, just one more thing I need to catch up on :P
09:23:14 <jakeyip> #topic Testing
09:23:19 <opendevreview> Merged openstack/magnum master: Fix flakey validation tests.  https://review.opendev.org/c/openstack/magnum/+/905636
09:23:20 <opendevreview> Merged openstack/magnum master: Drop Swarm support  https://review.opendev.org/c/openstack/magnum/+/894395
09:23:22 <opendevreview> Merged openstack/magnum master: Drop dependency on pytz  https://review.opendev.org/c/openstack/magnum/+/906949
09:23:24 <opendevreview> Merged openstack/magnum master: Move the chmod function before the write and flush functions to prevent sensitive information leakage.  https://review.opendev.org/c/openstack/magnum/+/906108
09:23:35 <jakeyip> oh yay ^
09:24:01 <jakeyip> mnasiadka: anything that needs help re: testing?
09:24:37 <mnasiadka> I need to solve dalees comments on the patch that polls failed heat stack state and updates node_addresses
09:25:17 <mnasiadka> https://review.opendev.org/c/openstack/magnum/+/905357
09:25:19 <mnasiadka> that one
09:25:23 <mnasiadka> #link https://review.opendev.org/c/openstack/magnum/+/905357
09:26:54 <mnasiadka> So, Swarm support drop is merged, I'll have a look at the rest of the drivers
09:27:00 <mnasiadka> Since we only have Kubernetes now
09:27:04 <jakeyip> oh yeah I had a brief look at that too
09:28:41 <jakeyip> am not sure, one thing was, should we limit it to CREATE_FAILED (and make sure the timeout we set will be < CI timeout, so it will always fail before CI kills it?)
09:40:50 <opendevreview> Michal Nasiadka proposed openstack/magnum master: Drop k8s_coreos_v1 driver  https://review.opendev.org/c/openstack/magnum/+/907300
09:48:02 <jakeyip> anyway let's end the meeting
09:48:05 <jakeyip> #endmeeting