14:00:16 #startmeeting kolla 14:00:16 Meeting started Wed Mar 20 14:00:16 2024 UTC and is due to finish in 60 minutes. The chair is mnasiadka. Information about MeetBot at http://wiki.debian.org/MeetBot. 14:00:16 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 14:00:16 The meeting name has been set to 'kolla' 14:00:20 #topic rollcall 14:00:23 o/ 14:00:37 o/ 14:00:46 \o 14:01:00 o/ 14:01:25 aravindh: it would be very welcome if you can rewrite it in python, I don't know about the cli framework you mentioned though. 14:01:49 ah they are gone 14:02:09 o/ 14:02:29 \o 14:03:33 o/ 14:03:39 https://www.irccloud.com/pastebin/wjoS0J7a/ 14:03:45 oops 14:03:50 #topic agenda 14:03:50 * CI status 14:03:50 * Release tasks 14:03:50 * Current cycle planning 14:03:50 * Additional agenda (from whiteboard) 14:03:51 * Open discussion 14:03:55 #topic CI status 14:04:05 I think it's mainly green, especially after fixing mariadb timeouts 14:04:46 jovial: how's kayobe CI fixing? 14:05:51 I've submitted a change to Matt's patch. Just awaiting CI. 14:06:15 great 14:06:19 #topic Release tasks 14:06:47 It's R-6 - client libraries release time 14:07:18 Any volunteer to switch Kolla to use Caracal UCA? 14:07:53 RDO as well for CentOS/Rocky builds 14:09:19 I guess I can make that again 14:09:29 Fantastic 14:09:29 #link https://review.opendev.org/c/openstack/kolla/+/891018 14:09:39 just for my personal reference 14:09:42 mnasiadka I can 14:09:50 great 14:09:53 two volunteers 14:10:00 mmalchuk: can you do RDO and I do UCA? 14:10:09 lets swap 14:10:20 I've already made change 14:10:22 okay, have to look up the RDO stuff again :D 14:10:30 ah alright, that makes sense then 14:10:40 no need for duplicate work 14:10:53 what does UCA stadn for? 14:11:00 Ubuntu Cloud Archive 14:11:09 ah! Ok! thx 14:11:20 #topic Current cycle planning 14:12:07 Let's go through dashboards 14:12:09 #link https://tiny.cc/kolla-dashboard 14:12:12 Maksim Malchuk proposed openstack/kolla master: [release] Use UCA Caracal https://review.opendev.org/c/openstack/kolla/+/913788 14:12:30 two exit code related patches and proxysql bump awaiting reviews 14:13:03 I just noticed comments on https://review.opendev.org/c/openstack/kolla/+/905116/2 (thanks frickler ) 14:13:06 I'll update today 14:14:35 #link https://tiny.cc/kolla-ansible-dashboard 14:14:39 mnasiadka UCA: https://review.opendev.org/c/openstack/kolla/+/913788 14:14:46 Kolla-Ansible dashboard - seems some patches also awaiting reviews 14:15:08 mmalchuk: thanks 14:15:27 Ok, anybody has any feature/patch that he needs reviews on - or just wants to talk about them? 14:15:57 well it would be nice if we have a clear plan with regards to bash and if people would like to have more bash linting (shellcheck) 14:16:04 so if we abandon bash (big 14:16:33 So, my first problem with shellcheck is that it seems the most widely adopted tool in openstack land is bashate 14:16:40 sorry hint enter to fast: +1 from me), I would not put much time in refactoring our bash 14:17:02 second of all, I prefer to reduce our bashisms instead of promoting them :) 14:17:45 mnasiadka: yes, what about this small podman fix: https://review.opendev.org/c/openstack/kolla-ansible/+/912521 14:17:48 any other comments? 14:17:56 I can agree to the second statement, I don't understand the first tbh. that's like saying: we already do pep8 linting on python, no need for any flake8 rules? they really don't conflict with each other 14:18:44 and honstly bashate doesn't really do much, you can count the checks it does on 2 hands and they are almost all only about optics, not about actual errors. 14:18:48 o/ 14:18:50 Maksim Malchuk proposed openstack/kolla master: [release] Change RDO's DELOREAN_DEPS repo to Antelope https://review.opendev.org/c/openstack/kolla/+/913790 14:18:57 but agreed, no new bash scripts then? 14:19:06 mnasiadka RDO: https://review.opendev.org/c/openstack/kolla/+/913790 14:19:23 Just on the podman support in kayobe. Do you think it is OK to land whilst podman is broken on ubuntu (https://review.opendev.org/c/openstack/ansible-collection-kolla/+/911422)? Otherwise how do I proceed? 14:19:38 SvenKieske: from my perspective it would be good to have a plan around what we can do to reduce number of bash scripts on the deployment side - and also have a plan for the CI side (if needed) 14:20:20 jovial: I think we should have that problem documented for users, that should be fine - and since next release we should be supporting 24.04 - it might get fixed there 14:20:38 maybe we should also have a precheck in kayobe/kolla-ansible warning users about possible problems? 14:21:12 can we maybe finish one topic before we start the next one? 14:21:31 so what about new bash scripts, e.g. https://review.opendev.org/c/openstack/kolla-ansible/+/836941/43/tests/test-container-engine-migration.sh ? 14:21:34 I'm a strong support of get ride of bash as much as possible. 14:21:46 just a random example 14:22:23 imho at first we should document in our dev guide that people please at least not add new bash scripts, bugfixes in existing scripts are fine I guess. 14:22:46 I guess I will write a docs patch for that and see if that gets traction 14:22:55 What is the replacement for bash? 14:23:01 python? 14:23:08 there is no replacement for now 14:23:29 once we have one, and patches like this one can reuse a ,,framework'' 14:23:40 then I'm fine with saying no bash, or whatever - adapt to current ,,framework'' 14:24:01 but now nobody has made any plan if we should continue with CI based on bash scripts 14:25:12 and it feels like PTG topic 14:25:20 do we all agree here - or is there some other proposal? 14:25:22 so I'm back at square one: if we don't have a plan to replace bash (and I don't really get the distinction between code for testing in CI and deployment code, both are equally important to me) we need to somehow ensure bash code quality, no? 14:25:41 There seems to be a lot of hate for bash. IMO stringing a load of shell commands together in bash script is a lot more readable than the python equivalent. 14:25:41 For me there are two types of bash usage in Kolla-Ansible 14:25:49 mnasiadka, CI = zuul so python/ansible/yaml as much as possible meaning almost everywhere. 14:25:50 I already added it to the PTG topics and I fear I do disagree on some fundamentals, but maybe let's discuss this at PTG then 14:25:59 the CI scripts - I'm fine with them being as they are today 14:26:10 But I'm also fine with whatever we decide 14:26:17 jovial, bash isn't portable neither it is readable imho 14:26:21 \o 14:26:49 the bash that we use in some places that gets executed on normal deployment - it might be better to replace that with Ansible/Python - on a case by case basis 14:26:51 bash runs on most systems ;-) 14:26:55 and that bash probably could do some linting 14:26:59 but we already have bashate 14:27:01 jovial: I don't hate bash - if that came across like that - I just wrote enough of it to know that it's very very hard to write bash without serious bugs without a linter like shellcheck 14:27:12 and I'm not going to tell it's bad or something, it might be limited 14:27:18 but we also don't lint a lot of other things 14:27:25 jovial, not really, there are so many exemple against that; Like the tests conditions for instance. 14:28:02 agreed, let's move the discussion to PTG then because I don't think we can agree on something actionable right now. I'll think about it for PTG to maybe come up with some proposal. 14:28:20 yeah, flame wars on PTG 14:28:32 Fl1nt, Do you mean running a bash script in alternative shell? 14:28:35 I've missed something... do we have any time slots for PTG with Google Calendar links? 14:28:36 and please also bring your proposals :) 14:29:36 Sounds like an interesting session :) 14:29:42 jovial, shell/bash/ksh/whatever bash isn't made to do code, it's made for commands chaining. 14:29:54 it's a useful tool sure 14:30:01 on daily ops looping :D 14:30:08 mmalchuk: https://etherpad.opendev.org/p/kolla-dalmatian-ptg - line 44 14:30:08 but for dev, it's horrible 14:30:20 and https://ptg.opendev.org/ptg.html 14:31:53 mnasiadka last PTG we use some website with planing where I can add google calendar events. do we have it now? 14:32:11 I wanted to add to the podman breakage: might it be worth to file a bug against the actual podman package in ubuntu? all I have seen so far is a bug against the linux kernel (which is also technically true, but there is a workaround patch in upstream podman) 14:32:45 mmalchuk: google calendar events? maybe it was on the doodle poll, but the timeslots are the same as usual 14:33:29 mnasiadka yep. doodle. do we have it now? 14:33:34 no, we don't 14:33:39 :( 14:33:42 doodle was only for a poll when to meet 14:34:00 you can ask on #openinfra-events if there's support for .ics file generation via the ptg website ;-) 14:34:12 (and maybe even contribute) 14:34:25 nevermind. will create events myself 14:34:37 jovial: it might make sense to file the bug as SvenKieske says 14:34:41 let's go forward 14:34:55 #topic Additional agenda (from whiteboard) 14:35:27 (SvenKieske): Skyline patches need core reviewers, look finished to me: https://review.opendev.org/c/openstack/kolla-ansible/+/910514 , basically all currently owned by Uwe: https://review.opendev.org/q/owner:uwe.jaeger@valiton.com 14:36:37 yeah, Uwe is pretty active actually and responds rather fast if you have feedback for improvements :) 14:36:51 but what I looked at myself is in good shape now imho 14:37:26 I noticed some stuff just got merged yesterday, thanks 14:39:34 and there's also some activity in the other stuff afaik, I need to re-review those myself, thanks so far. 14:39:38 (SvenKieske): please also review keystone bugfix: https://review.opendev.org/c/openstack/kolla-ansible/+/912452 14:39:54 CI is failing 14:40:01 yeah about that one, it's on my todo for today to investigate the upgrade job that fails with this in CI 14:40:19 Could not find versioned identity endpoints when attempting to authenticate. Please check that your auth_url is correct. Service Unavailable (HTTP 503)\n 14:40:26 noticed that myself but was busy, I thought I would have fixed CI until the meeting, sorry. 14:41:08 mnasiadka, For the ubuntu packaging issue. There is this one: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2052961, but now much activity. Adding a known issue to the release notes sounds like a good path forward for now. 14:41:15 this seems clearly related to the patch, maybe the task is called at the wrong place (to early)? not sure though 14:42:03 jovial: this is a bug against the linux kernel source, afaik. it would be better to report this against podman in ubuntu instead, if you want the fix to be backported, that is. 14:42:07 strange that all upgrade jobs are failed 14:42:21 ok then, next one 14:42:23 (ihalomi/mhiner): Patchset that bumped version of docker ( https://review.opendev.org/c/openstack/ansible-collection-kolla/+/910751 )didn't work because we install package python3-docker during tests using package manager and not pip. Debian currently doesn't support release of docker-py higher than 5.0.3, would it be possible to change installation using pip for all cases? Or maybe adding package package by ourselves to osbpo 14:42:23 repository as is it done in podman role 14:42:35 tldr: if venv is not used, the docker python package is installed through system package manager and required minimal version 6.0.0 is not available there 14:42:40 mmalchuk: yes, strange 14:42:55 mhiner: where do we install python3-docker? 14:43:02 from rpm/deb? 14:43:38 yes, but only if virtual environment is not used 14:43:46 and only on debian 14:44:03 SvenKieske, That makes sense. Totally missed that one was against the kernel :facepalm: 14:44:05 kevko: how do we get python3-docker bumped in Debian? 14:44:09 mhmm, but didn't we switch to use venvs everywhere? 14:44:14 mnasiadka: i've built and upload :D 14:44:24 mhiner: solves your problem? :D 14:44:39 jovial: no problem :) but I guess you won't get an answer there with regards to backports of podman patches ;) 14:44:52 if we don't use venvs in all CI - we should alter the CI I guess 14:45:01 +1 imho 14:45:14 I am a maintainer https://packages.debian.org/sid/python3-podman << it's sid ...but I've asked zigo to add to osbpo deb repo 14:45:17 or was that on purpose? (what would that be? local mirror instead of pypi?) 14:45:27 mnasiadka: I guess, since I'm only a middle man in this because Ivan can't attend these meetings :) 14:45:39 mhiner: ok, makes sense 14:45:53 mhiner: can you check where in CI python3-docker/podman gets installed and we rework this CI to use venvs? 14:45:55 oh, sorry python3-docker ... that package i asked also zigo to backport from sid 14:46:32 i don't think we should install packages via pip in operating system 14:47:02 also new ubuntu and debian distros don't allow installation via pip 14:47:15 no we didn't talk about operating system but to use a venv instead? at least to me that implies to not overwrite system-packages? 14:47:50 and the issue seems to be that we don't use venv everywhere so system package is used and version there is wrong. and the solution should be to just use venv everywhere 14:48:12 anyway, I hope mhiner/ihalomi can find the place and hopefully improve that 14:48:21 so you will set ansible_python_interpreter to something local env ? 14:48:23 kevko: afaik a proper venv everywhere would sidestep this :) 14:49:07 I confirm, it does, that's the way we build everything, container > venvs > pip > kolla > whatever 14:49:22 my point is that there are minimum python packages installed in system ... it would be better to handle it in system 14:49:40 what i know ..it's only python3-docker and python3-podman 14:49:53 what else do we need to run ansible modules against the host ? 14:50:37 sysctl stuff springs to mind, there's a current patchset floating around splitting it into it's own role 14:51:07 kevko, that's is just for kolla scope, not if you step back then you've got the same for ceph-ansible and many others that will necessarily collide with kolla at some point. 14:51:29 I find our distinction with host/container also rather fuzzy, because we tend to mount lot's of host stuff into the containers and stuff bleeds through everything (pid namespaces, net namespaces, user namespaces..) 14:53:06 Fl1nt: i don't think 14:53:29 kevko, it is, we do HPC and it does collide 14:54:58 Fl1nt: with system-wide python packages ? 14:55:00 we basically use venv everytime, so it makes sense to use that in CI - especially that we only use python3-docker/podman only on Debian in CI 14:55:07 kevko, yes 14:55:10 Mark Goddard proposed openstack/kayobe master: CI: Test custom routes & rules on EL9 https://review.opendev.org/c/openstack/kayobe/+/899941 14:55:21 we install from pip on other distros even if there is no venv 14:55:29 mnasiadka: ack +1; imho we should do in CI what we do in actual deployments (where possible) 14:55:50 I think I had some patches about that, will try to dig them out later 14:55:52 Fl1nt: containerize whatever it is ? 14:55:56 that doesn't mean that system packages can't be updated separately :) 14:56:08 Sorry, but we need to move to the last topic ;) 14:56:11 #topic Open discussion 14:56:13 kevko, wdym? 14:56:16 Any other topics? 14:56:52 just wanted to say thank you all for letting me learn a lot in the past year (it's almost a year since I work almost full time on this) 14:57:52 a year, nice - we all learn every day ;) 14:57:56 nice work ;) 14:58:10 yeah, the learning never stops :) 14:58:29 also just a couple of hours left for TC election, if you waited to make your vote, do it now 14:59:10 I actually just did that today, because I forgot it yesterday :D 14:59:14 frickler I didn't receive email with personal link... maybe google spam filter 14:59:42 mmalchuk: it doesn't come from opendev domain, but from a university, kevko had also trouble finding it 14:59:58 I know. so spam in progress) 15:00:28 mmalchuk: did you actually register? you may want to check the instructions https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/message/PXG7D3AUTFDOITTTLMJJHPUTXEHNMCMB/ 15:00:33 thats all, folks I need to go. mnasiadka thanks for chairing 15:00:46 mmalchuk: you might want to check for a mail sent 7. of march 2024 from "Condorcet Internet Voting Service (on behalf of Ian Y. Choi) " 15:00:51 ok then, it's time to finish the meeting 15:00:56 thanks for attending! 15:00:58 #endmeeting