14:03:30 <zxiiro> #startmeeting jjb
14:03:31 <openstack> Meeting started Fri Oct  6 14:03:30 2017 UTC and is due to finish in 60 minutes.  The chair is zxiiro. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:03:32 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:03:34 <openstack> The meeting name has been set to 'jjb'
14:03:37 <zxiiro> #chair waynr electrofelix
14:03:38 <openstack> Current chairs: electrofelix waynr zxiiro
14:03:49 <zxiiro> #topic JJB 2.0
14:04:28 <zxiiro> #info need to review electrofelix's patch https://review.openstack.org/506691
14:06:18 <zxiiro> #info The YAML Parser patch that was merged recently breaks using macros from inside other plugins.
14:06:45 <zxiiro> #link https://review.openstack.org/333076 YAML Parser patch
14:07:09 <zxiiro> #info waynr provided one possible solution https://review.openstack.org/503771
14:08:26 <zxiiro> waynr: I'm not sure about this solution though as I think it means we will have to know every plugin that allows macros and add explicit support for them right?
14:09:49 <waynr> zxiiro: that's right
14:11:16 <waynr> however, embedding the yaml parser in the module registry in order to refer back to it during xml expansion completely defeats the original motive for jjb 2 as far as i am concerned
14:11:58 <waynr> although it's worth pointing out that i no longer use JJB at all so my concerns shouldn't be considered a high priority
14:15:51 <zxiiro> We use macro expansion inside of various plugins extensively and it breaks our jobs so I think we need a solution. Whatever it ends up being.
14:16:01 <zxiiro> electrofelix: any thoughts?
14:20:57 <electrofelix> sorry. distracted
14:21:24 <electrofelix> just looking at the patch mentioned above
14:23:40 <electrofelix> I wonder is there a way to annotate the function to tell registry what to look for and then expand?
14:24:49 <electrofelix> i.e. move the dispatch code from inside the function, to being a decorator that adds some pointers that are added to the registry for added help when processing specific plugins on how to expand?
14:25:33 <waynr> ah yeah that's not a bad idea
14:28:17 <electrofelix> then once it's in the function it can just process the expanded content
14:28:44 <electrofelix> it would mean adding to the entrypoint loading code
14:29:09 <electrofelix> but I think that shouldn't be too difficult
14:29:40 <waynr> yeah
14:30:37 <zxiiro> hmm waynr is that something you can look into?
14:36:38 <electrofelix> I don't mind looking at it next, just been slow to get to things
14:36:55 <zxiiro> electrofelix: ok sure
14:38:06 <waynr> yeah i can't commit to much right now with the chicago move and all
14:38:22 <waynr> (moving from portland to chicago next weekend)
14:38:52 <zxiiro> #action electrofelix to look into fixing macro expansion issue caused by 333076 possibly using an annotated function call
14:38:55 <zxiiro> thanks
14:39:18 <zxiiro> #action waynr and zxiiro to review https://review.openstack.org/506691
14:39:27 <zxiiro> I think that's all i got.
14:39:31 <zxiiro> you guys got anything else to discuss?
14:40:09 <electrofelix> that's it from me
14:55:52 <zxiiro> alright I'll take that as meeting adjourned
14:55:53 <zxiiro> thanks guys
14:55:55 <zxiiro> #endmeeting