16:01:25 <TheJulia> #startmeeting ironic_bfv
16:01:26 <openstack> Meeting started Thu Jun 15 16:01:25 2017 UTC and is due to finish in 60 minutes.  The chair is TheJulia. Information about MeetBot at http://wiki.debian.org/MeetBot.
16:01:28 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
16:01:30 <openstack> The meeting name has been set to 'ironic_bfv'
16:01:55 <TheJulia> Good morning everyone!  Who is here for an ironic boot from volume meeting?
16:02:19 <phuongnh> good morning TheJulia :)
16:02:37 <dtantsur> o/
16:02:38 <derekh> o/
16:02:42 <tiendc> morning, everyone
16:03:03 <TheJulia> \o/ peoples!
16:03:45 <TheJulia> Our agenda can be found on the wiki, or the link I'm about to post.
16:03:48 <TheJulia> #link https://wiki.openstack.org/wiki/Meetings/Ironic-BFV
16:04:11 <TheJulia> It looks like this should be a very light agenda today
16:04:22 <TheJulia> #topic Announcements/Reminders
16:05:19 <TheJulia> The only reminder that I have at present is for people to review the outstanding patches as detailed on the etherpad.
16:05:27 <TheJulia> Does anyone else have any announcements or reminders?
16:07:07 * dtantsur does not
16:07:17 <dtantsur> except for review, review, REVIEW!!
16:07:25 <TheJulia> ^^^ That!
16:07:34 <TheJulia> Moving on then!
16:07:38 <TheJulia> #topic Current Status
16:07:55 <TheJulia> #link https://etherpad.openstack.org/p/Ironic-BFV
16:07:56 * derekh has to run all of a suddon, will read logs.
16:08:30 <TheJulia> Our etherpad details current status, I updated and rebased everything in the critical path in openstack/ironic this morning.
16:08:53 <TheJulia> It looks like we have some test failures occurring in the volume connector rest API, I've not had a chance to look into those yet.
16:09:58 <TheJulia> Basically, we need reviews.
16:10:17 <TheJulia> Does anyone have anything to report status wise?
16:11:42 <TheJulia> I'm guessing not, but I'll give folks another minute or so
16:12:44 <TheJulia> Moving on...
16:12:59 <TheJulia> #topic Planning/Priorities
16:13:28 <TheJulia> To me, this one is simple: Priority: Reviews and re-reviews.
16:13:53 <dtantsur> yeah. quite some activity on the next patch
16:14:07 <dtantsur> a good sign
16:15:38 <TheJulia> If nobody picks up the api revision by Monday morning, I'll take a look at it and start fixing the tests. I'm sure it is something minor, and the API changes are fairly standard as they are just matching up to the data model.
16:16:24 <TheJulia> Anyone else with priorities?
16:18:28 <TheJulia> Well, since the answer seems to be no right now, we shall move on to Open Discussion as we have no explicit discussion items.
16:18:42 <TheJulia> #topic Open Discussion
16:19:15 <dtantsur> for open discussion, let's open some beer!
16:19:21 <TheJulia> I like that idea
16:19:22 * dtantsur is not entirely kidding
16:19:28 * TheJulia goes and gets a beer
16:19:57 <dtantsur> we have a wine fest here though.. I need to review it!
16:19:58 <phuongnh> I would like to have some discussion on my patchset API temptest test https://review.openstack.org/#/c/473717/
16:20:17 <phuongnh> - Currently the gate failed because currently ironic-api-version=1.31, how can I get ironic-api-version=1.32?
16:20:28 <TheJulia> dtantsur: I like that idea! :)
16:21:09 <TheJulia> phuongnh: so you need inter and intra repo dependencies there.
16:21:39 <TheJulia> hm
16:21:44 <TheJulia> wait a second, not the patch I was thinking
16:21:48 * TheJulia looks more
16:22:39 <dtantsur> at first glance, min_microversion is set right
16:23:14 <TheJulia> phuongnh: you need https://review.openstack.org/#/c/214586/89 to be the parent
16:23:45 <phuongnh> oh, I see
16:23:58 <TheJulia> phuongnh: I say that because it looks like your revision has a master branch commit as its parent
16:24:23 <TheJulia> phuongnh: do you know how to change the parent?
16:24:30 <phuongnh> yes, master branch is its parent, I will change its parent
16:24:38 <TheJulia> awesome!
16:24:46 <phuongnh> TheJulia: I will google for it :)
16:25:12 <phuongnh> another question, should I add depend on nova patch?
16:25:27 <TheJulia> phuongnh: it is actually kind of easy, I'm happy to walk you through it in #openstack-ironic after the meeting
16:25:32 <TheJulia> phuongnh: that specific patch, no
16:25:58 <TheJulia> at least, I think the answer is no.  It appears that it is just interacting/testing the api contract for the ironic api
16:26:18 <phuongnh> TheJulia: I got it
16:26:27 <TheJulia> Where as the tempest scenario provided by https://review.openstack.org/#/c/472740/ does
16:26:59 <phuongnh> TheJulia: yes, I see your comment there :)
16:27:20 <tiendc> TheJulia: I see, I will update the patch
16:27:28 <phuongnh> the last question, should I split the file test_boot_from_volume.py to 2 files: test_volume_connector.py and test_volume_target.py ?
16:28:51 <dtantsur> do we have a similar split for other things? e.g. ports separate from portgroups?
16:29:47 <TheJulia> phuongnh: Ideally I would think so because connectors and targets are two separate things
16:30:14 <phuongnh> dtantsur: I am not sure about that, just think that the file should be objective
16:30:21 <TheJulia> dtantsur's question is also super valid
16:30:39 <dtantsur> I'd prefer to be consistent with whatever we do now. I don't feel strongly either way otherwise
16:30:39 <phuongnh> TheJulia: yes, I will do that :)
16:31:27 <TheJulia> I'd prefer delineation, but also do not feel strongly
16:32:05 <TheJulia> phuongnh: ports and port groups are split https://github.com/openstack/ironic/tree/master/ironic_tempest_plugin/tests/api/admin
16:32:32 <phuongnh> TheJulia: yes, I see
16:33:21 <phuongnh> tomorrow I will upload new patchset with update and add more test case "update"
16:33:29 <phuongnh> that is all for me
16:33:31 <TheJulia> Awesome, by chance do you have any interest in fixing some of the unit test failures on the api patch that needs to be the parent?
16:34:11 <phuongnh> yes, I will try to fix it too
16:34:27 <TheJulia> phuongnh: awesome, thank you :)
16:34:34 <phuongnh> thanks
16:34:40 <TheJulia> Do we have anything else to discuss today?
16:35:01 * dtantsur does not
16:35:34 <phuongnh> I have nothing :)
16:36:38 <TheJulia> Excellent, well then, thank you both, and I guess we will all get about 20 minutes back :)
16:36:50 <dtantsur> \o/
16:36:53 <dtantsur> thanks all!
16:37:02 <phuongnh> thanks
16:37:06 <tiendc> thanks
16:37:24 <TheJulia> See everyone next week!
16:37:27 <TheJulia> #endmeeting