15:00:03 #startmeeting ironic 15:00:03 Meeting started Mon Feb 8 15:00:03 2021 UTC and is due to finish in 60 minutes. The chair is TheJulia. Information about MeetBot at http://wiki.debian.org/MeetBot. 15:00:04 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 15:00:05 o/ 15:00:06 The meeting name has been set to 'ironic' 15:00:14 o/ 15:00:14 o/ 15:00:15 o/ 15:00:19 o/ 15:00:19 o/ 15:00:19 o/ 15:00:22 Good morning everyone! 15:00:33 It is time for our weekly meeting of maximum irony! 15:01:05 o/ 15:01:06 Our agenda can be found on the wiki, as always. 15:01:09 #link https://wiki.openstack.org/wiki/Meetings/Ironic#Agenda_for_next_meeting 15:01:30 o/ 15:01:33 o/ 15:01:38 * TheJulia tries to make a joke about rollercoasters, but *shrugs* 15:01:52 o/ 15:01:52 #topic Announcements / Reminders 15:02:30 #info This week is R-9 on the OpenStack Wallaby release cycle. R-6 is non-client library freeze. R-5 is client/library requirements freeze. 15:02:52 In other words, if youhave changes that need to go into sushy, ironic-lib, or the clients, it is important to get those moving forward ASAP. 15:03:23 #info This week concludes our seconds print of the release cycle, and we *should* be releasing at some point this week. 15:03:44 As an aside, it looks like the cryptography 3.4 release might cause us some difficulties there. Only time will tell :) 15:03:58 maybe worth - cores can edit hashtags =) 15:04:33 #info The team started having two weekly review jams, one EMEA focused time zone wise, and one US->Eastern APAC friendly time zone wise. 15:04:47 Dmitry Tantsur proposed openstack/ironic-python-agent-builder master: Upgrade pip to at least 19.1.1 https://review.opendev.org/c/openstack/ironic-python-agent-builder/+/774475 15:04:48 Details are on the wiki 15:04:49 trying this for the CI ^^ 15:04:49 #link https://wiki.openstack.org/wiki/Meetings/Ironic#Review_Jams 15:05:13 #info Cores can now edit hash tags on changes 15:05:24 iurygregory: is there some doc or guidelines writen for this yet? 15:05:36 if not, it might help to have something so we try and have consistency 15:05:41 TheJulia, I have an etherpad =) 15:05:46 \o/ 15:05:51 and a topic so we can discuss what we will use =) 15:06:03 I see it is in discussion now 15:06:07 Excellent, Onward! 15:06:17 Does anyone have anything else to announce or remind us of this week?! 15:07:51 * TheJulia hears the sounds of crickets and the corgi objecting to the LolCat in the window. 15:08:14 ++ to move 15:08:16 Sadly, I don't think the Corgi can join the OIF and review patches 15:08:27 hmm, why not? 15:08:39 eh, bylaws language 15:08:43 * iurygregory asks the same questions 15:08:45 Anyway, moving on! 15:09:12 we can understand if he is mad or not =) 15:09:13 Looks like we had no action items last week 15:09:23 Merged openstack/ironic stable/victoria: Don't mark an agent as alive if rebooted https://review.opendev.org/c/openstack/ironic/+/774410 15:09:41 dtantsur: iurygregory: one has to be a person to join the foundation afaik 15:09:54 what a discrimination! 15:10:00 heh 15:10:03 no owls either? did I lie somewhere? 15:10:08 lol 15:10:15 * TheJulia had a feeling this would be the thing 15:10:18 Anyway! 15:10:24 XD 15:10:25 #topic Sub-team status reports 15:10:26 #link https://etherpad.opendev.org/p/IronicWhiteBoard 15:10:39 Starting around line 265 15:12:14 bdodd: thanks for the update on raid 15:12:27 and my cat has decided I'm not allowed to have an HDMI connection this morning on my other monitor :\ 15:12:30 TheJulia YW! 15:12:42 TheJulia: they're definitely plotting something! 15:12:42 (This is what happens when you start your day at like 4:30 AM 15:12:43 ) 15:12:48 dtantsur: I know right! 15:12:58 omg 15:13:27 bdodd: fwiw, I think it is really close if not ready to go. Left a couple comments but aside from that I'm good with it 15:14:02 TheJulia Yes, I saw your comments. Thanks for those. 15:14:25 ajya: Thanks for the update on config molds 15:14:51 I guess kaifeng couldn't join us today. I've updated a few of the items with what I'm aware of 15:15:01 if there are no objections, we can proceed 15:15:54 * TheJulia hears crickets 15:16:06 TheJulia: yw 15:16:31 #topic Deciding on priorities for the coming week 15:16:40 #link https://etherpad.openstack.org/p/IronicWhiteBoard 15:16:58 Starting at line 129 15:17:45 It doesn't look like much merged last week :( 15:19:26 I've proposed four new items starting around line 200, if there are no objections we can add them to the list 15:19:36 But first, does anyone have anything else to add? 15:19:48 looks good 15:20:18 okay then 15:21:03 Err, 3 15:21:07 Moved those up in the list 15:21:36 Everyone good to proceed? 15:21:53 ++ 15:22:29 #topic Discussion 15:22:48 dtantsur: Would you like to start with your topic? 15:22:51 yep, thanks 15:23:02 #link http://lists.openstack.org/pipermail/openstack-discuss/2021-February/020329.html 15:23:15 tl;dr people start coming up with various in-band deploy steps 15:23:23 some of them can be potentially useful for a wider audience 15:23:33 so I wonder what we do (and whether we do) about it 15:23:51 we could start a new project with extra deploy steps. or we can add them to IPA with priority==0. 15:23:57 I'm kind of in the put them in ipa with priority=0 15:23:58 boat 15:24:01 opinions? cc JayF if you're around 15:24:43 being a separate package seems to cause confusion and pain for folks where as if it is just already there, it is relatively easy 15:24:46 i think to simplify things, put them in ipa. 15:24:58 having said that, i'm assuming we're talking 'little bit of code'... 15:25:51 lemme find an example 15:26:12 I would imagine some woudl be a little bit, and some would be really almost nothing because the code is already kind of there 15:26:34 https://github.com/dtantsur/ironic-netconfig/blob/master/ironic_netconfig.py 15:26:35 For me, at least, priority==0 kind of sets the bar 15:26:39 that's fine. just don't want ipa to get fat and cause ramdisk to get fat :D 15:26:47 this is what I'm preparing for my future blog post (spoilers!) 15:27:00 which also matches something that downstream requested 15:27:18 rloo: worry not then, our python code is negligible compared to other stuff there 15:27:23 like firmware 15:27:39 heh. for now. and hopefully forever ;) 15:27:43 and unlike binaries compress well 15:27:58 Firmware == root of all hardware evil 15:28:03 putting in a separate package just adds more overhead and confusion. 15:28:23 I fully agree 15:28:29 rloo: and also getting separate packages into build pipelines downstream and all 15:28:36 just... simple is key in my mind. 15:28:40 yeah, having in another project people will be a bit lost on how to use I think XD 15:28:41 ++ 15:28:53 Anyway, seems like we have consensus. 15:29:00 I would appreciate if you could comment in the ML thread 15:29:08 rfe please :) 15:29:12 to have visibility for anyone following 15:29:17 dtantsur: remind me about 15 minutes *after* the meeting 15:29:19 ack 15:29:23 I'll file an RFE per each item 15:29:27 if that's your request :) 15:29:44 * TheJulia readies the "rfe-approved" stamp 15:30:13 * dtantsur wonders if he has a chance to record a demo by tomorrow 15:30:18 seriously though, if it is default disabled, and generally helpful, I'm not sure the bar should be high. It should be "easy" 15:30:24 dtantsur: good luck! 15:30:32 Are we good to proceed to Iury's topics? 15:30:37 ++ 15:30:44 ok o/ 15:30:45 iurygregory: your turn :) 15:30:58 first topic hashtags =) 15:31:21 now all ironic cores can edit hashtags we can start using it to improve reviews 15:31:28 this was the main goal =) 15:31:36 #link https://etherpad.opendev.org/p/ironic_hashtag 15:31:39 I like the backport idea 15:31:56 I've started this etherpad so we can add the tags we would like to use 15:32:03 So I guess we'll shift reviewing priorities to "reviewing the hashtags"? 15:32:39 I think ironic and ironic-backport make sense to start with 15:32:53 if we add a patch to review priorities they need to have a hashtag so we can have a simple query in gerrit =) 15:33:02 something like ironic-priorities 15:33:05 ironic-current-sprint? 15:33:23 I'd avoid "priorities" as its absence may upset people 15:33:30 (and priority today != priority in a week) 15:33:32 any hashtag would work, and we can have more than one ofc 15:33:33 =) 15:33:36 \o/ 15:33:55 and just define in the search with and or etc =) 15:34:40 we can probably take some time this week and idea more ideas to the etherpad so we can discuss next monday I would say 15:34:48 dtantsur: that could work as well 15:34:53 ironic does seems a little too generic 15:36:00 so if you have ideas please add to the etherpad \o/ 15:36:28 with some explanation about the name so others can give +1 etc =) 15:36:28 who adds (and removes) the tags? 15:36:45 rloo, so, the owner of the patch can add/remove tags 15:36:53 and now the cores can also do this 15:37:18 what prevents all authors from adding this to their patch. everyone wants their patch reviewed? 15:38:11 people may forget ? =) and we also need to define a pattern 15:38:23 (is reminded of the patches where an author adds all cores to list of reviewers) 15:38:37 lol 15:39:11 I geuss we could make clear that certain tags are restricted, not sure if we can configure that in some way 15:39:20 I think whatever we settle on, we should keep it as simple as possible so it is single maintained list 15:39:28 so we can spot stuff like that and remove it 15:40:05 yeah 15:40:08 Backports being a slightly different mechanism where I think we might welcome peopel suggesting small fixes as backports 15:40:31 It is hard for us to guess on some things, so it actually can help us 15:40:34 next topic is about backports (+hashtag basically) 15:40:43 I know the hashtag thing was brought up in the midcycle. For myself, I would continue to look at our etherpad, wrt weekly priorities. For folks that want to use the hashtags, how do they envision using it etc. 15:41:21 for example you can have a dashboard in gerrit with the weekly priorities https://review.opendev.org/q/hashtag:ironic 15:41:36 and we can define the dashboards in the etherpad to help people =) 15:41:41 ++ Less need to tend to the state outside of maybe some context 15:43:47 so if you have ideas, please add to the etherpad and next week we will have some results of the hashtags we will use =) 15:44:05 just looked at iurygregory's link. guess whoever approves (or??) should remove the tag after it merges? 15:44:35 we can do things like hashtag:ironic state:open 15:44:41 unless we want to review/look at that list weekly in our meetings? in that case, we'd want them there with their hashtag and status. 15:44:42 or we add the state:open 15:44:45 yeah 15:45:46 status would help, I don't think people will remember to remove the hashtag after it merges (but maybe a bot or some sort of automation to remove tags from merged patches) 15:46:04 so maybe instead of the etherpad, they are listed/available via the hashtag? I'm concerned about too much overhead/duplication (and out of sync) info. 15:46:47 if we adopt the hashtags, we remove the prios from the etherpad and just leave the link to the filters? 15:46:54 the etherpad is just so we can define things, after we can probably add to the wiki 15:46:59 or our docs 15:47:07 Yeah, I'm thinking of moving away from maintaining a list in the etherpad 15:47:13 just keeping the couple canned links there 15:47:21 yup 15:47:29 ++ that would work for me. 15:47:31 and maybe earth shattering things that need attention 15:47:43 in weekly meeting, people coudl bring up their PRs, and we could (or not) add hashtag then. 15:47:51 This sounds reasonable 15:47:59 ++ 15:47:59 yeah 15:48:06 is it possible to only allow cores to add certain hashtag strings? 15:48:39 I don't believe so, but if we keep the list to a reasonable length, then it would be easy to remove improperly tagged things 15:48:44 we can restrict the hashtag usage to cores (not sure if we want) 15:49:08 ideally we'd resitrct only certain hashtags 15:49:10 We also don't have any controls over the etherpad at present, it is more on the honor system 15:49:18 true 15:49:25 If we try to over-complicate it, we're just going to make it more difficultg 15:49:27 difficult 15:49:29 yeah 15:49:36 right. one could go back and look at history of the etherpad though. and it isn't the PR itself. 15:49:44 so people need to know about the weekly meetings etc. 15:49:48 baby steps =) 15:49:58 just concerned that authors will see the hashtags and maybe think they should add one to their pr. 15:50:01 First we learn to walk, then we learn to run 15:50:13 rloo: I'm sure some will 15:50:26 rloo: and I think that is unavoidable, which is why the list needs to be tended to 15:50:29 i'm good if it can be restricted to cores. we can try this and if people keep accidentally adding it, we can restrict. 15:50:40 rloo: It is something I do at least once a week if not twice a week already 15:51:02 sounds like a plan rloo =) ++ 15:51:04 thx TheJulia. I don't want you have to do additional work to all that you do! 15:51:20 Thus far, we've really not had a problem outside of where people were asked to "hey, could you go add this to the list" 15:51:31 At which point, it makes sense as well 15:51:34 * TheJulia shrugs 15:51:36 Anyway 15:51:39 onward? 15:51:42 yeah 15:51:49 #topic Baremetal SIG 15:52:01 arne_wiebalck: would you like give the update? 15:52:06 Channel with videos of previous presentations now available from #link https://www.youtube.com/playlist?list=PLKqaoAnDyfgoBFAjUvZGjKXQjogWZBLL_ 15:52:22 Tomorrow: dtantsur on deploy steps! 15:52:29 :) 15:52:31 #info Youtube Presentations 15:52:35 Dmitry Tantsur proposed openstack/ironic-lib master: Add a helper for getting partition path https://review.opendev.org/c/openstack/ironic-lib/+/774502 15:52:38 I think that's it. 15:52:38 Actually... 15:52:53 #success Ironic now has videos posted youtube https://www.youtube.com/playlist?list=PLKqaoAnDyfgoBFAjUvZGjKXQjogWZBLL_ 15:52:56 TheJulia: Added success to Success page (https://wiki.openstack.org/wiki/Successes) 15:53:04 #link https://www.youtube.com/playlist?list=PLKqaoAnDyfgoBFAjUvZGjKXQjogWZBLL_ 15:53:07 =O 15:53:10 TheJulia: ++ :-) 15:53:10 nice 15:53:20 Anything else arne_wiebalck ? 15:53:27 No, thanks! 15:53:36 Any volunteeres for March yet? 15:53:42 iurygregory! 15:53:47 April!? 15:53:48 yep =) 15:53:50 Dmitry Tantsur proposed openstack/ironic-lib master: Add a helper for getting partition path https://review.opendev.org/c/openstack/ironic-lib/+/774502 15:54:00 TheJulia: you want another slot? 15:54:12 April is still available :) 15:54:13 arne_wiebalck: I suspect Talking about Secure RBAC may be good :) 15:54:14 eventually 15:54:23 Yes! 15:54:24 Anyway, sounds like we're done with the SIG updates 15:54:31 Moving to Open Discussion! 15:54:35 #topic Open Discussion 15:54:42 Now, about that take over the world plan.... 15:54:46 Talked with bdodd about this - there are 2 task monitors in sushy - https://opendev.org/openstack/sushy/src/branch/master/sushy/resources/taskservice/taskmonitor.py https://opendev.org/openstack/sushy/src/branch/master/sushy/resources/task_monitor.py 15:54:52 They are a bit different, used in different flows, but we think there should be only one. We're thinking about keeping taskservice's one as it's exposed in firmware update used by ironic's clean step. However, recently updated volume methods in sushy expose the other task monitor. Any way forward to deprecate that and unify both task monitors? 15:55:22 eek 15:55:26 does anyone remember how we ended with two of them? 15:55:38 Nope :( 15:55:45 I do :( 15:55:53 Would be easy to miss the other 15:56:27 Seems like that is going to take someone focusing on it for a little time to wrap their head around both task monitors 15:56:39 To figure out which one to deprecate, etc 15:57:36 need to understand what adjustments are necessary to make it work from places where it's used 15:57:50 we are thinking to keep taskservice's because that's used in ironic already 15:57:58 the other one is only internal to sushy, except the volume methods 15:58:04 I also thjink that's the best option 15:58:18 That does sound reasonable 15:58:25 I agree 15:58:48 Sounds good 15:58:59 the only thing - how to deprecate return type of volume methods? 15:59:01 Anything else for us all to discuss today? Or should we resume our plans to take over the world? 15:59:03 or deprecate method itself? 15:59:45 ajya: Hmmmmm maybe itself, but would need to look at each one first 16:00:35 ok, I'll look at unifying them and then can decide how to deprecate 16:01:50 Well, Thanks everyone! 16:01:57 Have a wonderful week! 16:02:03 thanks TheJulia , you too 16:02:06 Thanks, TheJulia ! 16:02:07 #endmeeting