17:00:00 <dtantsur> #startmeeting ironic
17:00:01 <openstack> Meeting started Mon Feb 13 17:00:00 2017 UTC and is due to finish in 60 minutes.  The chair is dtantsur. Information about MeetBot at http://wiki.debian.org/MeetBot.
17:00:02 <JayF> O?
17:00:02 <jlvillal> o/
17:00:03 <pas-ha> o/
17:00:03 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
17:00:04 <JayF> o/
17:00:04 <jroll> o/'
17:00:05 <zhenguo> o/
17:00:05 <vdrok> o/
17:00:05 <openstack> The meeting name has been set to 'ironic'
17:00:07 <TheJulia> o/
17:00:09 <mariojv> o/
17:00:10 <hshiina> o/
17:00:12 * jroll raises a cup
17:00:27 <rajinir_> o/
17:00:28 <dtantsur> hi everyone! welcome to the ironic weekly meeting!
17:00:29 <crushil> \o
17:00:30 <lucasagomes> o/
17:00:30 <aslezil> o/
17:00:34 <galyna> o/
17:00:36 <mariojv> congrats on your first meeting dtantsur
17:00:36 <jason77> o/
17:00:37 <rloo> o/
17:00:39 <rpioso> o/
17:00:41 <dtantsur> our agenda is where it usually is:
17:00:46 <dtantsur> #link https://wiki.openstack.org/wiki/Meetings/Ironic#Agenda_for_next_meeting
17:00:50 <jlvillal> +1 congrats
17:00:55 <dtantsur> thanks all :)
17:00:58 <galyna> hello, dtantsur :) congrats
17:01:13 <dtantsur> #topic Announcements / Reminders
17:01:22 <krtaylor> o/
17:01:33 <dtantsur> first, as you've noticed already, you'll see my leading this meeting much more often now :)
17:01:34 <rpioso> dtantsur: Congratulations!
17:01:39 <krtaylor> +1
17:01:40 * jroll dances
17:01:50 <rloo> dtantsur: the first more many :)
17:01:51 <dtantsur> huge thanks to jroll for EVERYTHING
17:01:57 <jlvillal> +1!
17:01:58 <rloo> s/more/of/
17:02:01 <lucasagomes> ++
17:02:02 <krtaylor> YES
17:02:07 <rpioso> Absolutely!
17:02:11 <vdrok> \o/ jroll !!
17:02:12 <rloo> who's jroll? :)
17:02:14 <jroll> psh, y'all did all the work, I just turned the steering wheel. thanks to YOU
17:02:17 <TheJulia> dtantsur: congrats :)
17:02:22 <dtantsur> also many thanks to JayF and TheJulia for running for the PTL this time
17:02:40 <jlvillal> It's an anagram of rloo with a 'j'
17:02:40 <rloo> ++ thx for making it harder for me to decide :)
17:02:45 <dtantsur> haha
17:02:45 <JayF> Thanks for winning to save us from the stack of work the PTL has to do ;)
17:02:51 <dtantsur> :)
17:02:55 <TheJulia> JayF: ++
17:02:56 <mariojv> jlvillal: jrool?
17:03:03 <jlvillal> Close enough ;)
17:03:06 <mariojv> :)
17:03:07 <jroll> mariojv: ja rule
17:03:19 <mariojv> lol
17:03:22 <galyna> :)
17:03:25 <dtantsur> now, to more sad things:
17:03:27 <rloo> jlvillal: :)
17:03:40 <vdrok> we have to release? :(
17:03:42 <dtantsur> we need to release today or tomorrow, and get stable/ocata for the final 3 projects: ironic, inspector and IPA
17:03:47 <davidlenwell> o/
17:03:48 <dtantsur> or even
17:03:52 <dtantsur> #info we need to release today or tomorrow, and get stable/ocata for the final 3 projects: ironic, inspector and IPA\
17:03:56 <jroll> ++
17:04:07 * rloo wonders why that is sad
17:04:09 <TheJulia> Bifrost also needs to be released, I think our last change should be going through CI now
17:04:18 <jroll> just waiting on this for ironic, afaik:
17:04:19 <dtantsur> TheJulia, good point, totally forgot about it
17:04:20 <jroll> #link https://review.openstack.org/#/c/431188/
17:04:20 <dtantsur> ironic-ui?
17:04:25 <jroll> ironic-ui is done
17:04:36 <JayF> jroll: will review that
17:04:38 <jroll> dtantsur: btw, I'm still pretending I'm PTL for ocata things
17:04:40 <jroll> :)
17:04:49 <dtantsur> jroll, pretend well please ;)
17:05:01 <jroll> heh
17:05:02 <JayF> Isn't that how it's supposed to work anyway? PTLs are assigned per project+release set
17:05:04 <dtantsur> e.g. I'm leaving it up to you to propose the final releases
17:05:12 <jroll> JayF: eh, kinda, not really
17:05:14 <jroll> dtantsur: yeah, will do
17:05:29 <dtantsur> jroll, I think we have reno clean up proposed against all three I*
17:05:32 <dtantsur> then we can release
17:05:45 <jroll> dtantsur: awesome, thanks
17:05:57 <dtantsur> next,
17:06:05 <dtantsur> #info The first in history PTG starts next week
17:06:06 <mgould> o/
17:06:41 <dtantsur> I'm looking for volunteers to try reserve a place for get-together one evening
17:06:49 <dtantsur> probably someone knowing the place :)
17:07:00 <JayF> Do we have anyone on the project in or familiar with the Atlanta area?
17:07:03 <vgadiraj> o/
17:07:12 <jlvillal> lucasagomes + Yelp = Success :)
17:07:25 <TheJulia> I lived in the atlanta area for about six months, so semi-familiar
17:07:25 * dtantsur approves lucasagomes :D
17:07:32 * JayF nominates TheJulia
17:07:34 <lucasagomes> jlvillal, I wish :-P
17:07:34 <mariojv> what night would this be? wednesday or thursday maybe?
17:07:41 <TheJulia> But, I have no idea what is around the conference center
17:07:54 <dtantsur> mariojv, we probably need a doodle
17:07:54 <rloo> fwiw, milan offered to organize the get together.
17:08:04 <lucasagomes> mariojv, would be good to have a vote
17:08:06 <dtantsur> rloo, that's why he's not here ;)
17:08:16 <dtantsur> TheJulia, so, could you please figure this out?
17:08:28 <rloo> dtantsur: even better :) it's in the ptg etherpad, i didn't make it up (this time) :)
17:08:28 <TheJulia> dtantsur: sure!
17:08:37 * jroll votes wed/thurs, refuses to plan it (sorry)
17:08:41 <mat128> o/
17:08:41 <dtantsur> #action TheJulia to try organizing a get-together on the PTG
17:08:45 <dtantsur> thanks!
17:08:45 <jroll> TheJulia: thank you!
17:08:53 <rloo> thanks TheJulia!
17:09:01 <dtantsur> any other announcements?
17:09:05 <davidlenwell> can someone paste the ptg etherpad?
17:09:07 <rloo> if i recall, it isn't hard to take the subway in atlanta...
17:09:08 <JayF> I'm also generally curious how many folks will be at the PTG Mon/Tues
17:09:09 * jroll asks ATL friends what might be good
17:09:15 <JayF> for the cross-project sessions
17:09:15 <dtantsur> davidlenwell, we'll get to it soon
17:09:23 <dtantsur> davidlenwell, but it's https://etherpad.openstack.org/p/ironic-pike-ptg
17:09:25 <lucasagomes> davidlenwell, https://etherpad.openstack.org/p/ironic-pike-ptg
17:09:29 <davidlenwell> I got last minute travel approval ..so I'll actually be there.
17:09:39 <dtantsur> JayF, I arrive on Sun
17:09:42 <lucasagomes> JayF, I will arrive on tuesday
17:09:49 * JayF arrives Sunday
17:09:56 * jroll sun-fri
17:10:00 * davidlenwell arrives sunday too
17:10:04 <dtantsur> and milan
17:10:05 * vdrok same
17:10:07 <rpioso> Suggest we post on etherpad.
17:10:12 <davidlenwell> good idea
17:10:22 <dtantsur> ++
17:10:35 <dtantsur> #topic Review subteam status reports (capped at ten minutes)
17:10:42 <dtantsur> #link https://etherpad.openstack.org/p/IronicWhiteBoard
17:10:55 <dtantsur> starts with line 90
17:11:33 <rloo> dtantsur: bugs go down, more features than bugs now :) or is it :(
17:11:38 <mariojv> TheJulia: made a doodle, feel free to use a different one (or i can give you the admin link for this): http://doodle.com/poll/urmpt82pax77vmuz
17:11:42 <JayF> As a note relating to subteam stuff: once ocata is cut, Rescue is sitting waiting reviews. I'd love if we could get it in early in Pike so we can land nova support as well.
17:11:56 <dtantsur> rloo, still more than 200, too many IMO
17:12:00 <TheJulia> mariojv: Awesome
17:12:07 <rloo> dtantsur: +1
17:12:26 * dtantsur wants to schedule something like regular bug triage meeting/mini-midcycles
17:12:47 <rloo> vdrok: are you OK if I delete the 'Some bugs vdrok thinks'... from etherpad?
17:13:09 <vdrok> rloo: sure
17:13:16 <dtantsur> #action Review rescue patches once Pike is open
17:13:22 <vdrok> I guess we won't do more anyway
17:13:26 <vdrok> in this cycle
17:13:38 <rloo> someone added the 'misbehaving -- provision-state thing. was it something proposed for ocata?
17:14:03 <dtantsur> rloo, this was found by me, I thought it's an easy win
17:14:15 <rloo> dtantsur: oh, i just deleted it. it was in the client from the looks of it.
17:14:16 <dtantsur> mat128, did you have a chance to take a look at yolanda's deploy steps spec?
17:14:23 <dtantsur> rloo, it probably is, ignore it
17:14:41 <rloo> vdrok: for portgroups support, is there still more docs needed?
17:14:50 <mat128> dtantsur: not yet, I'll put it on today's todolist
17:15:07 <vdrok> rloo: I don;t think so, maybe we should move those to install guide at some point tho
17:15:15 <vdrok> along with multitenancy docs
17:15:18 <rloo> jlvillal and vdrok: good news about grenade & multitenant
17:15:33 <vdrok> rloo: was it vsaienk0 ? :)
17:15:45 <jlvillal> rloo: And vsaienk0 for patching networking-generic-switch the correct way.
17:15:45 <rloo> vdrok: we should discuss; i think maybe admin guide, but not sure.
17:15:48 <jlvillal> Unlike my hack :)
17:16:02 * rpioso added attendance section to bottom of Pike PTG etherpad
17:16:03 <rloo> vdrok: oh, sorry, you might be right. vsaienk0, good work on grenade and multitenant!
17:16:15 <vsaienk0> rloo thanks :)
17:16:23 <rloo> vdrok: deleting the 'documentatoin' part of portgroups. it just needs tempest test, rigth?
17:16:40 <vdrok> rloo: right
17:16:56 <dtantsur> thanks rpioso
17:17:02 <vdrok> sorry for not updating that :(
17:17:07 <rloo> TheJulia: Monday today is 2/13 (wrt boot-from-volume)
17:18:00 <TheJulia> rloo: indeed :)
17:18:06 <rloo> wrt driver comp. jroll, dtantsur. someone added a comment saying it was done for ocata except for docs?
17:18:13 <dtantsur> rloo, it was me
17:18:27 <rloo> dtantsur: what about CI? can we consider than separate/follow up?
17:18:30 <dtantsur> notice: 2 minutes to review the statuses
17:18:36 <dtantsur> rloo, we have a non-voting job with ipmi hw type
17:18:49 <dtantsur> line #135
17:18:56 <rloo> dtantsur: and are there plans for more? (based on irc discussion earlier)
17:19:04 <jroll> and in pike we'll add more HW types
17:19:09 <dtantsur> jroll++
17:19:10 <jroll> and figure out how to deprecate classic
17:19:17 <dtantsur> we need cooperation with vendors on it
17:19:26 <jroll> right
17:20:13 <dtantsur> done reviewing statuses?
17:20:18 <rloo> wrt soft power off etc. that last bullet about treating separately.
17:20:29 <rloo> is that separate treatment being tracked?
17:20:35 <dtantsur> rloo, nope, just my proposal
17:20:45 <dtantsur> as it's not really part of "getting soft power/NMI in"
17:20:54 <dtantsur> just a consequence of our design decisions
17:21:07 <dtantsur> for context: rloo is talking about patches exposing supported_power_states in API
17:21:09 <rloo> dtantsur: it is part of the spec. i dont' care if we treat it separately or not, just so it isn't forgotten.
17:21:31 <dtantsur> the patches are up anyway, yeah. I think we can rename this section, if we think the other bits are done
17:21:39 <rloo> dtantsur: so can i delete that subteam then? or is doc still outstanding too?
17:21:39 <vdrok> that patch looks fine, just won't make it this release
17:22:03 <dtantsur> rloo, I don't quite remember, sorry
17:22:29 <dtantsur> we're 2 minutes past 10 minutes cap. ready to move on or do we need a few more minutes?
17:22:40 <rloo> dtantsur: ok, will leave it there until someone (ptl?) decides later.
17:22:54 <dtantsur> rloo, I think we rebuild these subteams on the PTG anyway
17:23:00 <rloo> dtantsur: this week's priorities?
17:23:01 <dtantsur> depending on what we call priorities?
17:23:11 <dtantsur> ah, yeah
17:23:25 <jroll> imo, release ocata and review all the ptg specs/proposals/etc
17:23:28 <jroll> specs in general
17:23:34 <rloo> imo, take the week off :)
17:23:38 <jroll> bug triage, RFEs, etc
17:23:43 * jroll saving time off for after ptg :P
17:24:04 <rloo> or maybe 'please test ocata' ?
17:24:09 <joanna> o/
17:24:14 <rloo> or maybe 'prepare for ptg' ?
17:24:32 <jroll> sure
17:24:40 <jroll> I think we all know generally what to do for this week :P
17:25:33 <rloo> are there other release notes/things to review to get releases done?
17:25:41 <dtantsur> there are moar release notes, yeah
17:25:59 <rloo> dtantsur: maybe put down in priorities
17:26:22 <dtantsur> done
17:26:25 <rloo> release notes are coming out of the woodwork now :)
17:26:27 <dtantsur> now looks good to me
17:26:33 <rloo> ++
17:26:41 <dtantsur> any objections/additions?
17:26:41 <jroll> agree
17:27:02 <dtantsur> ok, let's move to the biggest fun we may have today
17:27:04 <dtantsur> #topic PTG planning
17:27:12 <dtantsur> #link https://etherpad.openstack.org/p/ironic-pike-ptg
17:27:19 <jroll> uh oh
17:27:23 <dtantsur> is an etherpad with a lot (> 30) of topic ideas
17:28:00 <dtantsur> note that folks suggested (and I agree with that) to not have a formal schedule, but rather a flow of topics
17:28:31 <dtantsur> the "Summary of the proposed topics" section is the list of these topics, roughly grouped and roughly prioritized
17:28:42 <JayF> So the three days will be "organized" more like a mid-cycle than the traditional design summit?
17:28:56 <dtantsur> this was the idea, yeah
17:28:57 <jroll> yeah, that's how I imagined it
17:29:13 <rloo> unless folks have other ideas?
17:29:20 <dtantsur> now, seems like at least some projects still plan formal slots, but I was not impressed how it worked previously..
17:29:20 <JayF> Awesome. So it's also possilbe we'll have simultaneous stuff then, like a mid-cycle? Two groups with different interests talking about different things?
17:29:22 <rloo> that are better :)
17:29:36 <dtantsur> JayF, it is, and we'll plan such things as we go
17:29:43 * JayF mainly wondering if theres *one list* or if it's just "stuff to talk about"
17:29:58 <dtantsur> JayF, I don't quite see the difference
17:30:30 <JayF> In a world where you can break out smaller groups, I'm just not sure there's as much of a need to prune the list
17:30:46 <JayF> Is where I'm going with that :)
17:31:11 <TheJulia> JayF: I agree with that, not every topic will apply to everyone
17:31:18 <mariojv> the breakout sessions at the midcycle of 2015 were pretty effective imho
17:31:19 <dtantsur> well, I only suggest pruning right now, if there are items that people think should not be there at all
17:31:35 <mariojv> with a couple larger group sessions on high priority and contentious topics
17:31:42 <dtantsur> I'm pretty sure many of the things, especially from the second half, can be done in parallel
17:31:55 <jroll> I think pruning will be easier in person, "does anyone actually want to talk about x?"
17:32:01 <dtantsur> jroll++
17:32:18 <lucasagomes> jroll, I agree
17:32:21 <dtantsur> do folks want to decide *anything at all* right now, or just as we go?
17:32:25 <jroll> FYI nova plans to talk about placement/scheduling things wed afternoon, some of that will be ironic related. I'll be heading over to their room for that, other folks are welcome
17:32:55 * TheJulia makes mental note of that
17:33:11 * dtantsur makes physical note of that
17:33:19 * rloo interested in nova wed aft
17:33:28 * TheJulia updates calendar
17:33:40 * rloo votes to have JayF in charge wed aft
17:33:48 <krtaylor> wasn't there a Kolla/Ironic session also?
17:33:50 <JayF> wait, what?
17:33:53 * krtaylor searches...
17:33:55 <rloo> ha ha
17:33:55 <dtantsur> haha
17:33:55 * JayF didn't do it
17:33:59 <dtantsur> krtaylor, not that I'm aware of
17:34:14 <rloo> there was an email about kolla & ironic i think?
17:34:15 <jroll> there's a kolla topic about ironic
17:34:19 <jroll> but not a meetup sort of thing
17:34:25 <krtaylor> ok, thx
17:34:35 <jroll> there's nothing for the ironic team to do, afaik, they just want to deploy the thing
17:34:56 <JayF> they've come into channel with strange questions/issues in the past
17:35:06 <JayF> might be wise for one of us to pop in if we can
17:35:12 <JayF> to prevent spread of FUD or general misunderstanding
17:35:29 <krtaylor> I plan on attending most of Kolla Mon/Tues
17:35:35 * jroll touches his nose
17:35:39 * dtantsur too
17:35:40 <krtaylor> I'll be happy to report
17:35:54 <jroll> here's kolla's etherpad: https://etherpad.openstack.org/p/kolla-ptg-pike
17:35:58 <jroll> ctrl-f ironic returns nothing
17:36:00 <lucasagomes> I remember questions around how to deploy project atomic, because it uses OSTree so we couldn't use partition images for that (it requires some more complex root= kernel cmdline)
17:36:11 <lucasagomes> JayF, so ++
17:36:16 <TheJulia> krtaylor: I'll be around all week, so feel free to ping me and I can jump into one of their sessions if needed
17:36:30 <krtaylor> TheJulia, cool, will do
17:36:51 <dtantsur> thanks krtaylor, TheJulia
17:36:57 <jroll> yeah, I expect lots of "can <nick> come to <room> please" in irc channels next week :)
17:37:24 <krtaylor> hehheh
17:37:24 <TheJulia> jroll: That could be awesome, or get old very quickly :)
17:37:30 <vdrok> :D
17:37:41 * dtantsur moves attendance higher in the etherpad
17:37:42 <jroll> TheJulia: I think/hope it works well
17:37:53 <mariojv> would be neat if we got a couple large screens displaying an irc live stream
17:38:10 <jroll> TheJulia: I think it'll be similar to e.g. nova/ironic shared midcycles, where we could yell between them
17:38:54 <dtantsur> is there a dedicated IRC channel for the PTG?
17:39:25 <jroll> I think they discussed it, but not sure
17:39:34 <TheJulia> It appears that there might be one
17:39:35 <jroll> #openstack-ptg
17:39:36 <vdrok> oh, by the way, what's the scheduled time for all the things to happen? 9am-5pm?
17:39:41 <jroll> 17:39:28  -- | Topic for #openstack-ptg is "Discussion of the Project Teams Gathering and for use during the PTG for on-site announcements"
17:39:56 <TheJulia> ^^^
17:40:21 <dtantsur> #link http://doodle.com/poll/urmpt82pax77vmuz#table is the poll for a team get-together
17:40:40 <TheJulia> dtantsur: I was just going to mention that :)
17:40:48 <dtantsur> #info IRC channel openstack-ptg will be used for coordination during the PTG
17:41:11 <TheJulia> If people could fill that out today/first thing tomorrow, that will help me out figuring how many people and time windows
17:41:26 <dtantsur> TheJulia, wanna send out a email?
17:41:30 <TheJulia> Sure
17:41:38 <dtantsur> or are we going to keep it private for folks who don't skip meetings? :)
17:42:00 <rloo> wow, that's err a big poll...
17:42:05 * jlvillal is sad he won't be there :(
17:42:06 <dtantsur> anyway, anything else here? schedule suggestions, logistics, etc?
17:42:09 <dtantsur> jlvillal, :(
17:42:15 <lucasagomes> jlvillal, :-/
17:42:26 <dtantsur> oh, when filling in the attendance, please also state your hotel/rough location
17:42:27 <jlvillal> But rloo will be! :)
17:42:31 <rloo> jlvillal: :-(
17:42:51 <rloo> jlvillal: :-( to that too!
17:43:12 <dtantsur> moving on?
17:43:14 <jroll> dtantsur: "attendance" - on the poll or elsewhere?
17:43:21 <JayF> jroll: it's in the pike ptf
17:43:30 <JayF> *etherpad, line 81
17:43:33 <dtantsur> jroll, etherpad
17:43:37 <dtantsur> right
17:43:37 <jroll> oh right in the middle, heh
17:43:57 <rloo> TheJulia: when you send out email, perhaps also mention the Attendance thingy in the ptg etherpad too
17:44:23 <dtantsur> ++
17:44:39 * rloo wonder why dtantsur wants to know where we're staying
17:44:48 <dtantsur> hehehe
17:44:52 <NobodyCam> :)
17:44:59 <rloo> dtantsur: any word on logo?
17:45:07 * rloo sorry she asked that
17:45:11 <dtantsur> rloo, I haven't heard anything
17:45:12 <jroll> oh yeah, need to loop back on that
17:45:22 <dtantsur> it's probably still on jroll's plate
17:45:39 <jroll> I completely forgot about it
17:45:43 <jroll> because I really don't care
17:45:46 <joanna> I sent the email about adding horns to make the bear more metal, but I suppose nobody likes that idea
17:45:47 <dtantsur> ++
17:45:49 <TheJulia> rloo: will do
17:45:50 <jroll> was hoping she'd answer lucas' questions
17:46:10 <jroll> dtantsur: I'll bump one of the threads this week and include you
17:46:15 <dtantsur> jroll, thanks!
17:46:15 <jroll> today or tomorrow
17:46:17 <rloo> jroll: ++ but no peep
17:46:35 <JayF> I will be bringing my cache of Pixie Boots stickers to the PTG
17:46:36 <dtantsur> anything else here?
17:46:40 <JayF> so snag me if you don't have one yet :)
17:46:46 <lucasagomes> jroll, yeah me too, but seems the ML thread is now dead :-/
17:46:47 <dtantsur> JayF++ though I still have a few
17:46:48 <rpioso> JayF: +1
17:47:21 <dtantsur> #topic RFE review
17:47:32 <dtantsur> I have a few prepared
17:47:47 <dtantsur> #link https://bugs.launchpad.net/ironic/+bug/1662446 Add should_bind_property to NetworkInterface
17:47:47 <openstack> Launchpad bug 1662446 in Ironic "[RFE] Add should_bind_property to NetworkInterface" [Wishlist,In progress] - Assigned to Vasyl Saienko (vsaienko)
17:48:01 <vdrok> +1 from me :)
17:48:03 <rloo> dtantsur: you can't have any prepared w/o noting them in the agenda.
17:48:12 <rloo> dtantsur: but we'll make an exception for you today :)
17:48:14 <dtantsur> rloo, sorry :)
17:48:14 <jroll> well, you can
17:48:19 <jroll> it's just annoying :P
17:48:35 <rloo> jroll: esp since we're supposed to mention them the thurs before or something like that and we never do!
17:48:41 * vdrok was getting ready to get back to beer
17:48:51 <dtantsur> whatever, I can skip it
17:49:04 <mariojv> i'm +1 to the part that adds binding:host_id
17:49:07 <jroll> rloo: meh
17:49:11 <mariojv> i think "do some things" should be more specific, though
17:49:12 <jroll> dtantsur: go ahead it's cool
17:49:18 <milan> JayF ++
17:49:24 <rloo> jroll: so we should remove that note about thurs etc :)
17:49:49 <dtantsur> context: currently we do thinks like "if node.network_interface == 'neutron': # some logic"
17:50:07 <jroll> rloo: idk, people should try to be respectful, but if nobody reads anyway, meh.
17:50:23 <dtantsur> I'd prefer we move these to explicit flags/properties on task.driver.network instead
17:50:26 <rloo> i'm good with this, except i would like more details about the new property. described in the bug.
17:50:31 <jroll> well
17:50:40 <jroll> why shouldn't those things be abstracted to the driver
17:50:53 <rloo> jroll: i try to read the morning of, to prepare :)
17:50:56 <jroll> instead of https://github.com/openstack/ironic/blob/b9a792af9f90dcaa33896a82a4183ad403155591/ironic/common/neutron.py#L198
17:51:08 <jroll> we should have node.driver.network.set_bind_host_id()
17:51:26 <dtantsur> or this, yes
17:51:40 <vdrok> maybe even get_port_body then?
17:51:56 <vdrok> to be completely abstract
17:52:14 <jroll> sure, something like that, I don't think we need an RFE for this tbh
17:52:20 <dtantsur> another example: https://github.com/openstack/ironic/blob/b9a792af9f90dcaa33896a82a4183ad403155591/ironic/common/neutron.py#L407
17:52:25 <jroll> consider this a bug:  if node.network_interface != 'flat':
17:52:27 <jroll> and go fix it
17:52:34 <jroll> we shouldn't ever need to write that
17:52:56 <dtantsur> ok, objections to converting this to a bug?
17:52:59 <rloo> jroll: unless the solution is a change to an API, then we do need an RFE
17:53:08 <rloo> i think
17:53:15 <jroll> rloo: a REST API, imo
17:53:18 <dtantsur> well, it does change the driver interface, right?
17:53:22 <rloo> any API
17:53:23 <jroll> an interface api, idk
17:53:27 <TheJulia> any api imho, otherwise agreed
17:53:37 <jroll> oh
17:53:51 <jroll> I thought we did specs for API changes (even if I thought it was REST API only)
17:53:54 * jroll muahaha
17:54:52 <jroll> anyway, yeah, I'm fine with this rfe, I'm also fine with a new method
17:55:28 <dtantsur> hmm, I'd remove the @abstractproperty as it's going to break the backward compatibility. otherwise looks fine
17:55:41 <jroll> ah yeah
17:55:41 <rloo> it depends on the 'places' where that kind of code is being used. (i mean, whether it is a property or a method)
17:56:00 <dtantsur> rloo, currently it's just a static flag
17:56:09 <dtantsur> but I was mostly objections to "abstract" bit
17:56:35 <rloo> dtantsur: no abstract if it breaks backwards compat.
17:56:49 <dtantsur> yep
17:57:23 <dtantsur> so, rfe-approved with removal of "abstract"?
17:57:51 <sambetts> sounds good to me
17:58:00 <rloo> dtantsur: not quite. i still want to know what it will be set to
17:58:09 <rloo> dtantsur: i mean, default value in the base class is what?
17:58:27 <rloo> and it should say that it is a flag...
17:58:39 * rloo tired of descriptions being incomplete. makes it harder to review later.
17:58:48 <dtantsur> yeah, makes sense
17:58:58 <dtantsur> rloo, mind summing it up in a comment?
17:59:07 <rloo> dtantsur: i can do after the meeting
17:59:10 <dtantsur> thanks!
17:59:11 <TheJulia> One minute
17:59:16 <dtantsur> right
17:59:24 <dtantsur> any other extremely quick comments? :)
17:59:37 <JayF> dtantsur: good 1st meeting :D
17:59:37 * TheJulia hears crickets
17:59:38 <JayF> o/
17:59:41 <jroll> \o/
17:59:41 <vdrok> thanks!
17:59:42 <TheJulia> Thank you dtantsur
17:59:43 <dtantsur> o/
17:59:44 <NobodyCam> o/
17:59:45 <jroll> thanks dtantsur
17:59:48 <lucasagomes> o/
17:59:49 <crushil> \o
17:59:51 <rpioso> o/
17:59:56 <vgadiraj> \o
17:59:56 <rloo> thx
17:59:57 <aslezil> o/
18:00:00 <dtantsur> #endmeeting