17:01:08 #startmeeting ironic 17:01:09 :) 17:01:09 Meeting started Mon Dec 5 17:01:08 2016 UTC and is due to finish in 60 minutes. The chair is jroll. Information about MeetBot at http://wiki.debian.org/MeetBot. 17:01:10 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 17:01:11 o/ 17:01:11 o/ 17:01:12 The meeting name has been set to 'ironic' 17:01:16 o/ 17:01:17 o/ 17:01:18 Hello to everyone! 17:01:20 o/ 17:01:23 o/ 17:01:23 o/ 17:01:24 rloo and all, I'd like to ask about the priority of etags spec in api evolution. As for my status, the spec is updated and needs a review https://review.openstack.org/#/c/381991/. And approapriate patches, POC are up, just need uninttests. Thanks for you review in advance 17:01:25 o/ 17:01:33 o/ 17:01:40 o/ 17:01:53 o/ 17:01:54 o/ 17:01:59 o/ 17:02:07 galyna_: please wait for open discussion for review requests :) 17:02:27 as always, the agenda: 17:02:31 #link https://wiki.openstack.org/wiki/Meetings/Ironic#Agenda_for_next_meeting 17:02:37 #topic announcements and reminders 17:02:52 I just have one thing, I'll be out next week, does someone mind running the meeting? 17:03:17 I could run it 17:03:26 awesome, thanks! 17:03:31 #info TheJulia to run next week's meeting 17:03:32 jaypipes asked about reviews on resource providers stuff -- http://lists.openstack.org/pipermail/openstack-dev/2016-December/108393.html 17:03:47 vdrok: yeah, that's on my list for today, I encourage others to review it 17:04:56 anything else? 17:05:01 o/ 17:05:02 o/ 17:05:27 #topic subteam status reports 17:05:30 as always 17:05:32 #link https://etherpad.openstack.org/p/IronicWhiteBoard 17:05:35 around line 79 this week 17:05:53 o/ 17:06:05 o/ 17:06:12 looks like dtantsur|brb didn't have time to update bug stats, but I know I saw JayF helping with some triage last week, thanks for that! 17:06:13 my apologies for missing notification status update last week; i was on vacation 17:06:19 it's updated this week 17:06:43 I have been, there's a lot more left to go 17:06:55 but I'll keep trying to triage a couple dozen a day until I've worked through them all 17:07:21 oh, is dtantsur|brb away today? 17:07:31 i can update the bug stat i think... 17:07:39 o/ 17:07:45 rloo: nice, thanks 17:08:02 rloo, I'm semi-away, sorry :( 17:08:19 o/ 17:08:24 o/ 17:08:30 luzC: nice job fixing the postgres job :) 17:08:45 er, lucas is not here :( 17:09:24 looks like rolling upgrades spec can land this week 17:10:38 BFV made good progress \o/ 17:10:44 only cores can do bug triage? 17:10:50 xavierr: No 17:10:54 I don't think so 17:11:01 xavierr: no, anyone can help, just be sure to ask questions if you don't know things 17:11:02 xavierr: You just need to join the launchpad group 17:11:10 ok, bug stats updated. inspector has 2 critical! :-( 17:11:34 jroll jlvillal o/ 17:11:39 xavierr: https://launchpad.net/~ironic-bugs 17:12:37 jlvillal: thanks 17:12:46 * dtantsur back 17:12:52 thanks rloo for covering me with bug stats 17:13:04 dtantsur: yw, the hardest part was doing the math :) 17:13:26 xavierr, join that group and get acquainted with https://wiki.openstack.org/wiki/BugTriage 17:13:31 that's all you need 17:14:30 TheJulia, re BFV nova part: I guess it's in pretty sad condition, right? 17:14:39 * xavierr have successfully joined Ironic Bugs Team 17:14:41 dtantsur: wrt inspector. 'there might be some controversion w/r ...'. controversy? 17:15:06 rloo, it was not me who wrote that, but yes :) 17:15:07 dtantsur: I've not touched it because I pretty much considered that I was mainly pushing this stuff forward alone and the the only way I would be able to get stuff moving is one cycle at a time per project 17:15:14 * dtantsur would definitely confuse these words as well 17:15:27 dtantsur: tl;dr help on that front would be awesome! 17:15:31 TheJulia, ok, Lucas and I may will with it 17:15:37 s/may will/will help/ 17:15:43 \o/ 17:16:14 * TheJulia looks at the clock 17:16:25 indeed 17:16:39 anything we should add/remove in terms of what to look at this week? 17:16:46 * jroll puts next driver comp patch in there 17:17:07 rloo, ah, yeah 17:17:09 thx 17:17:14 milan: :) 17:17:27 just a note: I'm out Dec 17 - Jan 2 17:17:48 good to know 17:17:50 so we'd better land a few driver composition before that :) /me sees one on the priority list, good 17:17:53 Similarly; I'm out 12/17 - 12/26 17:17:54 o/ 17:17:54 I actually put this on the agenda 17:18:01 so let's wait to all post our vacation :) 17:18:05 jroll: the review url for bfs stuff needs to be updated, but I can take care of that later. Ether pad is hung for me at the moment 17:18:18 'so we better land everything before Dec 17' :D 17:18:20 err, bfv 17:18:21 TheJulia: link it here and I'll do it :) 17:18:27 https://review.openstack.org/#/q/status:open+project:openstack/ironic+branch:master+topic:bug/1559691 17:18:50 thanks 17:19:10 anything else on this topic? 17:19:11 I'm expecting to be semi-unavailable for a few days around the 26th, but I'm fine with a meeting on the 2nd. 17:19:11 does anybody has a link to nova bp handy? 17:19:18 dtantsur: for? 17:19:24 jroll, BFV 17:19:33 dtantsur: not sure we have one, we don't expect it to happen this cycle 17:19:38 afaik 17:19:41 dtantsur: I'll get it, give me a couple minutes 17:19:42 I may be remembering wrong 17:19:44 oh cool 17:19:45 we do, I saw it today 17:20:16 aha, https://blueprints.launchpad.net/nova/+spec/ironic-boot-from-volume 17:20:23 ahh, thank you dtantsur 17:21:28 ok, anything else? 17:22:05 #topic what are core's schedules like for december? What meetings should we cancel? (initial proposal, cancel Dec 26 and Jan 2) 17:22:20 so I'm out dec 9-14 and dec 22 - jan 2 17:22:34 and propose we cancel meetings for dec 26 and jan 2 17:22:35 I'm out Jan 2 and Jan 7 :'( 17:22:57 i'm out dec 22 - jan 8 17:23:10 I am out 24-Dec-2016 through 2-Jan-2016. Back on 3-Jan-2016. 17:23:20 I'm only really expecting to be out the 26th, maybe sporadically that week. 17:24:01 not core but out 22nd-27th, probably 1 more day last week of december, and jan. 2nd 17:24:07 I'm out 12/17 - 12/26 17:24:15 jroll: I wonder why we should even try to have the 12/19 meeting 17:24:24 jroll: why not cancel 12/19, 12/26 and 1/2 17:24:36 I will be here the 19th 17:24:44 I'll be here Jan 2 btw 17:24:48 But agree with cancelling 112/26 and 1/2 17:24:49 JayF: seems like at least a few people will be here 12/19 17:24:52 there are at least 4 cores that will be here the 19th. 17:25:00 i think cancelling 3 meetings in a row is too much 17:25:00 I'm out only on 19th and 26th 17:25:12 * JayF just trying to save others from meetnigs, he won't be at a 12/19 meeting either way 17:25:17 Lets just cancel the 26th, if we have super short meetings on the 19th and 2nd, then \o/ 17:25:23 I'm out 12th -> 3rd 17:25:25 TheJulia: you don't get 1/2 off? 17:25:28 +1 to keeping the 19th meeting. it'll probably be short though 17:25:35 okay, we could leave jan 2 if people like, can't hurt 17:25:36 TheJulia: most people in US should get 1/2 off as observation of NYD 17:25:39 will need someone to run it though :) 17:25:43 JayF: I dunno :) 17:25:53 think TheJulia can run them :) 17:25:54 jroll, I can run Jan 2 if needed.. though I'm not sure it's going to be useful 17:26:27 JayF: Holidays are weird for me since my significant other works for a bank. 17:26:32 dtantsur: it might be nice for the people that are around to sync up 17:26:46 jroll, ok, I can run it if I'm not too wasted that day 17:26:58 heh 17:26:59 jroll: I think syncing up would be a good idea so we don't loose all velocity until mid janurary 17:27:07 okay, we'll leave it 17:27:29 thanks y'all 17:27:31 that reminds me, we have < 2 months before ocata release 17:27:35 so, only 12/26 is out for everyone, right? 17:27:40 sounds like it 17:28:11 #topic RFE review 17:28:15 rloo: take it away :) 17:28:41 https://bugs.launchpad.net/ironic/+bug/1638505 17:28:41 Launchpad bug 1638505 in Ironic "[RFE] Allow to not cache images on conductor for iPXE nodes in standalone mode" [Wishlist,New] - Assigned to Pavlo Shchelokovskyy (pshchelo) 17:28:59 should we require a spec for that? 17:29:24 I thought we do have a spec, but maybe I'm wrong 17:29:52 I'd personally like a little more context on that RFE. 17:29:59 I seem to remember a spec too, pas-ha isn't here 17:30:02 I would as well 17:30:11 let's ask for one and maybe there already is one :) 17:30:17 ok, let's ask for one. 17:30:26 next ... 17:30:27 https://bugs.launchpad.net/ironic/+bug/1639688 17:30:27 hmm, I thought about https://review.openstack.org/#/c/392290/ 17:30:28 Launchpad bug 1639688 in Ironic "[RFE] Add "reset bios settings to default" to iRMC drivers as cleaning step" [Wishlist,New] 17:30:48 Not sure if the scope is sufficent. What does "default" mean? Seems to me that the BIOS settings depend on the role/flavor. 17:30:54 rloo, I'm fine with that 17:31:01 rpioso, I think to factory defaults, but I may be wrong 17:31:08 I'm fine with it too, but rpioso has a good question 17:31:10 oh yes, probably 17:31:35 I'm generally fine with any cleaning step added to a driver 17:31:39 dtantsur: I don't feel that would be sufficient. 17:31:40 i think that RFE needs to be expanded, though 17:31:41 as they would be the experts 17:31:51 but I would like the RFE to mention if it's going to be a priority =0 or >0 17:31:54 rloo: I'm also fine with it just being an RFE for a cleaning step. 17:31:55 I vote for an RFE. I'm interested in helping with it. 17:32:06 so clarification in the rfe itself, no spec required. 17:32:10 +1 17:32:53 we good with that then? 17:33:00 as usual, I vote for more drivers to support the same thing, but I'm fine with RFE 17:33:09 moving on... 17:33:12 https://bugs.launchpad.net/ironic/+bug/1640546 17:33:12 Launchpad bug 1640546 in Ironic "[RFE] Sub-endpoints of ironic resources should be considered subcontrollers, not fields of the resource" [Wishlist,New] - Assigned to Vladyslav Drok (vdrok) 17:33:34 sounds like a refactoring/bug, not RFE 17:33:43 this feels like another pecan bug to me 17:33:49 hm, I don't remember making it an rfe :) 17:34:02 oh yes, I did, sorry 17:34:12 vdrok: i added 'rfe' cuz you tagged it as an rfe. 17:34:23 it is going to require a microversion bump 17:34:33 yup 17:34:47 that seems straightforward enough not to require a spec, even though it changes api behavior 17:34:47 i am fine if it is a bug. i can't remember if an rfe is needed for a microversion bump 17:34:51 dtantsur: I agree re: more drivers to support BIOS thing. 17:35:03 I almost wonder if we should just leave it if we're going to want a microversion bump 17:35:20 I would argue like crazy against this behavior if it was new 17:35:28 but now that it's there I'm not sure I see a benefit in removing it 17:35:46 maybe a microversion bump is warranted even though it's just changing error-like behavior.... in case clients rely on the 400 17:35:47 I only want a microversion bump because it's a significant-enough change in behavior to break some clients imo 17:35:53 +1 JayF 17:35:57 mariojv exactly 17:36:01 yes, if we do it, we need a version bump 17:36:06 the question is: should we? 17:36:19 I don't think we should, but could be convinced otherwise 17:36:30 i think we should 17:36:36 400 is for syntax errors generally, right? 17:36:58 I'm +1 to fixing our API endpoints 17:37:00 does it matter either way? it is a bug so seems like we should fix it. 17:37:11 #link https://en.wikipedia.org/wiki/List_of_HTTP_status_codes#4xx_Client_Error 17:37:12 the only inconvenience it brings is - some subendpoints return 404, some 400 17:37:21 oh wait 17:37:22 just not a high priority thing though 17:37:31 +1 to not high priority 17:37:33 is this only fixing the status code? 17:37:50 sorry, I thought this was also about making /nodes/foo/driver_info not succeed 17:37:55 jroll: about removing possibility too :) 17:38:01 if this is only s/400/404/ I'm good with it 17:38:06 not good with the other bits 17:38:12 oh, i did not know that vdrok 17:38:17 I don't see a real benefit to that 17:38:28 i agree with jroll in that case. i just think the status code should change 17:38:35 OK, I'll remove the last paragraph theb 17:38:37 then 17:39:09 well, remove part of it :) 17:39:16 idk, what do other people think? 17:39:26 jroll: its about fixing our REST api to be more consistent, how do you tell the difference between a subresource and a field on the node? e.g. nodes/node-0/ports vs /nodes/node-0/driver_info 17:39:47 I'm personally +1 to only allowing subcontrollers/resources in the URL 17:39:58 * JayF does not have strong opinions on api semantics 17:40:00 yeah, consistency is good 17:40:07 fields should be accessed using GET /nodes/node-0?field= 17:40:08 * jroll waffles some more 17:40:15 is that also a thing? 17:40:23 fields* 17:40:25 yeah 17:40:28 ಠ_ಠ 17:40:41 yes, a list can be specified there too 17:40:46 oh right, that 17:41:21 maybe it's fine, why not 17:41:26 sambetts: different links returned in response? 17:41:28 * jroll is not decisive today 17:41:40 this way we can distinguish subresource or just a field 17:41:56 in either case, neither of those should require a spec, right? 17:42:17 This seems more than something that can just be masked with a micro version... and to qariojv's point, it needs a spec. 17:42:17 i think we were originally trying to decide spec / no spec 17:42:38 * sambetts wonders if we should include this sort of thing in the API reworking that devananda was working on and talked about at the summit 17:42:48 sambetts: I'm kind of wondering the same 17:42:56 yeah, let's have a short spec on this 17:42:56 TheJulia: so you think the removal of /node-0/ should require a spec, but status code should not? 17:42:56 we should cover all the endpoints for nodes/ports/portgroups 17:43:05 sambetts: +1, then it could be done all at once 17:43:08 this would just be adding to the list of api things to do 17:43:22 I'd also be fine with a 'fix all the subresource junk' spec 17:43:24 sambetts, +1 about API. It may touch etags 17:43:43 mariojv: if we're starting to change the overall behavior of the api, I worry we would have to maintain backwards compatibility, which means we will just end up with quite a headache. 17:43:45 yeah, if there are more changes than this required for subresource fixing, then a spec would be good 17:44:00 i don't see that it matters if it falls under the 'api reworking'. it still needs to be described and it looks to me that folks want a spec. 17:44:01 TheJulia: oh, true... gotta leave in some code to respect the lower versions 17:44:05 rloo: +1 17:44:29 are we good with asking for a spec? any nays? 17:44:37 no nay here. 17:44:42 yay from me 17:44:45 OK, will bring rfe things back 17:44:48 sambetts: Yeah on the API reworking. It would be good to eliminate the overloading of fields/node_names. 17:44:54 sounds like we want one 17:45:10 yay, given there's additional work and we've been discussing for quite a while - RFEs should be easier to discuss 17:45:16 thanks for the feedback 17:45:19 ok, a spec it is. thx! 17:45:23 and last but not least 17:45:25 https://bugs.launchpad.net/ironic/+bug/1641857 17:45:25 Launchpad bug 1641857 in Ironic "[RFE] Allow IPA to perform disk erase using thirdparty storage controller" [Wishlist,New] 17:45:30 JayF: will like this one 17:45:37 oh yes 17:45:59 I am not only not in favor of approving the RFE 17:46:00 how is this not just a different priority clean step? 17:46:02 I agree with JayF's last comment on this 17:46:04 I am -2 to the feature being in-tree 17:46:22 I remember what JayF said when discussion this feature the other day, and I'm with him on it 17:46:45 did any of you get any good reasons for that rfe? 17:46:53 no 17:47:08 jroll: ok. then not approved. 17:47:11 the concern is mainly proprietary tooling, right? 17:47:21 i agree, should not be in-tree 17:47:43 Well it's basically two in-treee options for this, both are unsavory: 17:48:10 1) Add $proprietary_tool to methods we use to detect block devices, so we can see the storage controller disks and wipe them 17:48:39 2) add a new *upstream* cleaning step of "erase_controller_disks" or similar which would noop in Generic (not sensible -- why would we ship a noop step?) 17:48:46 * dtantsur does not get why an out-of-tree hardware manager cannot Just Do It (tm) 17:48:52 3) Add a 3rd party HWM step that can detect+erase these devices 17:49:01 yeah, 3 sounds much better 17:49:02 #3 is the sanest solution, and doesn't require any in-tree work for IPA 17:49:07 yup 17:49:30 so, perhaps just reject and link to the meeting notes here 17:49:45 +1 reject 17:49:47 Is there anyone here who wants to fight for that RFE? So far we have two core votes to reject the RFE 17:49:49 make that 3 17:49:56 I also vote for #3. 17:50:07 And also for reject of RFE. 17:50:39 let's reject. they can come back if they have a good reason but so far, there doesn't seem to be one. 17:50:53 i'm done. thanks all. over to you jroll. 17:50:59 thanks 17:51:03 #topic open discussion 17:51:05 anything? 17:51:06 I do wanna send kudos to those folks who have been adding third party managers in-tree to IPA 17:51:14 (and yeah, i'll update the rfe's with what we discussed in this meeting) 17:51:14 we have one in-tree now and another up for review 17:51:26 yes 17:51:30 For testing the SNMP driver in CI, lindycoder and I have a change in progress https://review.openstack.org/#/c/388154/. 17:51:35 Once we land that, we will move the experimental gate (gate-tempest-dsvm-ironic-ipa-partition-pxe_snmp-tinyipa-ubuntu-xenial-nv) to a non-voting gate to be sure it's stable before making it voting. 17:51:43 Does everyone agree with the way it's done ? We would like to land this this week, if nobody disagree, to begin the un-deprecation of snmp driver. 17:52:11 yeah, it seems fine to me 17:52:22 Should we, at this point, go ahead and un-deprecate teh snmp drive? 17:52:24 *driver? 17:52:28 Given CI is in progress 17:52:28 +1 :-) 17:52:36 or should we wait the few weeks until the CI is running? 17:52:41 xhku, I agree with vsaienk0's comment, but I do realize it may require non-trivial refactoring of our devstack scripts, so I'd just let this in 17:52:53 Btw, I d ask to review the spec for Etags https://review.openstack.org/#/c/381991/ 17:52:55 JayF, ++ for wait, we do have time before we start removing drivers 17:52:57 JayF: I would say wait for CI 17:52:59 yeah, having it as out of tree plugin would be good 17:53:05 i vote to wait, otherwise something could break it before CI is merged 17:53:10 dtantsur: NobodyCam: the only reason I say we should maybe go ahead and do it 17:53:19 is there are a number of very minor SNMP patches that people want 17:53:22 i.e. support for new PDUs 17:53:34 JayF: I htink we have to +A https://review.openstack.org/#/c/388154/ first. and wait -- how long? 17:53:35 that wouldn't be tested in the gate anyway, but are blocked right now for, honestly at this point, probably no reason 17:53:39 JayF, we should not land patches before they're covered by CI, right? 17:53:54 In case of the SNMP driver, we do have some "mappings" of SNMP mibs to actions 17:53:54 dtantsur: + 17:53:54 JayF: those could still break SNMP in general, theoretically 17:53:56 I mean, I dunno if an innocent change may actually break the whole driver 17:54:00 that are for individual pieces of hardware 17:54:02 dtantsur: For now we did it the same way vbmc does, I agree it could be moved to virtualpdu project. We could do both at the same time in a separate patchset ? 17:54:20 that I don't think the virtualpdu testing would expose breakage for, unless somehow it magically breaks the whole driver which doesn't make sense 17:54:24 xhku, I suggest we land the change as it is, and then we think how to split this code cleanly 17:54:34 I'm just mainly tired of -2'ing small, non-dangerous patches just because "SNMP is deprecated" 17:54:50 JayF, I get your point.. but I also don't want to guess each time if the change may break something or not 17:55:00 +1 dtantsur 17:55:06 How far off is the CI 17:55:08 I feel much safer when I see a green CI run 17:55:17 let's get non-voting CI and go from there 17:55:24 NobodyCam: a few weeks 17:55:42 nah, I think we can get it this week or next if we review the patches xhku mentioned 17:55:48 NobodyCam, the job is already ready in experimental 17:56:18 why don't we add xhku's patches to the priority ones listed in the etherpad? 17:56:33 then we can be more optimistic about when it will be merged 17:56:35 * dtantsur just reviews the patch in question ~ now 17:56:53 mariojv: it isn't a high priority, though, really :) 17:56:58 too much to do this cycle 17:57:09 fair enough. i'll just add it to my review list 17:57:20 For the Etags, by the way, the patches- POC are up and need unittests, for now I am blocked by spec review :( 17:57:27 2.5 minute time check btw 17:57:38 galyna1: awesome, that should be a fairly simple review 17:58:20 jroll, thanks :) 17:58:51 if there's nothing else, let's get one minute back :) 17:58:53 thank you everyone.. Great meeting! 17:58:55 thanks everyone 17:58:58 #endmeeting