15:00:13 <vishalmanchanda> #startmeeting horizon
15:00:13 <opendevmeet> Meeting started Wed May 31 15:00:13 2023 UTC and is due to finish in 60 minutes.  The chair is vishalmanchanda. Information about MeetBot at http://wiki.debian.org/MeetBot.
15:00:13 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
15:00:13 <opendevmeet> The meeting name has been set to 'horizon'
15:01:04 <tmazur> o/
15:01:22 <vishalmanchanda> Hello everyone
15:01:31 <rdopiera> o/
15:02:22 <amotoki> hi
15:02:34 <vishalmanchanda> let's start the meeting
15:02:45 <vishalmanchanda> agenda of meeting can be found here https://etherpad.opendev.org/p/horizon-release-priorities#L39
15:03:22 <vishalmanchanda> #topic Notices
15:04:31 <vishalmanchanda> Just a casual reminder about the schedule, This week is R-18 week.
15:04:53 <vishalmanchanda> more info. about the schedule here https://releases.openstack.org/bobcat/schedule.html
15:05:03 <vishalmanchanda> moving to next announcement
15:05:32 <vishalmanchanda> horizon integration job is broken
15:06:20 <vishalmanchanda> more specifically, you may have noticed  "test_floatingip_associate_disassociate" test fail for your patch, this is due to now devstack is using cirros 0.6.1 image https://review.opendev.org/c/openstack/devstack/+/881437
15:06:37 <vishalmanchanda> So we have to merge https://review.opendev.org/c/openstack/horizon/+/883953 to fix the CI.
15:07:57 <vishalmanchanda> but Unfortunately  many integration tests still fails randomly for this patch but please approve this patch asap to unblock the CI.
15:09:05 <vishalmanchanda> I was also thinking if we should ask infra team to force merge the above patch an then check random failures for other tests.
15:09:27 <vishalmanchanda> You can find about random failing tests here https://etherpad.opendev.org/p/random-failed-horizon-integration-tests
15:10:46 <vishalmanchanda> Does anyone have any suggestion, what we should do force-merge https://review.opendev.org/c/openstack/horizon/+/883953 or anything else?
15:13:08 <amotoki> vishalmanchanda: one question on cirros image. what happens if the cirros version does not match the version specified by devstack?
15:13:22 <amotoki> does it mean our job fails with 100%?
15:14:27 <vishalmanchanda> no if cirros vesrion doesn't match then ' test_floatingip_associate_disassociate' test fails and then job stops after that.
15:15:36 <amotoki> okay. I am fully sure how cirros version affects the fip test failure though
15:15:40 <vishalmanchanda> if cirros version match then 'test_instances_pagination_and_filtration ', ' test_instances_pagination ' and test_router_delete_interface_by_row
15:16:29 <vishalmanchanda> fails randomly.
15:16:37 <amotoki> could you add the context you mentioned here to the commit msg in change 883953?
15:17:51 <vishalmanchanda> For Fip tests it try to launch a VM first and then associate and disassociate floating ip but instance not creating now due to different cirros image and fails
15:18:37 <amotoki> because such image does not exist?
15:18:43 <vishalmanchanda> amotoki: ok, I will upadte commit-msg for patch 883953
15:18:46 <vishalmanchanda> amotoki: yes.
15:19:11 <amotoki> got it.
15:19:49 <amotoki> for further step, we can explore a way to pick up the cirros version registered by devstack automatically by default
15:20:15 <vishalmanchanda> ok please +2ed and w +1 on patch 883953.
15:20:27 <vishalmanchanda> amotoki: yeah, sounds good.
15:20:57 <vishalmanchanda> moving to next announcement.
15:20:58 <amotoki> vishalmanchanda: will +2 once you update the commit msg
15:21:04 <vishalmanchanda> amotoki: thanks.
15:21:24 <vishalmanchanda> I will update it after the meeting
15:22:28 <vishalmanchanda> You may have noticed I have self-approve few patches in the stable branches
15:22:36 <vishalmanchanda> https://review.opendev.org/q/I9c75b084705dfdc6df52aca1659f89444c8a1728
15:23:10 <vishalmanchanda> It was done to fix zuul config errors https://zuul.opendev.org/t/openstack/config-errors
15:24:05 <vishalmanchanda> the stable branch patches waiting for review from long time and infra team suggested me to merge them immediately to avoid more conflict.
15:24:25 <vishalmanchanda> I hope no-one have any issue with that.
15:24:29 <amotoki> I see no problem on such kind of patches
15:24:36 <vishalmanchanda> ok cool
15:25:13 <amotoki> they failed when proposed. was there any change since then?
15:25:17 <vishalmanchanda> but stable/stein branch is still broken see https://review.opendev.org/c/openstack/horizon/+/878846
15:26:21 <amotoki> is it the oldest EM branch in horizon?
15:26:34 <vishalmanchanda> no they failed because of merge conflict after some changes i.e. Remove usage of openstack/xstatic-font-awesome
15:26:56 <vishalmanchanda> So I squashed two patches in a single patch to fix the CI.
15:29:33 <vishalmanchanda> stable/stein is in extended maintenance phase
15:30:03 <vishalmanchanda> yeah we already move stable/rocky to eol.
15:30:51 <vishalmanchanda> So now my question here is anyone here is  interested in maintaining stable/stein branch, otherwise we can move it to EOL?
15:30:52 <amotoki> I can say nothing on detail, perhaps we need to check other projects for requirements-check job at least.
15:31:46 <vishalmanchanda> infra-team suggested me to make failed job non-voting for stable/stein branch.
15:32:07 <amotoki> rdopiera: tmazur: I think stein can be EOL'ed from RH perspective, right?
15:32:13 <rdopiera> we don't use stein anymore, I'm fine with EOL
15:32:39 <tmazur> +1
15:33:45 <amotoki> all here are okay to make stein EOL :-)
15:33:53 <vishalmanchanda> ok, I will check with infra team if they can force merge open patches in stable/stein branch https://review.opendev.org/q/project:openstack%252Fhorizon+branch:stable%252Fstein+status:open and then we can move it to EOL.
15:33:57 <rdopiera> off with its head
15:34:29 <vishalmanchanda> or no need to merge open patches?
15:34:51 <amotoki> vishalmanchanda: could you send a mail to propose stein EOL to the mailing list for clarification?
15:34:51 <rdopiera> I don't mind either way
15:35:01 <tmazur> No need for zuul one for sure
15:35:13 <vishalmanchanda> amotoki: mail I will send for sure.
15:35:22 <amotoki> yeah, we don't need to fix the gate if we EOL a branch :)
15:35:48 <vishalmanchanda> ok thanks, I will send a mail on open-discuss ML.
15:36:28 <tmazur> Two others seems to be nice to have still, but again EOL, so I'm ok with either option
15:37:16 <vishalmanchanda> noted
15:37:23 <vishalmanchanda> moving to next thing.
15:38:27 <vishalmanchanda> It come to my attention that horizon is failing with the latest font-awesome release https://zuul.opendev.org/t/openstack/build/e5dd3c8fced64cf2b95ecc2d50bc0827
15:39:08 <rdopiera> that's why we have it pinned
15:39:14 <vishalmanchanda> I remember we decided  to pin xstatic pypi version
15:39:32 <vishalmanchanda> so I think we should do it now asap.
15:41:12 <vishalmanchanda> we need to pin the version in openstack/requirements as well.
15:43:42 <vishalmanchanda> ok I will check we should pin the version in openstack/requirements for the pypi which we are not maintaining anymore atleast.
15:43:59 <amotoki> pinning is okay as a temporary solution. what do we need to do to unpin them?
15:43:59 <vishalmanchanda> moving to next announcement
15:45:25 <vishalmanchanda> we should atleast open a new bug for that issue and keep checking on it I think.
15:47:02 <rdopiera> do we really need to use the latest release of a font?
15:47:22 <rdopiera> iirc Dreimark just randomly changed some paths
15:47:55 <vishalmanchanda> TBH, I have no idea about that.
15:48:23 <amotoki> I don't think we always need to the latest version of the font, but if we continue to use a specific version it leads to a situation we use very old version.....
15:48:24 <rdopiera> it's an icon font, we don't use any new icons they added
15:48:29 <amotoki> this is my only concern
15:48:53 <rdopiera> there is not going to be a CVE for a font
15:49:21 <amotoki> yeah
15:49:27 <amotoki> it is very static one
15:49:48 <rdopiera> eXtra Static
15:50:18 <amotoki> hehe
15:50:28 <vishalmanchanda> ok then we can pin the same version in openstack/requirement and mentioned these comments for future reference.
15:50:56 <vishalmanchanda> for awosome-font pypi
15:51:18 <rdopiera> I recently had a message from our security team, telling us that customers are complaining about old library versions in horizon, because they use some outomated script for checking it, and it claims it's insecure
15:51:42 <rdopiera> And I really don't know where to start explaining
15:51:54 <amotoki> rdopiera: like jquery or angularjs?
15:52:18 <rdopiera> among others, yes
15:53:46 <vishalmanchanda> what more library versions they are complaining about, if you have any list?
15:54:17 <vishalmanchanda> we can target them next to update.
15:54:44 <rdopiera> I don't, they were very sparse in detail, I also asked them about any particular cve or exploit they are concerned about, and they weren't able to answer either
15:55:03 <vishalmanchanda> hmm
15:55:19 <rdopiera> people shouldn't be allowed to use tools they don't understand
15:55:26 <vishalmanchanda> lol
15:56:06 <rdopiera> (we are patching jquery and angularjs downstream to fix any cves that pop up)
15:56:47 <vishalmanchanda> good.
15:58:04 <vishalmanchanda> next announcement is, I am on full week vacation next week. I have no access to my mails. So I was thinking if we can skip next weekly meeting until someone wants to chair the next horizon weekly meeting.
15:58:30 <vishalmanchanda> no internet.
15:58:40 <rdopiera> 'm fine with skipping, enjoy your vacation
15:59:03 <vishalmanchanda> thanks.
15:59:11 <amotoki> vishalmanchanda: I am fine to skip it. enjoy your vacation!
15:59:42 <tmazur> yeah, let's skip
15:59:45 <vishalmanchanda> ok cool then I will send a mail on open-discuss ML about this.
15:59:54 <tmazur> Enjoy your vacation Vishal!
16:01:45 <vishalmanchanda> next to next week, we have Vancouver summit.
16:01:52 <vishalmanchanda> tmazur: are you travelling?
16:01:59 <tmazur> No
16:02:01 <vishalmanchanda> next to next week we have Vancouver summit.
16:02:01 <vishalmanchanda> tmazur: are you travelling?
16:02:02 <vishalmanchanda> or anyone else
16:02:54 <vishalmanchanda> ok then we can have our weekly meeting in summit week as no-one of us travelling.
16:03:09 <tmazur> Yeah
16:03:24 <amotoki> no. I am not travelling either
16:03:35 <vishalmanchanda> we already  out of time.
16:04:26 <vishalmanchanda> I have no updates on release-priorities topic because spend most of my time in fixing CI for master and stable branches last week.
16:04:36 <vishalmanchanda> #topic open-discussion
16:04:50 <vishalmanchanda> Does anyone have any other topic to discuss?
16:05:02 <tmazur> I fixed those ports at launch Instance dialog
16:05:18 <vishalmanchanda> tmazur: thanks for the quick fix
16:05:30 <tmazur> And that's it from me for today :)
16:05:38 <vishalmanchanda> waiting for CI to fix then I will review it.
16:06:17 <amotoki> vishalmanchanda: feel free to ping me if we can land fixes this week :-)
16:06:19 <vishalmanchanda> Does anyone look at setuptool bug
16:06:30 <vishalmanchanda> amotoki: thanks.
16:08:26 <vishalmanchanda> If no other topic to discuss, let's end this meeting
16:08:40 <vishalmanchanda> thanks everyone for joining.
16:08:54 <vishalmanchanda> Take care.
16:08:59 <vishalmanchanda> #endmeeting