20:01:46 <robcresswell> #startmeeting horizon
20:01:47 <openstack> Meeting started Wed Jul 26 20:01:46 2017 UTC and is due to finish in 60 minutes.  The chair is robcresswell. Information about MeetBot at http://wiki.debian.org/MeetBot.
20:01:48 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
20:01:51 <openstack> The meeting name has been set to 'horizon'
20:01:59 <david-lyle> o/
20:02:05 <pboutin> o/
20:02:12 <ying_zuo> o/
20:02:28 <robcresswell> \o/
20:02:30 <gary-smith> o/
20:02:32 <rubasov_> o/
20:02:35 <jgravel> o/
20:02:44 <gary-smith> Hjkjj
20:02:51 <gary-smith> nice (vi command)
20:03:04 <robcresswell> gary-smith: Ah, I thought you just fell asleep on the keyboard
20:03:19 <gary-smith> iNope<Esc>
20:03:34 <robcresswell> right, lets get started
20:03:38 <robcresswell> #topic Notices
20:04:07 <robcresswell> Only quick thing I have to mention is that I'll be tagging Pike-3 tomorrow, which is feature freeze
20:04:46 <robcresswell> After this point I'll be -2ing all the blueprint patches until we have our first release candidate on Aug 10, 2 weeks time.
20:05:17 <robcresswell> After that point master opens for Queens, iirc.
20:05:35 <robcresswell> Oh I really need a better way of starting sentences it seems :)
20:06:09 <robcresswell> If you think something is ready to merge, you've got about 24 hours to ping me, or you'll need to send an email to dev mailer requesting an FFE.
20:06:24 <robcresswell> Thats Feature Freeze Exception, for those new to the process
20:07:18 <robcresswell> I know there's a couple of big Neutron features which look like they will miss the deadline, which is unfortunate.
20:07:37 <robcresswell> Anyway, thats all from me
20:07:41 <robcresswell> #topic Open Discussion
20:07:48 * rdopiera is late again, sorry
20:08:11 <robcresswell> Open discussion time, feel free to raise any bugs, blueprints, patches, or just ask questions. We have several cores about to answer :)
20:08:33 <robcresswell> I'll leave the meeting running for a while, so there's no rush if you're struggling to phrase a question
20:08:45 <pboutin> Well, i'd have a few points to discuss
20:08:59 <robcresswell> pboutin: Sure, fire away
20:09:11 <rubasov_> I also have a question about incomplete blueprint stuff
20:09:40 <pboutin> I'm working to fix the bug 1703708, I found the issue, and I'm able to show the proper error in the modal, do we still want the toast to be shown behind the modal (i assume not)
20:09:40 <openstack> bug 1703708 in OpenStack Dashboard (Horizon) "Horizon image upload with bad Glance CORS config fails with "[object Object]"" [Undecided,New] https://launchpad.net/bugs/1703708 - Assigned to Alok Kumar (rajalokan)
20:09:50 <rubasov_> shall we create a tiny patch to enable/disable from config the incomplete panel?
20:10:19 <robcresswell> pboutin: Ideally it should be a little alert box inside the modal
20:10:32 <pboutin> that's what I have now, will remove the toast then
20:10:40 <pboutin> the review should follow shortly
20:10:56 <robcresswell> rubasov_: Yeah, if you check how angular panels have done it previously, we have an ANGULAR_FEATURES setting
20:11:17 <robcresswell> rubasov_: Which is this related to? Trunks?
20:11:28 <robcresswell> pboutin: Great, sounds good to me
20:11:34 <rubasov_> robcresswell: yes it is about the trunks panel
20:11:52 <robcresswell> rubasov_: In that case, because its a new panel, you could also just disable it in the enable/ file
20:12:13 <robcresswell> I believe that works
20:12:17 * robcresswell would have to check
20:12:24 <robcresswell> Either of those options is viable
20:12:25 <rdopiera> I think enable/ would be cleaner
20:12:38 <rdopiera> the code is there already
20:12:42 <rubasov_> robcresswell: okay, and I guess the default should be to disable it, right?
20:13:07 <robcresswell> rubasov_: If its incomplete, yes, unfortunately. I'm happy for it to be mentioned in release notes though.
20:13:15 <robcresswell> rubasov_: Then we can just land it during Queens
20:14:19 <pboutin> For the bug 1609777, since there's no longer a tab for "security stuff" and only one for the key pairs. What would be the best place to display those fields
20:14:19 <openstack> bug 1609777 in OpenStack Dashboard (Horizon) "'can_set_password' ignored in the new launch instance experience" [Medium,Confirmed] https://launchpad.net/bugs/1609777
20:14:20 <rubasov_> robcresswell: okay, then I will write a patch for the enable/disable of trunks tomorrow
20:15:13 <robcresswell> rubasov_: Thanks; just do it ASAP please, I'm not sure what your tz is, but mines UTC and I'd prefer not to have to stay at my PC all night :)
20:15:22 <rubasov_> robcresswell: we only have a release note currently in the details patch (not yet merged), shall I move that to this new enable/disable patch then?
20:15:42 <robcresswell> rubasov_: I'll likely merge that tomorrow; I think I only had small nits on it, right?
20:15:47 <robcresswell> It was all just visual comments
20:15:57 <rubasov_> robcresswell: I'm in UTC+2 and will start tomorrow morning with this
20:15:59 <robcresswell> pboutin: Looking
20:16:06 <robcresswell> rubasov_: Ah, perfect, thanks
20:16:38 <rubasov_> robcresswell: yes, I think the details patch could be merged tomorrow
20:16:58 <robcresswell> pboutin: Oh, honestly, I don't know. Possibly the keypairs tab. I can't recall the naming of them off the top of my  head.
20:17:10 <robcresswell> We could rename it to Security and make it more generic if it has other options.
20:17:26 <pboutin> Yeah, for this tab is already pretty loaded
20:19:14 <robcresswell> pboutin: How is it handled in the old launch instance?
20:19:23 <robcresswell> Makes me sad having to ask that...
20:19:46 <pboutin> I think it's just security, but the UI for handling the key pair was less overkill than it is now i think
20:20:13 <robcresswell> Yup
20:21:05 <robcresswell> One moment, let me spin up my dev server...
20:23:14 <rubasov_> robcresswell: for me that was all, thank you
20:23:14 <robcresswell> pboutin: I'd probably just go with the keypair tab
20:23:33 <robcresswell> rubasov_: You're welcome :)
20:23:33 <rubasov_> robcresswell: will ping you when done with the enable/disable patch
20:23:39 <pboutin> coolio, will take a look
20:23:41 <robcresswell> rubasov_: Sounds good, thanks
20:23:48 <rubasov_> robcresswell: and sorry for leaving for the last moment
20:24:33 <pboutin> and for the quick ones, I've noticed that the karma conf files are hardcoded to look for python2.7 xstatic packages. On my computed, they are located under python3.4, so to be able to run my tests, I have to change the karma files.... dunno if it's a problem on my own or if the karma files should be more flexible...
20:24:50 <rubasov_> I'm off to sleep, bye everyone
20:24:55 <robcresswell> rubasov_: \o
20:24:56 <pboutin> my computer*
20:25:03 <pboutin> bye rubasov_ :)
20:25:07 <robcresswell> pboutin: They should be more flexible
20:25:24 <robcresswell> pboutin: Tbh they just shouldnt even be using this xstatic nightmare :p
20:25:41 <pboutin> I couldn't agree more
20:25:58 <pboutin> JS libs belongs in that package.json :)
20:25:59 <robcresswell> pboutin: But yes, probably should be something in there that checks for a valid version path or something :/
20:26:09 <robcresswell> pboutin: Yeah, nobody likes xstatic.
20:26:20 <pboutin> fiewwww, glad to hear that
20:26:38 <robcresswell> Well, its there because of packaging restrictions supposedly
20:26:54 <robcresswell> I'm still not entirely sure what the value is over just pulling the upstream package :D
20:27:27 <pboutin> well, if i find a somewhat cool workarround for this, i'ill propose it
20:28:05 <pboutin> (this being the version problems) i'm not confortable enough with all this to mess with packaging stuff
20:28:20 <robcresswell> haha, I understood
20:28:54 <robcresswell> Yeah, the packaging thing is something I'd have to sort probably, I'm not sure how many active people are about that have good-ish knowledge of the background
20:28:57 <pboutin> and my last point, I worked on the step readiness review that my colleague pushed a few days ago
20:29:38 <pboutin> I think i could be ready
20:29:38 <robcresswell> Yep, I saw the reviews popping up in the horizon channel
20:29:45 <pboutin> sorry for the spam :P
20:29:46 <robcresswell> Cool, I'll take a look tomorrow
20:29:54 <pboutin> it's good spam tho' :)
20:29:58 <robcresswell> No not at all, I'm just glad the work is getting done
20:30:07 <robcresswell> Thanks for the contributions :)
20:30:51 <pboutin> good, i'm done with my questions
20:31:12 <robcresswell> Awesome. Anyone else?
20:34:00 <pboutin> good, see you all next week then o/
20:34:46 <robcresswell> Yep, I think we can end here
20:34:51 <robcresswell> Thanks everyone :)
20:34:53 <robcresswell> #endmeeting