20:01:30 #startmeeting Horizon 20:01:31 Meeting started Wed Apr 22 20:01:30 2015 UTC and is due to finish in 60 minutes. The chair is lhcheng. Information about MeetBot at http://wiki.debian.org/MeetBot. 20:01:32 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 20:01:35 The meeting name has been set to 'horizon' 20:01:41 hello 20:01:45 hello everyone 20:01:52 hi 20:02:00 hello 20:02:07 o/ 20:02:09 hi 20:02:46 howdy 20:02:58 hello 20:03:14 o/ 20:03:41 will for a minute for people to trickle in 20:03:42 #chair david-lyle 20:03:43 Current chairs: david-lyle lhcheng 20:04:32 ok, Let's get rolling now that tqtran_afk is gone :P 20:04:51 lol sorry have a dentist app 20:04:56 haha 20:04:57 cindy has agreed to take over 20:04:59 no worries 20:05:08 enjoy 20:05:40 #topic General 20:06:02 So we have opened RC-2 mostly for translation and a few opportunistic bug fixes 20:06:06 #link https://launchpad.net/horizon/+milestone/kilo-rc2 20:06:57 I'm not sure if this is the correct time to ask, is the window open to submit/request a fish-bowl talk for the vancouver summit? 20:07:09 I see there are 5 bugs that are tagged as rc-potential: https://bugs.launchpad.net/horizon/+bugs?field.tag=kilo-rc-potential 20:07:15 adurbin_, we'll cover that in a minute 20:07:58 doug-fish, o/ 20:08:06 david-lyle: ok, thanks 20:08:18 are those bug still to be determined if we want to include them for rc2? 20:08:18 david-lyle: did we win? 20:08:49 lhcheng, doug-fish, doug-fish has a couple of bugs that are string changes on that list 20:09:07 the csv one certainly didn't make it to translators and I -2'd it 20:09:18 wasn't sure about the admin state one 20:09:39 since it's a previously translated string, I wasn't sure 20:09:51 wondeing if the mapping is there in the .po file 20:10:05 * david-lyle also wondering 20:10:16 oh yes - I don't think there is any new translation for the Admin State fix 20:10:21 not sure, worst case if will just default to english 20:10:32 which it already does 20:10:35 it's pointing to the existing translations 20:10:35 doesn't break anything 20:10:40 so we can probably approve that 20:11:12 sounds good to me 20:11:46 ok I +2'd it, I'll let ttx, approve it 20:12:29 okay, targetted the bug for Kilo too. 20:12:35 thanks 20:14:49 ok, everything should be set now for RC-2 20:14:58 translations should be ready tomorrow 20:15:04 then we'll wrap Kilo 20:15:08 \o/ 20:15:23 \o/ 20:15:43 it does look like we'll get another requirements bump 20:15:55 glanceclient apparently not ideal 20:16:03 so the other 3 bugs tagged for rc-potential, we won't be adding them to RC-2? 20:16:18 they don't have patches merged on master do they? 20:16:46 no, 2 still in progress, 1 haven't started 20:17:01 https://review.openstack.org/#/c/128133/ is just waiting for core reviews 20:17:01 mrunge, I couldn't reproduce this one 20:17:08 have you reverified? 20:17:18 david-lyle, sorry? 20:17:33 you filed a bug regarding nova-net 20:17:43 sorry, I didn't had a minute to look at that 20:17:56 ok, let me know if you can reproduce 20:18:04 so, I guess it's either not a bug, or we'll hear from users 20:18:20 I'm hoping for the former 20:18:27 yes, me too 20:18:27 david-lyle can we get https://review.openstack.org/#/c/128133/ into rc2 if it's ready? 20:18:55 david-lyle, thank you for looking into that 20:19:19 mrunge if you can repro, we need to fix 20:19:23 for kilo 20:19:28 sure 20:19:34 anyone else testing with nova-net 20:19:42 lhcheng? 20:19:42 mrunge: that bug is from using the existing launch instance? 20:19:46 yes 20:19:50 lhcheng, yes 20:19:57 wonder if it was glanceclient related 20:19:58 I'll try it out after the meeting 20:19:59 current lauch instance 20:20:14 I'll try again tomorrow 20:20:15 new launch instance renders just a white screen 20:20:27 I didn't file a but for that 20:20:34 really? 20:20:38 it's experimental :P 20:20:47 no bug to see 20:20:48 we're settling on a shade of white 20:20:58 that was rc1 20:21:09 mrunge: would like to know more about that. 20:21:28 let's move that to #openstack-horizon please 20:21:35 sounds good 20:21:43 mattfarina, I've meant to look into that. 20:22:05 david-lyle it's a regression that would be nice to have fixed. otherwise some of us will need to carry that change 20:22:17 mattfarina: +1 20:22:57 does it effect only editing the local_settings.py to add the dashboard, or the plugin mechanism via local/enabled as well? 20:23:12 s/does it effect/is it seen/ 20:23:27 I see it when usnig local/enabled 20:23:29 david-lyle: it's to fix a bug in the plugin mechanism 20:23:41 ok, I'll review today 20:23:54 thanks 20:24:15 lhcheng, that's your backyard, can you take a look too? 20:24:21 i've seen people asking about that bug in the horizon channel a few times 20:24:34 we're building interest :) 20:24:42 been affecting a number of folks 20:24:59 we should try to get that in 20:25:22 fyi, The instructions for installing manila-ui require manually applying 128133 (https://github.com/hp-storage/manila-ui/blob/master/README.rst) 20:25:26 david-lyle: yeah, been reviewing that initially. got distracted with other stuff 20:25:36 I'll look at it later 20:25:40 but does it rebreak the issue that caused a patch creating the regression 20:25:41 ? 20:25:56 will review and see 20:25:59 moving on 20:26:08 no, the intial issue is also addressed by the patch 20:26:18 er, original issue 20:26:24 jwy, ok, thanks, that flew under my radar a bit 20:26:50 we have a day or so to get it landed 20:27:01 depending on when translations lannd 20:27:43 I'm still working on the specs repo 20:27:56 hope to have more progress reported soon, been traveling 20:28:57 Moving on to the agenda which I'm prepending a topic onto 20:29:03 #topic summit planning 20:29:45 topic proposal etherpad up #link https://etherpad.openstack.org/p/horizon-liberty-summit 20:29:59 please propose your ideas there in the next week 20:30:11 and then we'll start picking topics 20:30:32 remember we have 3 fishbowl sessions, 8 working sessions and all day Friday 20:30:39 Do you know the days and times for the session allocation? 20:30:43 so propose working session topics there too 20:30:54 TravT yes 20:30:55 :P 20:31:11 #link https://docs.google.com/spreadsheets/d/1VsFdRYGbX5eCde81XDV7TrPBfEC7cgtOFikruYmqbPY/edit#gid=569963128 20:31:16 from the ML 20:31:40 thanks, added that link to the etherpad 20:31:41 recent change in Horizon schedule to free up Thursday afternoon Horizon talk time 20:31:57 mrunge, when is you talk? 20:32:01 *your 20:32:04 monday 20:32:10 no conflicts then 20:32:11 good 20:32:44 david-lyle, I don't see, why we have two talks with nearly the same topic 20:32:55 we'll start sorting topics next week and try to begin placing them 20:33:08 mrunge, shrug 20:33:16 latter will focus much more angular side 20:33:28 I don't think they'll overlap too much 20:33:45 unless you're talking angular in Horizon 20:33:49 yeah, makes sense. I will skip that completely 20:33:58 and will point folks to your talk 20:34:07 perfect 20:34:22 any questions on the summit? 20:35:37 will we have a contributor meetup? 20:35:39 So, Thursday afternoon is like extra contributor meetup? 20:36:14 mrunge: you mean like, meet informally over a drink before the summit starts? 20:36:21 yes! 20:36:25 +1 20:36:27 +1! 20:36:59 My flight arrives kind of early on Sunday, so I'd be up for that. 20:37:16 I'll be in late on Sunday, count me in 20:37:23 +1 20:37:31 doug-fish, glad you'll manage to come 20:37:55 well let's hope I don't break anything between now and then. :-) 20:38:00 so session types, non-program f2f pre-summit, fishbowl, working (40 minute smaller group), contributor meetup (all day Friday) 20:38:03 I'm looking forward to it. 20:38:47 somebody pick a venue for the pre-summit 20:39:26 TravT, I'm not entirely sure your question 20:39:48 david-lyle: above you said something about freeing up time Thursday for Horizon talks. 20:39:56 Did you mean the conference presentations? 20:40:00 TravT, you're presenting 20:40:21 5 people are that would be a sizeable chunk 20:40:22 lol - yeah, i just wasn't quite sure 20:40:31 it overlapped with a working session 20:40:34 ok. 20:40:50 if you hadn't looked before, I probably couldn't have said anything :P 20:41:13 lol... no I hadn't looked at the design summit schedule before. 20:41:14 * david-lyle has no idea what tense I'm typing in 20:41:24 all I think 20:41:34 equal opportunity tense 20:41:49 ok, there was another topic on the agenda 20:42:11 #topic Jshint undef and unused clean up for legacy code, should we do it? (tqtran) 20:42:39 clu_, did tqtran_afk pass this off to you? 20:42:52 david-lyle: yes 20:43:05 he ran off before i could say no :) 20:43:10 haha 20:43:16 ok, unconfuse me 20:43:22 what is the question 20:44:04 he wants to know see if everyone is ok with adding to 2 flags 20:44:11 I think tqtran_afk want to add the undef and unusued variable in jshint 20:44:19 to check for unused variables and such 20:44:21 yep 20:44:25 but it fails on a lot of the old javascript code 20:44:40 oh, so go hack up all the legacy code? 20:44:48 (boom) 20:44:52 * turn on flags but ingore legacy javascript 20:45:02 yup 20:45:12 I think that was tqtran's proposal. 20:45:17 wait turn on and ignore 20:45:18 ? 20:45:22 won't that be noisy 20:45:33 or not checking the legacy code? 20:45:37 we still work on the legacy code... jshint should still be run on that 20:45:43 exclude the legacy code from the check 20:45:52 just for those two flags? 20:46:02 hmm not sure if that is possible 20:46:11 I think it was ignore entirely 20:46:11 I would doubt it 20:46:24 how hard would a patch to clean up the problems be before we add the flags? 20:46:25 hmm, there's a fair amount of active JS code there 20:46:27 there isn't that much JS 20:46:40 * mattfarina thinks the amount of JS is relative 20:46:55 uncle leo? 20:47:10 I think there are hundreds, not complicated by tedious 20:47:15 *but 20:47:16 I like the idea of bringing the legacy js inline with what jshint recommends 20:47:16 I think he turned it on and hit ~ 400 20:47:29 400 errors? 20:47:32 cool 20:47:36 yeah 20:47:45 I those flags would point out relatively benign fixes, like unused 20:47:54 let's make tqtran_afk fix it! 20:47:59 +1 20:48:01 +1 20:48:02 +1000 20:48:03 +1 20:48:03 +1 20:48:04 +1 20:48:07 lol 20:48:10 his idea, he can do it 20:48:13 word! 20:48:18 sold 20:48:27 now is a good time for that kind of refactor too (early in the release) 20:48:28 I see now why he turned over to clu_ and went to the dentist 20:48:29 congrats tqtran_afk 20:48:41 #action tqtran_afk fixes legacy JS 20:48:46 too bad it backfired 20:48:48 lol 20:48:48 lol 20:48:56 zodm 20:48:58 oops 20:48:59 i like that action. it's so well defined! 20:49:13 I think I scoped it correctly 20:49:17 lol 20:49:18 Isn't that what he intended? Permission/agreement on that approach 20:49:40 let's do it early 20:49:46 I think he is looking more for forgiveness 20:49:58 we need a saner L-3 than k-3 20:50:01 all joking aside, i think it is a good idea. 20:50:28 I assume tqtran_afk will let us know if he wants to break it up and get help 20:50:40 my only worry is possibility of regression 20:50:51 all the more reason to do it early 20:50:57 so, while he's doing this he should add to the tests? 20:51:08 lhcheng, unused should be fairly harmless unless they're globals 20:51:12 :/ 20:51:30 tqtran has a patch up to add thse 2 paths to .jshintignore 20:51:30 20:51:31 david-lyle: true 20:51:33 horizon/static/horizon/tests/ 20:51:41 horizon/static/horizon/js/*.js 20:51:44 has anyone been able to spend time on our integration tests? 20:51:48 I miss them. 20:51:58 doug-fish, I haven't got back to them 20:52:07 I haven't either. 20:52:09 #topic open discussion 20:52:16 just a little late 20:52:35 I want to discuss at the summit a more robust approach 20:52:59 might be a dream, but we break a lot on integration tests, but not by them catching issues 20:53:18 only selenium or another dependency hamstringing us 20:53:43 I sent out a message to the ML a bit ago. 20:53:44 which make the integration tests ignored 20:53:55 on the angular work. please take a look 20:54:06 TravT: have a link? 20:54:15 hmm... let me see. 20:54:45 #link: http://www.mail-archive.com/openstack-dev@lists.openstack.org/msg51188.html 20:55:54 TravT: +1 20:56:14 I have to run 20:56:24 lhcheng, can you shut this down in 5 minutes 20:56:25 ? 20:56:30 sure 20:56:31 thanks! 20:56:38 david-lyle: you should also consider eating better. 20:57:24 :P 20:59:32 doug-fish: do you have an idea on the changes need for integration test to work? 20:59:50 no. Haven't studied it yet to know what's happening 21:00:13 I'm hopeful I can spend some time on it next week. But I hoped that last week as well. :-( 21:00:27 okay, I'll try to help out when I get the time. 21:00:36 alright, time's up 21:00:39 thanks everyone 21:00:43 thanks! 21:00:52 #endmeeting