14:00:28 #startmeeting glance_artifacts_sub_team 14:00:28 Meeting started Mon Aug 24 14:00:28 2015 UTC and is due to finish in 60 minutes. The chair is nikhil_k. Information about MeetBot at http://wiki.debian.org/MeetBot. 14:00:30 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 14:00:30 o/ 14:00:32 The meeting name has been set to 'glance_artifacts_sub_team' 14:00:33 o/ 14:00:44 We are all open discussion today :-) 14:00:50 #topic Open Discussion 14:01:12 OK 14:01:19 so, we have a number of reviews 14:01:32 which await for some kind of a fast track mergement 14:01:37 I'm here 14:01:41 o/ 14:01:53 #link https://review.openstack.org/#/c/207374/ 14:02:04 #link https://review.openstack.org/#/c/214185/ 14:02:17 o/ 14:02:17 #link https://review.openstack.org/#/c/214600/ 14:02:32 #link https://review.openstack.org/#/c/216180/ 14:02:45 These are mostly the bugs discovered when adopting V3 in Murano 14:03:00 And there will another one for ranged vesion filtration today 14:03:35 ativelkov: May I raise one concern I added to the comments of 214600 as well 14:04:25 folks, I want to discuss one thing - disable v3 by default in Liberty 14:04:47 ativelkov: I don't think the agreement with FastTrack was that you FT approve your own changes without review, no? I think the point was that the changes are reviewed within the Artifacts group and then FT'd 14:05:08 I think it's reasonable, because no one except Murano won't use it in near future 14:05:39 mfedosin: makes sense 14:06:05 mfedosin: if the V3 is going to experimental, I would strongly agree with you 14:06:09 I made a commit, but several tests failed there 14:06:36 I'll fix it today, so can I ask you for review then? 14:06:58 https://review.openstack.org/#/c/215709/ 14:07:09 mfedosin: you probably need to hax some functional tests as the tests are ran once for default values, once for thew values specified in the configs iirc 14:07:37 yeah, I've already made it 14:07:49 ah cool 14:07:54 jokke_: sure 14:07:55 I'll ask mfedosin to do that 14:07:55 My +2 was that I am ok with the tests written to it by dshakhray :) 14:07:55 (we have some kind of work breakdown between those who write code and those who write tests for it) 14:08:23 oops, there was some IRC glitch 14:08:43 ativelkov: ah, fair enough, it was just that the commit was owned, authored, committed and +2'd by you ;) 14:09:01 jokke_: sure, I got you. I'll change it to +1 for clarity ) 14:09:16 there is no approve by him :) 14:09:26 so, I think we all pretty much agree on keeping the default off for v3 in Liberty 14:09:31 ativelkov: thanks ... and as you can see, I keep eye for your FTs ;) 14:09:48 keep it EXPERIMENTAL and indicate that in the release notes and 14:09:52 jokke_: thanks :) That's appriciated :) 14:10:24 I have one more important question to discuss: how do we release EXPERIMENTAL python-glanceclient? 14:10:37 one email to tbe sent to ML that indicates the adoption by Murano 14:10:53 ativelkov: we have the feature branch, right? 14:11:07 nikhil_k: ok, will do that as soon as all patches are submitted for review 14:11:10 jokke_: yes, we do 14:11:15 someone was supposed to create that branch 14:11:22 ah cool 14:11:35 https://github.com/openstack/python-glanceclient/tree/feature/artifacts 14:11:47 Thanks to jokke_ who aske dhellmann :) 14:11:49 we just need to dedicate version number for it and request release when we need. Just making sure that it's clear enough being experimental due the artifacts. IMO 14:12:13 it's a feature branch so the client versioning won't apply on it 14:12:31 ativelkov: I just haven't been following that branch so I have no idea what you guys have been merging in there 14:12:33 ativelkov: I think it's best to indicate the rel-mgrs about this particular aspects 14:12:45 ativelkov: as they are handling release of the clients/libs 14:12:47 jokke_: nothing has been merged yet 14:12:55 nikhil_k: if we want to release from it, we need to have some version due to pbr 14:13:15 jokke_: :) 14:13:28 I think we should not release anything on the pip from it 14:13:38 rather encourage tarball installs 14:13:38 #link https://review.openstack.org/#/q/status:open+project:openstack/python-glanceclient+branch:master+topic:bp/artifact-repository,n,z 14:14:29 ativelkov: those are all against master not against artifacts! :o 14:14:43 jokke_: ouch! 14:14:46 mfedosin: ^ 14:14:49 -2 :P 14:14:52 yup 14:15:14 no-no-no :D 14:15:32 I'll fix it :) 14:15:35 mfedosin: thanks 14:15:49 nikhil_k: you start from the top of thew list, I start from the bottom. Which one is first on https://review.openstack.org/#/c/197970/ :P 14:16:11 haha 14:16:17 #action mfedosin to change client commit to feature/artifacts branch 14:16:31 for some reason gerrit is slow to get to today 14:16:41 'cherry-pick to' is okay? 14:16:42 mfedosin: just a hint, you probably want to to rebase of that artifacts branch against master first 14:16:53 might have some problems othewise 14:16:56 yep 14:17:04 cherry-pick ie 14:17:51 & remove the already PRS so that reviewers will be aware of such gotchas 14:17:56 PRs* 14:18:16 we have no code intersection between master and artifacts, so I don't think there will be problems 14:18:39 but anyway rebase is good 14:18:45 most likely not 14:18:54 but you could change common file 14:19:19 anyways, I think a fresh review shouldn't hurt. keeping a clean slate :) 14:19:31 This review has been sitting a while, just thought I would mention it: https://review.openstack.org/#/c/200057/ 14:19:50 nikhil_k: mind to add task to document how to build artifacts client for the liberty for those who wishes to try the experimental 14:20:00 bunting, yes, I remember 14:20:21 mfedosin: ah, thanks :) 14:20:40 yup, I'll talk with Olena tomorrow 14:20:41 jokke_: good point, I think we need to chat with rel-mgrs on how they want to take it 14:21:00 nikhil_k: ++ 14:21:01 cannot we release it as version 0.x.1? 14:21:13 they have holiday in Ukraine today, so they don't work 14:21:14 ativelkov: let's see. if need be 14:22:14 The thing is that murano client uses glance (regular v2 images api) for its own needs. So, we have to have python-glance client in murano's client requirements.txt 14:22:43 if we put tarball reference there, it will break the requirements job in gate 14:22:48 ativelkov: I wassuggesting if the can do a tarball install for liberty? 14:22:53 i see 14:23:13 Technicallu, artifacts support it experimental in Murano in L 14:23:15 ativelkov: what if you use the git reference there? 14:23:49 i.e. we have "legacy mode" which uses old murano's package repo instead of glance 14:24:24 jokke_: didn't try, but I believe that requirements job fails in this case as that git reference is not part of global requirements 14:24:26 ativelkov: I think let's all hop on to the rel-mgr channel after this meeting 14:24:35 we have a freeze on libs soon 14:24:40 nikhil_k: yup 14:25:06 anything else? 14:25:49 not from my side 14:26:05 I don't have any artifacts related questions too :) 14:26:20 ok, see you all on #openstack-relmgr-office after this. 14:26:22 ok, then thanks all 14:26:23 Thanks all! 14:26:26 nice meeting 14:26:31 thanks! 14:26:32 #endmeeting