14:01:41 <abhishekk> #startmeeting glance 14:01:42 <openstack> Meeting started Thu Jul 30 14:01:41 2020 UTC and is due to finish in 60 minutes. The chair is abhishekk. Information about MeetBot at http://wiki.debian.org/MeetBot. 14:01:43 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 14:01:45 <openstack> The meeting name has been set to 'glance' 14:01:51 <dansmith> o/ 14:01:52 <abhishekk> #topic roll call 14:01:55 <jokke> o/ 14:01:58 <abhishekk> #link https://etherpad.openstack.org/p/glance-team-meeting-agenda 14:02:01 <abhishekk> o/ 14:02:38 <abhishekk> wait for couple of minutes for rosmaita and smcginnis 14:02:54 <smcginnis> o/ 14:02:56 <rosmaita> o/ 14:03:04 <abhishekk> cool, everyone is here, lets start 14:03:11 <Steap> o/ 14:03:23 <abhishekk> #topic Updates 14:03:33 <abhishekk> Open Infrastructure summit 19 October, 2020 14:03:47 <abhishekk> As expected summit will be virtual 14:04:15 <abhishekk> you can submit your topics at, 14:04:41 <abhishekk> #link https://docs.google.com/spreadsheets/d/1bfkQOpYCR0vYte1JbvRwMZxK4_0ODRvG21qp9ClHW_g/edit#gid=1290473281 14:05:08 <abhishekk> Also there is a poll for PTG date selection 14:05:15 <abhishekk> #link https://civs.cs.cornell.edu/cgi-bin/vote.pl?id=E_a69944444a9b7c93&akey=3eccaa5b4fa5cfe6 14:05:31 <abhishekk> Kindly do vote 14:05:37 <abhishekk> Moving ahead 14:05:46 <abhishekk> #topic release/periodic jobs update 14:05:54 <abhishekk> This is V2 release weel 14:06:01 <abhishekk> s/weel/week 14:06:58 <abhishekk> forgive me for the Summit topic link, its wrong, kindly ignore 14:07:13 <abhishekk> So we have tagged glance V2 yesterday as planned 14:07:25 <abhishekk> Thank you all for your efforts and reviews on time 14:08:02 <abhishekk> There are no major changes in glance_store and glance_client so I am not going to release those at the moment 14:08:37 <abhishekk> Periodic jobs are green at the moment 14:09:00 <abhishekk> Do you have any suggestions/questions related to release? 14:09:21 <jokke> did you tag the stable ussuri and train? 14:09:40 <abhishekk> Nope, not yet, I am going to tag those on Monday 14:10:06 <abhishekk> To avoid release on Friday 14:10:20 <abhishekk> Tomorrow I will submit reno patches for both 14:10:42 <abhishekk> sounds good? 14:11:25 <abhishekk> Ok, moving ahead 14:11:30 <smcginnis> ++ 14:11:39 <abhishekk> #topic Specs status 14:12:05 <abhishekk> We still need reviews on below specs; 14:12:06 <abhishekk> Make cinder driver compatible with multiple stores - https://review.opendev.org/695152 - Need reviewes 14:12:07 <abhishekk> Update proposal for duplication image download - https://review.opendev.org/734683 - Need reviews 14:12:07 <abhishekk> Optimize Ceph store network usage - https://review.opendev.org/#/c/740980/ - Need reviews 14:12:07 <patchbot> patch 695152 - glance-specs - Make cinder driver compatible with multiple stores - 10 patch sets 14:12:07 <abhishekk> Introspect import plugin to calculate virtual size of image - https://review.opendev.org/741121 - Need reviews 14:12:08 <patchbot> patch 734683 - glance-specs - Update proposal for duplication image download - 3 patch sets 14:12:10 <patchbot> patch 740980 - glance-specs - Optimize Ceph store network usage - 2 patch sets 14:12:10 <abhishekk> Cache API - https://review.opendev.org/#/c/665258/ - Need reviews 14:12:11 <patchbot> patch 741121 - glance-specs - Introspect import plugin to calculate virtual size... - 2 patch sets 14:12:13 <patchbot> patch 665258 - glance-specs - Spec for Glance cache API - 4 patch sets 14:12:34 <jokke> I need to put that patchbot into ignore list ;) 14:12:40 <dansmith> which of those might be something I can grok and contribute reviews to? 14:12:58 <abhishekk> Out of which cinder multiple stores, Introspect import plugin, Cache API are priorities 14:13:17 <abhishekk> dansmith, You can choose any of them 14:13:42 <dansmith> abhishekk: heh, I know, but .. I figure maybe some of them are more generic or more in need? 14:13:54 <abhishekk> Duplicate downloads is also good to have A 14:14:19 <abhishekk> dansmith, cinder multiple stores and Introspect plugin 14:14:36 <abhishekk> you are now familiar with multiple stores and Import flow as well 14:14:46 <dansmith> ack 14:15:29 <abhishekk> We will finalize final specs out of these which we will work during this M3 time by next meeting 14:15:41 <abhishekk> Others will be pushed back to Next cycle 14:16:00 <abhishekk> So all members please spend some time on reviewing those 14:16:14 <abhishekk> Moving ahead 14:16:25 <abhishekk> #topic Core reviewers situation 14:17:14 <abhishekk> So I had given some thought about our current core team, additional work pressure/duties etc and come up with plan 14:17:19 <abhishekk> A. short term 14:18:00 <abhishekk> I had discussion with dansmith and he is interesting to help us in core duties for part time similar to what rosmaita and smcginnis are doing 14:18:23 <dansmith> I _am_ interesting 14:18:39 <jokke> :P 14:18:48 <abhishekk> Even he is new to Onion architecture of glance we can help him to understand those aspects 14:19:16 <abhishekk> Also at the moment all our work focus is around import and multiple stores which he is quiet familiar with 14:19:47 <smcginnis> Sounds great to me. 14:19:59 <abhishekk> So I would like to have dansmith onboard and get his help as much as possible 14:21:07 <abhishekk> I will send a mail on ML for voting and will update cores list around Tuesday according to the votes 14:21:20 <abhishekk> jokke, rosmaita ^^ 14:21:25 * jokke waves to dansmith while runnig, GZ it's yours now :P 14:21:44 <jokke> LOL ... happy to get some fresh eyes to do reviews 14:21:54 <abhishekk> B. Long term 14:22:11 <dansmith> heh 14:22:24 <abhishekk> Couple of meetings before rosmaita hinted that he is unable to give much time to glance 14:22:57 <abhishekk> I wish that he will be with us even he manages to give some hours in the week 14:23:24 <abhishekk> I am in discussion with couple of guys who has potential to become cores 14:23:49 <abhishekk> and I have suggested them to increase there presence on reviewing the patches 14:24:49 <abhishekk> I will observe their reviews during this 3rd milestone and based on that we can discuss this after release of this cycle 14:25:09 <abhishekk> I am positive that at the end of this cycle we will have 2 more reviewers with us 14:25:33 <smcginnis> That would be amazing. That's a huge percentage increase. ;) 14:25:44 <jokke> ++ 14:25:59 <abhishekk> yeah, I hope everything will work as I am planning :D 14:26:09 <rosmaita> (sorry, i am in my cinder squad meeting right now and am missing this whole discussion) 14:26:33 <abhishekk> rosmaita, ack 14:26:58 <abhishekk> Ok, moving into Open discussion 14:27:06 <abhishekk> #topic Open discussion 14:27:20 <abhishekk> Change database migration version to victoria 14:27:31 <abhishekk> #link Change database migration version to victoria 14:27:43 <abhishekk> #link https://review.opendev.org/743914 14:27:44 <patchbot> patch 743914 - glance - Change database migration version to victoria - 1 patch set 14:27:55 * abhishekk looks like I need some sleep 14:28:04 <jokke> ;) 14:28:31 <abhishekk> I remember we used to do this from stein and this is something related to release 14:28:35 <smcginnis> Maybe we can get some of rosmaita's time after his meeting. 14:28:55 <smcginnis> I thought we had to do it too, but it's quite possible something has changed since then. 14:29:25 <abhishekk> As soon as we do release for the first time in the cycle, that changes the Major version which matches with database constant 14:29:46 <jokke> So that should not be necessary. IIUC we only need the empty migrations _if_ there is partial migrations coming. Like neither Newton nor Stein had any and it's working just fine as there wasn't anything touching DB 14:29:48 <abhishekk> I remember that we have documented it somewhere in release liasons duties 14:30:31 <jokke> abhishekk: it was other way around. We needed to have the release set before we could merge any migrations 14:30:53 <jokke> so the migrations had to wait milestone 1 because otherwise the alembic got wrong release 14:31:11 <rosmaita> i put a comment on the review, i put a patch up a while ago to check this, and i don't think we need the empty migrations 14:31:22 <jokke> rosmaita: ++ 14:31:27 <abhishekk> jokke, I guess we had done same in the train as well as stein 14:31:52 <smcginnis> We do have a note: https://docs.openstack.org/glance/latest/contributor/release-cpl.html#final-releases 14:32:49 <abhishekk> I will remove those empty migrations from the patch 14:32:50 <smcginnis> Last one: https://github.com/openstack/glance/commit/d41362517238b9ea3741c4a565e0b73a12c55b92 14:33:39 <abhishekk> On the last patch also rosmaita has suggested that we don't need empty migrations 14:33:55 <jokke> smcginnis: yeah, so the current release needs to get updated. the "latest_revision" flags which is last migration in the branch 14:34:06 <abhishekk> so this time I haven't added migration script but only added expand and contract scripts 14:34:10 <abhishekk> :P 14:34:16 <jokke> :P 14:34:22 <rosmaita> i *think* that as long as the name of the current release is correct, and the last migration is correct, it will still work 14:34:40 <abhishekk> rosmaita, ack 14:34:40 <jokke> rosmaita: that was my understanding as well 14:35:34 <abhishekk> Also we need to followup with Luzi_ for the image encryption work progress 14:35:37 <jokke> it's just _if_ we have say only contract migration in this cycle, we need empty expand and migrate for it to work 14:35:52 <jokke> but as long as we don't have any migrations, we don't need the scripts either 14:35:57 <abhishekk> right 14:36:03 <rosmaita> i believe that is correct 14:37:22 <abhishekk> rosmaita, jokke is it possible for either of you to contact Luzi_ ? 14:37:46 <rosmaita> she cancelled this week's pop-up meeting 14:37:54 <rosmaita> i am attending when i remember 14:38:00 <rosmaita> so i may see her on monday 14:38:11 <abhishekk> rosmaita, ack 14:38:17 <jokke> abhishekk: I'll try to catch her. I've seen her popping online every now and then. And what rosmaita said ^^ 14:38:27 <abhishekk> jokke, ack 14:38:31 <abhishekk> smcginnis, If possible kindly review cinder multiple stores specs 14:38:41 <jokke> I assume that holidays have found them too :P 14:38:48 <smcginnis> abhishekk: Will do. 14:39:00 <abhishekk> smcginnis, thank you 14:39:18 <jokke> Just heads up might affect others too. 14:39:33 <abhishekk> Also, we have series of patches up for copy-image race conditions by dansmith 14:39:37 <jokke> I found few more things broken. 14:39:48 <rosmaita> (just catching up ... i am +2 on dansmith as glance core) 14:40:06 <abhishekk> rosmaita, ack 14:40:24 <jokke> So by the looks of it web-download is currently broken due to eventlet+requests not playing well together with new PY37+ sslsockets 14:40:51 <abhishekk> jokke, lets log these issues in launchpad 14:41:08 <dansmith> gmann is working on web-download tests, which I think is working, 14:41:14 <dansmith> or do you just mean when the url is httpd? 14:41:16 <dansmith> er, https 14:41:16 <jokke> There is fix for that merged in eventlet master, not released yet but we need to get over the cap we have in place before we can get that anyways 14:41:27 <abhishekk> dansmith, those are running under py36 i guess 14:41:41 <dansmith> https://review.opendev.org/#/c/742295/ 14:41:41 <patchbot> patch 742295 - tempest - Add glance image import web-download tests - 16 patch sets 14:41:42 <dansmith> ah, maybe 14:41:54 <jokke> dansmith: I'm not sure if I got redirect to https and it broke again, but my tests failed while I tried both http and https 14:41:57 <abhishekk> I have confirmed in the logs 14:41:57 <gmann> yeah, all integration jobs are with py3.6 now 14:42:04 <dansmith> ack 14:42:30 <jokke> Yes I was aware that those tests are under works, that's why I wanted to highlight this 14:42:54 <jokke> so if you see this stuff suddenly breaking py37+ there is reason for it, nothing you did 14:43:18 <abhishekk> ack 14:44:18 <jokke> Also it seems that we somehow ended up setting the image active in multistore scenario where we set the all_stores_must_succeed false but all stores fails ... so digging into that as well 14:44:35 <dansmith> so, I have a multistore job in nova, 14:44:41 <dansmith> which I think we need to import into glance 14:44:43 <jokke> so I ended up with an image that is active and has no data, nor way to put data in for it 14:44:58 <dansmith> we should have a tempest test that does an import to all stores 14:45:31 <dansmith> but simulating a store error will be hard of course 14:45:32 <abhishekk> dansmith, that is in planning 14:45:34 <jokke> dansmith: this specific case was when I defined 2 stores out of my 4 configured ones, but both of those 2 stores were broken 14:45:41 <dansmith> yeah, so, 14:46:05 <gmann> i started copy-image with all_store but policy permission is failing, which i will debug today - https://review.opendev.org/#/c/742546/11 14:46:06 <patchbot> patch 742546 - tempest - Add glance image import copy-image tests - 11 patch sets 14:46:16 <jokke> like said looking into it 14:46:45 <jokke> gmann: yeah that's fun one ... took me a while of banging my head against the wall and some help from abhishekk to figure that out :P 14:47:02 <gmann> here that test is running(failing) even i use admin cred to import- https://review.opendev.org/#/c/742547/ 14:47:02 <patchbot> patch 742547 - nova - DNM: testing tempest copy-image test - 2 patch sets 14:47:09 <jokke> It's such an amazing that all our policies are hidden behind the code wall ;) 14:47:41 <dansmith> gmann: is the image public? 14:47:58 <dansmith> the policy in my job only allows copy if it is 14:48:20 <dansmith> https://18ba74107b7ba397949e-e6ce8e54d026b827dc95e0507d541939.ssl.cf2.rackcdn.com/742547/2/check/nova-ceph-multistore/f2fe9f0/controller/logs/etc/glance/policy.json 14:48:32 <gmann> dansmith: no, its private. but i use admin cred to import so default policy should pass 14:48:46 <dansmith> not with my policy I think, 14:48:54 <dansmith> you'd have to add the admin check back in there IIUC 14:49:31 <gmann> dansmith: ah i see, that policy is overridden, got it 14:49:41 <dansmith> yeah 14:50:01 <dansmith> let it be known that one time I helped gmann with a policy thing instead of the opposite :) 14:50:26 <jokke> dansmith: time to take that marker and draw a cross on the wall :D 14:50:39 <dansmith> heh 14:51:16 <abhishekk> Ok, that's it from me for today 14:51:32 <jokke> I have nothing else either for now 14:51:41 <alistarle> I review your spec for https://review.opendev.org/#/c/740980/ jokke, for the RBD optimization 14:51:42 <patchbot> patch 740980 - glance-specs - Optimize Ceph store network usage - 2 patch sets 14:51:54 <jokke> alistarle: cheers 14:52:14 <alistarle> I am interested to see some example to help me understand well what the point is :) 14:52:23 <tosky> last week I mentioned there is one remaining legacy job in glance, and it turned out to be easy to port, so here it is https://review.opendev.org/#/c/743191/ ; the results seem fine but it's better if you ensure it's the case for real 14:52:24 <patchbot> patch 743191 - glance_store - zuul: glance_store-src-ceph-tempest replaces a leg... - 1 patch set 14:52:30 <tosky> (before I forget again :) 14:53:57 <abhishekk> tosky, ack 14:55:25 <abhishekk> Ok, wrapping up 14:55:27 <abhishekk> thank you all 14:55:33 <abhishekk> have a nice weekend 14:55:59 <abhishekk> #endmeeting