14:01:29 <abhishekk> #startmeeting glance
14:01:30 <openstack> Meeting started Thu Jan  9 14:01:29 2020 UTC and is due to finish in 60 minutes.  The chair is abhishekk. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:01:32 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:01:35 <openstack> The meeting name has been set to 'glance'
14:01:36 <jokke_> o/
14:01:39 <abhishekk> #topic roll call
14:01:45 <abhishekk> #link https://etherpad.openstack.org/p/glance-team-meeting-agenda
14:01:51 <abhishekk> o/
14:01:52 <yebinama> o/
14:02:22 <abhishekk> lets wait 2-3 minutes for others to join
14:02:34 <rosmaita> o/
14:03:16 <abhishekk> guess jokke_ and smcginnis might be busy
14:03:27 <abhishekk> lets start
14:03:27 <jokke_> I'm here
14:03:37 <abhishekk> cool
14:03:44 <abhishekk> #topic release/periodic jobs update
14:04:02 <abhishekk> two jobs are failing at the moment
14:04:11 <abhishekk> openstack-tox-py36-with-oslo-master is failing with module import error
14:04:18 <abhishekk> Failed to import test module: glance.tests.unit.v2.test_registry_client
14:04:44 <abhishekk> didn't have time to look into it, will try to put some time tomorrow
14:05:04 <abhishekk> and 2nd job has failed with subunit parser error
14:05:23 <abhishekk> Regarding release, Ussuri milestone 2 - 6 weeks to go
14:05:38 <jokke_> there's patch up from sfinucan that pokes the replicator code
14:06:00 <jokke_> not sure why, but apparently it helps
14:06:15 <abhishekk> jokke_, will have a look at it
14:06:45 <abhishekk> In this milestone we need to get import-multi-store related specs/work in at any cost
14:07:07 <abhishekk> So kindly review all related specs, those are in good shape and good to go
14:07:25 <jokke_> both should have +2 from me
14:07:29 <abhishekk> rosmaita, your concern is addressed on multi-store import specs
14:08:03 <abhishekk> yes, if rosmaita and smcginnis agree then I can get those in this weekend
14:08:14 <rosmaita> ok, i need to look at them
14:08:15 <abhishekk> That leads us to next topic
14:08:26 <abhishekk> #topic Multiple store import plugins
14:08:34 <abhishekk> multiple import specs
14:08:43 <abhishekk> #link https://review.opendev.org/669201
14:08:52 <abhishekk> Copying existing image specs
14:09:00 <abhishekk> #link https://review.opendev.org/694724
14:09:14 <abhishekk> yebinama, do you have any questions related to import specs?
14:09:28 <yebinama> No, I think we're good now :)
14:09:38 <abhishekk> I saw your new revision and it almost covered entire specs except notification I guess
14:09:59 <yebinama> Only the notification part is missing
14:10:04 <abhishekk> also you need to provide doc changes and release note for the same
14:10:34 <yebinama> Ok, I'll update that with next patch
14:10:37 <abhishekk> if you are ok, I will write functional tests for your patch
14:10:52 <abhishekk> cool
14:11:14 <rosmaita> yebinama: you can't pass up an offer like that!
14:11:16 <yebinama> I've already added 2 functional tests but if you want to add more, no problem for me :)
14:11:36 <yebinama> rosmaita: yep sounds too good to be true :p
14:11:44 <jokke_> :P
14:11:57 <abhishekk> yebinama, cool, I haven't looked at your tests yet :D
14:12:31 <yebinama> They are based on existing ones
14:12:39 <jokke_> I'll start looking the code patches as well. The specs should be covering pretty much everything.
14:13:02 <jokke_> Once they are merged I'll update the client patch to include the extra parameters as well
14:13:05 <abhishekk> cool, I guess I will write one test to check revert logic
14:13:24 <yebinama> ok, great
14:13:25 <abhishekk> jokke_, great
14:14:03 <abhishekk> just one question, do we need api version bump for these patches?
14:15:21 <yebinama> I think that's what we said in the specs
14:16:16 <abhishekk> ack
14:16:48 <jokke_> I have bit mixed feelings about that 'though
14:17:02 <abhishekk> me too
14:17:27 <abhishekk> I am inclining more towards not to do it
14:17:43 <jokke_> as it changes the behaviour of two plugins that are not even necessarily available. there is nothing in the API itself changing
14:18:09 <abhishekk> yes
14:18:18 <jokke_> That was king of the point of the import plugins that they can be developed without needing heavy API changes
14:18:31 <abhishekk> +1
14:19:06 <rosmaita> i agree
14:19:14 <abhishekk> ok,  we can always increase the version later if required
14:19:30 <abhishekk> great, moving ahead
14:19:41 <abhishekk> #topic Delete image from single store
14:19:55 <abhishekk> jokke_, do you want to share updates about this?
14:20:06 <jokke_> sure
14:20:14 <abhishekk> specs is merged for this feature
14:20:29 <abhishekk> #link https://review.opendev.org/#/c/698049/
14:20:34 <jokke_> the patch should be good to go. grenade failed again for scheduling issues, nothing in the patch itself failing
14:20:42 <abhishekk> above is the implementation
14:21:20 <abhishekk> rosmaita, you are worrying about race condition, IMO new revision has handled it well
14:21:31 <jokke_> thanks to rosmaita for identifying the race condition, it should be addressed now
14:21:46 <rosmaita> thanks for working on it, i'll take a look today
14:22:06 <jokke_> And surprising for my patch it also includes the tests :D
14:22:16 <jokke_> thanks for helping on those abhishekk & rosmaita
14:22:38 <abhishekk> great, please put some time in specs review as well, those are pretty much good to go
14:22:39 <jokke_> I also have client patch for it up
14:22:40 <rosmaita> jokke_: we'll make a software developer out of you yet!
14:22:52 <abhishekk> haha
14:23:23 <jokke_> #link https://review.opendev.org/#/c/699644/
14:23:23 <abhishekk> jokke_, is running like bullet train since shanghai :P
14:23:48 <jokke_> ^^ that's the client patch to go with the API change, and it has some tests too :o
14:24:28 <abhishekk> great work ./
14:24:51 <abhishekk> anything else on this topic?
14:25:12 <jokke_> No unless rosmaita you want to discuss the way the race condition got handled now
14:25:53 <rosmaita> i haven't had time to look
14:25:59 <rosmaita> will you be around this time tomorrow?
14:26:43 <jokke_> So TL;DR I changed the test to raise the store NotFound from store_utils and handled it from the location.py
14:26:59 <jokke_> I'll try
14:27:15 <rosmaita> i'm just assuming that i'll want to think about it
14:27:18 <rosmaita> :)
14:27:30 <jokke_> likely
14:28:35 <abhishekk> rosmaita, I can be around post dinner tomorrow
14:28:55 <abhishekk> which might be around 1900 UTC
14:28:56 <rosmaita> well, i don't want to ruin people's evenings, especially on a friday!
14:29:24 <rosmaita> i'll put comments on the review
14:29:24 <abhishekk> moving ahead
14:29:41 <abhishekk> ty
14:29:47 <abhishekk> #topic Open discussion
14:29:51 <jokke_> rosmaita: I have my 101 tomorrow late afternoon anyways
14:30:13 <jokke_> so don't worry about, I'll be around ish anyways
14:30:16 <rosmaita> ok, cool
14:30:27 <abhishekk> I have some patches up
14:30:36 <abhishekk> 1. remove registry related tests
14:30:41 <jokke_> next week back on my regular timezone so will be more active later on
14:30:48 <abhishekk> #link https://review.opendev.org/698651
14:31:02 <abhishekk> 2. backport to stable/train
14:31:10 <abhishekk> #link https://review.opendev.org/701491
14:31:15 <jokke_> abhishekk: oh we did not merge that yet. I was wondering why reg client test were still failing on the oslo issue
14:31:35 <abhishekk> kindly have a look at those
14:31:41 <abhishekk> jokke_, no we didn't
14:32:04 <jokke_> abhishekk: ok so merging that might just solve those isssues already
14:32:23 <abhishekk> jokke_, yes
14:33:21 <jokke_> anything else on flight?
14:33:48 <abhishekk> another thing is I will be away on 13 and 14
14:33:52 <jokke_> I feel like I'm not fully on track what's going on (which is same time nice and scary) :P
14:34:02 <abhishekk> and having holiday on 15th
14:34:34 <abhishekk> I will be carrying my laptop with me in case of urgency and will be available on mails and telegram
14:34:43 <jokke_> abhishekk: ok, enjoy and let me know if anything needs babysitting
14:35:00 <abhishekk> jokke_, thanks
14:35:37 <abhishekk> Do we have anything to discuss?
14:36:04 <jokke_> I'm good
14:36:07 <rosmaita> abhishekk: what needs immediate review?
14:36:19 <abhishekk> rosmaita, specs
14:36:26 <rosmaita> ok, i can do that
14:36:28 <abhishekk> top priority
14:36:34 <abhishekk> great
14:36:46 <abhishekk> I will try to find out smcginnis
14:37:13 <smcginnis> Sorry, too many conflicts lately.
14:37:23 <abhishekk> smcginnis, no problem
14:37:24 <smcginnis> Ping me on anything and I will catch up on scrollback here.
14:37:31 <jokke_> rosmaita: this would be nice and quick as well https://review.opendev.org/#/c/701491/
14:37:37 <jokke_> the stable backport ^^
14:37:40 <rosmaita> ack
14:37:44 <abhishekk> kindly have a look at specs once you get some time
14:38:07 <abhishekk> rosmaita, this is clean backport
14:38:38 <abhishekk> Lets wrap up and save some time
14:38:51 <rosmaita> ok, backport looks good
14:38:52 <jokke_> Yeah, would be gret to cut stable release after that merges
14:38:56 <abhishekk> Thank you all, have a good weekend
14:39:08 <yebinama> bye
14:39:16 <jokke_> I think we have pending out of stain as well (or launchpad has not updated)
14:39:23 <jokke_> Thanks all, o/~
14:39:40 <abhishekk> jokke_, yes, we need to backport this to stein as well
14:39:54 <abhishekk> once done we can cut release of stein branch as well
14:40:05 <jokke_> sounds good
14:40:55 <abhishekk> #endmeeting