14:00:00 <abhishekk> #startmeeting glance 14:00:01 <openstack> Meeting started Thu Jan 2 14:00:00 2020 UTC and is due to finish in 60 minutes. The chair is abhishekk. Information about MeetBot at http://wiki.debian.org/MeetBot. 14:00:02 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 14:00:04 <abhishekk> #topic roll call 14:00:04 <openstack> The meeting name has been set to 'glance' 14:00:11 <abhishekk> #link https://etherpad.openstack.org/p/glance-team-meeting-agenda 14:00:15 <abhishekk> o/ 14:00:30 <rosmaita> o/ 14:00:33 <abhishekk> erno is ooo today 14:00:36 <rosmaita> happy new year! 14:00:42 <abhishekk> Happy new year to all!!! 14:01:26 <abhishekk> looks like only two of us today 14:01:43 <abhishekk> #topic Updates 14:02:23 <abhishekk> Milestone 1 is released a week before Christmas 14:02:33 <rosmaita> congratulations! 14:03:23 <abhishekk> o\/ 14:03:47 <abhishekk> #topic release/periodic jobs update 14:04:17 <abhishekk> Periodic job, oslo tips job has failed recently, will look at the logs to find out the reason 14:04:44 <abhishekk> openstack-tox-py36-with-oslo-master ( I guess something with oslo-concurrency) 14:04:55 <rosmaita> ok 14:05:31 <abhishekk> Otherwise it was good day before yesterday 14:06:02 <abhishekk> AND we are approaching towards 2nd milestone 14:06:09 <abhishekk> 7 weeks away 14:06:39 <abhishekk> So requesting all cores to have a look at specs so that we can get those merged as early as possible 14:06:48 <abhishekk> Moving ahead 14:06:54 <rosmaita> ok, i need to go back and look at them 14:07:02 <abhishekk> yes please 14:07:06 <abhishekk> #topic 14:07:11 <abhishekk> #topic Multiple store import plugins 14:07:31 <abhishekk> #link https://review.opendev.org/669201 14:07:40 <abhishekk> #link https://review.opendev.org/694724 14:08:06 <abhishekk> so above are links for specs respectively multiple image imports and copying existing image imports 14:08:38 <abhishekk> I guess only remaining thing is renaming the parameter name from allow_failure to something more meaningful 14:09:03 <abhishekk> We didn't come to agreement on this in our previous meeting 14:09:48 <rosmaita> i think erno was the only one who opposed my suggestion 14:09:48 <abhishekk> Moving ahead 14:09:57 <abhishekk> rosmaita, yes 14:10:17 <rosmaita> i think since metadata keys can be 255 chars, his length objection has no merit 14:10:56 <rosmaita> but the key thing is, it's looking like the import call is going to be used more and more 14:11:09 <rosmaita> like for multistore copy 14:11:19 <abhishekk> yes 14:11:20 <smcginnis> rosmaita: What was your suggestion again? 14:11:41 <rosmaita> so i think it's better to have a specific key name so that when we add other functinality, it's clear what failures we are allowing 14:11:48 <rosmaita> smcginnis: i need to look it up! 14:12:15 <abhishekk> instead of allow_failure, we should use something line all_stores_must_succeed 14:13:00 <abhishekk> this is a input parameter passed in body 14:13:18 <rosmaita> smcginnis: https://review.opendev.org/#/c/669201/16/specs/ussuri/approved/glance/import-multi-stores.rst@60 14:13:22 <smcginnis> That does seem more explicit and clear then. 14:14:18 <rosmaita> i think erno's objection was that my key names are too verbose 14:14:36 <abhishekk> yes 14:15:03 <abhishekk> and we are not going to store this as a metadata, this will be just a input parameter 14:15:05 <rosmaita> but i also think since allow_failure: true can still fail (if all stores are inaccessible), it's not a good name and the logic should be reversed 14:15:37 <smcginnis> A longer, more clear name would be preferrable to me than a short name that requires some further context. 14:15:48 <rosmaita> i agree 14:16:03 <abhishekk> kindly add your suggestion on the specs 14:16:08 <abhishekk> smcginnis, please ^^ 14:16:27 <abhishekk> I am also good with this change 14:16:52 <rosmaita> i think gregoire was waiting to work on it until we had agreement 14:17:00 <abhishekk> yes 14:18:11 <rosmaita> let's ask gregoire to update the spec to use the new name/logic, and then erno will have one last chance to object 14:18:29 <rosmaita> so we're not going behind erno's back since he's on vacation 14:18:32 <abhishekk> +1 14:18:38 <smcginnis> Good plan. 14:18:45 <rosmaita> but i think we 3 agree that it's a good change 14:19:02 <abhishekk> yes 14:19:19 <rosmaita> so unless he has a valid engineering objection that none of us are considering, he should be ok with it 14:19:44 <abhishekk> :D 14:19:53 <rosmaita> he == erno, i think gregoire said he is ok with the change 14:20:05 <abhishekk> rosmaita, smcginnis kindly reply on the specs 14:20:12 <rosmaita> ok 14:20:14 <abhishekk> moving ahead 14:20:27 <abhishekk> #topic Delete image from single store 14:20:39 <abhishekk> #link https://review.opendev.org/698018 14:20:46 <abhishekk> so this specs is in good shape 14:20:56 <abhishekk> and implementation is also complete 14:21:24 <abhishekk> #link https://review.opendev.org/#/c/698049/ 14:21:43 <abhishekk> rosmaita, smcginnis kindly have a look at the specs 14:21:48 <rosmaita> ack 14:21:52 <smcginnis> Just re-read it and looks good. 14:22:00 <abhishekk> cool 14:22:17 <abhishekk> We need to get all above 3 changes before milestone 2 14:22:49 <abhishekk> So that we can have one milestone spare to fix if something goes wrong 14:23:09 <abhishekk> Moving ahead 14:23:17 <abhishekk> #topic Open Discussion 14:23:41 <abhishekk> smcginnis, I could use your help in reviewing priorities patch 14:23:44 <abhishekk> #link https://review.opendev.org/696017 14:23:57 <rosmaita> reread single-store deletion, looks good 14:24:13 <abhishekk> cool 14:24:33 <smcginnis> Missed the priorities updates. Just a few corrects - looks good to me. 14:24:41 <rosmaita> we have to remember to look for race conditions on the implementation, though 14:25:14 <abhishekk> also one high priority bug fix 14:25:19 <abhishekk> #link https://review.opendev.org/#/c/697647/ 14:25:26 <abhishekk> rosmaita, ack 14:25:39 <abhishekk> I have tested the patch, will test for race condition as well 14:26:24 <rosmaita> ok, i can review 697647 today 14:26:40 <abhishekk> thank you 14:27:02 <abhishekk> anything else to discuss?? 14:27:34 <smcginnis> Nothing from me. 14:27:39 <smcginnis> Happy New Year all! 14:27:47 <abhishekk> smcginnis, I might need some of your time next to next week to understand possible design for cinder driver of glance-store 14:28:05 <abhishekk> #link https://review.opendev.org/695152 14:28:09 <abhishekk> ^^^ 14:28:23 <smcginnis> OK, I'll try to take a look again. 14:28:30 <smcginnis> Might have to talk to the PTL. :) 14:28:43 <abhishekk> :D 14:29:12 <abhishekk> Thank you for your time !!! 14:29:20 <smcginnis> Thanks abhishekk! 14:29:27 <abhishekk> Happy new year once again !!! 14:29:32 <rosmaita> smcginnis: which PTL? 14:29:39 <abhishekk> rosmaita, ^^ 14:30:07 <rosmaita> i completely missed that spec, sorry 14:30:30 <rosmaita> will also put that on my list for today 14:30:44 <abhishekk> great 14:31:10 <abhishekk> rosmaita, anything from you or should we wrap this early? 14:31:26 <rosmaita> nothing from me 14:31:41 <abhishekk> cool, see you next week !!! 14:31:54 <rosmaita> bye! 14:31:59 <abhishekk> #endmeeting