14:00:00 #startmeeting Glance 14:00:01 Meeting started Thu Feb 12 14:00:00 2015 UTC and is due to finish in 60 minutes. The chair is nikhil_k. Information about MeetBot at http://wiki.debian.org/MeetBot. 14:00:02 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 14:00:05 The meeting name has been set to 'glance' 14:00:05 o/ 14:00:09 o/ 14:00:13 o/ 14:00:16 o/ 14:00:16 o/ 14:00:17 o/ 14:00:26 https://etherpad.openstack.org/p/glance-team-meeting-agenda 14:00:46 o/ 14:00:57 Welcome all, good morning, afternoon, evening to all in resp. TZ! 14:01:15 zhiyan: hope you are feeling better! 14:01:20 o/ 14:01:23 Let's get the party started 14:01:36 #topic Abandoning stale PS from review 14:01:43 was that you jokke_ ? 14:01:46 Yup 14:01:53 rosmaita: thanks! I'm better now. 14:02:06 jokke_: please take over 14:02:12 I would like to adopt the principle some other projects like Nova is using 14:02:35 so if PS has been inactive for 3 weeks + we just abandon it to keep the review list clean and fresh 14:02:58 I think we have at the moment year(s) old changes still on the list 14:03:28 should we get a vote here and then take to ML if necessary? 14:03:44 hm, before I would say it's a bad idea, but now, when we have lots of active reviewers I'm okay with it 14:04:44 mfedosin: ok let me refrase a bit ... lets say there is change that has bunch of -1 and the author just has not acted on those, so effectively already abandoned the change 14:05:07 jokke_: right, I think that's something that needed to be clarified 14:05:14 If the change has 5 +1 and +2 we're not gonna drop it just because last activity was 21 days 14:05:18 so, not just inacative, but inactive with negative feedback or broken tests, right? 14:05:34 but taking this on would help us to identify those changes that would be ready & good to go in 14:05:34 o/ 14:05:45 ativelkov: I think negative review is enough 14:05:54 Passing tests don't mean very much if no one wants the change :) 14:06:08 ativelkov: yes, only with a -1 (though even from jenkins) 14:06:10 ativelkov: yeah I think either one of those would be good enough trigger 14:06:20 nikhil_k: well formatted! 14:06:41 also, I think we can do this on Glance but not on some repos like glance-specs 14:06:44 jokke_: I'm wondering about changes with a bunch of +1s during which Jenkins was broken and no one rechecked them 14:07:14 (as some specs would mean carry over to next cycle and will sit for a more than 3 weeks in some cases) 14:07:45 sigmavirus24: if author does not care enough to recheck the change in 3 weeks, I think it's good to drop ... specially when the owner can revive any abandone change later on if needed 14:08:09 nikhil_k: yes, I think -spec is special cupcake anyways 14:08:27 Yes, and this should not happen during freezes: if we are close to release, some changes may lack attention for some time 14:08:29 sigmavirus24: or anyone else in that matter 14:09:01 3 weeks seems slightly short. is that what all the other projects did? 14:09:02 ativelkov: ++ I think this needs bit of game eye on holiday seasons, around freeze etc. 14:09:06 ativelkov: hmm, good point 14:09:12 i was just thinking of holiday 14:09:28 and why exactly 21 days or not 28 or 14? 14:09:47 Yeah I think an etherpad detailing the exact procedure should be the next step and have it sent to the ML? I think everyone here is in favor 14:09:52 o/ 14:09:55 mfedosin: cause 21 is 3x7, and 3+10 is 10, which is cool 14:09:58 I'm not proposing that we will do automated script or anything like that, but this would be just mandate for cores to clean up the list for those oldies no-one seems to care about 14:10:01 We're all just nitpicking the details and finer mechanics so that's better suited for the ML 14:10:17 heh, I think that is probably a rythm within openstack of 3 weeks 14:11:15 fast rhythm btw 14:11:29 jokke_: sigmavirus24 : ok, how about a email is sent to the ML and we announce a reminder in next weeks meeting for all those interested to respond accordingly 14:11:45 okay, I don't mind just was a little bit curious 14:11:58 mfedosin: so, we've 6 weeks long intermediate milestones 14:11:59 nikhil_k: will try to get the etherpad/e-mail out there today or tomorrow latest 14:12:14 (like k-1, k2, etc.) 14:12:35 jokke_: Thanks! 14:12:44 #action jokke_ to put together an etherpad and send a message to the mailing list 14:12:55 sigmavirus24: thanks, was just about to :) 14:12:56 jokke_: i think automated script is better... 14:12:57 =P 14:12:58 mfedosin: consistency 14:13:19 Nova abandons patches that are >4 weeks old, maybe we should keep the same time 14:13:27 btw is it 3 weeks since patch submitted or 3 weeks since first negative review? 14:13:33 pkoniszewski: is it 4? 14:13:46 TravT_: last activity 14:13:49 it is 4, e.g., https://bugs.launchpad.net/nova/+bug/1246201/comments/22 14:13:49 Launchpad bug 1246201 in OpenStack Compute (nova) "Live migration fails when the instance has a config-drive" [High,In progress] - Assigned to Tony Breeds (o-tony) 14:13:49 TravT_, from las activity I suppose 14:13:51 TravT_: since the last owner's activity 14:13:56 *last 14:14:13 Can we move on? 14:14:14 pkoniszewski: ok, thanks for catching that, 4 weeks it would be then ;) 14:14:16 author's or committer's ? 14:14:29 so, let's drill down on the details in the etherpad 14:14:33 yes 14:14:36 move on please 14:14:44 #topic CLI Sorting Argument Guidelines 14:14:51 https://review.openstack.org/#/c/145544/ 14:15:12 they're approved and it's nice 14:15:27 mfedosin: not yet 14:15:35 fyi ^ , there is a api-wg spec that has been approved 14:15:46 that is - https://review.openstack.org/#/c/145579/ 14:16:14 so, for everyone to be on the look out for this change. Seems like it'd not affect anyone directly 14:16:34 * ativelkov bookmarks to check if artifacts API complies with it 14:16:36 but we will be having some changes on the g-api side that would involve minor version bump 14:16:43 There is no +A but looks pretty stronly that this will be the merging iteration of that spec ;) 14:16:44 I heard we need a spec in glance for this 14:16:50 At worst, the change that would affect people is allowing multiple sort-keys which is already in progress 14:17:04 mfedosin: I didn't get to it yesterday since I was trying to re-review the k-3 specs that are important 14:17:14 mfedosin: yes, to document all the related links and the changes that would be made to Glance and the client 14:17:18 I can write it today 14:17:18 I'm also in meeting hell this morning but I can try to get to it this afternoon 14:17:23 as those are not evident in that spec 14:17:25 Thanks mfedosin 14:17:37 sigmavirus24, welcome :) 14:18:26 ok, moving on. thanks for the input everyone 14:18:29 #topic Cross-Repo Dependencies in Zuul 14:18:37 #action mfedosin to write an sorting spec for changes in glance-api 14:18:46 http://osdir.com/ml/openstack-dev/2015-02/msg00785.html 14:18:54 So just heads up for everyone who missed that e-mail in mailing list 14:18:57 this is so cool! 14:19:34 so, we may now set dependencies between commit to python-*client and API commit? Cool 14:19:35 there is cross repo dependency mechanism introduced with "Depends-On: " on commit message 14:19:35 it's really great. 14:19:58 I believe this is documented in the openstack infra manuals 14:20:01 #link http://docs.openstack.org/infra/manual/developers.html#cross-project-dependencies 14:20:11 ativelkov: yes, we can make dependency chains to have client change depending on glance change depending on glance_store change 14:20:25 I want to say we should all thank fungi but I know they didn't work on it alone 14:20:27 wow, I really need that 14:20:33 So, I would strongly encourage all developers and reviewers to look into the manual 14:20:41 ++ 14:20:44 i definitely did not ;) 14:20:49 \o/ 14:20:50 fungi: woot! 14:21:04 fungi: :) 14:21:08 jeblair did pretty much all of the implementation 14:21:15 i merely reviewed most of it and nodded 14:21:31 fungi: kudos for both of you ;) 14:21:59 mmm, actually that documentation link is for the wrong thing i think 14:22:13 cross-repo dependency is what we're calling the depends-on bits 14:22:23 but i may need to re-read the manual now 14:22:55 ahh, yep, we cleaned that up, so it's the right thing now 14:22:56 so it says "another project" can the same thing be used within a project (sometime dependencies aren't all lined up - multiple dependencies) 14:22:57 huh, intersting 14:23:15 TravT_: between any two repo 14:23:22 TravT_: isn't that the idea for dependent patches? 14:23:34 Why not just rebase your patch on the patch it depends on? 14:23:36 fungi: ok, as I think it says cross project so was hoping that is all openstack wide and not confined to a program 14:23:38 right, within the same project just make them naturally dependent series within git 14:23:42 Also, this seem to be getting off topic 14:23:56 nikhil_k: as said any two repo 14:24:23 cross-repo dependencies using the depends-on line are for when you need dependencies between changes (either because you don't want one merging before the other, or want them to be tested together in some integration test suite) 14:24:24 jokke_: I was just asking as he said earlier that it was wrong link 14:24:34 patches aren't always necessarily sequential with multiple workstreams dependent on multiple patches 14:24:38 nikhil_k: k 14:24:43 but specifically between different git repositories 14:24:46 ok 14:24:47 thx 14:24:49 anyway, sorry to hijack 14:24:54 TravT_: read the e-mail ... it's all expained there ;) 14:24:58 * fungi gets back to his regularly-scheduled morning 14:25:09 fungi: thanks :) 14:25:16 (for the info) 14:25:23 #topic Liberty Summit planning 14:25:33 jokke_: ? 14:25:36 we didn't get any lizards :( 14:25:39 So first of all ... we have name \\o \o/ o// o/7 14:25:55 Yeah but it isn't the name we needed, it's the name we deserved 14:26:11 sigmavirus24: lol, batman fan much? 14:26:14 =P 14:26:19 second of all ... Should we kick off planning for the summit ... end of MAy will be sooner than anyone expects 14:27:02 jokke_: I think we can wait until the end of cycle before we do that 14:27:13 nikhil_k: any objections to make our well proven etherpad and start collecting stuff together to ease the planning and avoiding the last minute rush again? 14:27:16 Like for juno we had enough time after j3 14:27:31 Doesn't hurt to start the etherpad now 14:28:04 jokke_: yes, but this time I am hoping that the feature / psedo feature groups would update the etherpad proactively 14:28:16 I may send a reminder email every so often 14:28:36 sigmavirus24: I think we've 2 already would like to avoid more 14:28:52 sigmavirus24: that's what I thought and I noticed Doug was giving a shout for oslo one earlier so thought to bring it up 14:28:53 fair enough :) 14:28:57 #info K3 etherpad https://etherpad.openstack.org/p/kilo-glance-k3 14:29:08 kragniz: do you have the whiteboard link handy? 14:29:18 https://etherpad.openstack.org/p/glance-whiteboard 14:29:21 #link https://etherpad.openstack.org/p/glance-whiteboard 14:29:31 * sigmavirus24 steals kragniz's thunder 14:29:34 sigmavirus24 beat me too it 14:29:50 nikhil_k: it's just a wafer thin etherpad, certainly it's okay (Monty Python reference) 14:29:52 #info Whiteboard is not used for review priority, rather just for informal discussions 14:30:11 sigmavirus24: heh 14:30:38 #topic glance_store Releases 14:30:53 we are waiting on 14:30:59 https://review.openstack.org/#/c/141665/ 14:31:00 and 14:31:09 https://review.openstack.org/#/c/137416/ 14:31:13 https://review.openstack.org/#/c/137416/ just get +Aed 14:31:44 zhiyan: excellent. I was wondering when we'd ever get that approved =P 14:31:52 nice! 14:32:08 zhiyan: please update the blueprint status accordingly 14:32:14 however, i'm not sure if i can put https://review.openstack.org/#/c/136039/ on the list as the latest (to me) one 14:32:16 appreciate the effort there 14:32:23 nikhil_k: sure 14:32:55 #info try to review https://review.openstack.org/#/c/136039/ before next Tuesday else it will be postponed to next glance_store release 14:33:10 nikhil_k: thanks for review/support 14:33:17 :) 14:33:18 #topic client release 14:33:23 nikhil_k: so glance_store release is probably next tuesday? 14:33:23 https://launchpad.net/python-glanceclient/+milestone/v0.16.0 14:33:33 nikhil_k: so the plan is to release at 18th?\ 14:33:57 kragniz: hopefully, I deferrred it from this week to next to help reviewers relax a bit (right after k2) 14:34:07 * kragniz updates whiteboard 14:34:26 nikhil_k: good call also ref stable capping 14:35:15 About the client: do we need to clean up the dependent bugs for the next release? 14:36:02 dependant as in currently targeted for 0.16.0? 14:36:07 Seems like no objections? 14:36:41 #info Nikhil to clean up bugs related to the client for it's next release. Please contact if you need something to be released urgently. 14:36:50 Also, is anyone willing to volunteer to verify if we've no change that makes api backward incompatible 14:37:18 I can head up this one, since I think I was the last to complain about it 14:37:22 nikhil_k: could you rephrase that ... 14:37:37 jokke_: So, the concern that would brought up was.. 14:37:39 nikhil_k: sorry ... got you 14:37:41 (mostly with semver stuff) 14:37:55 we need to ensure that the client releases need to be semantically correct 14:38:19 ah 14:38:23 we don't *need* to, but it would be nice 14:38:24 I'm trying to identify if there are enough who actually care about this (by that I mean are affect by this) 14:38:37 I care about this 14:38:45 I posted this bug to the mailing list yesterday: https://review.openstack.org/#/c/154229/ 14:38:47 and you're affected? 14:38:48 kragniz, nikhil_k: well tbh it's easier to do before rather than after they have been released 14:39:22 wayne_: ok, we should get to it in the open discussion 14:39:34 I also care about this 14:39:39 jokke_: what do you mean? 14:39:54 So, all those who care about this - 14:40:21 are you all willing to ensure that the client release is tagged appropriately in the launchpad 14:40:43 that would involve creating a release for minor version change and tagging bugs to it 14:40:45 totes 14:40:50 yep 14:41:05 kragniz: it's easier to fix some inconsistencies if we find them now rather than after they've been out for a one release already 14:41:08 and if there are api back incompatible changes, then the release version is updated accordinly 14:41:15 consistency vs. backwards compatibility 14:41:36 nikhil_k: we can update release names/versions on launchpad? 14:41:45 I forget if you can change those 14:42:06 or create a new one and retarget 14:42:08 kragniz: it would be manual and tiresome process ( I believe) but not 100% on that 14:42:21 Launchpad has an API, but let us never speak of it 14:42:34 ok, I will move on for now 14:42:34 sigmavirus24: I had a look at it once 14:42:37 ...once 14:42:45 kragniz: never again 14:42:52 Let's discuss this offline, with all those who have time for this 14:42:57 nikhil_k: sounds good 14:43:05 #topic k2 released. 14:43:25 k2 released. 14:43:40 copy paste fail 14:43:43 https://bugs.launchpad.net/bugs/1412802 14:43:43 Launchpad bug 1412802 in Glance juno "copy-from broken for large files and swift" [Critical,In progress] - Assigned to Alexander Tivelkov (ativelkov) 14:43:53 that bug just made in time and is an important one 14:44:14 Thanks to all the reviewers 14:44:20 thanks to jokke_ who was available outside of this regular work hours for seeing this through 14:44:44 I hope that we will get a better velocity in k3 14:45:03 nikhil_k: NP ... just wanted to avoid k1 all over again ;) 14:45:03 reviews waiting for k3 are at https://launchpad.net/glance/+milestone/kilo-3 14:45:17 jokke_: true that! 14:45:37 #topic code cleanup 14:45:50 looking for volunteers to look into this https://review.openstack.org/#/c/145223/ 14:46:02 seems like we've some stale code 14:46:13 (possibly create a spec and see it working) 14:46:26 that was it 14:46:28 My guts are telling that we have loads of it 14:46:33 i'd like to have a look 14:46:37 thanks zhiyan 14:46:43 #topic Review request for Reload configuration file on SIGHUP signal 14:46:43 == jokke_ 14:46:47 due to i done before refacotrings 14:46:53 abhishekk: ? 14:47:04 nikhil_k: hi 14:47:13 just saw its marked in k3 14:47:26 ah ok, any significant change? 14:47:42 no, I want some early feedback 14:47:49 * sigmavirus24 left feedback yesterday 14:47:52 and approval for spec 14:47:53 nikhil_k: actually i trend to believe we could to remove file queue and 'cleanup' logic 14:47:55 ah ok, yes. It's marked for early k3 14:48:12 due to from juno we start to use db queue fully 14:48:21 #topic Open discussion 14:48:39 i will check the spec and left things for discussion.. 14:48:55 zhiyan: sure, can we get an informal proposal out , something that can be done in k3? 14:49:08 wayne_: glad that you brought it up 14:49:13 What about backports of https://bugs.launchpad.net/bugs/1412802 to J/I? 14:49:13 Launchpad bug 1412802 in Glance juno "copy-from broken for large files and swift" [Critical,In progress] - Assigned to Alexander Tivelkov (ativelkov) 14:49:29 https://review.openstack.org/#/c/154229/ 14:49:31 sure thing, i'd like to...it's on my list, thanks for propose it up for a formal spec! 14:49:39 Regarding bug https://review.openstack.org/#/c/154229/, are there any objections to me doing this? 14:49:59 wayne_: did you get a response back on/from the ML yet? 14:50:06 ativelkov: I know stuart is trying to come up with a smaller fix 14:50:09 ativelkov: you have any update on those backports? 14:50:22 no response yet. 14:50:34 ativelkov: yes, please try to review a related patch in glance_store 14:51:05 wayne_: ok, let's give it another couple days. We can sync up on #openstack-glance on Mon 14:51:10 kragniz: jokke_: nikhil_k: that's what I wanted to ask - this is a patch in glance_store 14:51:26 ativelkov: but not for icehouse 14:51:32 ok 14:51:38 it means it will be available in the next glance_store release 14:51:54 wayne_: do I understand correctly that that was done in k-{1,2} ? 14:52:09 nikhil_k: yes, it is not compatible with I, and I don't know if we may use newer glance_store with J - is it backwards compatible? 14:52:10 k1 14:52:12 sigmavirus24: ^ 14:52:19 ah 14:52:41 ativelkov: let's mark the glance_store release blocked by that 14:52:48 nikhil_k: so, perhaps I'm missing something, but aren't those alpha/beta-ish releases? Backwards incompatible changes between them is to be expected 14:52:50 zhiyan: np 14:53:03 If I'm not misunderstanding, I'll reply to the ML with my thoughts on it so I can stir the pot for Wayne 14:53:04 sigmavirus24: yes K1 14:53:10 sigmavirus24: right, so we got blessings from ttx 14:53:24 Just trying to confirm if no one else if affected by this 14:53:28 glance_store is not currently capped on Juno\ 14:53:41 nikhil_k: yeah, I'll respond on the ML then 14:53:59 nikhil_k: pkoniszewski do you think we can do it in k3 on time? https://review.openstack.org/#/c/147264 can you share some status info with me? 14:54:03 sigmavirus: thanks 14:54:11 sigmavirus24: cool, we are not expecting anyone besides horizon to be using it for now 14:54:28 but you never know 14:55:55 jokke_: that may change though, right? 14:56:38 nikhil_k: ofc it may ... I was just confirming that it's not ... so if we are planning to release glasnce_store that breaks Juno, we need to do something about that fact 14:56:54 zhiyan: I think we need that in k3 14:56:57 zhiyan: I'm sure we can, change is really small - it exposes new flag over API so it is backward compatible 14:57:18 ok..will check it asap 14:57:35 zhiyan: I think we need to get some reviews on https://review.openstack.org/#/c/148213/ along with the spec 14:57:47 to avoid the metadef tags like error again 14:57:48 Yeah we might want to cap stable/juno's g-r to be safe until we can test it so -infra doesn't get really mad at us 14:57:49 =P 14:58:20 sigmavirus24: infram is small problem on that :P 14:58:44 nikhil_k: indeed, that's what i worried about..unlike the case in j-3 14:58:53 :) 14:58:54 jokke_: right, but they've been dealing with problems like this repeatedly lately and I'm sure their patience is wearing thin. I don't want to add any more grey hairs to their heads 14:59:11 They're all good people and reducing their stress is something we can help with =) 14:59:14 sigmavirus24: tru dat 14:59:34 sigmavirus24: you suggest to cap it to the currently released version? 14:59:35 sigmavirus24: there was quite a heated discussion at X-Project meeting yesterday 14:59:49 ativelkov: until we can show that it won't break stable/juno 14:59:52 and there has been quite heated discussions on the mailing list 15:00:02 we're out of time 15:00:06 last thing - we should now have pretty glance logs in devstack! 15:00:06 yep 15:00:06 I think a pre-emptive cap will be good until we can test it out. There's no reason to break the gate for anyone integrating with glance 15:00:10 #link https://review.openstack.org/#/c/155024/ 15:00:12 yup ... thnx! 15:00:16 Thanks all! 15:00:18 Thanks everyone 15:00:21 thanks 15:00:22 thank you 15:00:23 thanks! 15:00:25 #endmeeting