20:01:04 #startmeeting glance 20:01:05 Meeting started Thu Oct 17 20:01:04 2013 UTC and is due to finish in 60 minutes. The chair is markwash. Information about MeetBot at http://wiki.debian.org/MeetBot. 20:01:06 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 20:01:08 The meeting name has been set to 'glance' 20:01:14 who do we have here today? give a o/ 20:01:39 hey 20:01:46 o/ 20:01:47 sorry folks are talking irl 20:01:57 ameade_: buncha irl jerks 20:02:05 Hi 20:02:05 o/ 20:02:36 o/ 20:02:44 \o 20:02:52 welcome all! 20:02:52 o/ 20:03:08 o/ 20:03:14 We've got a full agenda for today, thanks to all the helpful suggestions from folks 20:03:20 #link https://etherpad.openstack.org/p/glance-team-meeting-agenda 20:03:23 hi 20:03:41 wave 20:03:51 it doesn't say so, but we'll try to have an Open Discussion time at the end for at least 5 minutes 20:04:01 in case folks didn't have a chance to suggest stuff on the etherpad agenda 20:04:27 #topic project status meeting update 20:04:40 Just taking the opportunity to pass info down from the weekly openstack project meeting 20:05:01 this week was fairly uneventful for glance, but as you all know, rc2's and rc3's are out for all the projects 20:05:16 since glance seems pretty stable post rc2, we're full steam ahead on new code 20:05:22 woohoo! 20:05:35 (because we have no reason to believe we need to worry about backporting bug fixes needing to be especially easy) 20:06:04 there is also some install documentation in a wiki that glance folks might want to check out and see if they can contribute to 20:06:13 #link https://wiki.openstack.org/wiki/HavanaDocTesting 20:06:26 thanks again to everyone for their efforts with rc2 20:06:32 it really went well from my perspective 20:06:44 (we got everything merged before the crud hit the fan with jenkins gating) 20:07:06 any questions about the project meeting? 20:07:44 cool 20:08:02 #topic Release Notes 20:08:10 Glance release notes for havana have been published 20:08:20 #link https://wiki.openstack.org/wiki/ReleaseNotes/Havana#OpenStack_Image_Service_.28Glance.29 20:08:49 I think we could still fill out some more info there for "known issues" i.e. bugs that we're carrying over that are significant 20:08:55 and also possibly upgrade notes 20:09:11 anyone interested in helping out with that effort? 20:09:25 would upgrade notes be like new config values and stuff? 20:09:32 and migrations? 20:09:39 that could make sense 20:09:41 what goes in upgrade notes? 20:09:45 good question :-) 20:10:00 that same page has the release notes for other projects, we can take their lead a bit 20:10:42 yeah, it looks like new config is definitely appropriate 20:10:50 ah gotcha, I can try taking a stab at it 20:10:59 iccha_: can i #action you for that? 20:11:07 yes sir markwash 20:11:23 #action iccha_ to consider and add upgrade information to glance havana release notes 20:11:31 anybody else? 20:11:37 erm, or questions? 20:12:17 cool 20:12:18 sorry, i want to be more active on that but i dont see having time for it in the short term :-( 20:12:23 no worries 20:12:26 we do as we can 20:12:33 #topic design summit 20:12:49 there have been a fair number of submissions for talks at the design summit 20:12:55 #link http://summit.openstack.org/cfp/topic/15 20:13:10 forbidden 20:13:13 markwash: Forbidden 20:13:13 doh 20:13:24 #link http://summit.openstack.org/ 20:13:32 that's a bit more general, but I think you can sort by topic 20:13:42 click 'Topic' column to orderby 20:13:53 i added one yesterday 20:14:04 buzztroll: saw, need proxy? 20:14:15 zhiyan: i do 20:14:27 zhiyan: it is a pretty clear effort i think 20:14:28 i think the person who suggested this item is wondering if we should announce a cutoff date for the submissions? 20:14:38 zhiyan: i actually made a prototype for it at one point 20:14:57 markwash: which one? 20:14:59 markwash: yes, to review them i mean 20:15:09 buzztroll: sorry, not the design summit topic, but the agenda item 20:15:12 ah 20:15:13 topic looks good to me 20:15:13 ok 20:15:58 zhiyan: I think the time is running down on that. . its a task for me. . IIUC I could review and approve/reject everything by next meeting, and then folks could get a chance for some more general feedback 20:16:18 zhiyan: does having everything reviewed and set up by next meeting for feedback sound good to you? 20:16:33 markwash: sure, just remember that 20:16:35 :) 20:16:40 lol yes 20:16:54 #action markwash announce a cutoff for design summit submissions on the ML 20:17:06 #action markwash review design summit submissions for next meeting 20:17:18 any other thoughts folks want to share about the summit at this time? 20:17:42 cool 20:17:54 #topic releasing glanceclient 20:18:23 * markwash searches for a good link 20:18:34 we seem to have major functionaility for glanceclient to talk to glance v2 api in 20:18:43 couple of significant bug fixes have gone in here https://review.openstack.org/#/q/status:merged+project:openstack/python-glanceclient,n,z 20:18:46 erm 20:18:48 #link https://review.openstack.org/#/q/status:merged+project:openstack/python-glanceclient,n,z 20:19:15 I'd like to do a minor release very soon to grab those fixes 20:19:29 in particular I'm worried that the ones russ did are probably really important otherwise why would he bother? 20:19:41 what version is gc currently on? 20:20:08 0.11.0 20:20:20 as for a major release 20:20:26 there is something I've been stewing on for a while in private 20:20:38 I really don't care for the fact that we use our own SSL stuff 20:20:49 and I think we should switch to using requests 20:21:09 could you elaborate markwash ? 20:21:11 on first read that makes a lot of sense to me 20:21:27 bcwaldon was churning on both those items, but couldn't come up with a really satisfactory answer, because our custom SSL stuff is there to optionally disable ssl compression 20:21:27 i havent thought about it before 20:21:40 the idea is that disabling compression makes uploads of already compressed images much faster 20:22:05 which makes sense, but python just doesn't support it very well yet in terms of common libraries 20:22:25 anyway, I think we should revisit the major release in a week or two 20:22:37 any objections to a minor release in the next few days? 20:23:01 in my opinion the transfering of images in terms of efficiency in glance is quite imperfect right now anyway 20:23:26 buzztroll: yeah true 20:23:26 so leaning towards more supportable code and away from efficiency seems ok to me 20:23:34 +! 20:23:39 I need to pressure bcwaldon to submit the review if he ahsn't already 20:23:45 er, +1 :-) 20:23:47 because it is already a neglected category, why have tiny bandaides? 20:23:53 yeah 20:24:08 just my 2 cents there 20:24:14 k 20:24:24 no objection at all to a minor release 20:24:27 buzztroll: :) 20:24:27 to answer your question 20:24:30 sounds good 20:24:32 #action markwash try-release a minor version of glance client in the next few days 20:24:48 #action bcwaldon submit requests review 20:24:52 sounds good 20:24:55 okay, moving on 20:25:15 #topic bugs 20:25:24 some nice folks suggested bugs for us to consider in the meeting 20:25:45 first one 20:25:46 #link https://bugs.launchpad.net/glance/+bug/1176978 20:26:13 the issue is about how our deleted indexes make it so you cannot reuse an image id 20:26:30 for most users this has no significance, because they cannot specify the image id on create anyway (by policy) 20:26:36 ugh 20:26:50 I think folks sensibly think its pretty silly to reuse a uuid 20:26:56 yeah 20:26:58 i think i am on record as not liking the idea of reusing IDs 20:27:02 yeah 20:27:04 however, I think there are some rare operational situations where it makes sense 20:27:11 seems like glance-replicator needs it or something? 20:27:18 and i guess we'd just be saving folks the trouble of doing the mysql themselves 20:27:33 i fear it would move the problem around 20:27:45 also I think fixing the underlying db issue would help with some performance areas as well 20:28:14 I'm not sure we will have a fast answer in this meeting 20:28:20 markwash: do you think it is make sense if we support recover a pending-delete status image back to active ? 20:28:28 markwash: probably not 20:28:44 markwash: i am trying not to run off on tangents and derails the meeting with this topic 20:28:54 * buzztroll behaves 20:28:57 zhiyan: that makes sense, but I'm not sure its necessarily a substitute for what folks are trying to do 20:29:14 anyway, i'd love to see folks post their thoughts on the bug if they haven't already 20:29:23 markwash: cool will do 20:29:35 I suspect fixing the db would just pick a winner in this debate anyway 20:29:40 anyway 20:29:42 next one! 20:29:52 #link https://bugs.launchpad.net/glance/+bug/1197344 20:29:55 zhiyan: that would mean adding a re-use option in the CRUD methodology 20:30:00 just marked it as invalid :P 20:30:12 would multiple locations help? 20:30:38 basic issue: v2 doesn't show deleted images 20:30:51 * markwash backs up. . 20:30:53 and it should? 20:30:53 markwash: yeah neither does v1....that used to be a rax thing 20:30:58 sorry didn't mean to jump ahead 20:31:08 * markwash revs forward again! 20:31:12 lol 20:31:20 I don't really think it should 20:32:05 looks like this issue is covered for now 20:32:08 v1 doesn't show deleted images 20:32:10 so we can move on since its marked invalid 20:32:14 so invalid :P 20:32:14 +1 20:32:26 #link https://bugs.launchpad.net/glance/+bug/967832 20:32:47 glance verifying tenants with keystone has been a topic repeatedly brought up 20:33:01 basic issue: if I delete a keystone project, all the images for that project still exist 20:33:21 iccha_: I think this bug is related but a little bit different 20:33:36 yeah i was speaking off a similar conversation 20:33:49 i think if we do need this addressed it should probably be handled outside of glance? 20:33:53 that's my gut feeling 20:33:59 and our stance has always been that we want separation of concern 20:34:07 yeah, I think that is a fair point 20:34:11 we need superglance 20:34:16 in any case its certainly not something we can just solve by ourselves 20:34:25 we need either a separate project taht does this cleanup 20:34:37 or we need some standard way of consuming openstack notifications to delete things 20:34:42 either approach would work 20:34:55 that makes sense 20:35:26 markwash: i'm thinking again glance-worker ... 20:35:27 so I think we really want some TC guidance on this. . I'd really like the TC to adopt/suggest a path forward on this across the board 20:35:28 how can we ensure glance as a stand alone service if it's married to openstack then or that is not one of the goals? 20:35:44 nikhil: I think we're married to keystone at least 20:35:47 probably nova too 20:35:50 (must be Utah) 20:35:57 gotcha 20:35:59 lol 20:36:10 * markwash turns off Sister Wives to focus 20:36:37 so maybe we can bring this up during an early TC meeting 20:36:45 no advetisements of TV shows here :P 20:36:49 there is no way for glance to proactively know when things are deleted from keystone. 20:36:52 +1 markwash 20:37:36 okay, sounds good. . how do we make sure we don't forget? 20:37:43 I don't know when the first TC meeting is 20:38:13 have a separate etherpad for tc -glance communication notes? markwash or keep this etherpad 20:38:14 I'll just carry it over on the agenda etherpad 20:38:28 ya one etherpad is better than two 20:38:52 cool 20:38:55 moving on! 20:39:02 #topic reviews 20:39:08 I saw one review I just wanted to bring up here briefly 20:39:17 https://review.openstack.org/#/c/46715/ 20:39:26 someone is helpfully contributing unit test coverage 20:39:36 several folks have been, actually, adding in use of mock 20:39:42 which IMO is much nicer than mox 20:39:42 i would prefer the context manager over decorator 20:39:49 for mock.patch 20:40:01 but i don't have a strong opinion 20:40:06 +1 ameade_ 20:40:09 i think there was universal propagation for mock vs mox 20:40:17 i thought we decided a bit ago that everything would be mock instead of mox from now on? 20:40:20 ameade_: thanks, I'm just not that familiar with it so your opinion is very helpful for context! 20:40:29 though nesting is trick with context manager 20:40:40 buzztroll: yes. I think we're all good with mock 20:40:54 my question is just mock.patch 20:41:10 mostly the thing I don't like is that the order of the decorators is the reverse of the order of the extra arguments passed to the test function 20:41:12 nikhil: true story....i think we should just be consistent with one way 20:41:16 due to how decorators work 20:41:21 yeah decorators are wack 20:41:41 Guys, it was my commit. :) 20:41:51 okay well I'm not super worried about this patch, I dont think it will kill us even if we don't love mock.patch :-) 20:41:55 vkolosov: hi! 20:42:29 vkolosov: any thoughts then based on this conversation? keep in mind I'm thrilled for the extra test coverage 20:42:30 I used decorators to avoid multiple nesting 20:42:36 That's all. :) 20:42:57 hmm, yeah all that tabbing could be worse 20:43:09 it's hard to read/review though with decorators 20:43:16 I noticed that many unittests actually are not UNIT test 20:43:30 vkolosov: yeah :-( they sure aren't 20:43:32 haha no doubt 20:43:33 So I tried to make them more like "unit" 20:43:49 learn't hard way that tabbing (or not tabbing) could result into a useless tests 20:43:50 And used a lot of mock decorators 20:43:51 vkolosov: we're all on the same page there, but its been slow going, trying to keep sufficient coverage 20:44:20 nikhil, markwash: if we have to nest too deep it's a code smell, i like everything being in the test function...but i really dont wanna dwell on this 20:44:21 well, it may be the case that mock.patch is the least problematic way of doing this 20:44:26 vkolosov: :) good point (agree about unit tests) 20:44:41 ameade_: haha true! :) 20:44:43 okay, well folks chime in on the review, I'm removing my -1 20:45:00 sounds good, thanks for your efforts vkolosov 20:45:05 +1 20:45:06 if nobody has any other concerns I'll probably +2 as is in a few days 20:45:12 And it would be good to see some other opinions on the review. 20:45:29 vkolosov: thanks again 20:45:40 :) 20:45:55 I plan to work more on this way. 20:46:01 #topic glance async workers checkin 20:46:17 hey 20:46:20 despite missing all the meetings this week, we've got some progress with initial branches merging! 20:46:31 s/missing/me missing/ 20:46:33 thanks markwash and buzztroll! 20:46:58 nikhil: it looks like you've got some more review notices there for us to look into in the next few days 20:47:08 (there == in the agenda) 20:47:13 yeah, 20:47:38 I'm sure we can review and merge them without other patches needing design approval 20:47:46 okay cool 20:47:46 wanted to bring it to everyone's notice 20:47:54 I'll give it some more attention then 20:47:58 thanks 20:48:12 nikhil: any other notices wrt async stuff? 20:48:28 I feel like we should add more tests around tasks 20:48:35 nikhil: do you think it's ok for executor part? 20:48:38 even though with images we might have missed a few 20:49:00 and by tasks - I meant db api and REST api 20:49:27 without diving into async part yet - as it is not in images section of the code 20:50:08 markwash: something venkat_ and I felt the pain of fixing stuff 20:50:25 and had to rely on test_tasks_lifecycle for most things 20:50:29 ah 20:50:39 yeah, more unit testing could be good there. . 20:50:54 do you need any help with that, or just refocusing some priorities for you guys? 20:51:02 thanks! 20:51:20 markwash: just trying to focus on the review section in case some one notices it 20:51:23 gotch 20:51:28 I saw one review - do not know who posted it 20:51:29 s/$/a/ 20:51:51 saying this is like images so we should merge it (feel like that would be fast but painful in the future) 20:51:59 something to look out for in this huge patch 20:52:03 okay cool 20:52:04 let me check the patch 20:53:15 if there's nothing else on async, we can talk about the next/last item 20:53:15 well, ignore me for now (might be remembering a irc comment if not the review comment) 20:53:20 ah okay 20:53:29 #topic gnome OPW project ideas 20:53:45 #link https://wiki.openstack.org/wiki/OutreachProgramForWomen/Ideas 20:53:49 i wonder if any of the design summit proposals would be good for that? 20:54:01 :) 20:54:08 buzztroll: oh neat 20:54:09 if we have any small project in glance we would like an intern to work on we can add it to the ideas page 20:54:20 rewrite the unit tests 20:54:22 there may be a few things like that 20:54:22 heh 20:54:24 the internship is from dec- mid - march mid i think 20:54:38 i dont think they ll pick glance if the project is to rewrtie tests 20:54:41 buzztroll: do you think moving storage out could be good for that? 20:54:50 it could be yeah 20:54:57 there are some nuances 20:55:04 +1 from me 20:55:05 like backward compat 20:55:07 nikhil: and do you think stevedore (which i know you've been looking at) could be a good fit for external storage modules? 20:55:19 i used it in nova 20:55:26 and i ahve a prototype with it actually 20:55:29 if i can find it 20:55:32 ah cool 20:55:38 it seems to be the blessed OS way now, right? 20:55:40 markwash: I feel like stevedore can fit in great for multi-backend approach 20:55:54 I'm glad to know you guys have already covered this ground. . sounds very reasonable 20:55:55 it just hurts the legacy way to load a little 20:56:01 will take a shoe horn there 20:56:15 well we should also keep an eye out for other opportunities here 20:56:20 or a decree from our benevolent PTL 'backward compat be dammed!' 20:56:21 because the OPW seems like a great program 20:56:26 yeah 20:56:30 I'm personally pretty bad at thinking of tasks like that 20:56:33 it all depends on the itern that you get 20:56:36 +1 20:56:38 i have done GSoC in the past 20:56:42 which i think is similar 20:56:44 some of them are not very technical 20:56:48 and i was a mixed bag 20:56:52 take a simple well defined task and I'll figure out how to complicate it to the point that I can't explain how I want it done anymore, so I just do it myself :-) 20:56:57 but want to forray into technology 20:57:08 buzztroll: even gsoc is not technical? 20:57:19 last time i tried making the intern do some pythonclient features 20:57:28 oh crap, running out of time 20:57:31 hmmm gsoc is technical 20:57:38 #topic open discussion 20:57:39 maybe i do not understand the program, ill read up on it more 20:57:44 firehoses open! 20:57:47 how do you win the bid if you aren't technical 20:58:18 software engineering to me seems more process oriented that technology oriented 20:58:42 -2 mins? 20:58:52 yeah 20:59:07 -1 ! 20:59:21 flwang had a baby bot 20:59:25 *boy 20:59:28 :D 20:59:36 that was on purpose I bet 20:59:41 heh I was thinking, I didn't know flwang was a robot :-) 21:00:04 since the b'day was 10.01 at 00.01 in 2013 right? 21:00:05 congrats flwang! 21:00:23 okay, out of time. . lets make way 21:00:29 peace out 21:00:30 see ya folks! 21:00:30 (also I need lunch I guess0 21:00:35 thanks errbody 21:00:39 #endmeeting