14:00:44 <yushiro> #startmeeting fwaas
14:00:45 <openstack> Meeting started Tue Aug 22 14:00:44 2017 UTC and is due to finish in 60 minutes.  The chair is yushiro. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:00:46 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:00:48 <openstack> The meeting name has been set to 'fwaas'
14:01:06 <yushiro> #chair SridarK yushiro xgerman_
14:01:07 <openstack> Current chairs: SridarK xgerman_ yushiro
14:01:52 <SridarK> yushiro: ur turn to run the mtg ?
14:02:13 <SridarK> sorry i forget
14:02:24 <yushiro> SridarK, ah, me too :)
14:02:41 <SridarK> i think xgerman_ ran it last time
14:02:45 <xgerman_> yes
14:02:54 <SridarK> yushiro: so u are the chair
14:03:06 <yushiro> OK, I will :)
14:03:11 <SridarK> pls go ahead :-)
14:03:14 <yushiro> so, let's start
14:04:10 <yushiro> #topic Pike
14:04:46 <yushiro> L2-agent
14:05:20 <yushiro> #link https://review.openstack.org/#/c/323971/
14:05:30 <amotoki> isn't FFE period over?
14:06:00 <yushiro> amotoki, I think yes.
14:06:18 <yushiro> So,
14:07:11 <yushiro> Just an announce.  I fixed l2-agent bug which relates existing l3 behavior.
14:07:23 <reedip_> hi
14:07:54 <yushiro> As you know, this week is dashboard release term.
14:08:27 <yushiro> So, let's move next topic if there is no comment on l2.
14:08:30 <reedip_> sorry I was late , got stuck in the gym , and then traffic
14:08:32 <SridarK> yushiro: nice - i just see the email from u
14:08:57 <yushiro> reedip_, NP
14:09:07 <yushiro> #topic Horizon support
14:09:10 <amotoki> yushiro: if l2-agent stuffs is really a bug, it can be considered for backport, but it should be without any feature
14:10:10 <yushiro> amotoki, OK
14:10:22 <yushiro> SarathMekala, Hi
14:10:36 <SarathMekala> hi.. let me give some updates on Horizon
14:11:02 <SarathMekala> thanks yushiro and amotoki for your suggestions
14:11:39 <yushiro> SarathMekala, NP :)
14:11:43 <SarathMekala> I am following up on the #link https://etherpad.openstack.org/p/fwaas-v2-dashboard created by yushiro
14:11:55 <yushiro> #link https://etherpad.openstack.org/p/fwaas-v2-dashboard  FWaaS dashboard reviews and feedbacks
14:12:15 <SarathMekala> so there seems to be an issue when the ingress/egress policies are not specified
14:12:28 <SridarK> yushiro: will that fix the duplicate problems as u mentioned on the fwaas channel (sorry i went to bed)
14:12:34 <SarathMekala> and it effects all the crud operations.. i will fix it
14:13:04 <SridarK> SarathMekala: yes i seem to have issues on CR on FWG and Policy
14:13:07 <SridarK> Rules were ok
14:13:26 <amotoki> CR = code review?
14:13:26 <yushiro> SridarK, Yes.  Previous code used 'public' instead of 'shared' for getting.
14:13:28 <SridarK> If u spin another PS - i can do more testing
14:13:36 <SarathMekala> ok.. did you find any issues with creating policies?
14:13:42 <SridarK> amotoki: sorry CR - CReate
14:13:46 <SarathMekala> they should have gone smoothly as well
14:13:59 <amotoki> too many abbrevs :(
14:14:04 <SridarK> SarathMekala: no i was not able to create a policy
14:14:11 <SridarK> amotoki: Sorrry :-)
14:14:17 <amotoki> hehe
14:14:22 <SarathMekala> ok..
14:14:46 <SarathMekala> I recently changed 'shared' to 'public' :(
14:14:52 <SridarK> SarathMekala: ok perfect
14:15:03 <SarathMekala> will revert it back
14:15:12 <SridarK> SarathMekala: ok thx
14:15:35 <yushiro> SarathMekala, yes, I commented it in your patch.
14:15:53 <SridarK> SarathMekala: also on FWG, can we update to add in the ingress / egress policy
14:16:11 <SridarK> i could update to add in ports but i seem to miss policy
14:16:35 <SridarK> my workflow: I created a policy on OSC (no ports or policy)
14:16:43 <SarathMekala> hmm.. the update operation should allow to select the policy using a drop down
14:16:45 <SridarK> i was now able to see that on the dashboard
14:17:01 <SridarK> then i was looking to update to add the policy
14:17:02 <SarathMekala> i have tested that flow
14:17:17 <SridarK> SarathMekala: ok my bad then - i may have missed something - let me recheck that
14:17:24 <yushiro> SridarK, it may be 'public'/'shared' issue ...
14:17:27 <reedip_> ** too much data to process **
14:17:35 <amotoki> perhaps everyone has different expected workflows, so we hit several issues.
14:17:35 <SridarK> yushiro: ok
14:17:35 <SarathMekala> SridarK, np .. I will also recheck
14:17:48 <SarathMekala> may have got broken during the last patches
14:17:53 <SridarK> amotoki: could be also
14:17:58 <reedip_> I tried to deploy the horizon plugin but failed :( Will recheck
14:18:08 <yushiro> I think it's better to respin new patch set for testing
14:18:11 <SridarK> SarathMekala: ok once u revert to shared
14:18:13 <SridarK> i will check
14:18:17 <SridarK> yushiro: +1
14:18:31 <SarathMekala> SridarK, sure
14:18:38 <amotoki> i have some questions
14:18:48 <amotoki> how can we move the thing forward fast?
14:18:50 <SarathMekala> amotoki, yes..
14:19:02 <SridarK> yushiro: also i am not pulling in the L2 Agent / driver patches in my testing
14:19:19 <SridarK> since they are not part of the release
14:19:31 <amotoki> we (including yushiro, me or others) might be able to propose a fix, but we are afraid the duplicated work
14:19:56 <yushiro> SridarK, OK.  for testing with dashboard, it is not necessary.
14:20:02 <yushiro> amotoki, +1
14:20:03 <SarathMekala> amotoki, its fine.. you can put in your fixes
14:20:11 <amotoki> i heard yushiro has some fixes for the current dashboard, but we don't know SarathMekala's status
14:20:16 <amotoki> and did not push it
14:20:46 <amotoki> if we are not aware of each other, we can easily override another fix :(
14:20:47 <SridarK> SarathMekala: i think both yushiro and amotoki have pointed to that in gerrit as well
14:21:03 <SarathMekala> SridarK, yes
14:21:13 <SarathMekala> amotoki, I am in a terrible fix right now... have a customer demo tomorrow and am running on a tight rope..
14:21:26 <SarathMekala> am actually planning to push in the patches by eod tomorrow
14:21:47 <amotoki> so, we need to discuss we should defer it to Queens or not
14:22:07 <xgerman_> mmh
14:22:24 <SarathMekala> can we take the call on 24th :)
14:22:29 <reedip_> do we want production bugs ?
14:22:38 <SridarK> SarathMekala: any chance u will be able to address the last set of review comments
14:22:47 <SridarK> then i can do some testing today
14:22:49 <xgerman_> nobody will use Pike in prod — people never update right away
14:22:51 <SridarK> SarathMekala: ur call
14:23:03 <SarathMekala> SridarK, I will address some issues today
14:23:05 <SridarK> SarathMekala: dont mean to put pressure on u
14:23:11 <SarathMekala> and the remaining tomorrow..
14:23:21 <amotoki> let me share my thoughts on the release schedule
14:23:22 <reedip_> xgerman_ oh yeah, right :)
14:23:37 <reedip_> its just us developers :P
14:23:43 <xgerman_> yes
14:23:46 <SridarK> SarathMekala: ok sounds good - i will pick up that PS
14:24:01 <xgerman_> customers are getting to Newton right now
14:24:18 <amotoki> xgerman_: tend to agree
14:24:26 <reedip_> That reminds me we need to pick up the migration of V1 to V2 as well soon
14:24:36 <SarathMekala> amotoki and yushiro wait for today and you can put in your patches on top of mine tomorrow
14:24:36 <reedip_> atleast in the start of queens
14:24:39 <xgerman_> +1
14:24:39 <SridarK> reedip_: yes
14:24:54 <amotoki> I think we need at least three rounds of reviews to land it and we don't have enough to do so
14:25:17 <amotoki> Thursday is the release day, so we should not count it as days we have.
14:25:23 <amotoki> it means Wed is the last day for larger changes
14:25:51 <amotoki> "three rounds' means: the next patch set addresses the current issues raised.
14:26:08 <amotoki> the second patch set will addressed new issues raised based on the next patch set.
14:26:19 <amotoki> the third one is for clean up
14:26:36 <amotoki> and the fourth one MUST be a release deliverable.
14:26:44 <amotoki> this is the current situation.
14:27:01 <SridarK> amotoki: +1 yes it is very tight
14:27:11 <amotoki> can we propose "the third patch set" in Wed?
14:28:25 <SarathMekala> amotoki, do you see any critical issues
14:28:40 <SarathMekala> other than the ones mentioned
14:28:40 <amotoki> SarathMekala: it depends on fwaas team
14:29:12 <amotoki> Note that on Thursday we need to land a patch in the releases repo. it means we propose a patch, ack by the neutron-release team, and approved by the release team.
14:29:17 <yushiro> SarathMekala, amotoki think that we can find any bugs after updated new patchset.
14:29:30 <SridarK> SarathMekala: IMHO - i think right now with PS 17 it has critical issues, but i think based on the review comments - it will be much better
14:29:43 <xgerman_> we are standing by — so if it’s us it would work
14:29:58 <SridarK> SarathMekala: but more testing can reveal other issues
14:30:05 <xgerman_> yes
14:30:31 <amotoki> I see there are two options: to have it in Pike, or to land it early Queens
14:30:33 <SridarK> How abt we give things a try with PS 18 and then decide if it is even realistic
14:30:47 <amotoki> SridarK: +1
14:30:54 <SarathMekala> SridarK, +1
14:30:56 <yushiro> hmm, yes, agree!
14:31:33 <yushiro> I can follow to update PS18 -> 19
14:31:55 <yushiro> also 19 -> 20 :)
14:32:02 <SridarK> :-)
14:32:04 <SarathMekala> yushiro, :)
14:32:16 <SarathMekala> yeah.. lets give it our best shot
14:32:23 <SridarK> +1
14:32:26 <xgerman_> +1
14:32:42 <amotoki> I will prepare a release patch based on the current commit and share the review link with you all. Someone from the fwaas team can take care of it then.
14:33:10 <yushiro> I will
14:33:10 <amotoki> I cannot have enough time on Thursday and Friday morning in my TZ
14:33:15 <SridarK> I am sure there will be bugs but if the basic workflows work - it is acceptable for someone to start playing with it
14:34:23 <amotoki> regarding Pike dashboard release, I would like to have https://review.openstack.org/#/c/495487/
14:34:50 <SarathMekala> patch set 15 is the one I have done quite a bit of testing
14:35:12 <xgerman_> amotoki done —
14:35:15 <amotoki> xgerman_: thanks
14:35:23 <SarathMekala> you can pickit up and see if things are better (it has 'shared' attribute) .. I made significant changes in patchset 16
14:35:49 <yushiro> if amotoki 's patch is merged, we don't need to execute 'cp' command, right?
14:36:08 <amotoki> yushiro: what do you mean by 'cp'?
14:36:18 <amotoki> yushiro: do you talk about the manual step?
14:36:25 <yushiro> amotoki, oops, sorry.  cp is 'copy' command.
14:36:31 <yushiro> yes, manual step
14:36:55 <amotoki> yushiro: they are different things
14:37:20 <yushiro> amotoki, ah, OK. I was just misunderstanding.
14:38:26 <amotoki> yushiro: no problem
14:39:54 <yushiro> OK, so it is just reminder for next patchset(18) from me.
14:40:10 <SridarK> yushiro: ok perfect
14:40:27 <SridarK> i will do more testing with PS 18 today
14:40:32 <SarathMekala> yushiro, yes
14:40:44 <SarathMekala> I will push in the patch tonight
14:40:48 <SridarK> yushiro: / SarathMekala: we can discuss during ur day time
14:40:49 <yushiro> SarathMekala, now 'Create firewall group'  and 'Add policy'(create firewall policy) button doesn't work (not displayed)
14:41:32 <SarathMekala> SridarK, sure.. I will be on hexchat.. you can reach me when you want
14:41:39 <yushiro> SarathMekala, I hope to fix both buttons in PS18
14:42:04 <SarathMekala> yushiro, I will do some thorough testing and push in PS18
14:42:11 <SridarK> ok
14:42:18 <yushiro> After that, we can start testing 'create' part.
14:42:29 <SarathMekala> all basic functionality should work excepting some corner case scenarios and any missed out validations
14:42:53 <SridarK> yushiro: SarathMekala: will we fix the duplicate issue as well with this ?
14:43:27 <SarathMekala> I will fix it as well SridarK
14:43:31 <amotoki> perhaps, we can update patch sets more
14:43:33 <SridarK> ok
14:43:42 <amotoki> with small changes
14:43:45 <SarathMekala> I will try to take out as many issues as possible.. yushiro and amotoki and pick up from there
14:44:26 <amotoki> a couple of small changes sounds better than a big single change :)
14:44:33 <yushiro> SridarK, duplicate issue is here: https://review.openstack.org/#/c/475840/17/neutron_fwaas_dashboard/api/fwaas_v2.py  (commented)
14:44:33 <xgerman_> +1
14:44:34 <SridarK> +1
14:44:40 <yushiro> +1
14:44:49 <amotoki> SarathMekala: btw, do you see any difficulties in passing unit tests?
14:45:30 <amotoki> we've never seen ut passed so far :(
14:45:38 <SarathMekala> amotoki, I could not run them locally as my setup had some issues...
14:45:47 <SridarK> yushiro: ok
14:46:02 <amotoki> woops.... really bad news.
14:46:54 <amotoki> SarathMekala: so, do you mean you need more help to make unit tests healthy?
14:47:43 <SarathMekala> amotoki, I referred to the existing V1 cases to create these.. so except for some import issue which i am seeing
14:47:52 <SarathMekala> there should not be much issue..
14:48:22 <SarathMekala> yushiro, amotoki it will be great if you can try to run them on your local setup and share me the feedback
14:49:00 <amotoki> can anyone help it?
14:49:03 <amotoki> yushiro?
14:49:05 <yushiro> SarathMekala, Of course I can.
14:49:29 <SridarK> SarathMekala: let me also pull in the PS and check UT
14:49:34 <amotoki> i could help it last week but i have no enough time this week
14:49:44 <SarathMekala> sure SridarK .. if possible try out PS 15
14:49:52 <SridarK> SarathMekala: ok
14:49:55 <SarathMekala> it should be more solid
14:50:10 <SridarK> But for manual tests i will wait on PS 18
14:50:23 <SarathMekala> SridarK, sure
14:50:48 <SridarK> So just to be sure that there is no confusion:
14:50:51 <amotoki> let's wait PS18 first and then test and fix various things
14:50:59 <yushiro> SarathMekala, I'll give you UT feedback after PS18.
14:51:12 <SarathMekala> yushiro, sure
14:51:18 <SridarK> SarathMekala: u will push in PS18 with the Create issue and Duplicate fixed ?
14:51:34 <SarathMekala> SridarK, yes.. I think I will have to do a night out today :)
14:51:44 <SridarK> SarathMekala: :-(
14:52:09 <amotoki> SarathMekala: sounds not a good idea :/
14:52:26 <amotoki> it might be good to share the status in the etherpad if some of you are working on some
14:52:41 <yushiro> +1
14:52:46 <amotoki> something like 'hey, I am working on UT based on PS18'
14:52:54 <SridarK> yes +1
14:53:11 <SridarK> last thing we need now is for folks stepping on each othersPS
14:53:43 <yushiro> oops!! so fast today's time
14:53:48 <xgerman_> yes
14:53:51 <xgerman_> time flies
14:53:51 <SarathMekala> amotoki, sure.. wait for my PS 18 and you guys can jump in
14:54:10 <yushiro> SarathMekala, sure.  Thank you.
14:54:19 <xgerman_> Let us quick hit: https://specs.openstack.org/openstack/neutron-specs/specs/stadium/ocata/neutron-fwaas.html#c7
14:54:46 <xgerman_> I asked kevinbenton how to update but he didn’t get back — anyone has an idea?
14:54:47 <SridarK> SarathMekala: thanks
14:54:50 <xgerman_> +1
14:55:12 <xgerman_> also is there a Pike verison?
14:55:52 <amotoki> you can propose an updated pike version to neutorn-spec repo
14:56:11 <reedip_> I created one for Tap-as-a-Service, I can work on it for Pike
14:56:11 <amotoki> unelss kevinbenton is preparing it
14:56:25 <reedip_> I updated the pending items on the fwaas channels yesterday
14:56:50 <SridarK> reedip_: i think fullstack is WIP else we are ok
14:56:59 <xgerman_> sounds good
14:57:04 <yushiro> +1
14:57:05 <reedip_> No, some are still pending, but not much
14:57:29 <reedip_> I will check the fwaas channel , I forgot what I wrote there :)
14:57:35 <SridarK> reedip_: ok could u paste that into the fwaas meeting etherpad whenever u have some time
14:57:42 <xgerman_> wonder if we archive?
14:57:53 <reedip_> sure.
14:57:58 <yushiro> it'S better.
14:58:03 <SridarK> xgerman_: yes we do
14:58:15 <xgerman_> :-)
14:58:30 <reedip_> I will share it still :)
14:58:33 <SridarK> :-)
14:58:38 <yushiro> SridarK, xgerman_ here is a bug which relates fw_group and fw_policy relation https://review.openstack.org/#/c/453786/  I noticed this fix is necessary while testing dashboard.
14:58:39 <TuanVu_> Hi guys, hopefully you have time to check
14:58:40 <reedip_> shall I take the Stadium patch ?
14:58:40 <TuanVu_> https://review.openstack.org/#/c/443385
14:58:40 <TuanVu_> Thanks to the help from Motoki, the Release Note has been added.
14:58:40 <TuanVu_> If there's not any other update required, I hope that this patch can be merged soon.
14:59:00 <yushiro> TuanVu_, Thanks for your fix.
14:59:06 <reedip_> TuanVu_ everything seems ok in your patch :)
14:59:36 <yushiro> 1 minutes left!
14:59:44 <TuanVu_> Thank you, yushiro and reedip_  :)
15:00:01 <amotoki> TuanVu_: np
15:00:02 <reedip_> ok, I am taking the stadium report patch SridarK :)
15:00:19 <yushiro> OK, it's time.
15:00:22 <yushiro> #endmeeting