21:01:49 #startmeeting crossproject 21:01:50 Meeting started Tue Aug 4 21:01:49 2015 UTC and is due to finish in 60 minutes. The chair is markmcclain. Information about MeetBot at http://wiki.debian.org/MeetBot. 21:01:51 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 21:01:53 o/ 21:01:54 The meeting name has been set to 'crossproject' 21:01:55 o/ 21:01:56 \o 21:01:58 o/ 21:01:59 o/ 21:02:00 * morganfainberg lurks mostly though. 21:02:05 o/ 21:02:10 morganfainberg: :P 21:02:13 hi 21:02:13 #link https://wiki.openstack.org/wiki/Meetings/CrossProjectMeeting 21:02:17 Hi 21:02:19 o/ 21:02:20 morganfainberg: that's all I normally do too :) 21:02:27 Light agenda for this week 21:02:35 #info Meeting chairs needed for next week (August 11th) and three remaining open 21:02:36 dates. 21:02:47 * Rockyg is still lurking (mostly) 21:03:06 * edleafe is still lurking too 21:03:11 * geoffarnold ditto 21:03:20 * jokke_ will look the dates 21:03:22 I can't take it next week 21:03:26 anyone available for next week? 21:03:29 o/ 21:03:32 * bknudson lurks 21:03:44 o/ 21:03:57 dhellmann: seems to have just volunteered ;) 21:04:04 hehe 21:04:10 jokke_: +1! 21:04:14 jokke_: no, no, no 21:04:25 :P 21:04:30 dhellmann: aw, don't be shy! 21:04:31 I can do it next week markmcclain 21:04:37 mestery: thanks! 21:04:44 markmcclain: yw :) 21:05:22 dhellmann, you dodged a bullet! 21:05:29 haha... moving on 21:05:31 that one was close 21:05:36 #topic Horizontal Team Announcements 21:05:46 On the release management side, not a lot of things this week 21:05:53 We've been starting to discuss how to actually implement continuous releasing of stable point releases, in two -dev threads: 21:05:58 #link http://lists.openstack.org/pipermail/openstack-dev/2015-August/071188.html 21:06:01 #link http://lists.openstack.org/pipermail/openstack-dev/2015-August/071189.html 21:06:01 edleafe: I've had my turn. 21:06:05 Chime on those if you have an opinion on the topic 21:06:33 taking a week off starting now so don't expect me to follow those threads closely! 21:06:40 yes, i worry we don't ever get much input from downstream package maintainers and operators/deployers on topics like this until we enact them 21:07:10 and then end up with a small-scale revolt on our hands because we changed something they depended on in their workflow 21:07:28 maybe post contents or summary to the operator's list with a request to discuss? 21:08:12 i'd love to just stop having stable point releases at all in liberty and beyond, which was the original proposal, but what little feedback we got from downstream consumers was that they didn't want to lose whatever nonexistent signaling they actually thought they were getting from those 21:08:15 we should get shout of discussions like these advertised on the every Friday spam ;) 21:08:34 fungi: ++ 21:08:51 jokke_: yep, i passed those threads along to the person writing the weekly newletter earlier today 21:08:59 gr8 21:09:04 so that might help raise visibility some 21:09:45 ttx: enjoy! 21:10:02 Any other horizontal announcements? 21:10:33 ttx: I quite like that increment on every commit, its simple 21:11:28 johnthetubaguy, ++ 21:11:35 johnthetubaguy: and easily automated 21:12:11 clarkb was arguing it would pollute the ref space 21:12:14 (i don't know about "easily") 21:12:24 also agreed with fungi about the need to get the package maintainers involved 21:12:38 fungi: well easier than the other models 21:12:57 mostly just don't want to waste time implementing something complex they don't need/won't use anyway 21:13:16 hmm, clarkb has a point, maybe I am not sure about the tag for each commit, if that would work well enough without that (shrugs) 21:13:21 it is kind of strange to have a tag on every commit 21:13:51 isn't a commit... effectively a tag? 21:13:58 the good point pro that in the ml discussion was that it's easy to find out if you have the fix for X which is A.B.C included C+7, yes it is 21:14:37 * morganfainberg doesn't really have a horse in this race but things it's silly to tag every commit... but ... meh? 21:14:48 morganfainberg: it's not easy for human (nor computer) to tell by commit id alone if it was before or after another random commit id 21:14:48 thinks* 21:15:02 morganfainberg: commits don't imply a sequence, nut anyway these are points better made on th ml 21:15:21 indeed. Follow up on ML if you care. Next topic! 21:15:21 where i also type gooder 21:15:49 yeah, to the ML on this one 21:16:13 cool.. moving on 21:16:27 #topic Return request ID to caller 21:16:28 #link https://review.openstack.org/#/c/156508/ 21:16:34 I want to discuss about 3 review comments given by Brant on the specs 21:16:44 First concern: Every method should return an object which contains request_id attribute, so that it’s consistent. This also applies to Tuple return type 21:17:05 IMO, we cannot change Tuple response as it would affect Openstack services. Tuple contains ‘X-Openstack-Request-Id’ in the response header of Response object. So I don’t think there is a need to add request_id attribute here. But I agree it’s not consistent with other types though 21:17:35 We are going to add a new method ‘get_request_id” in client which would return request_id (String) depending on the type of the response to the caller 21:17:50 All logic to interpret different response type will be contained in this new method so user don’t have to worry about it 21:18:11 Any comments? 21:18:17 yeah, that sounds like the compromise I remember us heading towards 21:18:42 johnthetubaguy: Right 21:19:00 Second concern: We were thinking of adding all base class (ListWithMeta, DictWithMeta) in oslo.incubator, but Brant pointed some serious concerns of using oslo.incubator library in keystoneclient 21:19:39 It's possible to add all these new classes in individual clients but it would be repetitive code 21:19:40 having oslo-incubator (unstable code) in keystoneclient (stable code) has been a real pain 21:20:16 I'd be fine if it was obvious that oslo-incubator code was private (prefixed with _) 21:20:33 where would these classes end up after they left the incubator? 21:20:33 but that's not how apiclient was implemented 21:20:46 if the oslo-incubator code isn't marked as private, I'm going to go out on a limb and say I will reject it for keystoneclient 21:21:25 i don't want external projects grabbing the incubator code from keystoneclient as though it was a stable interface of keystoneclient 21:21:40 tpatil: I don't understand why subclassing tuple so methods that return tuples behave the same as the other methods is going to break anything? 21:21:47 I am curious actually, what issues were you seeing with the incubator stuff? oh... thats nasty, I see 21:22:02 morganfainberg: yeah, the incubated code should clearly be private. Maybe we should change foo/openstack to foo/_openstack 21:22:15 dhellmann: that would solve my major concern :) 21:22:28 dhellmann: that would be great 21:22:34 although I'm not certain why this needs to be incubated at all, so I would like to understand that and where it will live later on 21:22:48 dhellmann: we haven't change anything related to Tuple 21:22:48 because maybe it can just go there now and skip the incubation step 21:23:15 dhellmann: i'd also be ok with that 21:23:29 the less that has to migrate through the incubator, the better. 21:23:30 tpatil, bknudson : can one of you explain the concern about tuples? maybe I'm misunderstanding, but it sounded like you thought there was a reason not to change methods that return tuples? 21:23:49 Rockyg: ++ 21:23:50 yeah, i thought oslo-incubator was for code extracted from one or more existing projects, not for entirely new works 21:24:01 tpatil: you say in a comment on line 111: "But we cannot change Tuple response since it will break OpenStack services consuming it." 21:24:11 * morganfainberg is against incubator code in general, especially *new* incubator code 21:24:43 morganfainberg, me, too 21:24:44 dhellmann: methods that return dict, dict is wrapped so you can do .request_id, whereas with tuple it's not wrapped so you can't do .request_id on the returned value 21:25:05 dhellman: first of all ,we cannot subclass tuple and add request_id attribute 21:25:07 dhellmann: so my concern was that I'd like it to be consistent where everything that's returned you can do .request_id on it. 21:25:10 fungi: it is for code where we expect the API to have to evolve in a way that will break things. In the past the predominant source of that code has been other projects, but there's no hard rule for that. 21:25:21 dhellman, so we want to keep the same behavior 21:25:28 tpatil: why can't you subclass tuple? 21:25:43 dhellman: immutable 21:26:02 dhellman: we tried to override __new__ method but that doesn't help too 21:26:23 tpatil: it seems to work fine for me: http://paste.openstack.org/show/406994/ 21:26:44 dhellmann: interesting that there aren't better ways to avoid people thinking you have stable interfaces in a library besides avoiding making a library at all 21:27:04 fungi: issues with python :( 21:27:12 but i guess that's verging off topic 21:27:23 let's switch to java 21:27:30 tpatil: a longer example: http://paste.openstack.org/show/406995/ 21:27:43 heretic! 21:28:20 fungi: well the point is that sometimes there aren't stable interfaces and rather than supporting something crummy for a long time we evolve it using static linking instead 21:28:24 dhellman: Ok, so with this, user can access request_id attribute 21:28:28 right 21:28:49 dhellman: We will confirm this if it works and incorporate it in the specs. Thanks. 21:29:00 Third concern: In case ListWithMeta, request_id is of type list and other places it is not. why? 21:29:09 ListWithMeta type is returned mostly for various list (volumes/snapshots etc) methods. 21:29:17 So it may contain one or more request_ids depending on 'limit' and 'page_size' parameters passed in the request 21:29:26 so these comments were about making the interface consistent 21:29:26 Whereas in all other cases, there will be only one request_id 21:29:34 so that the same code could be used to process it. 21:29:39 bknudson: right 21:29:44 bknudson: do we need a list everywhere, then? 21:29:46 But if we want request_id attribute to be consistent for all types, then we will change it list type 21:29:54 a list everywhere would be consistent 21:30:10 ok, so then request_ids instead of request_id 21:30:11 and also more resilient in case other methods required making multiple calls 21:30:26 dhellman: sure 21:30:32 yeah, that seems good, makes it simpler 21:30:58 That's address all my concerns, anyone has anything else to add 21:31:15 s/address/addresses 21:31:29 sounds like one more revision might jsut do it. Great work, tpatil 21:31:41 thanks for working on this the last few weeks 21:31:44 Rockyg: Thanks 21:31:56 #topic Vertical Team Announcements 21:32:08 Any vertical team announcements? 21:32:54 #topic Open discussion 21:33:15 #info Travel Support Program Deadline is August 10th 21:33:19 #link https://wiki.openstack.org/wiki/Travel_Support_Program 21:33:44 2 new api guidelines up for group review, #link http://lists.openstack.org/pipermail/openstack-dev/2015-August/071345.html 21:34:15 elmiko: apologies... I missed those otherwise would have added to agenda 21:34:37 markmcclain, no worries, it's more informational. i don't think there is much to discuss. 21:34:42 ok 21:35:00 although, i say that now, it really blew up last time lol 21:35:39 yeah.. funny how that happens 21:35:48 any other open items? 21:35:57 also, i did add them to the agenda wiki. is there a better place for future reference? 21:36:22 elmiko: that's the right place.. I had not refreshed my browser from this morning when I sent the email 21:36:32 gotcha, thanks =) 21:36:53 #info mestery to chair next week 21:37:20 markmcclain: Thanks ... I think. o_O 21:37:23 :) 21:37:34 Thanks for volunteering 21:37:41 Have a great week everyone. 21:37:43 #endmeeting