02:31:42 <ekcs> #startmeeting congressteammeeting
02:31:43 <openstack> Meeting started Fri Jun  8 02:31:42 2018 UTC and is due to finish in 60 minutes.  The chair is ekcs. Information about MeetBot at http://wiki.debian.org/MeetBot.
02:31:44 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
02:31:46 <openstack> The meeting name has been set to 'congressteammeeting'
02:32:15 <ekcs> hi all!
02:32:32 <ekcs> topics are kept here as usual. please add/comment as desired https://etherpad.openstack.org/p/congress-meeting-topics
02:32:47 <akhil_jain> ekcs: hi!
02:33:25 <ekcs> hi akhil_jain ! how’s it been?
02:33:59 <akhil_jain> nothing much. making monasca push driver ready on local env
02:35:13 <ekcs> nice!
02:35:35 <ekcs> I’ve had a pretty good week too.
02:35:38 <ekcs> ok let’s get started then.
02:36:04 <ekcs> just a quick announcement that rocky-2 releases are tagged for congress and congress-dashboard.
02:36:37 <ekcs> also a new congress client 1.10.0 release. doing that early in the cycle so hopefully any problems surface before the end of the cycle.
02:37:06 <masahito> hi
02:37:12 <ekcs> hi masahito !
02:38:02 <ekcs> #topic defer type consolidation from data source to policy engine
02:38:51 <ekcs> just want to mention this patch to see if anyone wants to take a look.
02:38:52 <ekcs> https://review.openstack.org/#/c/562089/
02:39:51 <ekcs> basically, congress data source driver converts some types (bool for example) to strings because that’s how agnostic engine handles them.
02:40:35 <ekcs> but other data consumers can benefit from the original (bool) data rather than the string. so this is some refactoring to move the conversion from datasource driver to policy engine.
02:42:02 <ekcs> any comments or discussions now? if not we can move on.
02:47:03 <ekcs> alright let’s move on then =)
02:47:33 <ekcs> #topic JSON in execute[]
02:48:00 <ekcs> some execute[client_method(args)] take JSON structure as arguments. e.g., neutron create_security_group
02:48:18 <ekcs> congress can't successfully call because Congress can pass it only JSON string, not JSON structure
02:49:28 <ekcs> There are two ways (at least) to fix this problem. one is to add code to data source drivers to convert from JSON string to JSON structure on these methods
02:49:43 <ekcs> the other is to add a new Congress builtin str2json(a, b) which takes str input a and convert to JSON structure b.
02:50:05 <ekcs> any interest in discussing the two approaches or other ideas?
02:50:42 <masahito> First one looks better to me.
02:51:23 <ekcs> right I think so too at least from the rule perspective.
02:51:34 <masahito> The policy writer usually doesn't care of the execute's [] argument format.
02:51:46 <ekcs> that’s a good point.
02:52:23 <ekcs> the difficulty is that we then need to manually indicate which arguments of which methods to convert. does not work well with the current automated import of client action methods into driver.
02:52:36 <ekcs> but if it’s the right thing to do then it’s the right thing to do.
02:53:43 <masahito> IIRC, neutronv2 driver handles the issue.
02:54:37 <masahito> here https://github.com/openstack/congress/blob/master/congress/datasources/neutronv2_driver.py#L470
02:56:09 <ekcs> ah interesting.
02:56:14 <masahito> we're now using servers_set_meta() in nova_driver.py internally, and the current rule forms more readable rule.
02:57:37 <masahito> execute[nova.server_set_meta(tag, value)] :- some_rule(tag, value)  like this.
02:58:54 <ekcs> I see. so maybe we should continue that approach with other things. like neutron create_security_group for example is where I ran into the issue.
02:59:17 <ekcs> great thanks for the related info!
02:59:33 <ekcs> very helpful to have that perspective
03:00:00 <ekcs> #topic open discussion
03:00:20 <ekcs> anything else we want to talk about today?
03:05:16 <ekcs> alright let’s end meeting then if nothing else for today. have a great weekend and see you next week!
03:06:29 <akhil_jain> Happy weekend!
03:09:05 <ekcs> bye akhil_jain !
03:09:08 <ekcs> #endmeeting