14:00:01 <rafaelweingartner> #startmeeting cloudkitty
14:00:01 <opendevmeet> Meeting started Mon Apr 29 14:00:01 2024 UTC and is due to finish in 60 minutes.  The chair is rafaelweingartner. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:00:01 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:00:01 <opendevmeet> The meeting name has been set to 'cloudkitty'
14:00:05 <rafaelweingartner> Hello guys!
14:00:08 <rafaelweingartner> Roll count
14:00:32 <seunghunlee> Hello
14:00:34 <mattcrees> o/
14:03:27 <rafaelweingartner> Do you guys know if priteau is comming?
14:03:38 <priteau> Hello. Sorry I am dealing with a customer issue.
14:03:45 <rafaelweingartner> ah, no worries :)
14:04:01 <rafaelweingartner> #topic Storyboard status
14:04:18 <rafaelweingartner> This is a process that is being done by priteau. I guess, we can sync up about this topic next week
14:05:50 <rafaelweingartner> The next topic is also to discuss with priteau, so I will just register it here, and we can return to it during our next meeting.
14:05:55 <rafaelweingartner> #topic Old branches deprecation/deletion
14:06:08 <rafaelweingartner> The idea is to deprecate and remove branches for EOL versions
14:06:17 <rafaelweingartner> therefore, we do not need to use time to maintain them anymore
14:07:28 <mattcrees> Makes sense, I suppose there will be some branches (at least Yoga plus afaik) that we'd be interested in continuing to maintain.
14:08:14 <rafaelweingartner> exactly
14:08:49 <seunghunlee> Sounds good
14:13:10 <rafaelweingartner> Moving on for the target reviews!
14:13:13 <rafaelweingartner> #topic: Target reviews
14:13:52 <rafaelweingartner> This one #link https://review.opendev.org/c/openstack/cloudkitty/+/876643, has been in the making for a long time, and it seems to be ready for merging. It would be awesome to get other's people review here.
14:14:14 <rafaelweingartner> Specially, as it is targeted to 2024.2
14:16:20 <mattcrees> That's a big one. I'll add it to my reviews list, but I'm not sure I'll have the time too soon to test it
14:16:43 <rafaelweingartner> no worries
14:16:47 <rafaelweingartner> indeed it is a big one
14:17:07 <rafaelweingartner> it is introducing a new concept to cloudkitty, which is the ability to have start/end date in the rating rules
14:17:16 <rafaelweingartner> It is a big milestone for us as a community
14:17:39 <mattcrees> Certainly sounds like a good feature to have!
14:17:48 <rafaelweingartner> =)
14:18:39 <seunghunlee> I'll have a look too. But it might take some time as this is a big one
14:19:09 <priteau> rafaelweingartner: I left comments on that patch
14:19:10 <seunghunlee> Definitely a good feature to have
14:19:10 <rafaelweingartner> no worries
14:19:17 <rafaelweingartner> priteau: yes!
14:19:22 <rafaelweingartner> Pedro is already taking a look into it
14:22:24 <rafaelweingartner> Moving on, we have the patch #link https://review.opendev.org/c/openstack/cloudkitty/+/684747, which also seems to be ready. Other revies would also be welcome!
14:26:04 <mattcrees> Looks like it's ready to go tbh. Are you waiting on a final review from priteau?
14:26:37 <priteau> I've not looked at this one yet
14:27:03 <rafaelweingartner> Not necessarelly, I am just inviting others to also review =)
14:27:16 <rafaelweingartner> just trying to include more contributors into the patches, before we merge them
14:29:24 <mattcrees> Makes sense :)
14:32:52 <rafaelweingartner> Moving on, we have the patches #link     https://review.opendev.org/c/openstack/cloudkitty/+/916986 and #link https://review.opendev.org/c/openstack/cloudkitty/+/916987
14:33:02 <rafaelweingartner> they are the same patches, but targetting different branches
14:33:10 <rafaelweingartner> why don't we open against master?
14:33:23 <rafaelweingartner> and then, when it is merged, we push/backport if needed to others
14:33:39 <rafaelweingartner> It does not seem to be a very important patch to be in releases already released.
14:33:51 <mattcrees> It was already merged in master: https://review.opendev.org/c/openstack/cloudkitty/+/904433
14:34:04 <mattcrees> These are the backports to that
14:34:59 <rafaelweingartner> I see
14:35:05 <rafaelweingartner> I guess we can just merge them
14:35:13 <rafaelweingartner> what do you guys think?
14:35:20 <priteau> One of them is not passing CI
14:35:38 <priteau> This is not an important fix, it's mostly to reduce spam in logs
14:36:44 <rafaelweingartner> the one that was ok, I merged then
14:37:40 <rafaelweingartner> the other one, seems that we might need to do another patch for that branch
14:37:42 <rafaelweingartner> to fix CI
14:37:46 <rafaelweingartner> what do you guys think?
14:40:21 <mattcrees> At a glance the failures look unrelated to the patch
14:40:30 <mattcrees> > alembic.script.revision.ResolutionError: No such revision or branch '175fa80908e1'
14:41:27 <rafaelweingartner> let's see the recheck output
14:41:30 <rafaelweingartner> and we move on from there
14:43:47 <rafaelweingartner> Moving on, we have #link https://review.opendev.org/c/openstack/cloudkitty/+/915992
14:44:06 <rafaelweingartner> I am not versed in ElasticSearch
14:44:11 <rafaelweingartner> but it seems something interesting
14:44:15 <rafaelweingartner> wha tdo you guys think?
14:44:22 <rafaelweingartner> Is it also supported in OpenSearch?
14:45:15 <mattcrees> Yes datastreams are in OpenSearch so it would be good to see that get into both backends.
14:45:44 <rafaelweingartner> Cool
14:45:52 <rafaelweingartner> Are you guys able to review that patch?
14:45:58 <rafaelweingartner> and maybe propose this to OpenSearch as well?
14:46:08 <priteau> We need to decide what we do about the ES driver
14:46:14 <rafaelweingartner> agree
14:46:17 <priteau> We said it was deprecated and we would remove it
14:46:25 <priteau> But maybe zigo is still using it?
14:46:34 <rafaelweingartner> that is why I was surprised when I saw the patch proposed there
14:46:56 <priteau> Also in kolla-ansible there was pushback against removing the ES configuration part for cloudkitty
14:47:05 <priteau> So maybe we should un-deprecate
14:47:44 <rafaelweingartner> That might be a good patch
14:47:45 <rafaelweingartner> path*
14:47:49 <rafaelweingartner> then we have both
14:47:55 <rafaelweingartner> and they both can evolve apart from each other
14:48:03 <rafaelweingartner> as they are completly separated drivers/components
14:52:16 <rafaelweingartner> Moving on, we have the patch #link https://review.opendev.org/c/openstack/cloudkitty/+/915479, where it does not seem to be needed the change proposed. However, we need to see the feedback from the author there
14:54:49 <rafaelweingartner> And, I guess those were all of the topics covered.
14:54:56 <rafaelweingartner> Do you guys have something else to add?
14:55:54 <mattcrees> There was this patch that was missed during the yoga switch to unmaintained. Not urgent just yet, but we'll need it when we try to backport OpenSearch support in KA. https://review.opendev.org/c/openstack/cloudkitty/+/913580
14:56:21 <rafaelweingartner> and we already aproved
14:56:27 <rafaelweingartner> but sadly, those are not merged by us
14:56:37 <rafaelweingartner> I guess we need to ping Elod there
14:56:55 <rafaelweingartner> If we want to add that patch into Yoga
14:57:25 <mattcrees> Oh I see, the unmaintained team needs to do this instead. I forgot that there was a different team for that
14:57:43 <rafaelweingartner> yes
14:59:30 <rafaelweingartner> We will need to close guys, but I guess that was it for today
14:59:32 <rafaelweingartner> Thank you guys for participating. Have a nice week.
14:59:35 <mattcrees> I don't think there's any other patches we're looking for reviews on. Thanks very much for the quick merges of our recent bugfixes :)
14:59:44 <rafaelweingartner> =)
14:59:45 <seunghunlee> Thank you
14:59:47 <rafaelweingartner> welcome!
14:59:48 <rafaelweingartner> #endmeeting