14:00:05 <rosmaita> #startmeeting cinder
14:00:05 <opendevmeet> Meeting started Wed Dec 14 14:00:05 2022 UTC and is due to finish in 60 minutes.  The chair is rosmaita. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:00:05 <opendevmeet> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:00:05 <opendevmeet> The meeting name has been set to 'cinder'
14:00:13 <rosmaita> #topic roll call
14:00:21 <rosmaita> o/
14:00:40 <eharney> hi
14:00:43 <felipe_rodrigues> hi
14:00:49 <kgube> hi
14:01:36 <rosmaita> #link https://etherpad.opendev.org/p/cinder-antelope-meetings
14:01:40 <happystacker> hello!
14:01:49 <simondodsley> hi
14:02:39 <rosmaita> ok, i guess we can get started
14:02:41 <ganso> o/
14:02:58 <jungleboyj> o/
14:03:06 <happystacker> o/
14:03:13 <rosmaita> (Rajat is stuck on a customer call, that's why I'm chairing the meeting)
14:03:24 <enriquetaso> hi
14:03:29 <rosmaita> #topic announcements
14:03:42 <rosmaita> 1 - cinderlib release tomorrow
14:04:01 <rosmaita> (we'll talk more about this later)
14:04:11 <rosmaita> 2 - spec freeze: Friday 16 December 2022 (23:59 UTC)
14:04:33 <rosmaita> 3 - Festival of XS Reviews on Friday ???
14:04:51 <rosmaita> Rajat sent an email asking whether people would be able to attend on Friday
14:05:00 <rosmaita> #link https://lists.openstack.org/pipermail/openstack-discuss/2022-December/031498.html
14:05:01 <happystacker> can you clarify on what the spec freeze is? I have a few patches to be reviewed, how will I be impacted by that?
14:05:12 <rosmaita> but there's been no response, last time i checked
14:05:18 <rosmaita> happystacker: sure
14:05:45 <rosmaita> big features require a spec to be approved first, before patches can be merged
14:06:00 <rosmaita> and since they're big, there's a deadline for filing a spec
14:06:14 <rosmaita> so the spec needs to be approved by friday, and then the code by milestone-3
14:06:43 <rosmaita> so "regular" patches aren't affected by the spec freeze
14:07:29 <rosmaita> happystacker: does that answer your question?
14:07:33 <happystacker> ok cool, the spec I was working on (PowerFlex 8GB increment) won't land into Antelope, as I don't have time to do it, so we're good then
14:07:44 <happystacker> yes absolutely, thanks Brian
14:07:48 <rosmaita> great
14:08:11 <rosmaita> ok, back to the Festival of Reviews on friday ... will anyone be around?
14:08:25 <rosmaita> turnout on the past 2 festivals has been pretty low
14:08:31 <rosmaita> i hope people aren't losing interest
14:08:58 <rosmaita> (this is where someone says "yes, i'll be here, we should have the Festival")
14:09:01 <jungleboyj> I think it has been a busy time of year.
14:09:17 <rosmaita> jungleboyj: ++
14:09:26 <happystacker> I'll be there
14:09:34 <happystacker> even if I'm not a big contributor
14:09:36 <jungleboyj> Probably the same for this Friday.  :-)
14:09:49 <rosmaita> i'll be there too
14:09:59 <rosmaita> OK, let's have it as usual!
14:10:06 <happystacker> ok
14:10:16 <jungleboyj> I will try to join for the last hour.
14:10:26 <rosmaita> #action rosmaita - reply to Rajat's email to say that we will have the festival on friday
14:10:36 <rosmaita> jungleboyj: sounds good
14:10:57 <rosmaita> and everyone else, remember that you can always use the Festival dashboard to do reviews on your own
14:11:13 <rosmaita> you can find it here: https://etherpad.opendev.org/p/cinder-festival-of-reviews
14:11:21 <simondodsley> I will try and get to it as well
14:11:40 <happystacker> just to let you know that we have a reorg at dell, and I'm pushing hard to the rest of team that we need to contribute MORE than we do now
14:11:46 <happystacker> yes, will look into it
14:11:57 <rosmaita> happystacker: ++
14:12:13 <jungleboyj> happystacker: ++  Hope it goes well.
14:12:24 <rosmaita> ok, and as incentive, remember that anyone who attends can nominate one of their own patches for special attention
14:12:27 <happystacker> exciting times, I guess yes
14:13:47 <rosmaita> ok, that's all the announcements
14:13:59 <rosmaita> #topic reviews needed for cinderlib release
14:14:23 <rosmaita> whoami-rajat and I finally got the cinderlib gate un-clogged so that we can merge Zed patches
14:14:34 <rosmaita> just in time, because the release is supposed to happen tomorrow
14:14:48 <whoami-rajat> mostly rosmaita , thanks a lot for fixing it!
14:14:48 <rosmaita> there is a stack of patches that need reviews
14:15:07 <rosmaita> well, "fixing" may be overstating it
14:15:21 <rosmaita> it turned out that the big problem was unit test isolation
14:15:40 <rosmaita> which suddenly stopped working and tests were interferring with each other all over the place
14:15:57 <rosmaita> i really don't understand it, so there's room for someone to dig in and figure out wtf
14:16:41 <rosmaita> anyway, the big change on https://review.opendev.org/c/openstack/cinderlib/+/867132/ is to run our unit tests in 3 batches and combine the results
14:16:41 <enriquetaso> Sorry, I'll be on the festival this friday too
14:16:54 <rosmaita> enriquetaso: ++
14:17:42 <rosmaita> i tested it out and the combination works, the only weird thing is that you may have to scroll back to see which set of tests failed
14:18:17 <rosmaita> anyway, since rajat and I did the first patch, we definitely need another core to review it
14:18:27 <rosmaita> #link https://review.opendev.org/c/openstack/cinderlib/+/867132/
14:18:52 <rosmaita> (this is where I stop and wait for someone to volunteer)
14:19:19 <jungleboyj> I can take a look.  :-)
14:19:24 <enriquetaso> sure
14:19:30 <enriquetaso> i can too
14:19:32 <rosmaita> 2 is better!
14:19:35 <rosmaita> thanks
14:19:38 <jungleboyj> That should be good then.
14:19:49 <rosmaita> the "open for zed" patch is kind of big, but it's not complicated
14:20:07 <rosmaita> well, it actually is, i guess, but there's documentation explaining exactly what it does
14:20:56 <rosmaita> #link https://docs.openstack.org/cinderlib/latest/contributor/contributing.html#cinderlib-tox-and-zuul-configuration-maintenance
14:21:03 <rosmaita> (took me a minute to find it)
14:21:21 <rosmaita> the other patches in the stack are pretty small and self-explanatory, and one even already has 2 +2s
14:22:27 <rosmaita> you can find them by going to https://review.opendev.org/c/openstack/cinderlib/+/867132/ and looking at the "Relation chain" in the gerrit interface
14:23:00 <rosmaita> ok, thanks jungleboyj and enriquetaso
14:23:17 <rosmaita> #topic reminder: re-review of https://review.opendev.org/c/openstack/cinder/+/812685
14:23:35 <rosmaita> i will take a look later today
14:23:57 <rosmaita> (I've kind of been busy with cinderlib)
14:24:25 <rosmaita> there's a new PS up addressing earlier comments, so let's keep moving this along
14:24:32 <rosmaita> ganso: anything to add?
14:24:46 <ganso> rosmaita: nothing to add =)
14:24:52 <rosmaita> cool
14:25:14 <rosmaita> #topic request core reviews of Pure driver patches
14:25:21 <rosmaita> kind of self-explanatory
14:25:30 <rosmaita> #link https://review.opendev.org/c/openstack/cinder/+/855060
14:25:39 <rosmaita> which is a bugfix, and
14:25:46 <rosmaita> #link https://review.opendev.org/c/openstack/cinder/+/862365
14:25:52 <rosmaita> which adds a feature
14:25:56 <rosmaita> simondodsley: anything to add?
14:26:21 <simondodsley> Nope - passing Pure CI and main Zuul. Need some eyes on
14:26:28 <rosmaita> ok, thanks
14:26:43 <rosmaita> #topic request review of attached extend spec for NFS drivers
14:26:52 <rosmaita> this is timely with the freeze fast approaching
14:27:00 <rosmaita> #link https://review.opendev.org/c/openstack/cinder-specs/+/866718
14:27:19 <rosmaita> kgube has rewritten it to address comments from the nova team about what they find acceptable
14:27:34 <rosmaita> kgube: anything to add?
14:27:34 <kgube> yeah, it was on hold, because the spec was rewritten and there was no feedback from nova on the new direction
14:27:54 <kgube> ive finally gotten feedback that the direction is acceptable
14:28:00 <kgube> for them
14:28:14 <rosmaita> great
14:28:22 <kgube> of course, i don'tr know if I even still have a chance of this making freeze
14:28:29 <rosmaita> eharney: maybe you could put this on your list to review?
14:29:03 <rosmaita> kgube: i think you can make a case for a freeze extension if that becomes necessary
14:29:17 <rosmaita> (though it will be up to the PTL to decide)
14:29:28 <eharney> i'll take a look at it
14:29:34 <kgube> thanks!
14:30:12 <rosmaita> ok, that covers our agenda for today
14:30:17 <rosmaita> #topic open discussion
14:30:31 <inori> Excuse me, I'd like to bring attention in these patches here.
14:30:44 <inori> https://review.opendev.org/q/owner:inori
14:31:20 <inori> These are patches that I've submitted and most of them have passed the CI. Because there's a large difference between our "enterprise" and "community" drivers, so  we want to merge them as eraly as possible.
14:31:42 <inori> So could you please review or reply them at your earliest convenience?
14:31:58 <rosmaita> your plan is to get all the features from the "enterprise" edition into the community driver?
14:32:32 <inori> Yes, we do. And now we've submitted some of them.
14:33:12 <rosmaita> sounds good ... was it your driver where there was a question about versioning, or was that someone else?
14:35:27 <inori> Most of the patches I submiteed have passed the CI, but there's no one reviewed or reply them.
14:35:45 <rosmaita> guess it was some other driver if you don't know what I"m talking about!
14:36:03 <rosmaita> ok, looks like they are independent patches, so the order of reviewing doesn't matter?
14:36:51 <inori> yes, taht's true.
14:37:58 <rosmaita> ok, sounds good
14:38:19 <rosmaita> sounds like we are out of discussion topics
14:38:55 <rosmaita> thanks everyone ... please use your 20 minutes of free time to review something mentioned in today's meeting!
14:39:00 <rosmaita> #endmeeting