14:00:11 #startmeeting cinder 14:00:11 Meeting started Wed Aug 17 14:00:11 2022 UTC and is due to finish in 60 minutes. The chair is whoami-rajat. Information about MeetBot at http://wiki.debian.org/MeetBot. 14:00:12 Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. 14:00:12 The meeting name has been set to 'cinder' 14:00:16 #topic roll call 14:00:22 hi 14:00:26 o/ 14:00:33 hi! o/ 14:00:36 o/ 14:00:37 Hi 14:00:45 hi 14:00:48 hi 14:00:54 o/ 14:01:05 #link https://etherpad.openstack.org/p/cinder-zed-meetings 14:01:07 o/ 14:01:09 hi 14:01:17 o/ 14:01:18 hi 14:01:24 o/ 14:01:35 hi 14:01:39 o/ 14:02:23 mep 14:03:04 good turnout today! 14:03:09 let's get started 14:03:11 #topic announcements 14:03:23 first, Midcycle summary 14:03:30 #link https://wiki.openstack.org/wiki/CinderZedMidCycleSummary#Session_Two:_R-8:_10_August_2022 14:03:45 I've written a brief summary of the main topics we discussed 14:04:11 other details can be found in the etherpad and the recording which is linked in the summary 14:04:46 thanks! 14:04:51 if anyone is working on a feature for Zed, please add the details to this etherpad 14:04:53 #link https://etherpad.opendev.org/p/cinder-zed-features 14:04:55 ++ 14:04:58 :) 14:05:40 next, Festival of XS reviews on 19 August (this friday) 14:05:55 so this week, we have third friday of the month that means festival of XS review 14:06:24 i was thinking of clearing os-brick backlog since we've non-client library release next week Thursday but let's see 14:06:41 I will send out a mail after the meeting with the details 14:07:05 next, os-brick release at R-6 (25th August) i.e. next week 14:07:41 we just had the midcycle and we have one deadline soon, time flies by this cycle 14:08:04 i checked the open patches and mostly are mypy ones 14:08:07 #link https://review.opendev.org/q/project:openstack/os-brick+status:open 14:08:23 I will update my 2 nvme-of patches 14:08:27 is there intent to review the mypy ones? 14:08:32 maybe we can have festival of mypy reviews this friday but let's see 14:08:41 geguileo, great 14:08:49 it would be good to get those closed out (mypy in os-brick) 14:08:57 eharney, yes, i was thinking of covering them this Friday (if the team is in agreement) 14:09:41 great 14:10:15 so the mypy patches are sorted and i don't see anything else major to be merged 14:10:22 since we already merged all nvmeof patches during M2 14:11:26 moving on 14:11:29 next, python-cinderclient release and feature freeze R-5 14:11:58 this is next to next week but we barely get time between deadlines so just for awareness 14:12:04 #link https://review.opendev.org/q/project:openstack/python-cinderclient+status:open 14:12:14 I don't see anything major apart from the MV bump abishop has proposed 14:12:38 so would be good to get Alan's cinder patch in before cinderclient release 14:12:46 hi 14:13:35 that's all i had for announcements, anyone has anything else? 14:14:15 I have two topics 14:14:21 guess not, so we can move to topics 14:14:37 #topic Approval request to post comment to patches for HPE XP Storage CI 14:14:40 adiare: are those topics in the agenda? 14:14:47 adiare, that's you 14:14:48 Yes 14:14:58 They are. Added them yesterday. 14:15:37 adiare: ok, the floor is yours 14:16:15 Completed testing of HPE XP Storage Cinder CI environment. Need approval to post comments. CI Link is on agenda. 14:17:19 adiare, I don't think any formal approval is required to post comments, just the CI job should be non voting 14:17:59 Understood. This page suggested one was needed https://docs.opendev.org/opendev/system-config/latest/third_party.html 14:18:36 We can move on to next topic then. 14:18:46 i see, it is a good practice to make the team aware about your CI 14:18:52 cool 14:19:03 #topic HPE XP Storage Cinder driver inclusion in Zed 14:19:18 adiare, that's also you 14:19:23 Yes. 14:19:42 I have a couple questions in regards to this topic. 14:20:16 The short answer to that Question about inclusion of driver in Zed is No, we're already past deadline 14:20:17 I am fairly new to space. How do I confirm whether our driver was picked up by Zed? 14:20:32 Understood. 14:20:53 Until the code changes are merged, which IIRC is not for HPE XP driver, it isn't included in a release 14:21:21 ok 14:21:33 we had a deadline on 15th July which was later extended to 29th July but HPE XP CI wasn't ready at that time so we had to target the driver for next release 14:21:34 adiare: you need to reassess your patch https://review.opendev.org/c/openstack/cinder/+/815582 as there are some changes in files that are not related to XP so I suspoect you need to rebase 14:22:03 specifically the support-matrix.ini 14:22:06 Ok thank you. 14:22:14 Will take a look. 14:22:22 you can see details on L#166 here https://etherpad.opendev.org/p/cinder-zed-new-drivers 14:22:32 adiare: also, read the second-to-last paragraph on https://docs.openstack.org/cinder/latest/contributor/contributing.html#getting-your-patch-merged 14:22:32 then we need to see the XP CI reporting success 14:22:41 ok. 14:24:09 From a process perspective, for a Storage system submitting both FC and iSCSI drivers. Can one or the other be accepted for inclusion? or both must pass CI? 14:24:43 ...For the cinder driver to be included. 14:24:49 if they are in the same patch they both have to pass 14:24:55 both should pass CI 14:25:02 Understood. 14:25:08 split the patch into 2 and they can be accepted separately 14:25:24 Makes sense. That covers my two topics. Thank you. 14:25:27 any driver working is confirmed by tempest testing against the vendor hardware which is the purpose of third party CI job so it's important 14:26:34 adiare, you can work on getting the CI ready so your driver can be merged early next cycle 14:26:36 Understood. Thank you again. I have no other topic/question. 14:26:47 Will do. 14:26:55 thanks 14:27:07 that was the last topic of today's meeting 14:27:14 let's move to open discussion 14:27:20 can I ask something? 14:27:21 #topic open discussion 14:27:27 hemna: any objection to rbd-iscsi-client supporting py 3.9? see geguileo's comment on https://review.opendev.org/c/openstack/rbd-iscsi-client/+/852783 14:27:30 yuval, sure 14:27:39 nope. 14:27:51 hemna: cool, i will update the patch 14:27:57 if I want to add qos support to lightbits driver - is it to late for zed? 14:28:37 yuval, no, feature freeze is R-5 which is on 1st september 14:28:44 got it 14:28:46 thanks 14:28:48 before that, you can add any feature to your driver 14:28:50 np 14:29:17 rosmaita: I'm ok with it if hemna is ok with it (which he seems to be) 14:29:24 for reference https://releases.openstack.org/zed/schedule.html 14:29:24 yup 14:29:40 geguileo: ty 14:31:44 How does a CI system get included on this list #link https://review.opendev.org/admin/groups/270,members 14:33:39 adiare: i don't know if that's still used ... i think the key thing is to follow all the instructions on that opendev page you referenced earlier 14:33:55 #link https://docs.opendev.org/opendev/system-config/latest/third_party.html 14:34:00 geguileo you had a patch to meld 2 functions in all the drivers - (I dont remember the function names) I think it was related to checks in driver start up 14:34:35 Ok. sg. Lots of data out there. Making sure I am looking at the right stuff. Thanks for the info. 14:35:47 yuval: yes, let me look for it (it's in merge conflict) 14:36:08 yuval: https://review.opendev.org/c/openstack/cinder/+/815659 14:36:20 it merges do_setup and check_for_setup_error 14:36:20 adiare: you might want to look at https://etherpad.opendev.org/p/cinder-drivers-documentation ... you can give us some feedback on the driver documentation 14:36:55 adiare, you can join #openstack-cinder channel for any queries/doubts so you won't have to wait for weekly meetings for small queries 14:37:22 rajat: will do. 14:37:46 geguileo yes, the lightbits driver is not updated there, should I add it or you? or is it not going to be merged? 14:38:20 yuval: I'll try to remember to add it when rebasing it 14:38:32 Thanks 14:38:52 yuval: thank you for the reminder 14:39:00 np 14:40:32 rosmaita: thx. will do. 14:41:10 if we don't have anything else for the meeting, let's wrap up 14:41:31 Thanks everyone for joining 14:41:38 #endmeeting