14:00:32 <rosmaita> #startmeeting cinder
14:00:32 <openstack> Meeting started Wed Feb 19 14:00:32 2020 UTC and is due to finish in 60 minutes.  The chair is rosmaita. Information about MeetBot at http://wiki.debian.org/MeetBot.
14:00:33 <openstack> Useful Commands: #action #agreed #help #info #idea #link #topic #startvote.
14:00:35 <openstack> The meeting name has been set to 'cinder'
14:00:36 <smcginnis> o/
14:00:39 <eharney> hi
14:00:49 <rosmaita> #link https://etherpad.openstack.org/p/cinder-ussuri-meetings
14:00:57 <rosmaita> #topic roll call
14:01:10 <geguileo> hi! o/
14:01:12 <whoami-rajat> Hi
14:01:14 <eharney> hi
14:01:29 <jungleboyj> O/
14:01:40 <rosmaita> looking like a good turnout
14:02:04 <tosky> o/
14:02:09 <rosmaita> ok, let's get started
14:02:16 <rosmaita> #topic announcements
14:02:22 <rosmaita> a bunch of business items today
14:02:29 <rosmaita> #topic announcements - Vancouver PTG head count
14:02:37 <rosmaita> reminder - need a head count for the Vancouver 2020 PTG (8-11 June)
14:02:45 <rosmaita> please add yourself to the etherpad
14:02:52 <rosmaita> #link https://etherpad.openstack.org/p/cinder-victoria-ptg-planning
14:03:01 <rosmaita> also, feel free to start adding topics
14:03:05 <e0ne> hi
14:03:19 <rosmaita> #topic announcements - virtual mid-cycle part 2
14:03:26 <rosmaita> as discussed last week, will be the week of 16 March
14:03:32 <rosmaita> watch the ML for a poll - hopefully in the next day or two
14:03:41 <rosmaita> i need to figure out what went wrong with the time zones in doodle for the volume-local-cache meeting poll before sending it out
14:03:52 <rosmaita> #topic announcements - possible data loss situation (bug 1852106)
14:03:54 <openstack> bug 1852106 in Glance "Possible data loss from createImage action" [Undecided,New] https://launchpad.net/bugs/1852106
14:04:01 <rosmaita> i think i mentioned this at the end of last week's meeting
14:04:08 <rosmaita> kind of an unlikely scenario, i think
14:04:16 <rosmaita> details and a quick workaround were sent out on the ML yesterday
14:04:23 <rosmaita> #link http://lists.openstack.org/pipermail/openstack-discuss/2020-February/012641.html
14:04:32 <rosmaita> it only applies to train (or if someone is running a cloud out of master)
14:04:49 <rosmaita> btw, the main nova patch addressing this merged last night
14:04:55 <rosmaita> #link https://review.opendev.org/#/c/707738/
14:05:03 <rosmaita> if you have a ussuri devstack around set up to do encrypted volumes
14:05:10 <rosmaita> it would be worth giving that change a workout
14:05:18 <rosmaita> i'm not worried about it preventing direct boot of an image of an encrypted volume
14:05:26 <rosmaita> but i'm a little worried about it working *too* well, that is, preventing a legitimate use case
14:05:35 <rosmaita> all the obvious stuff seems to work
14:05:43 <rosmaita> i think i should probably spend some time working on some tempest tests
14:05:59 <rosmaita> #topic releases
14:06:09 <rosmaita> cinder 16.0.0.0b1 has been released for milestone-2
14:06:16 <rosmaita> thanks to smcginnis for fixing some bugs around config and docs and the kilo branch (!) that were blocking the release
14:06:30 <rosmaita> cinderclient and brick cinderclient extension also had their first py3-only releases
14:06:30 <smcginnis> Right place, wrong time?
14:06:48 <rosmaita> :)
14:06:50 <rosmaita> 6.0.0 for client, 1.0.0 for the extension
14:06:58 <rosmaita> these aren't the final ussuri releases, we just wanted the py3-only versions available so that they can get a workout in the gate
14:07:10 <rosmaita> #topic releases - os-brick
14:07:17 <rosmaita> would like to get a py3-only release out there
14:07:24 <rosmaita> again, this won't be the final ussuri release
14:07:31 <rosmaita> let's take a quick look at whether there's anything that would be good to get in
14:07:40 <rosmaita> #link https://review.opendev.org/#/q/project:openstack/os-brick+status:open+branch:master
14:08:38 <rosmaita> i think 697564 was being held by zuul because its parent hadn't merged
14:08:57 <rosmaita> i just did a recheck, it should be ok now
14:08:58 <enriquetaso> o/
14:09:52 <rosmaita> my main question here is: is there anything we should wait for, keeping in mind that this is *not* the actual ussuri release
14:10:13 <eharney> nothing jumps out at me as crucial
14:10:44 <e0ne> looks like os-brick is in a good shape to be released
14:11:06 <rosmaita> ok, thanks
14:11:13 <rosmaita> looks like  699861 may be ready
14:11:25 <rosmaita> #link https://review.opendev.org/#/c/699861/
14:11:32 <jungleboyj> Yeah, given that this isn't the final release it looks pretty good.
14:11:55 <rosmaita> ok, great
14:12:15 <rosmaita> #topic releases - final rocky release
14:12:28 <rosmaita> this is supposed to happen soon
14:12:37 <rosmaita> looks like we've got 3 unmerged patches
14:12:43 <rosmaita> Support Incremental Backup Completion In RBD
14:12:50 <rosmaita> #link https://review.opendev.org/705703
14:12:57 <rosmaita> Fix: Create new cache entry when xtremio reaches snap limit
14:13:00 <jungleboyj> 699861 is on its way.
14:13:06 <rosmaita> #link https://review.opendev.org/707341
14:13:20 <rosmaita> jungleboyj: thanks, that was sitting for a long time
14:13:26 <rosmaita> Tell reno to ignore the kilo branch
14:13:33 <rosmaita> #link https://review.opendev.org/707498
14:13:40 <rosmaita> (that last one is a no-brainer, we can't cut a release without it)
14:13:47 <rosmaita> (but we need the cherry-pick to stein merged first:)
14:13:54 <rosmaita> #link https://review.opendev.org/#/c/707497/1
14:14:11 <jungleboyj> What about the Comment on 705703 from Lucian?
14:14:27 <enriquetaso> i'm working on it
14:14:43 <enriquetaso> so far, I wasn't able to reproduce it in stein/master
14:14:50 <enriquetaso> i'm going to try with rocky
14:15:06 <eharney> that's probably a latent bug in the object code
14:15:17 <enriquetaso> if someone would like to reproduce it too, it would be great:)
14:15:25 <smcginnis> enriquetaso: The reno one? You may need to force updating reno to the latest.
14:15:34 <eharney> the backup fix could make it more likely to occur, hard to say
14:16:06 <enriquetaso> smcginnis, about Lucian's comment in 705703
14:16:32 <enriquetaso> what do you suggest eharney ?
14:17:31 <eharney> it would be nice to know where it actually happened -- given that rbd incr backup is totally broken without this patch, if it only happens sometimes when using incr backup, we're still better off just landing 705703
14:17:48 <jungleboyj> Ok.
14:18:04 <eharney> it also happened on windows, which, no idea what that tells us
14:18:38 <enriquetaso> ok
14:18:45 <enriquetaso> oh..
14:18:52 <jungleboyj> He he he.
14:19:08 <rosmaita> so it sounds like it would be ok to merge into stable/rocky as enriquetaso continues to investigate?
14:19:35 <rosmaita> (which investigation can consist of asking lucien to give us more info)
14:19:43 <jungleboyj> https://gph.is/1gTrfDd
14:19:56 <jungleboyj> rosmaita: ++
14:20:07 <eharney> export_record is in the traceback, i guess we could try testing backup import/export
14:20:57 <lpetrut> hey, looking at that trace, I think that the parent field should be part of the OPTIONAL_FIELDS list: https://github.com/openstack/cinder/blob/master/cinder/objects/backup.py#L152
14:21:22 <lpetrut> someone mentioned Windows so a notification popped up :D
14:21:44 <enriquetaso> I've tried http://paste.openstack.org/raw/789482/ eharney
14:22:02 <enriquetaso> #link https://bugs.launchpad.net/cinder/+bug/1862635
14:22:03 <openstack> Launchpad bug 1862635 in Cinder "Cinder backup export broken" [Undecided,New]
14:22:15 <rosmaita> smcginnis: what's the absolute deadline for final rocky release?
14:23:34 <rosmaita> for some reason 24 February is in my head, but i don't know if it's that day, or anytime that week
14:24:20 <smcginnis> Yes, theoretically Feb 24.
14:25:19 <rosmaita> ok, well, i think we can merge enriquetaso's patch and hopefully come up with a bugfix before monday
14:25:29 <jungleboyj> WFM
14:25:31 <rosmaita> so, the above patches are the only things i see for *all* cinder components for stable/rocky
14:25:37 <rosmaita> but i am not 100% confident in my gerrit query abilities
14:25:43 <rosmaita> so if anyone here has anything they are watching to get into stable/rocky
14:25:51 <rosmaita> say something now
14:26:05 <rosmaita> otherwise, i think we are looking good for final rocky release
14:26:33 <jungleboyj> rosmaita:  Thanks for keeping such good track of all of that.
14:26:46 <rosmaita> just trying to do my job :D
14:26:55 <jungleboyj> :-)
14:26:59 <rosmaita> ok, that's all from me
14:27:09 <rosmaita> #topic friendly review request
14:27:14 <rosmaita> going out of order here
14:27:21 <rosmaita> becasue this should be quick
14:27:35 <rosmaita> e0ne has a request for people to look at
14:27:46 <rosmaita> #link https://review.opendev.org/630305
14:27:47 <e0ne> rosmaita: thanks
14:27:59 <rosmaita> last patch required for generic backups feature!
14:28:04 <e0ne> this patch was waiting for reviews few month
14:28:08 <e0ne> months
14:28:18 <e0ne> but now I updated it with unit-tests
14:28:32 <rosmaita> that makes it much sexier
14:28:50 <jungleboyj> Ooooh, I like a good unit test.
14:28:52 <e0ne> I've added unit-tests only for a *new* code, so some old functions are still not covered :(
14:29:08 <e0ne> anyway, I hope to. get some feedback on it
14:29:20 <rosmaita> thanks e0ne
14:29:30 <jungleboyj> Ok.  I will take a look.  Would be great to get that feature in.
14:29:31 <rosmaita> any other comments?
14:29:48 <e0ne> I'll propose few next patches soon with new unit tests and generic backup implementation
14:29:59 <rosmaita> very cool!
14:30:00 <e0ne> hope to get it ready for Ussuri
14:30:21 <jungleboyj> Yay!
14:30:21 <rosmaita> #topic volume-local-cache
14:30:28 <rosmaita> LiangFang: that's you
14:30:40 <rosmaita> quick question first, though
14:30:49 <LiangFang> hi team, I have updated the spec based on the cross team meeting with nova
14:30:54 <rosmaita> did you send an email for nova spec-freeze exception?
14:31:00 <LiangFang> yes
14:31:06 <jungleboyj> Yeah, I saw that go out.
14:31:08 <rosmaita> ok, i missed it
14:31:12 <LiangFang> http://lists.openstack.org/pipermail/openstack-discuss/2020-February/012615.html
14:31:16 <rosmaita> thanks
14:31:29 <LiangFang> I will attend Nova meeting tomorrow
14:31:55 <rosmaita> ok, great
14:31:59 <LiangFang> Nova team is giving +1, and wait cinder team to go first
14:32:07 <jungleboyj> He he.
14:32:29 <LiangFang> https://review.opendev.org/#/c/689070/
14:33:07 <rosmaita> #link https://review.opendev.org/#/c/684556/
14:33:24 <rosmaita> (that's the cinder one)
14:33:29 <LiangFang> yes
14:33:53 <rosmaita> ok, i will commit to re-reading the cinder spec today
14:34:14 <jungleboyj> Me too.
14:34:23 <LiangFang> my thinking is: could it be an experimental feature in Ussuri, so customers can test it
14:34:29 <rosmaita> eharney: it would be helpful if you have time to verify that the encryption part is OK by you
14:34:58 <eharney> ok
14:35:06 <rosmaita> thanks
14:35:29 <LiangFang> it looks like a big feature, and let's improve it in next release
14:35:34 <rosmaita> LiangFang: that sounds reasonable
14:35:34 <tosky> is any scenario tempest test planned for the feature?
14:35:44 <tosky> I'd say it would be almost a requirement
14:36:26 <LiangFang> I just tests in my Openstack running time environment, so tempest test run yet.
14:36:35 <LiangFang> no tempest test run yet
14:36:45 <eharney> i wonder what kind of new tempest test we would want for it
14:37:14 <eharney> we definitely would want to create a job that runs a lot of existing tests on this config
14:37:23 <rosmaita> eharney: ++
14:37:29 <LiangFang> ++
14:37:46 <rosmaita> we'd need a node with open-cas running, and then just use the current tests
14:38:19 <rosmaita> although i don't know that we have a lot of tests that check data integrity?
14:38:38 <whoami-rajat> rosmaita, agreed
14:38:38 <LiangFang> should I provider such node?
14:38:57 <eharney> opencas is open source software right?
14:39:03 <LiangFang> yes
14:39:04 <rosmaita> LiangFang: can you run open-cas even without the SSDs
14:39:24 <rosmaita> just using node memory or something
14:39:35 <LiangFang> yes, we can use DRAM as cache
14:39:49 <rosmaita> ok, because we don't need to know about performance
14:40:02 <rosmaita> just that stuff does not blow up when the cache is being used
14:40:13 <LiangFang> yes, we even can /dev/loop1 as cache
14:40:27 <rosmaita> cool, that would do it
14:40:50 <eharney> we probably want some devstack support to install it with a basic config, and then we can create a zuul job for it
14:41:07 <rosmaita> that sounds right
14:41:41 <rosmaita> so how does this sound
14:41:48 <LiangFang> inspur seems interest with this feature, not sure what the deploy tool they are using
14:41:54 <rosmaita> experimental feature -> zuul job -> finish feature
14:42:10 <rosmaita> that is, don't require the zuul job for this spec
14:42:30 <jungleboyj> Sounds fair.
14:42:35 <eharney> makes sense
14:42:54 <rosmaita> ok, i'll be sure to mention this on the review
14:43:02 <rosmaita> tosky: thanks for bringing this up
14:43:13 <rosmaita> nice to have someone worried about testing in the room!
14:43:32 <jungleboyj> :-)
14:43:39 <tosky> a lot of people around are worried about testing too - I'm just noisy
14:43:40 <tosky> :)
14:43:46 <LiangFang> rosmaita: should I provide test node?
14:44:26 <LiangFang> I know a team from Intel is providing CI node
14:44:42 <LiangFang> oh, may be the same team with RSD
14:44:55 <rosmaita> well, my main concern for the experimental feature is that having its code there doesn't break normal cinder
14:45:03 <rosmaita> so our current tests should cover that
14:45:16 <LiangFang> ok... thanks
14:45:28 <rosmaita> i guess i'm not so interested in a test node as much as what tosky and eharney suggested
14:45:51 <rosmaita> make it possible to run open-cas in a devstack with no fancy hardware
14:46:03 <rosmaita> and run our tempest tests against it
14:46:07 <jungleboyj> rosmaita:  ++
14:46:21 <LiangFang> ++
14:46:41 <rosmaita> ok, any general comments from anyone?
14:46:50 <tosky> rosmaita: I guess that if a 3rd-party CI would like to setup such environment with real hardware, they will be more than welcome
14:47:06 <tosky> in addition to the open-cas job
14:47:22 <rosmaita> sure
14:47:33 <rosmaita> the problem is that those things come and go
14:47:39 <rosmaita> while devstack is forever
14:48:25 <rosmaita> but yes, LiangFang if you know of someone who wants to set up a 3rd party CI with SSDs and stuff, please encourage them
14:48:39 <LiangFang> rosmaita: ok
14:49:02 <rosmaita> anything else?
14:49:21 <LiangFang> gibi comments in Nova spec
14:50:07 <LiangFang> saying he want to see +2s in Cinder spec.........
14:50:30 <LiangFang> :)
14:50:36 <rosmaita> what time is the nova meeting tomorrow?
14:50:37 <LiangFang> sorry to say that
14:50:45 <jungleboyj> :-)
14:50:59 <LiangFang> seems the same time of today
14:51:31 <rosmaita> i'll review today
14:51:46 <LiangFang> 14:00 UTC (#openstack-meeting)
14:51:47 <rosmaita> it looks like you've addressed all the points that came up in the meeting
14:51:48 <LiangFang> thanks
14:52:00 <rosmaita> so i anticipate a +2
14:52:23 <rosmaita> unless someone notices a major problem that we've all missed
14:52:43 <rosmaita> i think we'd be able to require clarifications in a follow up
14:52:43 <LiangFang> thanks team
14:53:01 <rosmaita> no promises, but i am optimistic
14:53:24 <rosmaita> i know it's late where you are, hopefully you will awaken to good news tomorrow
14:53:52 <LiangFang> :-Dthanks
14:53:54 <jungleboyj> Sleep with dreams of caching
14:54:02 <rosmaita> #topic open discussion
14:54:03 <LiangFang> ..........
14:55:11 <rosmaita> finally we have time for open discussion, and nobody has anything to say?
14:55:16 <rosmaita> :)
14:55:19 <whoami-rajat> :D
14:55:31 <jungleboyj> rosmaita:  You are just on top of everything.
14:55:37 <rosmaita> i wish
14:56:02 <rosmaita> ok, so please look at volume-local-cache spec
14:56:10 <rosmaita> and e0ne's backup patch
14:56:17 <e0ne> :)
14:56:43 <rosmaita> and stable cores, please look at the 3 reviews for stable/rocky
14:56:59 <rosmaita> and enriquetaso is going to investigate lpetrut's bug a bit further
14:57:04 <rosmaita> anything else?
14:57:12 <enriquetaso> +1
14:58:16 <rosmaita> sounds like we are all done
14:58:20 <rosmaita> thanks everyone!
14:58:20 <whoami-rajat> Thanks!
14:58:24 <enriquetaso> thanks
14:59:16 <e0ne> see you next week!
14:59:17 <rosmaita> #endmeeting