Saturday, 2021-03-06

*** tosky has quit IRC00:44
*** piotrowskim has quit IRC01:28
*** zenkuro has quit IRC01:44
*** jamesmcarthur has joined #zuul03:02
*** jamesmcarthur has quit IRC04:19
*** jamesmcarthur has joined #zuul04:27
*** jamesmcarthur has quit IRC04:32
*** jamesmcarthur has joined #zuul04:43
openstackgerritJames E. Blair proposed zuul/nodepool master: Add a state machine driver framework  https://review.opendev.org/c/zuul/nodepool/+/77907104:44
openstackgerritJames E. Blair proposed zuul/nodepool master: Add an example state machine driver  https://review.opendev.org/c/zuul/nodepool/+/77907204:45
corvusmordred, tobiash, avass: ^ that's a WIP idea that i have for a driver framework that tries to incorporate everything we've learned over the past few years; it's inspired by tobiash's de-threading work and the simple driver interface i did for gce that isolates cloud implementation from nodepool logic.  i think we can accomodate all of the clouds with that framework, which means more shared code that's easier04:48
corvusto understand and maintain.04:48
corvusmordred, tobiash, avass: the easiest way to check it out is probably to look at adapter.py in 779072.  that's a complete (no-op) driver implementation using it.  then take a look at the bottom part of statemachine.py in 779071 for the interface documentation (the top half is not user-servicable).04:52
*** jamesmcarthur has quit IRC05:00
*** evrardjp has quit IRC05:33
*** evrardjp has joined #zuul05:33
*** bhavikdbavishi has joined #zuul05:56
openstackgerritMerged zuul/nodepool master: Offload waiting for server creation/deletion  https://review.opendev.org/c/zuul/nodepool/+/77543806:09
openstackgerritMerged zuul/nodepool master: Optimize list_servers call in cleanupLeakedInstances  https://review.opendev.org/c/zuul/nodepool/+/77579606:14
*** jamesmcarthur has joined #zuul07:01
*** jamesmcarthur has quit IRC07:05
*** bhavikdbavishi1 has joined #zuul07:16
*** bhavikdbavishi has quit IRC07:18
*** bhavikdbavishi1 is now known as bhavikdbavishi07:18
*** harrymichal has joined #zuul07:20
*** harrymichal has quit IRC07:25
*** bhavikdbavishi has quit IRC08:06
openstackgerritAlbin Vass proposed zuul/zuul master: Use shell-type config from nodepool  https://review.opendev.org/c/zuul/zuul/+/77538210:17
*** jangutter has quit IRC10:41
*** jangutter has joined #zuul10:41
*** jangutter has quit IRC10:43
*** jangutter has joined #zuul10:44
*** jangutter has quit IRC11:06
*** jangutter has joined #zuul11:07
*** jangutter has quit IRC11:29
*** jangutter has joined #zuul11:30
avasszuul-client doesn't seem to work very well with single tenant zuul installations :/11:31
openstackgerritSorin Sbârnea proposed zuul/zuul-jobs master: Upgrade ansible-lint to 5.0  https://review.opendev.org/c/zuul/zuul-jobs/+/77324512:04
*** tosky has joined #zuul13:06
*** bhavikdbavishi has joined #zuul13:33
*** jangutter has quit IRC13:33
*** jangutter has joined #zuul13:34
*** jangutter has quit IRC13:43
*** jangutter has joined #zuul13:44
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Zuul Cache role with s3 implementation.  https://review.opendev.org/c/zuul/zuul-jobs/+/76480813:51
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Zuul Cache role with s3 implementation.  https://review.opendev.org/c/zuul/zuul-jobs/+/76480813:53
*** bhavikdbavishi has quit IRC14:02
*** jangutter has quit IRC14:16
*** jangutter has joined #zuul14:17
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Zuul Cache role with s3 implementation.  https://review.opendev.org/c/zuul/zuul-jobs/+/76480814:20
corvusavass: how so?14:21
avasscorvus: I think half of it was sort of my fault since I was routing /api/tenant/<tenant> wrong (it went to /api/tenant/<tenant>/tenant/<tenant) but I was still required to supply a --tenant flag14:38
avassso imo if --tenant isn't supplied it should try /api/<project>.pub when trying to encrypt for example14:39
avassso I ended up fetching the public key with curl and encrypting, but then I was still required to supply --zuul-url even though it was a local operation.14:40
corvusavass: i agree.  regarding tenant auto detection, we provide the /info endpoint so programs can do that, so should be possible14:46
corvusmhu: ^ fyi14:46
corvusavass: we are talking about a whitelabel setup, right?14:47
avassyeah14:47
avasshttps://zuul.vassast.org14:47
corvusthought so, just checking :)14:47
openstackgerritJames E. Blair proposed zuul/zuul master: Use ZooKeeper TLS in tests  https://review.opendev.org/c/zuul/zuul/+/77748915:00
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Zuul Cache role with s3 implementation.  https://review.opendev.org/c/zuul/zuul-jobs/+/76480815:06
avasscorvus: found a nice way to batch uploads without resorting to python scripts ^ :)15:07
corvusavass: ah yep!  is there no upper limit on the number in parallel?15:16
corvusoh there i see it batch(10)15:16
avassyeah :)15:16
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Zuul Cache role with s3 implementation.  https://review.opendev.org/c/zuul/zuul-jobs/+/76480815:17
avasstests were successful, just needed to remove some debug tasks. so that should now be ready to review15:18
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Zuul Cache role with s3 implementation.  https://review.opendev.org/c/zuul/zuul-jobs/+/76480815:21
mordredcorvus, tobiash: I +2'd but did not +A the global repo state patch - wasn't sure if you wanted anyone else to look at it too15:49
*** jangutter has quit IRC15:50
*** jangutter has joined #zuul15:51
mordredcorvus: on the statemachine change - looking nice! should the machines have an unwind() method (or similar?) or is the idea that a CreateStateMachine that fails halfway through should have any intermediate resources cleaned up by the cleanup thread?15:59
mordredcorvus: or maybe the higher level is going to call cleanupNode for a node launch failure - so the delete state machine should be written such that it could also delete partially created nodes?16:02
mordredcorvus: also - I left a couple of comments on the example change16:10
mordredI really like that whole approach16:10
*** tosky has quit IRC16:12
*** vishalmanchanda has quit IRC16:22
corvusmordred: the latter -- my thought is the state machine should set external_id as early as possible, and if it exists, then the higher level will hand it to a DeleteStateMachine.  if it doesn't, then anything created will have to be cleaned up by the leak cleanup.  i was also thinking we should handle external_id changing.  so, for example, if a really bad cloud didn't have any metadata support, maybe16:40
corvusexternal_id could be a json serialization of uuids of things as they are created (eg: "{fip: uuid1}" ... "{fui: uuid1, port:uuid2}" ... etc, until it finally gets to a vm uuid that ties it all together)16:40
corvusmordred: (i had an earlier version where i wrote an unwind method but it didn't feel right sitting right next to a DeleteStateMachine)16:42
corvusalso, as currently written, the state machine will have to internally handle retries, but i think we shoud move that into the higher level (it will involve retrying a node launch as a new node)16:44
corvus(that's not too hard, it's almost what we do right now in case we hit a quota limit)16:44
mordred++16:44
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Zuul Cache role with s3 implementation.  https://review.opendev.org/c/zuul/zuul-jobs/+/76480816:52
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Zuul Cache role with s3 implementation.  https://review.opendev.org/c/zuul/zuul-jobs/+/76480816:55
*** zenkuro has joined #zuul17:24
openstackgerritJames E. Blair proposed zuul/zuul master: Use ZooKeeper TLS in tests  https://review.opendev.org/c/zuul/zuul/+/77748917:57
avasserr, I got some weird zuul-web console bug, try opening the last of the lists in the archived files and then try to close it: https://zuul.vassast.org/build/fe46800c203f4439859463cbe6e6fe08/console18:35
avasswhen I try to close the list it instead opens the items from 2300 to 240018:36
avassclosing that one opens the items 2400 to 250018:36
corvusavass: which task?18:38
corvusavass: this one? https://zuul.vassast.org/build/fe46800c203f4439859463cbe6e6fe08/console#3/0/3/fedora18:39
avassoh yep, I got the wrong link18:40
corvusavass: i get weird similar (but not exactly the same) behavior.  i can't close it, but attempting to opens the earliest unopened list18:41
corvusavass: we just upgraded that component recently to deal with the string-sorted array index issue, wonder if a new bug crept into that release18:42
avassyeah i'm either getting a random list opened to the one i'm trying to close is closed18:42
avasscorvus: yeah I was thinking the same18:42
corvusavass: heh, it seems like they didn't test with numbers >10 before, what are the chances they test with numbers > 3500? :)18:42
avass:D18:43
avasswho needs more than 10 numbers anyway18:43
corvusyep: 0, 1.  done.18:57
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: zuul-cache-s3: Allow setting compression level  https://review.opendev.org/c/zuul/zuul-jobs/+/77908118:58
*** tosky has joined #zuul19:02
*** jamesmcarthur has joined #zuul19:27
*** jamesmcarthur has quit IRC21:02
*** jamesmcarthur has joined #zuul21:03
*** jamesmcarthur has quit IRC21:08
openstackgerritJames E. Blair proposed zuul/zuul master: Use ZooKeeper TLS in tests  https://review.opendev.org/c/zuul/zuul/+/77748921:20
openstackgerritJames E. Blair proposed zuul/zuul master: Make ConnectionRegistry mandatory for Scheduler  https://review.opendev.org/c/zuul/zuul/+/75709521:20
openstackgerritJames E. Blair proposed zuul/zuul master: Instantiate executor client, merger, nodepool and app within Scheduler  https://review.opendev.org/c/zuul/zuul/+/75714921:21
openstackgerritJames E. Blair proposed zuul/zuul master: Move setupZK() helper function to BaseTestCase class  https://review.opendev.org/c/zuul/zuul/+/77908221:21
openstackgerritJames E. Blair proposed zuul/zuul master: Initialize ZooKeeper connection in server rather than in cmd classes  https://review.opendev.org/c/zuul/zuul/+/77908321:21
*** jamesmcarthur has joined #zuul21:21
*** jamesmcarthur has quit IRC21:33
*** jamesmcarthur has joined #zuul21:34
*** tosky has quit IRC21:42
openstackgerritAlbin Vass proposed zuul/zuul-jobs master: Prepend ansible_user_dir when relative path is supplied  https://review.opendev.org/c/zuul/zuul-jobs/+/77908422:19
*** jamesmcarthur has quit IRC22:21
*** jamesmcarthur has joined #zuul22:35
*** jamesmcarthur has quit IRC23:12
avassnice. with the zuul-cache our rust project build went from 25 min to 2 min 50 sec23:18
*** jamesmcarthur has joined #zuul23:43

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!