Monday, 2020-09-28

*** wuchunyang has joined #zuul00:32
*** wuchunyang has quit IRC00:37
*** sshnaidm is now known as sshnaidm|off00:41
openstackgerritMerged zuul/zuul master: Fix multiple prs found when commit is not head  https://review.opendev.org/74140200:56
openstackgerritMerged zuul/zuul master: gitlab: merge request approval: specify the commit  https://review.opendev.org/75203101:45
*** bstinson has quit IRC02:12
openstackgerritMerged zuul/zuul master: FakeGitlabAPIClient: use subject instead of title  https://review.opendev.org/75203502:12
*** freenzyfriday has joined #zuul03:04
*** freenzyfriday has quit IRC03:09
openstackgerritMerged zuul/zuul master: Ansible command module: allow to use stdin param  https://review.opendev.org/74481403:09
*** bhavikdbavishi has joined #zuul03:20
*** bhavikdbavishi1 has joined #zuul03:45
*** bhavikdbavishi has quit IRC03:47
*** bhavikdbavishi1 is now known as bhavikdbavishi03:47
*** freenzyfriday has joined #zuul03:54
*** freenzyfriday has quit IRC03:59
openstackgerritIan Wienand proposed zuul/zuul-jobs master: update-json-file: add role to combine values into a .json  https://review.opendev.org/74683404:19
*** bhavikdbavishi has quit IRC04:19
openstackgerritIan Wienand proposed zuul/zuul-jobs master: ensure-docker: Linaro MTU workaround  https://review.opendev.org/74706304:19
*** bhavikdbavishi has joined #zuul04:20
*** evrardjp has quit IRC04:33
*** evrardjp has joined #zuul04:33
*** freenzyfriday has joined #zuul04:48
*** freenzyfriday has quit IRC04:58
*** freenzyfriday has joined #zuul06:01
*** bhavikdbavishi1 has joined #zuul06:07
*** bhavikdbavishi has quit IRC06:08
*** bhavikdbavishi1 is now known as bhavikdbavishi06:09
*** mach1na has joined #zuul06:09
openstackgerritDmitriy Rabotyagov (noonedeadpunk) proposed zuul/zuul-jobs master: Make sure that we pass list in loop  https://review.opendev.org/75461206:09
*** CraigR has joined #zuul06:31
*** CraigR has quit IRC06:33
*** mach1na has quit IRC06:35
*** saneax has joined #zuul06:37
openstackgerritJan Kubovy proposed zuul/zuul master: Recover from cat job failures during startup  https://review.opendev.org/75463606:43
*** hashar has joined #zuul06:52
openstackgerritMerged zuul/zuul-jobs master: Add ability to use *-docker-image roles in periodic jobs  https://review.opendev.org/74056006:53
*** mach1na has joined #zuul06:55
*** aluria has quit IRC06:56
openstackgerritJan Kubovy proposed zuul/zuul master: Recover from cat job failures during startup  https://review.opendev.org/75463606:56
*** jcapitao has joined #zuul06:58
*** aluria has joined #zuul07:00
*** bolg has joined #zuul07:01
*** mach1na has quit IRC07:20
*** mach1na has joined #zuul07:22
*** tosky has joined #zuul07:23
*** jpena|off is now known as jpena07:29
*** bhavikdbavishi has quit IRC07:43
*** aluria has quit IRC07:47
*** arxcruz has joined #zuul07:48
*** aluria has joined #zuul07:49
*** saneax has quit IRC07:54
*** saneax has joined #zuul07:55
*** yolanda has joined #zuul08:07
*** saneax has quit IRC08:10
*** bhavikdbavishi has joined #zuul08:27
*** bhavikdbavishi1 has joined #zuul08:30
*** bhavikdbavishi has quit IRC08:31
*** bhavikdbavishi1 is now known as bhavikdbavishi08:31
*** armstrongs has joined #zuul08:34
*** holser has joined #zuul08:41
*** ttx has joined #zuul08:41
openstackgerritMatthieu Huin proposed zuul/zuul master: Add zuul-client testing  https://review.opendev.org/75203908:44
openstackgerritMatthieu Huin proposed zuul/zuul master: Test zuul-client encrypt subcommand  https://review.opendev.org/75410308:44
*** saneax has joined #zuul08:49
*** armstrongs has quit IRC08:57
*** zbr has joined #zuul09:09
*** bhavikdbavishi has quit IRC09:10
*** bhavikdbavishi has joined #zuul09:13
*** bhavikdbavishi1 has joined #zuul09:26
*** brendangalloway has quit IRC09:28
*** bhavikdbavishi has quit IRC09:28
*** bhavikdbavishi1 is now known as bhavikdbavishi09:28
openstackgerritJan Kubovy proposed zuul/zuul master: Recover from cat job failures during startup  https://review.opendev.org/75463609:41
openstackgerritJan Kubovy proposed zuul/zuul master: Recover from cat job failures during startup  https://review.opendev.org/75463609:44
*** piotrowskim has joined #zuul09:49
openstackgerritJan Kubovy proposed zuul/zuul master: Recover from cat job failures during startup  https://review.opendev.org/75463609:49
openstackgerritJan Kubovy proposed zuul/zuul master: Add logging and monitoring of reporting timings  https://review.opendev.org/75244310:19
openstackgerritJan Kubovy proposed zuul/zuul master: Recover from cat job failures during startup  https://review.opendev.org/75463610:24
openstackgerritMatthieu Huin proposed zuul/zuul master: Test zuul-client encrypt subcommand  https://review.opendev.org/75410310:43
*** bhavikdbavishi has quit IRC10:49
*** jcapitao is now known as jcapitao_lunch11:01
*** mach1na has quit IRC11:10
*** saneax has quit IRC11:16
*** jpena is now known as jpena|lunch11:25
*** saneax has joined #zuul11:25
*** mach1na has joined #zuul11:51
*** rfolco has joined #zuul11:52
*** rfolco is now known as rfolco|ruck11:52
*** mach1na has quit IRC11:55
*** bhavikdbavishi has joined #zuul12:03
*** mach1na has joined #zuul12:05
*** mach1na has quit IRC12:24
*** jcapitao_lunch is now known as jcapitao12:24
openstackgerritJan Kubovy proposed zuul/zuul master: Scheduler's pause/resume functionality  https://review.opendev.org/70973512:28
openstackgerritJan Kubovy proposed zuul/zuul master: Separate connection registries in tests  https://review.opendev.org/71295812:28
openstackgerritJan Kubovy proposed zuul/zuul master: Prepare Zookeeper for scale-out scheduler  https://review.opendev.org/71726912:28
openstackgerritJan Kubovy proposed zuul/zuul master: Mandatory Zookeeper connection for ZuulWeb in tests  https://review.opendev.org/72125412:28
openstackgerritJan Kubovy proposed zuul/zuul master: Driver event ingestion  https://review.opendev.org/71729912:28
openstackgerritJan Kubovy proposed zuul/zuul master: Connect merger to Zookeeper  https://review.opendev.org/71622112:28
openstackgerritJan Kubovy proposed zuul/zuul master: Connect fingergw to Zookeeper  https://review.opendev.org/71687512:28
openstackgerritJan Kubovy proposed zuul/zuul master: Connect executor to Zookeeper  https://review.opendev.org/71626212:28
openstackgerritJan Kubovy proposed zuul/zuul master: Improve typings in context of 744416  https://review.opendev.org/75357812:28
openstackgerritJan Kubovy proposed zuul/zuul master: Merge Zookeeper connection methods and specialize exceptions  https://review.opendev.org/75436012:28
openstackgerritJan Kubovy proposed zuul/zuul master: Switch to using zookeeper instead of gearman for jobs  https://review.opendev.org/74441612:28
*** jpena|lunch is now known as jpena12:29
*** mach1na has joined #zuul12:30
*** jfoufas1 has joined #zuul12:32
*** jfoufas1 has quit IRC12:44
*** saneax has quit IRC13:23
*** saneax has joined #zuul13:24
*** benoit_lbc has joined #zuul13:28
benoit_lbcHello, Do you see it will be possible to have this review https://review.opendev.org/#/c/740328/ merged regarding my last answer ? (patchset 25). Thanks in advance :)13:29
benoit_lbcthink*13:29
*** saneax has quit IRC13:41
*** jamesmcarthur has joined #zuul13:53
*** gmann_pto is now known as gmann13:55
*** bhavikdbavishi has quit IRC14:19
*** hashar has quit IRC14:24
fungianybody noticed you can't highlight text on the builds view any longer?14:27
fungiwhen i try to click and drag to highlight text there, my browser acts like it's trying to drag-n-drop some page element14:27
*** jamesmcarthur has quit IRC14:41
*** jamesmcarthur has joined #zuul14:42
*** jamesmcarthur has quit IRC14:46
*** jamesmcarthur has joined #zuul14:51
*** hashar has joined #zuul15:01
openstackgerritzbr proposed zuul/zuul master: Enable display of dnf/yum failures inside console  https://review.opendev.org/73483315:04
clarkbfungi: I don't seem to have this problem on15:04
clarkbhttps://zuul.opendev.org/t/openstack/builds15:04
clarkbhit return a half second too quickly15:05
fungiyeah, that's where i'm seeing it. my cursor shows up as a grabby hand icon and can't highlight text anywhere on that page (firefox 80)15:06
clarkbI'm on FF 81 beta15:07
clarkbits a grabby hand icon on links15:07
clarkbbut I can still select link text by highlighting from just off the link first15:08
openstackgerritzbr proposed zuul/zuul master: Enable ANSI rendering via react-ansi  https://review.opendev.org/73944415:08
openstackgerritzbr proposed zuul/zuul-jobs master: More E208 mode fixes  https://review.opendev.org/74849815:09
openstackgerritzbr proposed zuul/zuul-jobs master: Add file mode to fetch-sphinx-tarball  https://review.opendev.org/74860615:13
openstackgerritzbr proposed zuul/zuul-jobs master: Partial address ansible-lint E208  https://review.opendev.org/74848015:13
fungiyeah, no matter where on the page i try to click and drag, it shows the hand cursor dragging a little document icon and doesn't highlight anything15:19
fungiwell, i take that back, i can highlight the column headings, just not anything on the rows beneath them15:21
*** hashar has quit IRC15:41
*** freenzyfriday has quit IRC16:03
*** jcapitao has quit IRC16:04
*** freenzyfriday has joined #zuul16:07
*** bhavikdbavishi has joined #zuul16:09
*** mach1na has quit IRC16:09
*** bhavikdbavishi1 has joined #zuul16:12
*** tosky has quit IRC16:12
*** freenzyfriday has quit IRC16:13
*** bhavikdbavishi has quit IRC16:13
*** bhavikdbavishi1 is now known as bhavikdbavishi16:13
*** freenzyfriday has joined #zuul16:15
*** hamalq has joined #zuul16:21
*** benoit_lbc has quit IRC16:24
*** jpena is now known as jpena|off16:43
clarkbfungi: I had to do a hard refresh and now I see what you see17:10
clarkb(I should've started with one of those)17:10
clarkbfungi: it is because the whole row on the builds page has become a link to the build17:11
fungiahh17:15
clarkbhttps://opendev.org/zuul/zuul/src/branch/master/web/src/index.css#L103-L115 is the code that causes that to happen17:15
funginot to my taste, but i assume that was an intentional behavior change17:15
fungiprobably helps people trying to browse using their thumbs on telephones17:16
clarkbI wonder if we can change pointer-events to modify the behavior to be more like what you expect17:16
clarkbif I change pointer-events to none then its no longer a clickable link :/17:22
clarkbbut the text does become selectable17:22
clarkbmaybe we can make the text clickable but not the fill area (I think that means dropping the ::after entirely and turning each text there into a url?)17:24
clarkbI've quickly surpassed my web dev knowledge here. Its definitely doing what you describe though and we can possibly fix it by changing the link clickable area17:26
clarkblooking at gitea it does the clickable text but not fill area for dir listings17:26
openstackgerritMerged zuul/zuul-jobs master: Allow skip files when download logs  https://review.opendev.org/75197319:03
clarkbtristanC: I'm not sure https://review.opendev.org/#/c/736367/5 is a ruel we should enforce19:03
*** bhavikdbavishi has quit IRC19:09
tristanCclarkb: i'm not sure either, i thought that would help container based user who do not want to run ensure-* role during ci19:13
clarkbmy concern is that there are valid reasons for running roles in different phases depending on the job19:14
tristanCclarkb: that doesn't seems to be case for existing zuul-jobs19:15
clarkbit is the case for a lot of zuul-tests.d19:16
clarkbbecause the roles themselves are under test19:16
*** Goneri has joined #zuul19:16
clarkb(I don't know if we run ansible-lint on those files though)19:16
tristanCclarkb: iirc the rule only apply to playbook defined in the zuul.d configuration19:16
*** freenzyfriday has quit IRC19:18
openstackgerritTristan Cacqueray proposed zuul/zuul-jobs master: Add ensure pre-run policy to ansible-lint  https://review.opendev.org/73636719:19
clarkbtristanC: we should probably document why that rule exists if we are adding it then because its completely valid as the testing shows19:20
*** tosky has joined #zuul19:27
openstackgerritJan Kubovy proposed zuul/zuul master: Connect merger to Zookeeper  https://review.opendev.org/71622119:29
openstackgerritJan Kubovy proposed zuul/zuul master: Connect fingergw to Zookeeper  https://review.opendev.org/71687519:29
openstackgerritJan Kubovy proposed zuul/zuul master: Connect executor to Zookeeper  https://review.opendev.org/71626219:29
openstackgerritJan Kubovy proposed zuul/zuul master: Improve typings in context of 744416  https://review.opendev.org/75357819:29
openstackgerritJan Kubovy proposed zuul/zuul master: Merge Zookeeper connection methods and specialize exceptions  https://review.opendev.org/75436019:29
openstackgerritJan Kubovy proposed zuul/zuul master: Switch to using zookeeper instead of gearman for jobs  https://review.opendev.org/74441619:29
clarkbmhu: looking at the zuul-client testing change (https://review.opendev.org/#/c/752039/) I'm curious why we don't put those in zuul-client then zuul can run the job from there? Is it because we're relying on zuul's test framework to run a zuul and zuulweb?19:41
*** armstrongs has joined #zuul19:51
corvusclarkb, mhu: that's my assumption19:53
clarkbok left a -1 because that change isn't testing what it seems to be trying to test due to stestr config (details in line)19:56
clarkbits a little weird at first glance to put the tests in zuul/zuul but ya we already have the bootstrapping machinery there19:56
*** armstrongs has quit IRC19:58
corvusi don't think these should be part of the standard unit tests though20:01
corvusso more like 264 rather than 03920:01
clarkbya they are separated into their own subtree which is related to my -120:06
clarkbthe implication is we want to run them as normal unittests but we dont currently20:06
clarkb(I mentioned adding a new job for that)20:06
*** holser has quit IRC20:07
*** holser has joined #zuul20:08
*** jamesmcarthur_ has joined #zuul20:54
*** jamesmcarthur has quit IRC20:57
*** rfolco|ruck has quit IRC21:08
mhuclarkb, corvus I was thinking about moving these back to zuul/zuul-client but yeah, there are many imports from the test framework that is proper to zuul21:11
mhuunless the tests lib gets moved to the zuul python package, it's going to be cumbersome to use in zuul/zuul-client21:12
mhuI don't like it much because you need to add tests *after* the feature patchset in zuul/zuul-client21:13
corvusmhu: yeah -- and i'm strongly opposed to declaring the zuul test framework part of the package (it's way too tightly coupled for that)21:14
mhubut it's the same with nodepool's zuul functional testing right?21:14
corvusmhu: it is21:14
mhucorvus, of course, totally understandable21:14
corvusi think it's worth brainstorming ways we could improve it though.  i don't have good ideas now.  but the problem is annoying me in a good way.  :)21:16
mhuand I am about ready to jump in bed so no good ideas over there either :)21:18
mhuand for that reason, clarkb I'll answer your comments on 039 tomorrow, good night!21:18
clarkbswest: tobiash https://review.opendev.org/#/c/752886 looks mergeable but ianw has a good point about cleaning up dead code21:44
clarkbwant to do a followup change or update that one?21:44
clarkbzuulians any reason to not land https://review.opendev.org/#/c/727374/7 and update the zuul docker images to python3.8?21:49
clarkbon the nodepool side we're relying on python3.7 wheels for arm64 currently21:49
clarkbbut for zuul I think this is fine21:50
openstackgerritAndrii Ostapenko proposed zuul/zuul-jobs master: Fix promote cleanup  https://review.opendev.org/75486521:58
clarkbcorvus: https://review.opendev.org/#/c/754636/ is an intersting one that makes cat job failures on zuul startup non fatal22:11
clarkbI'm not sure I have a good enough grasp on zuul's config loading on startup to undertsand if that should be fatal or not. Seems like we do already allow broken configs but only when we can get the files first22:11
corvusclarkb: it seems like it could be dangerous22:13
corvusit's one thing to "allow" broken configurations by allowing projects to bypass gating; but folks who chose not to do that might still end up running with a half-complete config with a change like that22:14
clarkbianw: oh you just acked https://review.opendev.org/#/c/752443/ I just left a suggestion on there for making the logging perhaps less noisy if you have a chance to check it again22:29
ianwclarkb: yeah, good suggestion too.  i don't feel too strongly if it's related to an error that has been seen (i guess by definition the debugging was helpful if it helped debug something :) but it does seem chatty22:31
*** tosky has quit IRC22:40
*** rfolco|ruck has joined #zuul22:45
openstackgerritIan Wienand proposed zuul/zuul-jobs master: Make sure that we pass list in loop  https://review.opendev.org/75461222:45
clarkbianw: also I left a couple thoughts on the json file editing changesin zuul-jobs earlier today if want to check those22:46
ianwclarkb: thanks, will go over22:47
openstackgerritMerged zuul/zuul master: Remove zuul-stream-functional-2.7  https://review.opendev.org/75368322:55
openstackgerritMerged zuul/zuul master: Use bionic images for zuul-stream-functional tests  https://review.opendev.org/74996722:55
openstackgerritMerged zuul/zuul master: gitlab: an "update" event isn't always a "labeled" action  https://review.opendev.org/75054422:55
*** jamesmcarthur_ has quit IRC22:57
*** jamesmcarthur has joined #zuul23:06
*** tosky has joined #zuul23:09
openstackgerritIan Wienand proposed zuul/zuul-jobs master: update-json-file: add role to combine values into a .json  https://review.opendev.org/74683423:15
openstackgerritIan Wienand proposed zuul/zuul-jobs master: ensure-docker: Linaro MTU workaround  https://review.opendev.org/74706323:15
*** rfolco|ruck has quit IRC23:15
*** freenzyfriday has joined #zuul23:16
*** tosky has quit IRC23:19
*** freenzyfriday has quit IRC23:20

Generated by irclog2html.py 2.17.2 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!