| *** EmilienM has quit IRC | 02:39 | |
| *** EmilienM has joined #storyboard | 02:40 | |
| *** udesale has joined #storyboard | 03:52 | |
| *** udesale has quit IRC | 05:34 | |
| *** jtomasek has joined #storyboard | 05:58 | |
| *** udesale has joined #storyboard | 06:11 | |
| *** tosky has joined #storyboard | 07:39 | |
| *** dtantsur|afk is now known as dtantsur | 07:59 | |
| *** udesale has quit IRC | 10:34 | |
| dhellmann | fungi : the problem is I can't tell the difference between a story that is "new" and just has todo tasks and one that is actively being worked on | 12:16 |
|---|---|---|
| dhellmann | SotK : I can't figure out where the test data for TestStorySearch is coming from. I've looked through the hierarchy of classes and there's nothing obvious that's creating the test stories. Can you help me out? | 12:20 |
| SotK | dhellmann: The setUp method of TestStorySearch calls the setUp method of base.FunctionalTest, which itself calls mock_data.load() (here: https://git.openstack.org/cgit/openstack-infra/storyboard/tree/storyboard/tests/base.py#n225). That function creates a bunch of test data, the stories are created here: https://git.openstack.org/cgit/openstack-infra/storyboard/tree/storyboard/tests/mock_data.py#n159 | 12:29 |
| dhellmann | SotK : aha! thanks | 12:30 |
| *** dtantsur is now known as dtantsur|brb | 12:36 | |
| fungi | we probably need a written-out matrix of task states and what story state we expect and particular combination to imply | 13:36 |
| fungi | for example, todo+invalid=new? todo+merged=active? | 13:37 |
| *** clarkb has joined #storyboard | 13:56 | |
| *** dtantsur|brb has quit IRC | 14:26 | |
| *** dtantsur has joined #storyboard | 14:28 | |
| SotK | I assume that extends to "all todo or invalid == new, all merged or invalid == merged, all invalid == invalid, otherwise == active"? | 14:35 |
| fungi | that summarizes it better than what i was coming up with | 14:38 |
| fungi | i spent a couple minutes trying to come up with counterexamples for that set of rules and so far have none | 14:38 |
| *** diablo_rojo has joined #storyboard | 17:05 | |
| *** diablo_rojo has quit IRC | 17:17 | |
| *** diablo_rojo has joined #storyboard | 17:23 | |
| *** dtantsur is now known as dtantsur|afk | 17:53 | |
| diablo_rojo | SotK, fungi any idea why the search is broken in the build on this patch: https://review.openstack.org/#/c/577870/ | 18:28 |
| diablo_rojo | The icons are gone and the search just returns a bunch of -1 errors | 18:38 |
| SotK | diablo_rojo: it seems to work fine for me, maybe you need to add an exception for the ssl cert on storyboard-dev? | 21:39 |
| *** fatema_ has joined #storyboard | 21:57 | |
| fungi | the search worked for me too (commented on the change to that effect) | 22:01 |
| fungi | icons in the draft don't work for me however even though i've permanently accepted the snakeoil cert for storyboard-dev | 22:01 |
| fungi | something might be up with the way fontawesome is being served though | 22:03 |
| fungi | if i turn off the "font" tag for that element in the dom inspector, it displays an fl ligature | 22:07 |
| fungi | (using the default sans font) | 22:07 |
| fungi | the font details for the page indicate a "custom_icons" font served from http://logs.openstack.org/70/577870/9/check/build-javascript-content/25f043d/npm/html/fonts/custom_icons.woff | 22:09 |
| fungi | and the file seems to be there | 22:09 |
| *** fatema_ has quit IRC | 22:15 | |
| *** fatema_ has joined #storyboard | 22:25 | |
| diablo_rojo | I'll clear my cache and stuff and see what happens | 22:44 |
| diablo_rojo | fatema_, did the search issue happen for you? seems SotK and fungi didn't have it | 22:44 |
| fatema_ | diablo_rojo, yes it's happening with me too | 22:56 |
| fatema_ | https://pasteboard.co/HxYTzqaT.png | 22:57 |
| *** tosky has quit IRC | 23:02 | |
| diablo_rojo | SotK, fungi so its not just me :) | 23:03 |
| fungi | is that after making sure you can browse https://storyboard-dev.openstack.org/ and does the draft show you logged in? | 23:05 |
| diablo_rojo | Ohh I needed to be logged in and now its fine | 23:07 |
| diablo_rojo | and all looks good | 23:07 |
| diablo_rojo | aside frm the icon angriness | 23:07 |
| openstackgerrit | Fatema Khalid Sherif proposed openstack-infra/storyboard-webclient master: Expose ordering criteria in search UI https://review.openstack.org/577870 | 23:32 |
| fungi | granted, a search function which requires authentication is not particularly user-friendly for a public task/defect tracker | 23:37 |
| diablo_rojo | fungi, yeah..making that not a thing would be better I think. | 23:42 |
| diablo_rojo | For adoption and openstack users that are not openstack contributors | 23:42 |
| fungi | well, just thinking generally if i'm running some software which takes bug reports in a storyboard instance, i might want to search for open bugs matching some problem i've encountered but don't necessarily want to create an account/log in unless i actually need to file a bug report or comment on one | 23:44 |
| diablo_rojo | Yeah that is my thought too. | 23:57 |
| diablo_rojo | If I am just searching for things I shouldn't have to log in until I make a change to a story or make a new story. | 23:57 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!
