| *** krotscheck has joined #storyboard | 00:43 | |
| *** b3rnard0 is now known as b3rnard0_away | 01:51 | |
| *** davidlenwell has quit IRC | 07:26 | |
| *** davidlenwell has joined #storyboard | 07:34 | |
| *** fay_ has joined #storyboard | 08:05 | |
| *** openstackgerrit has quit IRC | 09:03 | |
| *** openstackgerrit has joined #storyboard | 09:04 | |
| Zara | :) | 10:30 |
|---|---|---|
| Zara | I'm reviewing more today | 10:36 |
| Zara | will hopefully get to the end of the list | 10:36 |
| Zara | have left a coupla comments so far | 10:36 |
| Zara | 1) do ui patches depend on api stuff; have assumed so; should prolly be -A'd until that's merged ? | 10:37 |
| Zara | 2) worklist ui patch needs rework https://review.openstack.org/#/c/295450/ ; no 'add items' button in empty worklist (or maybe any worklist, can't remember) | 10:37 |
| Zara | also not an existing comment but 'add task to existing story' button would be ace, may get to it today, or may be too busy reviewing/testing. | 10:39 |
| * SotK does 1 | 10:39 | |
| * SotK is working on 2 | 10:39 | |
| Zara | ah, okay, I wasn't sure if it had got lost in a flood of emails, sorry for noise | 10:39 |
| * Zara gets distracted looking at socket.io | 10:55 | |
| Zara | I like it when I mistype commands like ` cd storyboarde` | 11:06 |
| Zara | ye olde storyboarde | 11:06 |
| * Zara gets the odd message again | 11:13 | |
| Zara | ' 400: GET /api/v1/users/preferences: Invalid input for field/attribute user_id. Value: 'preferences'. unable to convert to int ' | 11:13 |
| Zara | when I restart and first login to my instance | 11:14 |
| Zara | seems to be a remnant of the dreaded 401 | 11:14 |
| Zara | (so hahaha, have a ping, krotscheck-- but this isn't very disruptive really, and all works once I refresh. I assume it's to do with an error posting the refresh token since otherwise I have no idea what triggers it.) | 11:16 |
| krotscheck | Eh wha? | 11:22 |
| krotscheck | Oh | 11:22 |
| krotscheck | RIght | 11:22 |
| krotscheck | Probably a lack of token during the initial app phase while it's trying to resolve user prefs. | 11:22 |
| Zara | I wondered why it didn't affect more things, but I guess user prefs are the only thing that need the token... well, maybe there's other oddness that I can't see. | 11:24 |
| krotscheck | User prefs are initialized super early because of things like page size. It could just be a race condition between a directive and the app itself. | 11:30 |
| Zara | ahh, right, that should help me investigate when I get to it. (I had a glance at it because I feel bad about the number of console errors accumulating in general. (the subscriptions ones are definitely my fault; I thought ng-show/hide would stopthings being called sometimes, so atm $scope.subscriptions is undefined when user isn't logged in...)) | 11:45 |
| SotK | ng-if stops things being called I think, but stuff using ng-sho/ng-hide is always rendered and just hidden with css if necessary | 11:45 |
| Zara | yeah. really I should have coded the js properly, I think, so that $scope.subscriptions still has a value when nobody's logged in | 11:47 |
| Zara | I have a strong suspicion I got very confused by angular control flow and didn't know how to do it. | 11:47 |
| Zara | perhaps I still don't know how, hm. | 11:47 |
| * Zara finds $scope.subscriptions = $scope.subscriptions; | 12:00 | |
| Zara | in her old code | 12:00 |
| Zara | well that doesn't bode well | 12:00 |
| SotK | :D | 12:01 |
| Zara | so I thiiiink the issue is that we do this on initialisation $scope.subscriptions.$promise.then(resolveSubsList); | 12:05 |
| Zara | but the promise is undefined if user isn't logged in | 12:06 |
| Zara | in the subscribe directive | 12:06 |
| Zara | so the if statement above that bit needs tweaking, to say the least | 12:07 |
| * Zara goes back to review for now, depressed at confusion | 12:08 | |
| pedroalvarez | are you applying for queen in the north? | 12:08 |
| Zara | noooooooooo | 12:08 |
| pedroalvarez | :) you can do it! | 12:08 |
| pedroalvarez | at least this bug is not happening a lot in production, right? | 12:09 |
| Zara | well, that error's a different thing, anwyay; the 400 is the slightly disruptive one; the thing I was looking at was the subscriptions one in the web console | 12:09 |
| Zara | which doesn't affect things much, I just know it's my fault, and bad practice to leave things undefined | 12:09 |
| Zara | so just a bit annoyign seeing it when debugging somethign esle | 12:09 |
| Zara | yay spelling | 12:09 |
| Zara | but yeah, the 400 is infrequent | 12:10 |
| Zara | neither matters much; I was giving sotk some time to rework a ui patch before going back to review so I could check for any odd interactiosn between things | 12:10 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Allow an update of the SearchCriteriaController to be triggered https://review.openstack.org/295451 | 12:26 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Improve the worklist UI https://review.openstack.org/295450 | 12:26 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Add a resource abstraction for worklist filters https://review.openstack.org/295453 | 12:26 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Improve the tag-complete directive https://review.openstack.org/295452 | 12:26 |
| openstackgerrit | Adam Coldrick proposed openstack-infra/storyboard-webclient: Allow filters to be set on automatic worklists https://review.openstack.org/295454 | 12:26 |
| Zara | https://review.openstack.org/#/c/295450/ now seems fine to me; please review! | 12:36 |
| Zara | well, please review all of them, but ya know | 12:37 |
| Zara | I assume people sometimes use my reviews as a filter, might be wrong. | 12:37 |
| pedroalvarez | you are right | 12:38 |
| pedroalvarez | but sorry, patch is really big for me right now :( | 12:39 |
| * pedroalvarez used to have more spare time.. | 12:39 | |
| Zara | yeah, it's tricky. :( that's why I generally take my time over reviewing, because other people might not have enough time to check everything. but then it means it takes other people longer to start looking, if they wait for me, so... idk. | 12:41 |
| Zara | ooh, the tag complete patch makes the search box bold when loading | 13:05 |
| Zara | why? how? | 13:06 |
| Zara | not thtat I mind, just wondering | 13:12 |
| SotK | oh yeah, that is strange... | 13:12 |
| Zara | It also now goes 'undefined' in the searchbar accessed from the sidebar | 13:14 |
| Zara | maybe there's no $scope.placeholder ? | 13:19 |
| Zara | and hm, the 'Error: setting a property that has only a getter' has changed a bit to mention the tags | 13:23 |
| Zara | so guessing it's caused by something in that area of the code | 13:23 |
| * Zara is best detective | 13:25 | |
| SotK | yeah, its caused by autoresize-width I think | 13:38 |
| Zara | you have said, sorry. | 13:38 |
| * Zara has sieve-memory | 13:38 | |
| Zara | put a counter on how many times I mention it | 13:38 |
| Zara | so I'd rather not +1/+2 tag complete patch until it doesn't say 'undefined' as a placeholder in the sidebar search | 14:04 |
| * SotK is fixing it :) | 14:04 | |
| Zara | ahhh, I should just shush xD | 14:05 |
| Zara | I wasn't sure if I'd been explicit or if I'd just assumed that it was implied | 14:05 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Improve the worklist UI https://review.openstack.org/295450 | 14:08 |
| *** b3rnard0_away is now known as b3rnard0 | 14:08 | |
| *** openstack has joined #storyboard | 14:23 | |
| Zara | huh, worklist looked weird, refreshed page, is fine | 14:29 |
| Zara | noting for if we see that again in the futu | 14:29 |
| Zara | *future | 14:29 |
| Zara | it seems to take a while to display the list of stories | 14:31 |
| * persia was imagining "futu" as being like "tutu", only more skillfull | 14:31 | |
| Zara | hm, could be a way to attract people to the storyboard meeting. 'for one afternoon only, persia will be performing Swan Lake in a splendid tutu.' | 14:33 |
| * persia would definitely need some sort of fu enhancement to be capable of that. | 14:34 | |
| Zara | believe in yourself! and in your ability to do ballet! :D | 14:35 |
| Zara | I think it'll be a real hit. | 14:35 |
| Zara | okay, automatic worklists ui patches can't be merged until api is merged; that patch awaits review here: https://review.openstack.org/#/c/295422/ | 14:43 |
| Zara | it's sort of merge today or don't merge for a couple of weeks, because we still have tomorrow to fix things, but sotk goes on holiday after that, and I don't want to merge a new feature and then be unable to put out fires if they occur (pleased to say no fires during my testing, but we've been surprised before). | 14:47 |
| Zara | meeting in 7 | 14:53 |
| persia | Hrm. Looking at the implementation, I suspect there will be any number of feature requests surrounding automatic worklists, and at least some user confusion, but I can't imagine another implementation that wouldn't have the same effect :) | 14:54 |
| * SotK_ wonders where exactly persia is expecting confusion | 14:55 | |
| persia | Mostly that the UI looks very similar for automatic and non-automatic, but some of the operations that are easily performed on automatic (card archive, card sorting, etc.) don't appear to apply for automatic. | 14:55 |
| persia | But I don't think we can know the set of things that will confuse folk, or how to annotate things without input from more users. | 14:57 |
| SotK_ | I agree | 14:57 |
| persia | And, as someone who mostly cares about manual worklists, I'm ill-suited to constructively criticise the implementation, other than noticing the confusion. | 14:58 |
| persia | My hope is that this can land, and folk who want the automated kanban view can use it, and that input can be used to address things. | 14:58 |
| Zara | yup | 14:58 |
| Zara | storyboard meeting nowish anyway | 14:59 |
| persia | The data model is tricky, but one thing that comes to mind is that some users may want to manually select the set of cards that can appear in the automatic lists somehow (so as to avoid seeing all the extras). This can be done with assignment, but that's a heavy tool. | 14:59 |
| * persia subsides | 14:59 | |
| SotK_ | at that point they should make a manual worklist imo :D | 15:00 |
| *** SotK_ is now known as SotK | 15:00 | |
| persia | (yes, my first thought was some way to select from a worklist: for a project with thousands of issues, for which some team wants a kanban view of the few tens of tasks they expect to complete in the next timeframe, this becomes interesting, but the nature of the board view precludes having a "backlog" lane which is used as a filter, etc. There is probably a sensible model, but it doesn't fit in my head right now) | 15:03 |
| *** mrmartin has joined #storyboard | 15:05 | |
| *** openstackstatus has joined #storyboard | 15:13 | |
| *** ChanServ sets mode: +v openstackstatus | 15:13 | |
| openstackgerrit | Merged openstack-infra/storyboard: Add API functionality for automatic worklist filters https://review.openstack.org/295422 | 15:35 |
| Zara | my thorat is a bit sore | 15:58 |
| Zara | *throat | 15:58 |
| Zara | then again, it was a bit sore last week | 15:58 |
| Zara | and then it was fine again | 15:58 |
| Zara | whatever will happen next. | 15:58 |
| Zara | ¬_¬ https://review.openstack.org/#/c/295372/ | 16:02 |
| Zara | I've noticed it also removes the odd blank line, not sure if that makes a difference in puppet conf. | 16:02 |
| Zara | ^ sotk, krotscheck, anyone who has a stake in this | 16:06 |
| *** b3rnard0 is now known as b3rnard0_away | 16:27 | |
| Zara | #success storyboard.openstack.org sends emails now! | 16:31 |
| openstackstatus | Zara: Added success to Success page | 16:31 |
| pleia2 | \o/ | 16:32 |
| Zara | maybe I should use successbot more often :) | 16:32 |
| Zara | I've been worried I'll start using it for everything xD | 16:32 |
| pleia2 | haha | 16:32 |
| Zara | '#success my chair is comfy today' etc | 16:33 |
| Zara | so items remaining for review are ui patches for automatic worklists and boards. I'm probably gonna be in late double/triple checking these, but it'd be good if anyone with a spare moment could see if they look good enough for +1 in the meantime (I don't expect many others to be in late) we have https://review.openstack.org/#/c/295452/ , https://review.openstack.org/#/c/295453/ and https://review.openstac | 16:50 |
| Zara | k.org/#/c/295454/ | 16:50 |
| Zara | great link at the end three | 16:50 |
| Zara | *there | 16:50 |
| Zara | https://review.openstack.org/#/c/295454/ | 16:51 |
| Zara | ^ actual link | 16:51 |
| *** Guest63327 has quit IRC | 16:55 | |
| *** tlbr has joined #storyboard | 17:34 | |
| *** b3rnard0_away is now known as b3rnard0 | 17:38 | |
| Zara | getting a sudden mass of 401s on my test instance | 17:43 |
| Zara | it was okay earlier... | 17:43 |
| Zara | going to go back a few patches to narrow it down, yay | 17:43 |
| Zara | hm, things seem calmer on an older patch, though not totally calm | 17:48 |
| Zara | ('stop updating the board in place') | 17:48 |
| *** fay_ has quit IRC | 17:55 | |
| Zara | still getting 401s *everywhere* | 17:59 |
| Zara | wahhhhhhhhhhhhhhhh | 17:59 |
| Zara | Request URL: http://172.16.20.111:9000/api/v1/project_groups?limit=10&sort_dir=desc&sort_field=id | 18:00 |
| Zara | Request Method: GET | 18:00 |
| Zara | Status Code: HTTP/1.1 401 Unauthorized | 18:01 |
| Zara | why would that ever give a 401 | 18:01 |
| SotK | o.O | 18:01 |
| * Zara tries to send screenshot to imgur; imgur doesn't complete the upload | 18:04 | |
| persia | Can project groups be private? | 18:04 |
| Zara | there we go: http://imgur.com/fEv1Q7W | 18:04 |
| Zara | not particularly useful, more for the general feeling of it | 18:04 |
| SotK | persia: no | 18:07 |
| persia | That was the only excuse for 401 I could imagine | 18:08 |
| Zara | I'm not seeing any of this behaviour on s.o.o.; concerned it might be on its way | 18:08 |
| Zara | wondering if the change to the db could have possibly been involved | 18:08 |
| Zara | since I get it on older webclient patches, too | 18:08 |
| Zara | but didn't see it until today | 18:08 |
| * SotK hasn't seen anything like it whilst developing the change | 18:09 | |
| SotK | that screenshot looks like every single request is raising a 401... | 18:09 |
| Zara | yeah | 18:10 |
| Zara | sometimes it happens, sometimes not | 18:10 |
| Zara | sometimes 1 401, sometimes a page | 18:10 |
| Zara | it's fine when logged out, bad when logged in | 18:11 |
| *** krotscheck has quit IRC | 18:14 | |
| *** krotscheck has joined #storyboard | 18:15 | |
| *** mrmartin has quit IRC | 18:17 | |
| *** krotscheck has quit IRC | 18:26 | |
| *** krotscheck has joined #storyboard | 18:26 | |
| Zara | http://imgur.com/4wJzOoL :/ | 18:27 |
| Zara | http://paste.openstack.org/show/491624/ | 18:30 |
| Zara | haaaaaaaaaalp | 18:31 |
| Zara | I can't test at all like this (well, except for testing for this). | 18:32 |
| Zara | this persists when going back to a webclient version from several weeks ago | 18:33 |
| Zara | I'm gonna vanish for a bit, be back shortly, am completely blocked by this ;_; | 18:36 |
| *** b3rnard0 has left #storyboard | 18:38 | |
| *** krotscheck has quit IRC | 18:38 | |
| *** krotscheck has joined #storyboard | 18:39 | |
| *** openstack has joined #storyboard | 19:22 | |
| *** openstackstatus has joined #storyboard | 19:24 | |
| *** ChanServ sets mode: +v openstackstatus | 19:24 | |
| * Zara fiiiiiiiinally gets back to looking at things | 20:04 | |
| *** openstack has joined #storyboard | 20:32 | |
| SotK | \o/ | 20:37 |
| Zara | still no +1s for those, though; really not keen on merging anything tomorrow... | 20:41 |
| SotK | :( | 20:44 |
| Zara | okay, ui issue possibly | 21:17 |
| Zara | it seems it doesn't save your automatic preferences when you first set them | 21:17 |
| Zara | when creating a new worklist | 21:18 |
| Zara | if you create first, then set, seems to work | 21:18 |
| Zara | SotK ^ | 21:18 |
| Zara | ahhh, I know what I did | 21:19 |
| Zara | so it is confusing ui, a bit , but does work | 21:19 |
| *** zara____________ has joined #storyboard | 21:20 | |
| zara____________ | aaaaaaaargh computer froze | 21:20 |
| zara____________ | okay so the issue was that | 21:20 |
| zara____________ | I only clicked the big 'save' | 21:20 |
| zara____________ | without saving the filter first | 21:21 |
| zara____________ | so a bit confusing but something that can be tweaked later | 21:21 |
| zara____________ | my computer has completely died so resetting it now, might take me a little while to get all my windows back, gah | 21:21 |
| zara____________ | on the upside, ui seems to work fine so far! | 21:22 |
| zara____________ | in terms of doing the things it's asked to do, anyway | 21:23 |
| Zara | the real me is back | 21:26 |
| Zara | be nice in the future to have an 'edit criterion' button, rather just delete and then make a new one | 21:32 |
| Zara | in general this works really well so far =D | 21:37 |
| Zara | I can replicate a project story list page by using the filters, and so on | 21:38 |
| Zara | so I'd *like* an automatic worklist to look more obviously different to a regular one, even if it's just another border or something, so that users can tell why they can't move cards | 21:51 |
| Zara | but haven't yet looked at implementation and don't know how fiddly it will be; hopefully it's something I can add in the next two weeks | 21:51 |
| Zara | it is realy nice | 21:52 |
| Zara | I think this is the smoothest a new feature has ever worked | 21:52 |
| persia | This is the data model problem I mentioned earlier. | 21:56 |
| persia | Essentially, automatic worklists and manual worklists are entirely different beasts, and the current implementation offers no way to impose manual filtering on automatic worklists (excepting tags) or automatic filtering on manual worklists (so items manually put in backlog magically moving on a board) | 21:57 |
| persia | That said, it's the beginning of cool stuff, and until there are users playing with this, it isn't clear what needs to be done to make it especially cool. | 21:57 |
| Zara | yeah, I flagged it up at this point because it confused me when testing | 21:58 |
| Zara | even though I was already aware of it | 21:58 |
| Zara | had a brief 'huh how come I can't move cards-- oh yeah, this is an automatic one' | 21:58 |
| Zara | but yeah, first steps | 21:58 |
| Zara | and other than the stuff I've mentioned above, no clear idea on what to change yet either | 21:59 |
| persia | On the bright side, those who want views like "what stuff is being worked on currently in projects X, Y, and Z" can get it now. | 22:00 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Improve the tag-complete directive https://review.openstack.org/295452 | 22:04 |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Add a resource abstraction for worklist filters https://review.openstack.org/295453 | 22:05 |
| Zara | something to watch out for: changing a worklist back from automatic to manual will remove all items from the worklist. so I think in the future we either want to change that, so it keeps items by default, or we want an additional warning message for that. | 22:20 |
| persia | Or maybe introduce a new concept, e.g. "Lane" or "View". | 22:28 |
| persia | My current thought is that it might be interesting to have a kanban lane be an automatic selection from either a project or a worklist. | 22:29 |
| persia | So one can have the experience of populating a worklist that shows all the items being done, but then automatically spread the view of those items over several lanes as an alternate visualisation. | 22:29 |
| persia | Maybe something to discuss in Austin? | 22:29 |
| * persia is not very confident that the model described above actually covers the various uses, and suspects that documented requirements capture is probably a sensible step at this point | 22:30 | |
| Zara | I'm sleepy so heading off, but at a glance that sounds like what we're already working towards, be interesting to talk more soon, though. | 22:35 |
| zara____________ | GOOD NIGHT | 22:35 |
| *** zara____________ has quit IRC | 22:35 | |
| openstackgerrit | Merged openstack-infra/storyboard-webclient: Allow filters to be set on automatic worklists https://review.openstack.org/295454 | 22:36 |
| SotK | all the cards disappear when you switch from automatic to manual because the cards aren't real | 22:56 |
| SotK | (they are generated on the fly when the request is made and not stored in the database) | 22:57 |
| SotK | (that means it is theoretically possible to move things from automatic worklists into manual worklists if you have a mixture of the two in a board, but that isn't yet implemented | 22:58 |
| SotK | ) | 22:58 |
| SotK | moving things into automatic worklists is a tougher beast, since it is possible to define filters which cannot be used to set the task/story state sensibly (eg. dropping a card into a list of things assigned to one of me or Zara doesn't have a sensible way of deciding which of those filters to make the card's task match) | 23:00 |
| SotK | and allowing manual rearrangement of cards in an automatic list (for prioritisation) will mean storing the cards in the db, and updating all of them (plus checking they still match the filters, and adding anything that newly matches) each time a request affecting the worklist is made | 23:02 |
| SotK | and that implementation seems needlessly messy to me, unless people desperately want to reorder their automatic lists for some reason | 23:02 |
| SotK | allowing a filter to be based of a different worklist is interesting and should (theoretically) be fairly simple | 23:03 |
| SotK | (assuming that that means a filter like "Tasks with Status matching Todo and Worklist matching `persia's stuff`") | 23:04 |
| persia | That is the model that is tickling my brain | 23:06 |
| persia | And yeah, making them real cards seems massive overkill. | 23:07 |
| *** openstack has joined #storyboard | 23:23 | |
| *** openstackstatus has joined #storyboard | 23:24 | |
| *** ChanServ sets mode: +v openstackstatus | 23:24 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!