| *** caowei has joined #softwarefactory | 01:15 | |
| *** jpena|off has quit IRC | 07:40 | |
| *** ssbarnea_ has joined #softwarefactory | 07:41 | |
| *** ssbarnea_ has quit IRC | 07:49 | |
| *** jpena has joined #softwarefactory | 08:13 | |
| *** sfbender has quit IRC | 08:35 | |
| *** openstack has joined #softwarefactory | 09:29 | |
| *** caowei has quit IRC | 09:31 | |
| *** caowei has joined #softwarefactory | 09:31 | |
| *** ssbarnea_ has joined #softwarefactory | 09:57 | |
| *** caowei has quit IRC | 10:40 | |
| *** jpena is now known as jpena|lunch | 11:43 | |
| *** ssbarnea_ has quit IRC | 12:43 | |
| *** jpena|lunch is now known as jpena | 12:51 | |
| *** ssbarnea_ has joined #softwarefactory | 13:12 | |
| gundalow | nhicher: rcarrillocruz tristanC https://softwarefactory-project.io/r/#/c/12174/ updates network image and moves away from uuid. My first PR, so please let me know if I've missed something | 14:52 |
|---|---|---|
| rcarrillocruz | i think having just the name suffices, shade library does name_or_id search, but i'll leave SF folks to confirm | 14:53 |
| gundalow | rcarrillocruz: regarding the version part of the name? I wondered about that, though we call images fedora-27 fedora-28 so we can test both/one. For example vyos2.0will be RC1 soon and we may want to start testing that (just an example) | 14:56 |
| rcarrillocruz | noon, i mean you have both cloud-image name and cloud-image image-id | 14:57 |
| gundalow | ah | 14:57 |
| gundalow | That was based on http://paste.openstack.org/show/720603/ from corvus | 14:57 |
| rcarrillocruz | gundalow: https://docs.openstack.org/infra/nodepool/configuration.html | 15:01 |
| corvus | gundalow, rcarrillocruz: i believe that's the right way to write a config which identifies the image by UUID, and then maps it to a friendly name in the config file | 15:12 |
| gundalow | ack. I read that cloud-image/name could be the UUID, however if I'm reading the docs correctly, then I'd need to use the UUID again in labels, therefore duplicating the UUID | 15:13 |
| corvus | gundalow, rcarrillocruz: if you wanted to identify the image by *name*, i think you could drop image-id and just put the name (as it appears in glance) in the config file. but then, you'd be using that name to reference it below as well. so if it ever changed, you'd have to change it in multiple places. | 15:13 |
| nhicher | gundalow, rcarrillocruz: we can do testing without uuid, and revert if it doesn't work, wdyt ? | 15:14 |
| corvus | gundalow: cloud-image.name, when specified alone (with no image-id or image-name attribute) can be either the name or uuid in glance | 15:14 |
| corvus | there's like 12 ways you can do this :) | 15:15 |
| gundalow | For context this is to bring some new tests online, the existing images don't work. So this isn't going to make anything worse | 15:15 |
| gundalow | corvus: :D | 15:15 |
| gundalow | So as long as what I've got should work and looks OK then I think we should be good | 15:16 |
| gundalow | aka | 15:16 |
| gundalow | can haz +1's please :) | 15:16 |
| corvus | the other thing you can do is use name + image-name. that lets you specify the glance image by name, and then "alias" it to another name in nodepool. then you aren't using any uuids, but you still only need to change one thing in nodepool if the glance image changes. | 15:16 |
| corvus | gundalow: yes, i think what's there will work and is reasonable :) | 15:16 |
| gundalow | \o/ | 15:16 |
| corvus | (we should probably write more docs about this -- maybe suggest the 3 main ways of setting this up why you would use each) | 15:17 |
| gundalow | nhicher: and tristanC were added as reviews (I assume as they are owners of the `config` project) Do I need +1's from exactly those people? Not sure who has voting rights on that project (core-developers if I read the docs correctly) | 15:18 |
| gundalow | corvus: That would be good, a couple of examples in https://docs.openstack.org/infra/nodepool/configuration.html would help, or links to live code | 15:18 |
| nhicher | gundalow: I can add your user as core for config-repo, it will be easier to manage (or somebody else from your team) | 15:20 |
| gundalow | nhicher: erm, As long as that doesn't give me powers to break things | 15:22 |
| * gundalow lives in GitHub land usually, this was my first Gerrit PR for example | 15:22 | |
| nhicher | you will have the power to break everything =) | 15:22 |
| gundalow | Lets discuss that on !Friday | 15:23 |
| gundalow | Though would be good if I can get that changed merged today | 15:23 |
| nhicher | but, for now I can validate the review and we can add somebody from your team to validate the changes on nodepool. It's not possible to allow people to have +2 only on a file | 15:23 |
| nhicher | I can merge it, are you ok with your change or do you want to remove uuid ? | 15:24 |
| nhicher | gundalow: ^ | 15:25 |
| gundalow | If what I've got should work lets stick with that. In the near-future we will want more images. Though I want to understand a bit more about "The Zuul way", so we can discuss changes to that file then | 15:25 |
| gundalow | Good to merge | 15:25 |
| *** mordred has joined #softwarefactory | 15:31 | |
| nhicher | gundalow: it doesn work https://softwarefactory-project.io/paste/show/1057/ | 15:32 |
| gundalow | nhicher: ah, missing two chars from the image-id, I'll raise a fresh PR for that | 15:34 |
| gundalow | nhicher: https://softwarefactory-project.io/r/#/c/12175 | 15:41 |
| nhicher | same error message gundalow (but with the right uuid this time) | 15:47 |
| gundalow | hum | 15:48 |
| gundalow | nhicher: https://gist.github.com/gundalow/bdd08dba12f385b8f4de60e899923419 is where I created the image | 15:49 |
| gundalow | Did I need to match `name` in the above as well as `id`? | 15:50 |
| gundalow | rcarrillocruz: Anuy ideas? | 15:52 |
| gundalow | project_name: sf-nodepool | 15:53 |
| gundalow | username: svc-sf-nodepool | 15:53 |
| gundalow | is what my rdo-cloud account is using | 15:54 |
| nhicher | I don't know gundalow, I saw the image with the right id | 15:54 |
| nhicher | yes, that's the nodepool tenant for rdocloud | 15:54 |
| nhicher | the previous image is on the same tenant | 15:54 |
| gundalow | Cool, just wanted to check I'd created the image in the right place | 15:54 |
| nhicher | I will test on nodepool to change the name to match the image name | 15:55 |
| gundalow | Thank you :) | 15:55 |
| nhicher | same issue with ansible-network as name for cloud-image | 15:57 |
| gundalow | nhicher: Is it easy for you to test with https://softwarefactory-project.io/r/gitweb?p=config.git;a=blob;f=nodepool/ansible-network.yaml;h=d5b5a7ee91c73ee4d00a64fa3c898b426bd2f1c8;hb=f722d3567ddc06b8f04f51ea787c6b7b80cb4b9a though with the updated ID: 0e2e2e05-99e5-422b-b9e3-7e4a28d9088e | 15:59 |
| gundalow | So the only thing we are testing is the new image-id, rather than new images *and* new config format | 16:00 |
| gundalow | Or I can create that as a PR | 16:02 |
| nhicher | I can test quickly gundalow | 16:03 |
| nhicher | it fails, but I don't understand why https://softwarefactory-project.io/paste/show/1058/ | 16:14 |
| gundalow | nhicher: That's very confusing. Only change is the ID? | 16:15 |
| nhicher | yes, ID and renaming the label ansible-network | 16:18 |
| gundalow | What about if we don't change the label? | 16:19 |
| nhicher | KeyError: 'ansible-network', but there is only ansible-network-vyos-1.1.8 on the nodepool configuration :/ | 16:22 |
| *** jangutter has quit IRC | 16:22 | |
| nhicher | I will do some tests this afternoon if it ok for you, I have a dev environment | 16:22 |
| gundalow | nhicher: That would be great thank you so much. | 16:22 |
| nhicher | gundalow: | 16:22 |
| nhicher | we can revert your change if needed | 16:23 |
| gundalow | Whatever is easiest, as I said nothing live is using this yet. Only a WIP PR | 16:24 |
| nhicher | ok, I'll keep you in touch gundalow | 16:24 |
| gundalow | https://github.com/ansible-network/ansible-zuul-jobs/pull/13/files#diff-dbd9cd0ce7e9a5628770143f1488ff59R36 which I'l update the `label:` once nodepool is happy | 16:24 |
| gundalow | Thank you :) | 16:25 |
| *** openstack has joined #softwarefactory | 17:05 | |
| *** jpena is now known as jpena|off | 17:22 | |
| nhicher | gundalow: I found the solution, if you use image-name instead image-id it works (I tested on my dev env, I will propose a patch on sf.io) | 20:56 |
| gundalow | nhicher: Ace | 21:13 |
| nhicher | I have open a bug upsteam https://storyboard.openstack.org/#!/story/2002013 | 21:15 |
| gundalow | Good spot | 21:15 |
| nhicher | gundalow: there were error on nodepool logs, but it was for there were some node with ansible-network label (but it didn't not exists), I deleted the nodes | 21:20 |
| nhicher | everything seems ok now | 21:20 |
| *** ssbarnea_ has quit IRC | 22:16 | |
| gundalow | nhicher: Thank you :D | 22:46 |
| gundalow | zuul-jobs/roles/prepare-workspace/tasks/main.yaml's Synchronize src repos to workspace directory is failing for me, thought the task has no_log: true. Can I sub class that and remove the no_log? https://ansible.softwarefactory-project.io/logs/13/13/793d6e03a7af2d23cb6d333409c4079c63514471/check/ansible-test-network-integration-vyos-devel/0cedf45/ara/ hitting issues with a new node type I'm bring up | 22:46 |
| gundalow | Though that's failing in my new image, so getting there :) | 22:46 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!