Thursday, 2015-08-13

*** lixinhui_ has quit IRC00:31
*** Liu has quit IRC01:11
*** Qiming has joined #senlin01:26
openstackgerritYanyan Hu proposed stackforge/senlin: [WIP]Fix gate job of Senlin functional test
*** Yanyanhu has joined #senlin01:35
*** mathspanda has joined #senlin01:57
Qimingthis is insane02:00
Qimingmy comments may be too harsh ...02:01
Yanyanhuthis is the guy who also gave comment on the spec we saw yesterday?02:02
Yanyanhuoh, just the owner of that spec02:03
*** ChrisSen has joined #senlin02:11
*** lkarm has joined #senlin02:33
*** lkarm has quit IRC02:37
*** jdandrea has quit IRC02:54
openstackgerritxu-haiwei proposed stackforge/senlin: Make ignore_missing default to False
openstackgerritMerged stackforge/senlin: Revised node implementation with test cases
openstackgerritMerged stackforge/senlin: Updated from global requirements
*** Tennyson has joined #senlin04:32
*** lkarm has joined #senlin05:00
*** lkarm has quit IRC05:04
openstackgerritMerged stackforge/senlin: Polish stack profile unit test
openstackgerritMerged stackforge/senlin: Make ignore_missing default to False
Qimingjust proposed this05:15
Yanyanhunice, this is the correct thing I think05:15
openstackgerritMerged stackforge/senlin: RPC client support to triggers
Qimingummm, I had a second thought05:34
Qimingmaybe the emulation of find-by-name should be done at sdk layer05:34
Yanyanhuagree with this05:35
Yanyanhuactually what sdk is doing now is not wrong, just because the query logic in different service is distinct05:36
Yanyanhuthus cause the find() method can't work as expected05:36
Qimingthe problem is .... find is a classmethod05:37
Qimingcan we override it easily in Flavor?05:38
Yanyanhuhmm, I think so05:38
Yanyanhuthis is much better than implementing this logic in nova driver05:39
Yanyanhumaybe we can also do similar thing for other nova resource, then we can complete remove those get_xxx_by_name05:40
openstackgerritYanyan Hu proposed stackforge/senlin: [WIP]Fix gate job of Senlin functional test
xuhaiweiI think we should support find-by-name, maybe we should first LIST the resource and then query from the list?05:54
Qimingxuhaiwei, yes, find-by-name is an important feature for flavor resource05:54
Qimingthe only question is where should we implement it05:55
Qimingideally, nova05:55
Qimingsub-optimal, sdk05:55
Qimingfinally, senlin05:55
xuhaiweiyes, but I think the easiest way is doing in senlin05:55
QimingI'd try sdk first05:56
Qimingfrom sdk user's perspective, we would like it to hide the difference between services05:56
Qimingor else why are we using it05:57
Qimingit's not easy to override classmethod as far as I can see05:57
QimingI'm doing some experiments to try it out05:57
Qimingsomething like this:05:58
Qiming21     @classmethod05:58
Qiming 22     def class_method(cls):05:58
Qiming 23         super(Child, cls).class_method()05:58
Qiming 24         print "child class_method: cls = %s x = %s" % (cls, cls.x)05:58
Yanyanhuso it's different from overriding a normal method of a class?06:00
Qimingnot sure06:00
Qimingoverriding classmethod may be different from overriding instance method06:01
Yanyanhutrying to build a clean VM to test the senlinclient installation in devstack env06:01
Yanyanhuhope can find some reasons06:02
*** Tennyson has quit IRC06:42
*** Tennyson has joined #senlin06:42
Qimingchanged my minde06:43
Qimingrevised the SDK patch:
Qimingit is not that difficult06:44
Qimingwe need to test if it works06:44
Yanyanhuyes, this is better06:45
Yanyanhuwill make test using it06:45
QimingSDK is throwing DuplicateResource for this06:45
Qiminghold on your test06:45
Qimingfine now06:47
Qimingpatch3 should be okay06:47
Qimingwhat we learned from their experience ... don't introduce new exception types unless absolutely necessary06:48
Qimingit you pollute your code like kind of virus06:48
openstackgerritQiming Teng proposed stackforge/senlin: Replace flavor_get_by_name with flavor_find
Yanyanhuhi, Qiming, it works06:54
Qiminghope sdk guys won't force me to write some ... tests06:55
Yanyanhuif so, maybe we can just leave the flavor_find method06:55
Qimingit is a problem that has better solved by sdk06:55
*** lkarm has joined #senlin07:16
*** lkarm has quit IRC07:20
*** Tennyson has quit IRC07:24
xuhaiweiQiming, the DuplicateResource exception is not HttpException type, so we should take care of it in senlin I think07:25
*** Tennyson has joined #senlin07:25
Qimingyes, xuhaiwei07:27
Qimingor we should help SDK kill it07:27
xuhaiweibefore we can kill it, we should catch it and make it an internalError, besides this exception, ResourceTimeout and ResourceFailure seem to happen in some cases too07:32
*** Tennyson has quit IRC07:35
*** Tennyson has joined #senlin07:35
Qimingokay, those ones needs to be caught as well07:38
*** openstackgerrit has quit IRC07:41
*** openstackgerrit has joined #senlin07:42
*** openstackgerrit has quit IRC07:45
*** Qiming_ has joined #senlin07:49
*** Qiming has quit IRC07:49
*** openstackgerrit has joined #senlin08:00
openstackgerritQiming Teng proposed stackforge/senlin: Unit test for custom action module
openstackgerritQiming Teng proposed stackforge/senlin: Remove 'wrap_exception' function
*** Tennyson has quit IRC08:02
*** Tennyson has joined #senlin08:03
openstackgerritYanyan Hu proposed stackforge/senlin: [WIP]Fix gate job of Senlin functional test
Yanyanhuhi, Qiming_, I think I found the reason why senlinclient installation failed in gate side.08:25
Yanyanhuin our devstack plugin, we use git_clone function of devstack to clone senlinclient code from repo to dest dir, like /opt/stack/new/python-senlinclient08:26
Yanyanhugit_clone func will check whether the source url is a gerrit style url08:26
Yanyanhuif so, it will do the job correctly08:27
Yanyanhubut if NOT, it will check whether an old repo has been there in the dest dir08:27
Yanyanhuif it found the dest dir is not existing08:27
Yanyanhuit will further check ERROR_ON_CLONE env variable08:28
Qiming_so, solution?08:28
Yanyanhuif this ERROR_ON_CLONE is false, it will do a complete clone using clone_time08:28
Yanyanhubut if it is True, an error will be given and installation progress is cancelled...08:29
Yanyanhuin our local env, this variable is set to False by default08:29
Yanyanhuso the installation progress can complete correctly08:29
Yanyanhubut in gate, this value is always set to True by default08:29
Yanyanhufor this reason08:30
Yanyanhuso I think the solution could be manually change the value of this variable during the installation of senlinclient08:30
*** Tennyson has quit IRC08:30
Yanyanhuand change it back after client source code clone is finished08:31
Qiming_cann't we just avoid using git_clone function?08:31
YanyanhuI think this won't break the rule that gate wants to have08:31
Yanyanhuhmm, I think we can08:31
Yanyanhubut it is recommned by devstack08:31
Yanyanhuwhen any service try to implement its own plugin for devstack08:32
Yanyanhuit provides some control like timeout08:32
*** Tennyson has joined #senlin08:32
Yanyanhuor heat check08:32
Yanyanhuso I think we can directly use 'git clone', but maybe not as safe as 'git_clone'08:32
Qiming_the gate is designed to install and check the service targeted (e.g. senlin), not the other software08:32
Yanyanhuthis is the point08:32
Yanyanhuso I think maybe we can use a work around for code cloning of senlinclient08:33
Qiming_git_clone is obviously not designed for cloning an "irrelevant" software08:33
Yanyanhuso any suggestion?08:33
Qiming_1. we don't need senlinclient for functional test, right?08:33
Qiming_2. even we do need it, we are expected to do a pip install, suppose python-senlinclient is released with a version08:34
Yanyanhuactually after we have the first release, this problem will go I think08:34
Qiming_3. without a release published, everything we do today is a hack, so we choose the quickest way08:34
Qiming_in this case, it makes good sense to avoid install senlinclient08:35
Yanyanhuok, agree with this08:36
Yanyanhuso maybe we just remove the installing of senlinclient from devstack plugin and leave some comments in README?08:36
Yanyanhuto let people know how to enable it or manually do this job?08:37
openstackgerritYanyan Hu proposed stackforge/senlin: [WIP]Fix gate job of Senlin functional test
openstackgerritYanyan Hu proposed stackforge/senlin: [WIP]Fix gate job of Senlin functional test
*** Tennyson has quit IRC08:57
*** mathspanda has quit IRC09:20
openstackgerritYanyan Hu proposed stackforge/senlin: Fix gate job of Senlin functional test
*** ChrisSen has quit IRC09:43
*** Liu has joined #senlin09:44
openstackgerritxu-haiwei proposed stackforge/senlin: Handle exceptions which happen in heat driver
openstackgerritQiming Teng proposed stackforge/senlin: Unit test for actions in engine service
openstackgerritxu-haiwei proposed stackforge/senlin: Modify parse_exception method
*** Yanyan has joined #senlin09:59
*** Yanyanhu has quit IRC09:59
*** Yanyan has quit IRC10:04
openstackgerritQiming Teng proposed stackforge/senlin: Unit test for actions in engine service
*** branw has joined #senlin10:14
openstackgerritMerged stackforge/senlin: Modify parse_exception method
openstackgerritMerged stackforge/senlin: Add server_metadata_get and server_metadata_update method
*** Qiming_ has quit IRC10:26
*** Liu has quit IRC10:35
*** Liu has joined #senlin10:48
*** Qiming_ has joined #senlin11:25
openstackgerritMerged stackforge/senlin: Use Senlin generic driver to manage openstack lbaas driver
*** lkarm has joined #senlin12:13
openstackgerritMerged stackforge/senlin: Remove 'wrap_exception' function
openstackgerritQiming Teng proposed stackforge/senlin: Unit test for events in service engine
*** openstackgerrit has quit IRC13:01
*** openstackgerrit has joined #senlin13:02
*** jdandrea has joined #senlin13:40
*** lkarm has quit IRC13:51
*** lkarm has joined #senlin13:52
*** jroyal has joined #senlin16:28
*** openstackgerrit has quit IRC16:31
*** openstackgerrit has joined #senlin16:32
*** Qiming_ has quit IRC16:39
*** jroyal has quit IRC17:10
*** jroyal has joined #senlin17:11
openstackgerritNavneet Gupta proposed stackforge/python-senlinclient: Add unit test cases for sdk module
openstackgerritNavneet Gupta proposed stackforge/python-senlinclient: Add unit test cases for sdk module
*** lkarm has quit IRC21:10
*** jroyal has quit IRC21:21
*** jroyal has joined #senlin21:22
*** jroyal has quit IRC21:26
*** jroyal has joined #senlin21:27
*** jroyal has quit IRC21:32
*** branw has quit IRC22:50
openstackgerritMerged stackforge/senlin: Policy types API test case fix

Generated by 2.14.0 by Marius Gedminas - find it at!