| *** jcooley_ has joined #savanna | 00:07 | |
| *** tmckay has quit IRC | 00:10 | |
| *** jcooley_ has quit IRC | 00:13 | |
| *** matsuhashi has joined #savanna | 00:23 | |
| *** jcooley_ has joined #savanna | 00:30 | |
| *** matsuhashi has quit IRC | 00:33 | |
| *** matsuhashi has joined #savanna | 00:34 | |
| *** jcooley_ has quit IRC | 00:37 | |
| *** matsuhashi has quit IRC | 00:38 | |
| *** matsuhashi has joined #savanna | 01:04 | |
| *** tmckay has joined #savanna | 01:04 | |
| *** nosnos has joined #savanna | 01:05 | |
| *** jcooley_ has joined #savanna | 01:30 | |
| *** jcooley_ has quit IRC | 01:37 | |
| *** matsuhashi has quit IRC | 02:18 | |
| *** jcooley_ has joined #savanna | 02:26 | |
| *** matsuhashi has joined #savanna | 02:26 | |
| *** jcooley_ has quit IRC | 02:31 | |
| *** tmckay has quit IRC | 02:32 | |
| *** witlessb has joined #savanna | 02:56 | |
| *** witlessb has quit IRC | 02:56 | |
| *** jcooley_ has joined #savanna | 03:01 | |
| *** matsuhashi has quit IRC | 03:48 | |
| *** jcooley_ has quit IRC | 03:53 | |
| *** _nadya_ has joined #savanna | 04:02 | |
| *** _nadya_ has quit IRC | 04:03 | |
| *** matsuhashi has joined #savanna | 04:32 | |
| openstackgerrit | Jenkins proposed a change to openstack/savanna: Imported Translations from Transifex https://review.openstack.org/70918 | 06:09 |
|---|---|---|
| *** _nadya_ has joined #savanna | 06:13 | |
| *** saju_m has joined #savanna | 06:15 | |
| *** _nadya_ has quit IRC | 06:21 | |
| *** akuznetsov has quit IRC | 06:26 | |
| *** _nadya_ has joined #savanna | 06:27 | |
| *** dmitryme has joined #savanna | 06:28 | |
| *** akuznetsov has joined #savanna | 06:29 | |
| openstackgerrit | Lee Li proposed a change to openstack/savanna: Remove dependent module py3kcompat https://review.openstack.org/73535 | 06:39 |
| *** nosnos has quit IRC | 06:42 | |
| *** NikitaKonovalov is now known as NikitaKonovalov_ | 06:49 | |
| *** nosnos has joined #savanna | 06:52 | |
| openstackgerrit | Yongli He proposed a change to openstack/savanna: Use six.moves cStringIO instead of cStringIO https://review.openstack.org/73942 | 06:53 |
| *** dmitryme has quit IRC | 06:56 | |
| *** _nadya_ has quit IRC | 07:03 | |
| *** _nadya_ has joined #savanna | 07:05 | |
| *** _nadya_ has quit IRC | 07:09 | |
| *** NikitaKonovalov_ is now known as NikitaKonovalov | 07:16 | |
| openstackgerrit | Yongli He proposed a change to openstack/savanna: Use six.moves cStringIO instead of cStringIO https://review.openstack.org/73942 | 07:18 |
| *** mattf is now known as _mattf | 07:21 | |
| *** boris-42 has quit IRC | 07:40 | |
| *** akuznetsov has quit IRC | 07:48 | |
| *** akuznetsov has joined #savanna | 07:51 | |
| *** saju_m has quit IRC | 08:31 | |
| *** sreshetniak has quit IRC | 08:45 | |
| *** dmitryme has joined #savanna | 08:54 | |
| *** saju_m has joined #savanna | 08:58 | |
| openstackgerrit | Dmitry Mescheryakov proposed a change to openstack/savanna: Do eventlet.monkey_patch at the very beginning https://review.openstack.org/72992 | 08:59 |
| *** witlessb has joined #savanna | 09:08 | |
| *** DinaBelova_ is now known as DinaBelova | 09:50 | |
| *** boris-42_ has joined #savanna | 09:52 | |
| *** bogdando has joined #savanna | 09:53 | |
| *** matsuhashi has quit IRC | 09:54 | |
| *** matsuhashi has joined #savanna | 10:02 | |
| *** aignatov is now known as aignatov_ | 10:02 | |
| *** akuznetsov has quit IRC | 10:08 | |
| openstackgerrit | Daniele Venzano proposed a change to openstack/savanna: Add Spark plugin to Savana https://review.openstack.org/73989 | 10:09 |
| *** akuznetsov has joined #savanna | 10:09 | |
| *** matsuhashi has quit IRC | 10:17 | |
| *** matsuhashi has joined #savanna | 10:17 | |
| *** matsuhashi has quit IRC | 10:22 | |
| openstackgerrit | Nikita Konovalov proposed a change to openstack/savanna: Moving rest to Pecan/WSME framework https://review.openstack.org/63908 | 10:29 |
| *** aignatov_ is now known as aignatov | 10:37 | |
| *** dmitryme has quit IRC | 10:38 | |
| openstackgerrit | Sergey Reshetnyak proposed a change to openstack/savanna-image-elements: Add hadoop v2 support to hadoop element https://review.openstack.org/72651 | 10:38 |
| *** NikitaKonovalov is now known as NikitaKonovalov_ | 10:39 | |
| *** matsuhashi has joined #savanna | 10:47 | |
| *** tosky has joined #savanna | 10:50 | |
| openstackgerrit | Sergey Reshetnyak proposed a change to openstack/savanna: Add Hadoop 2 vanilla plugin https://review.openstack.org/73641 | 10:52 |
| openstackgerrit | A change was merged to openstack/python-savannaclient: Remove dependent module py3kcompat https://review.openstack.org/73757 | 11:06 |
| openstackgerrit | A change was merged to openstack/savanna: Sort modules in openstack-common.conf https://review.openstack.org/73050 | 11:29 |
| *** DinaBelova is now known as DinaBelova_ | 11:36 | |
| *** matsuhashi has quit IRC | 11:37 | |
| *** aignatov is now known as aignatov_ | 11:40 | |
| *** aignatov_ is now known as aignatov | 11:50 | |
| *** aignatov is now known as aignatov_ | 11:51 | |
| *** aignatov_ is now known as aignatov | 11:57 | |
| openstackgerrit | Sergey Reshetnyak proposed a change to openstack/savanna: Spped up attaching cinder volumes https://review.openstack.org/74015 | 12:33 |
| openstackgerrit | Sergey Reshetnyak proposed a change to openstack/savanna: Attach volumes in parallel https://review.openstack.org/74015 | 12:39 |
| *** _mattf is now known as mattf | 12:45 | |
| mattf | anyone have thoughts as to what's causing https://review.openstack.org/#/c/73010/ jenkins to fail? | 12:46 |
| openstackgerrit | Wei Wang proposed a change to openstack/savanna: Use cStringIO from six.moves instead of cStringIO https://review.openstack.org/74026 | 12:55 |
| openstackgerrit | Sofiia Kostiuchenko proposed a change to openstack/savanna: Added SCALE_ADDITIONAL_NODES_NUMBER and SCALE_NEW_NODES_NUMBER parameters to HDP plugin config. https://review.openstack.org/72300 | 12:58 |
| *** IvanBerezovskiy has joined #savanna | 13:07 | |
| *** nosnos has quit IRC | 13:08 | |
| mattf | aignatov, pls take another look at https://review.openstack.org/#/c/72933/ | 13:13 |
| aignatov | mattf, why do not create bug fix and unit tests in a single patch? | 13:16 |
| *** DinaBelova_ is now known as DinaBelova | 13:24 | |
| *** NikitaKonovalov_ is now known as NikitaKonovalov | 13:25 | |
| aignatov | ok, I've approved but I think bug fix related code and unit tests for it should go in the single patch set. | 13:31 |
| *** aignatov is now known as aignatov_ | 13:43 | |
| mattf | aignatov_, the bug fix and unit test for the bug are in the single patch/commit | 13:59 |
| *** aignatov_ is now known as aignatov | 14:03 | |
| *** saju_m has quit IRC | 14:15 | |
| openstackgerrit | Dmitry Mescheryakov proposed a change to openstack/savanna: Intial Agent remote implementation https://review.openstack.org/71015 | 14:24 |
| mattf | anyone have thoughts as to what's causing https://review.openstack.org/#/c/73010/ jenkins to fail? | 14:25 |
| mattf | it's py27 only. i can't reproduce locally. the code that's failing isn't obviously touched by the patch. | 14:26 |
| aignatov | just try 'recheck no bug' ;) if you think that this some unrelated jenkins fails :) | 14:31 |
| mattf | i do, it's been failing consistently. patches that dep on it have been passing though. | 14:33 |
| mattf | i'm not sure how to debug it at this point. | 14:33 |
| *** tmckay has joined #savanna | 14:42 | |
| *** jmaron has joined #savanna | 14:48 | |
| *** eanxgeek|log is now known as eanxgeek | 14:48 | |
| openstackgerrit | A change was merged to openstack/savanna: Fix swift data source credential validation https://review.openstack.org/72933 | 14:49 |
| *** themistymay has joined #savanna | 14:53 | |
| *** tmckay has left #savanna | 14:56 | |
| *** tmckay has joined #savanna | 14:56 | |
| *** rp__ has joined #savanna | 14:58 | |
| *** jmaron has quit IRC | 15:01 | |
| *** rp__ is now known as zerstoeren | 15:01 | |
| *** _nadya_ has joined #savanna | 15:14 | |
| *** jmaron has joined #savanna | 15:15 | |
| *** _nadya_ has quit IRC | 15:19 | |
| *** eanxgeek is now known as eanxgeek|log | 15:19 | |
| *** coolsvap has joined #savanna | 15:26 | |
| *** themistymay has quit IRC | 15:27 | |
| *** jmaron has quit IRC | 15:32 | |
| *** themistymay has joined #savanna | 15:33 | |
| *** jmaron has joined #savanna | 15:47 | |
| *** IvanBerezovskiy has left #savanna | 15:47 | |
| tmckay | SergeyLukjanov, ping, tempest question | 15:50 |
| openstackgerrit | Jonathan Maron proposed a change to openstack/savanna: Enable use of rootwrap for neutron private IP interactions https://review.openstack.org/73396 | 15:52 |
| *** aignatov is now known as aignatov_ | 15:54 | |
| *** NikitaKonovalov is now known as NikitaKonovalov_ | 15:59 | |
| SergeyLukjanov | tmckay, pong, gtg for 30-40 mins, short comments: I saw your email, cli patch will updated today | 16:01 |
| *** boris-42_ has quit IRC | 16:01 | |
| tmckay | SergeyLukjanov, okay. When you're available, I have a question about syncing client/api changes in projects with tempest tests | 16:02 |
| *** DinaBelova is now known as DinaBelova_ | 16:08 | |
| *** zerstoeren has quit IRC | 16:13 | |
| *** jmaron has quit IRC | 16:19 | |
| *** crobertsrh2 has joined #savanna | 16:48 | |
| *** DinaBelova_ is now known as DinaBelova | 17:02 | |
| *** tosky has quit IRC | 17:13 | |
| *** zerstoeren has joined #savanna | 17:19 | |
| *** akuznetsov has quit IRC | 17:26 | |
| openstackgerrit | A change was merged to openstack/savanna: Add support retrying rest call in IDH plugin https://review.openstack.org/69656 | 17:32 |
| *** zerstoeren has quit IRC | 17:33 | |
| *** _nadya_ has joined #savanna | 17:34 | |
| openstackgerrit | A change was merged to openstack/savanna: Fix cluster scaling in IDH plugin https://review.openstack.org/70452 | 17:37 |
| *** boris-42_ has joined #savanna | 17:40 | |
| *** akuznetsov has joined #savanna | 17:42 | |
| *** akuznetsov has quit IRC | 17:42 | |
| *** mattf is now known as _mattf | 17:44 | |
| *** akuznetsov has joined #savanna | 17:47 | |
| SergeyLukjanov | tmckay, I'm partially here | 17:48 |
| SergeyLukjanov | tmckay, what's up? | 17:48 |
| tmckay | SergeyLukjanov, thanks. A couple of questions | 17:49 |
| tmckay | SergeyLukjanov, first question, is it acceptable to use the python-savannaclient cli as the starting point for a scenario test, rather than the client itself? Since the "cli" test dir contains readonly ops, this is the only way to do real end-to-end testing of the cli in tempest | 17:50 |
| tmckay | I haven't seen an example of this, but no explicit objection either... | 17:50 |
| SergeyLukjanov | tmckay, in tempest scenarios tests are client-based | 17:51 |
| SergeyLukjanov | tmckay, anyway, we should test client itself, cli isn't so important as python bindigs | 17:51 |
| SergeyLukjanov | we're using python bindings in tests, dashboard and cli | 17:51 |
| SergeyLukjanov | so, it should be the high prio tested | 17:52 |
| SergeyLukjanov | and I'm sure that it's enough to have transformation tests for cli | 17:52 |
| SergeyLukjanov | unit tests that'll test how cli args converted to python bindings calls | 17:53 |
| tmckay | But there is still a gap. How do we know that the cli actually works, if there are not tests in savanna or tempest that start with the cli and do more than readonly operations? | 17:53 |
| tmckay | hmm, transformation tests are an interesting idea | 17:53 |
| SergeyLukjanov | unit tests will test correctness of cli args -> python bindings transforms | 17:53 |
| SergeyLukjanov | btw I've seen tons of projects with such approach | 17:54 |
| tmckay | so those unit tests would be based in savanna? (as opposed to tempest) | 17:54 |
| SergeyLukjanov | tmckay, it'll be based in client | 17:55 |
| SergeyLukjanov | tmckay, you can find examples in nova client | 17:55 |
| tmckay | SergeyLukjanov, right, okay, the python-savannaclient unit tests. | 17:55 |
| SergeyLukjanov | tmckay, exactly | 17:55 |
| tmckay | SergeyLukjanov, the second question is about syncing changes in tempest and api/client for a project | 17:55 |
| *** _mattf is now known as mattf | 17:56 | |
| tmckay | For instance, your patch currently is using plurals for plugins-list and plugins-show, and the requirements call out 0.4.1 | 17:56 |
| SergeyLukjanov | tmckay, for example, here is my change to python-novaclient where I'm adding new API feature support to client and CLI - https://review.openstack.org/#/c/31440 | 17:56 |
| SergeyLukjanov | tmckay, tempest runs tests for the client muster, that's why savanna job is failing | 17:56 |
| tmckay | but, running tempest from /opt/stack with the latest master branches for everything, those tests are out of date. they are now plugin-list and plugin-show | 17:57 |
| tmckay | yes | 17:57 |
| SergeyLukjanov | CLI should be stable after introducing tempest tests | 17:57 |
| SergeyLukjanov | it's usually implemented for stable API | 17:57 |
| *** akuznetsov has quit IRC | 17:57 | |
| SergeyLukjanov | so, CLI is stable enough due to the API stability | 17:57 |
| tmckay | ah. What if a change needs to be made? Do we strive for backward compatibility> | 17:58 |
| tmckay | ? | 17:58 |
| SergeyLukjanov | tmckay, I | 17:58 |
| SergeyLukjanov | I | 17:58 |
| SergeyLukjanov | oops :) | 17:58 |
| SergeyLukjanov | I'm not sure how it should be done | 17:58 |
| SergeyLukjanov | but that's how CLI tested in OpenStack | 17:59 |
| SergeyLukjanov | in tempest only bunch of very simple read-only tests | 17:59 |
| SergeyLukjanov | and everything else in unit tests of python-XXXclient | 17:59 |
| *** akuznetsov has joined #savanna | 18:00 | |
| tmckay | okay. So stability of the cli and the api is expected. If something *does* change, I imagine writing some kind of compat code would be the way to go. Or, everything has to be synced around a release milestone. | 18:01 |
| *** zerstoeren has joined #savanna | 18:01 | |
| SergeyLukjanov | tmckay, anyway, we'll have a small bunch of tests in tempest, so, I don't think that we'll have issues often | 18:02 |
| SergeyLukjanov | and if we'll have, we could add some conditional checks | 18:02 |
| SergeyLukjanov | and that's why I'd like to hold my CLI change right now - to stabilize CLI | 18:03 |
| SergeyLukjanov | for example, it looks like we should rename table headers for list/get ops | 18:03 |
| mattf | aignatov_, can i get a +2 on https://review.openstack.org/#/c/73111/ ? | 18:03 |
| SergeyLukjanov | to be consistent with other OpenStack CLIs | 18:03 |
| tmckay | SergeyLukjanov, when the tests run in the real tempest gate, does it pull from master or does it look for a released version? If it pulls from master, your work-in-progress CR should be failing too (but I haven't found the error message yet) | 18:06 |
| SergeyLukjanov | tmckay, it's working on master + CR | 18:06 |
| SergeyLukjanov | tmckay, and it's failing :) | 18:06 |
| tmckay | :) okay, thanks | 18:07 |
| mattf | SergeyLukjanov, lend a +A to https://review.openstack.org/#/c/73261/ ? | 18:07 |
| SergeyLukjanov | tmckay, check-tempest-dsvm-savanna-full-nv FAILURE in 48m 07s (non-voting) | 18:07 |
| SergeyLukjanov | tmckay, savanna is enabled only in jobs with name *savanna* | 18:07 |
| SergeyLukjanov | mattf, it depends on not-approved patch anyway | 18:07 |
| SergeyLukjanov | mattf, but I'll +A it :) | 18:08 |
| mattf | yeah, i'm still stuck on https://review.openstack.org/#/c/73010/4 | 18:09 |
| SergeyLukjanov | mattf, I'm advise to avoid such chains of absolutely independent changes - they could stuck on review for a while | 18:09 |
| tmckay | SergeyLukjanov, okay, I found the right log and the error. ;-) | 18:09 |
| mattf | i can't get it to break locally | 18:09 |
| mattf | SergeyLukjanov, yeah, i'm leaning my lesson this time around | 18:09 |
| SergeyLukjanov | mattf, re py27 fail, it looks very surprising | 18:11 |
| SergeyLukjanov | mattf, what's your feeling about CLI stability? | 18:11 |
| SergeyLukjanov | tmckay, ^^ | 18:11 |
| mattf | i've not been following, what's the question? | 18:15 |
| mattf | SergeyLukjanov, i'm coming up empty tr py27 fail... | 18:15 |
| SergeyLukjanov | mattf, the question is that I have a patch with CLI base/tests for tempest, but we should be sure that we'll break it in the nearest future to avoid pain with updating tempest on the go | 18:16 |
| SergeyLukjanov | mattf, it'll contain only read-only very simple checks | 18:17 |
| mattf | issue is how do we update the cli & tempest at the same time if they are in separate repos? | 18:17 |
| SergeyLukjanov | mattf, I'll try to take a look on your py27 fail today night/tomorrow | 18:17 |
| SergeyLukjanov | mattf, yup, but it's quite synthetic issue because we should add tests when we feel API and CLI stable | 18:18 |
| SergeyLukjanov | mattf, tmckay, I'll try to research how other projects dealing with it | 18:19 |
| mattf | the cli should be at a the point of a v1.0 | 18:19 |
| mattf | there's a proposed change to guess --name or --id, but that could be done in a backward compat way, so v1.1 | 18:20 |
| SergeyLukjanov | mattf, yup | 18:20 |
| SergeyLukjanov | mattf, and headers should be update | 18:20 |
| SergeyLukjanov | mattf, like Name vs. name to be consistent with other CLIs | 18:21 |
| mattf | Name vs name ? | 18:21 |
| mattf | oh, table headers? | 18:22 |
| SergeyLukjanov | yup | 18:22 |
| mattf | imho table headers are case-insensitive | 18:22 |
| SergeyLukjanov | i've missed the 'table' word :) | 18:22 |
| SergeyLukjanov | but it's inconsistent with all other clients, so, should be polished | 18:22 |
| mattf | i immediately thought #include <error> and was sad | 18:22 |
| mattf | we can certainly poliish it. | 18:23 |
| mattf | as a general rule, we should not be facilitating screen-scraping w/ the cli | 18:23 |
| openstackgerrit | A change was merged to openstack/savanna: Enable HDP 2 deployment leveraging HDP plugin https://review.openstack.org/71967 | 18:24 |
| SergeyLukjanov | mattf, I'll finalize tempest patch today, to just have a base and then when we'll be ready ask folks to review | 18:24 |
| mattf | i.e. if you write savanna plugin-list | grep name and get nothing in the future because we changed it to Name, the response should be "don't do that, use the client" | 18:24 |
| SergeyLukjanov | mattf, cli isn't release yet | 18:24 |
| SergeyLukjanov | and use grep -i always :) | 18:24 |
| mattf | cli != api | 18:25 |
| mattf | though i'm guilty of using cli's as apis | 18:25 |
| mattf | expectations just need to be set appropriately = | 18:25 |
| SergeyLukjanov | mattf, due to the fact that savanna is part of openstack expectation is to be consistent with other projects | 18:26 |
| mattf | do other project support the cli as an api? | 18:27 |
| SergeyLukjanov | mattf, what 'support' does you mean? | 18:27 |
| *** zerstoeren has quit IRC | 18:27 | |
| mattf | community support where you'd provide a deprecation path w/ backward compatibility for "grep name" when "grep Name" would work | 18:28 |
| mattf | there shouldn't be a deprecation path for something like name vs Name in a table header, or ' id |' vs ' id |' for that matter | 18:29 |
| mattf | if you're using the cli as an api you're either doing it wrong or you're assuming the responsibility if things break. the community isn't "supporting" it. | 18:29 |
| SergeyLukjanov | mattf, I don't think that CLI is something so important to worry about such stuff | 18:30 |
| SergeyLukjanov | and I think that python bindings should be always used for any automationg | 18:30 |
| SergeyLukjanov | anyway we could agree on one of the approaches and follow it | 18:31 |
| mattf | so we're in agreement about the "and i think" | 18:31 |
| SergeyLukjanov | yup | 18:31 |
| mattf | no matter how important we think the cli is, people will try to use it as an api. we need to set expectations properly there, or we'll end up with upset users | 18:31 |
| mattf | or worse, we'll be stuck not being able to change the cli because it would break users | 18:31 |
| mattf | how is this related to your topic of the header appearing upper or lower case for human eyes to consume? i agree we should be visually consistent, but we should avoid locking ourselves into a particular expected output for the cli | 18:33 |
| SergeyLukjanov | oh, I found that keystone and neutron are using lower case table headers | 18:33 |
| SergeyLukjanov | heh, so, there's already no consistency in CLIs :( | 18:34 |
| SergeyLukjanov | so, I'm ok with both approaches | 18:34 |
| mattf | cli tests could be non-voting. maybe we want to just delete 'plugin-list' in the future? | 18:34 |
| * mattf shakes fist at py27 | 18:34 | |
| SergeyLukjanov | mattf, I think that when we'd like to move our CLI to the next API version, we could just add the second bunch of API tests | 18:35 |
| mattf | i need a better workflow for managing one-off changes | 18:35 |
| SergeyLukjanov | mattf, I'm using branches for all change | 18:35 |
| mattf | at the end of the day i want our cli to work, i want it to be free to change, but i don't want anyone to ever open a bug that says "hey, you changed the cli output" | 18:36 |
| SergeyLukjanov | git fetch gerrit && git checkout -b super_mega_hack gerrit/master | 18:36 |
| SergeyLukjanov | mattf, sounds very nice :) | 18:36 |
| * mattf lives in a dreamworld sometimes | 18:37 | |
| mattf | imho, if you want the cli to be an api, then you provide functions that let the user format the output | 18:37 |
| mattf | i think keystone (or was it neutron) are starting to do that | 18:38 |
| mattf | e.g. savanna plugin-list --format "%s,%s" name,version | 18:38 |
| mattf | then i can parse vanilla,1.2.1 in a repeatable fashion | 18:38 |
| mattf | that's all cli v2 or v3 imho | 18:39 |
| *** _nadya_ has quit IRC | 18:39 | |
| SergeyLukjanov | sounds nice | 18:41 |
| SergeyLukjanov | currently, I just would like to be sure that our current read-only CLI will be quite stable and add simple tests for them to tempest | 18:42 |
| *** themistymay has quit IRC | 18:43 | |
| *** aignatov_ is now known as aignatov | 18:48 | |
| *** openstackgerrit has quit IRC | 18:53 | |
| *** openstackgerrit has joined #savanna | 18:54 | |
| openstackgerrit | Matthew Farrellee proposed a change to openstack/savanna: Add run_test.sh for running tests https://review.openstack.org/72948 | 18:58 |
| mattf | ok, restructured all my reviews | 18:59 |
| mattf | aignatov, SergeyLukjanov, if you can +A https://review.openstack.org/#/c/72948/ it'll get me unstuck | 18:59 |
| aignatov | ok, +2 | 19:00 |
| aignatov | :-) | 19:00 |
| SergeyLukjanov | mattf, you should rebase all dependent patches too | 19:00 |
| SergeyLukjanov | mattf, because they have outdated commit id in parants | 19:00 |
| * mattf now has master + master-[0-4] | 19:01 | |
| mattf | that's in progress | 19:01 |
| SergeyLukjanov | it could be done in UI | 19:01 |
| SergeyLukjanov | by the rebase button | 19:01 |
| SergeyLukjanov | or you'd like to split the chain completely? | 19:01 |
| SergeyLukjanov | btw in gerrit 2.8 you can rebase changes in UI to the specified refs | 19:02 |
| mattf | they all depend on that run_tests.sh, because i use run_tests.sh to verify them | 19:02 |
| * mattf clings to his cli | 19:02 | |
| openstackgerrit | Matthew Farrellee proposed a change to openstack/savanna: Expand swift data source credential tests https://review.openstack.org/73010 | 19:02 |
| mattf | i split the chain "complete" (sans the run_tests.sh) | 19:02 |
| openstackgerrit | Matthew Farrellee proposed a change to openstack/savanna: Shorten swift-internal:// to swift:// https://review.openstack.org/73261 | 19:03 |
| openstackgerrit | Matthew Farrellee proposed a change to openstack/savanna: Delete 'links' only if it is present https://review.openstack.org/73836 | 19:03 |
| openstackgerrit | Matthew Farrellee proposed a change to openstack/savanna: Expand node-group-template usage validation msg https://review.openstack.org/73888 | 19:04 |
| SergeyLukjanov | mattf, I'll approve the patches with 2x+2 and 2x+1V | 19:05 |
| *** aignatov is now known as aignatov_ | 19:07 | |
| *** jcooley_ has joined #savanna | 19:15 | |
| openstackgerrit | Sergey Lukjanov proposed a change to openstack/savanna: Auto generate and check config sample https://review.openstack.org/73053 | 19:37 |
| openstackgerrit | Sergey Lukjanov proposed a change to openstack/savanna: Standardize config sample locations https://review.openstack.org/73052 | 19:37 |
| openstackgerrit | Sergey Lukjanov proposed a change to openstack/savanna: Fix how migration's cli register db connection opt https://review.openstack.org/73051 | 19:37 |
| *** aignatov_ is now known as aignatov | 19:38 | |
| *** _nadya_ has joined #savanna | 19:38 | |
| SergeyLukjanov | mattf, please, take a look on https://review.openstack.org/#/c/73051/ and https://review.openstack.org/#/c/73052/ | 19:38 |
| SergeyLukjanov | aignatov, please, take a look at https://review.openstack.org/#/c/73052/ | 19:38 |
| *** aignatov is now known as aignatov_ | 19:42 | |
| *** _nadya_ has quit IRC | 19:52 | |
| openstackgerrit | Sergey Reshetnyak proposed a change to openstack/savanna: Add ability to support several versions vanilla plugin https://review.openstack.org/74145 | 20:11 |
| *** witlessb has quit IRC | 20:13 | |
| *** witlessb has joined #savanna | 20:13 | |
| *** jcooley_ has quit IRC | 20:25 | |
| *** akuznetsov has quit IRC | 20:29 | |
| *** witlessb has quit IRC | 20:29 | |
| *** mattf is now known as _mattf | 20:31 | |
| *** aignatov_ is now known as aignatov | 20:48 | |
| *** DinaBelova is now known as DinaBelova_ | 20:54 | |
| openstackgerrit | A change was merged to openstack/savanna: Add run_test.sh for running tests https://review.openstack.org/72948 | 20:56 |
| *** _mattf is now known as mattf | 21:04 | |
| *** coolsvap has quit IRC | 21:44 | |
| mattf | aignatov, SergeyLukjanov, quick before ci decides otherwise +A https://review.openstack.org/#/c/73010/ | 21:48 |
| mattf | tho, i guess we have to get lucky twice in a row for it to actually go through | 21:48 |
| * mattf shakes fist at ghost in the py27 | 21:48 | |
| SergeyLukjanov | mattf, it's already +2'ed by me | 21:48 |
| mattf | danke | 21:50 |
| * mattf learns spasibo | 21:52 | |
| *** jmaron has joined #savanna | 21:59 | |
| SergeyLukjanov | mattf, :) | 22:03 |
| *** aignatov is now known as aignatov_ | 22:10 | |
| openstackgerrit | Sergey Lukjanov proposed a change to openstack/python-savannaclient: Make the single entrypoint for client https://review.openstack.org/74184 | 22:34 |
| openstackgerrit | A change was merged to openstack/savanna: Shorten swift-internal:// to swift:// https://review.openstack.org/73261 | 22:34 |
| *** jmaron has quit IRC | 22:49 | |
| *** tmckay is now known as _tmckay | 23:14 | |
| openstackgerrit | A change was merged to openstack/savanna: Delete 'links' only if it is present https://review.openstack.org/73836 | 23:27 |
| *** jcooley_ has joined #savanna | 23:37 | |
| *** mattf is now known as _mattf | 23:55 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!