| *** witlessb has quit IRC | 00:10 | |
| *** witlessb has joined #savanna | 00:11 | |
| *** matsuhashi has joined #savanna | 00:25 | |
| openstackgerrit | Andrew Lazarev proposed a change to openstack/savanna: [DOC] Fixed link to oozie in docs https://review.openstack.org/71169 | 00:46 |
|---|---|---|
| *** nosnos has joined #savanna | 00:57 | |
| *** mst89 has quit IRC | 00:57 | |
| *** nosnos has quit IRC | 01:01 | |
| *** nosnos has joined #savanna | 01:01 | |
| openstackgerrit | Andrew Lazarev proposed a change to openstack/python-savannaclient: Changed base Resource class to prevent changing of passed arguments https://review.openstack.org/71086 | 02:19 |
| *** crobertsrh has joined #savanna | 04:00 | |
| *** crobertsrh is now known as _crobertsrh | 04:02 | |
| *** ylobankov1 has quit IRC | 04:22 | |
| *** ylobankov has joined #savanna | 04:23 | |
| *** IlyaE has joined #savanna | 04:28 | |
| *** IlyaE has quit IRC | 04:52 | |
| *** akuznetsov has joined #savanna | 04:56 | |
| *** jcooley_ has quit IRC | 05:19 | |
| *** IlyaE has joined #savanna | 05:23 | |
| *** jcooley_ has joined #savanna | 05:48 | |
| openstackgerrit | Jenkins proposed a change to openstack/savanna: Imported Translations from Transifex https://review.openstack.org/70918 | 06:09 |
| *** jcooley_ has quit IRC | 07:12 | |
| *** jcooley_ has joined #savanna | 07:12 | |
| *** jcooley_ has quit IRC | 07:17 | |
| *** DinaBelova_ is now known as DinaBelova | 07:19 | |
| *** IlyaE has quit IRC | 07:27 | |
| *** dmitryme has joined #savanna | 08:25 | |
| *** akuznetsov has quit IRC | 08:28 | |
| *** akuznetsov has joined #savanna | 08:31 | |
| *** dmitryme has quit IRC | 08:46 | |
| *** dmitryme has joined #savanna | 08:52 | |
| *** matsuhashi has quit IRC | 08:54 | |
| *** matsuhashi has joined #savanna | 08:55 | |
| *** aignatov_ is now known as aignatov | 08:59 | |
| *** aignatov is now known as aignatov_ | 09:02 | |
| *** ylobankov has left #savanna | 09:02 | |
| *** ylobankov has joined #savanna | 09:07 | |
| *** aignatov_ is now known as aignatov | 09:10 | |
| *** skolekonov has joined #savanna | 09:28 | |
| openstackgerrit | A change was merged to openstack/savanna: Fixed HDP plugin to support Heat engine https://review.openstack.org/70076 | 09:34 |
| *** aignatov is now known as aignatov_ | 10:25 | |
| *** nosnos has quit IRC | 10:53 | |
| *** aignatov_ is now known as aignatov | 11:14 | |
| openstackgerrit | Daniele Venzano proposed a change to openstack/savanna-image-elements: Add a Spark element https://review.openstack.org/71237 | 11:24 |
| *** dmitryme has quit IRC | 11:45 | |
| openstackgerrit | Sergey Reshetnyak proposed a change to openstack/savanna: Add integration tests to Intel plugin https://review.openstack.org/66812 | 11:50 |
| openstackgerrit | Sergey Reshetnyak proposed a change to openstack/savanna: Add configuration integration test for IDH plugin https://review.openstack.org/70819 | 11:53 |
| *** ruhe has joined #savanna | 11:59 | |
| openstackgerrit | Sergey Reshetnyak proposed a change to openstack/savanna: Add configuration integration test for IDH plugin https://review.openstack.org/70819 | 12:04 |
| *** ruhe is now known as ruhe_ | 12:06 | |
| *** ruhe_ is now known as ruhe | 12:06 | |
| *** dmitryme has joined #savanna | 12:11 | |
| *** IvanBerezovskiy has joined #savanna | 12:26 | |
| *** dmitryme has quit IRC | 12:41 | |
| *** ruhe is now known as ruhe_ | 12:44 | |
| *** ruhe_ has quit IRC | 12:48 | |
| *** qwerty_nor has joined #savanna | 13:01 | |
| openstackgerrit | Nikita Konovalov proposed a change to openstack/savanna: Moving rest to Pecan/WSME framework https://review.openstack.org/63908 | 13:02 |
| mattf | SergeyLukjanov, why is there still a -2 on the api discussion? | 13:03 |
| *** ylobankov has left #savanna | 13:03 | |
| *** ylobankov1 has joined #savanna | 13:03 | |
| *** ylobankov1 has quit IRC | 13:03 | |
| *** ylobankov1 has joined #savanna | 13:04 | |
| *** ylobankov1 has left #savanna | 13:06 | |
| *** ylobankov_ has joined #savanna | 13:06 | |
| *** dmitryme has joined #savanna | 13:10 | |
| SergeyLukjanov | mattf, please, add note to the commit message that it's for discussion | 13:11 |
| *** dmitryme has joined #savanna | 13:13 | |
| mattf | SergeyLukjanov, it's in the commit message | 13:14 |
| SergeyLukjanov | mattf, are you expecting to merge this change? | 13:15 |
| SergeyLukjanov | mattf, additionally you can take a look on Pecan patch from Nikita | 13:17 |
| NikitaKonovalov | mattf, hi | 13:19 |
| NikitaKonovalov | I've just sent a CR with initial Pecan/WSME framework setup | 13:20 |
| NikitaKonovalov | it still handles v1 requests | 13:20 |
| *** ruhe has joined #savanna | 13:22 | |
| NikitaKonovalov | think it will take a few days to match all the functionality from v1 using Pecan, because it requires some hacks to handle our config dictionaries | 13:26 |
| SergeyLukjanov | NikitaKonovalov, let's split it to the Pecan/WSME initial work with one example endpoint like Plugins that you already added | 13:28 |
| SergeyLukjanov | and some additional commits like additional WSME models definitions | 13:28 |
| SergeyLukjanov | and etc. | 13:28 |
| SergeyLukjanov | I think mattf will add all other endpoints | 13:29 |
| NikitaKonovalov | the missing thing right now is auth token check | 13:29 |
| NikitaKonovalov | there are two possible ways to handle that in Pecan: with hooks and @secure decorator | 13:30 |
| NikitaKonovalov | I'm trying to figure which one is better right now | 13:30 |
| ruhe | don't forget about tests, it's not that easy to build testing infrastructure with Pecan+SQLAlchemy+Alembic infrastructure | 13:30 |
| NikitaKonovalov | v1 api is checked only through integration tests, right? | 13:32 |
| NikitaKonovalov | if so, then nothing should breake, because v1 is still served with Flask | 13:32 |
| SergeyLukjanov | there is no need to add tests for v1 now | 13:39 |
| SergeyLukjanov | and tests for v2 could be added later | 13:39 |
| *** ruhe is now known as ruhe_ | 13:46 | |
| mattf | SergeyLukjanov, depends on if pecan is in a state for prototyping | 13:54 |
| mattf | NikitaKonovalov, hello! | 13:54 |
| *** ruhe_ is now known as ruhe | 13:54 | |
| *** ruhe has quit IRC | 13:54 | |
| mattf | NikitaKonovalov, what's the complexity that ruhe mentioned? | 13:55 |
| SergeyLukjanov | mattf, it was about writing functional tests (not integration) for REST API | 13:56 |
| mattf | is it somehow more difficult w/ pecan than it was w/ flask? | 13:56 |
| SergeyLukjanov | mattf, we're not doing it w/ Flask | 13:57 |
| mattf | NikitaKonovalov, i'll take a look at your first commit for pecan today | 13:57 |
| mattf | SergeyLukjanov, sure, but is it somehow harder to do w/ pecan? | 13:57 |
| NikitaKonovalov | no dfference here, the challenge is to make tests work with different a different database each | 13:57 |
| SergeyLukjanov | mattf, it's difficult because we have rest api framework, sqla and alembic | 13:58 |
| mattf | because if the difficult is the same, pointing out the complexity w/ pecan is distracting | 13:58 |
| mattf | s/difficult/difficulty/ | 13:58 |
| SergeyLukjanov | mattf, it's the same | 13:58 |
| SergeyLukjanov | I think that ruhe mentioned it to help make the correct extimates | 13:58 |
| SergeyLukjanov | because we'd like to functional testing v2 api | 13:59 |
| SergeyLukjanov | so, I'd like to land initial impl of Pecan/WSME support with one simple endpoint like Plugins // when it'll be reviewed and ready | 13:59 |
| NikitaKonovalov | the solution btw is using the config fixture from oslo | 13:59 |
| SergeyLukjanov | it'll unblock mattf to start working on other enpodints | 14:00 |
| SergeyLukjanov | endpoits* | 14:00 |
| SergeyLukjanov | and we could work in parallel on other improvements like functinonal tests and decoupling from v1 api | 14:00 |
| SergeyLukjanov | functional* | 14:00 |
| *** tmckay has quit IRC | 14:11 | |
| *** dmitryme has quit IRC | 14:26 | |
| *** dmitryme has joined #savanna | 14:27 | |
| openstackgerrit | Nikita Konovalov proposed a change to openstack/savanna: Moving rest to Pecan/WSME framework https://review.openstack.org/63908 | 14:31 |
| *** ruhe has joined #savanna | 14:35 | |
| *** ruhe is now known as ruhe_ | 14:46 | |
| *** ruhe_ is now known as ruhe | 14:49 | |
| *** aignatov is now known as aignatov_ | 14:49 | |
| *** skolekonov has quit IRC | 14:50 | |
| *** aignatov_ is now known as aignatov | 14:53 | |
| *** ruhe is now known as ruhe_ | 14:53 | |
| *** ruhe_ is now known as ruhe | 14:53 | |
| *** NikitaKonovalov is now known as NikitaKonovalov_ | 15:01 | |
| *** ruhe is now known as ruhe_ | 15:01 | |
| *** ruhe_ is now known as ruhe | 15:05 | |
| *** ruhe is now known as ruhe_ | 15:07 | |
| *** ruhe_ is now known as ruhe | 15:09 | |
| SergeyLukjanov | tmckay, aignatov | 15:10 |
| SergeyLukjanov | https://blueprints.launchpad.net/savanna/+spec/benchmarking-from-horizon | 15:10 |
| SergeyLukjanov | any thoughts? | 15:10 |
| mattf | SergeyLukjanov, sounds pretty good. i'm not too keen on debugging pecan itself though. the plugin example needs to be functional. | 15:12 |
| aignatov | SergeyLukjanov: interesting idea, but I see huge efforts on that because we need to do some research etc before implementing | 15:13 |
| aignatov | propose to add as track to next design summit :) | 15:14 |
| aignatov | anyway this will not be landed in icehouse | 15:14 |
| SergeyLukjanov | mattf, sure, it should at least work and probably we'll need one more endpoint to demonstrate all Pecan/WSME usage details | 15:14 |
| SergeyLukjanov | aignatov, yup | 15:14 |
| SergeyLukjanov | aignatov, please add comments to the bp | 15:14 |
| aignatov | also, OS contains Rally project targeted for benchmarking all components | 15:15 |
| *** tmckay has joined #savanna | 15:15 | |
| mattf | aignatov, it should be possible to run hibench from the savanna api. he can always demonstrate how it works and then push for inclusion in the dashboard, if there's actually anything to include | 15:16 |
| mattf | it might just be a set of steps "upload xyz to swift, make job binary spq, run job abc" | 15:16 |
| ruhe | also, Boris (lead of the Rally) offered his help to include performance tests for Savanna to Rally | 15:16 |
| *** matsuhashi has quit IRC | 15:17 | |
| *** matsuhashi has joined #savanna | 15:18 | |
| *** IlyaE has joined #savanna | 15:24 | |
| *** ruhe is now known as ruhe_ | 15:27 | |
| *** aignatov is now known as aignatov_ | 15:28 | |
| *** ruhe_ has quit IRC | 15:32 | |
| *** matsuhashi has quit IRC | 15:34 | |
| openstackgerrit | Trevor McKay proposed a change to openstack/savanna: Extract configs beginning with "edp." from job_configs['configs'] https://review.openstack.org/69712 | 15:49 |
| openstackgerrit | Trevor McKay proposed a change to openstack/savanna: Generate streaming tag in mapreduce job https://review.openstack.org/69727 | 15:49 |
| openstackgerrit | Trevor McKay proposed a change to openstack/savanna: Add validation check for streaming elements on MapReduce without libs https://review.openstack.org/69960 | 15:50 |
| *** DinaBelova is now known as DinaBelova_ | 15:53 | |
| *** NikitaKonovalov_ is now known as NikitaKonovalov | 16:01 | |
| witlessb | _crobertsrh: howdy | 16:03 |
| witlessb | found the issue with devstack -- one has to list 's-proxy' explicitly in ENABLED_SERVICES | 16:04 |
| witlessb | in localrc | 16:04 |
| witlessb | otherwise glance-swift account doesn't get created in keystone | 16:05 |
| witlessb | with a bunch of problems after that | 16:06 |
| openstackgerrit | Trevor McKay proposed a change to openstack/savanna: Add integration test for streaming mapreduce https://review.openstack.org/70829 | 16:06 |
| openstackgerrit | Trevor McKay proposed a change to openstack/savanna: Add integration test for streaming mapreduce https://review.openstack.org/70829 | 16:08 |
| *** IvanBerezovskiy has left #savanna | 16:09 | |
| *** NikitaKonovalov is now known as NikitaKonovalov_ | 16:18 | |
| *** jcooley_ has joined #savanna | 16:21 | |
| *** venza_ has quit IRC | 16:22 | |
| *** venza has joined #savanna | 16:24 | |
| *** DinaBelova_ is now known as DinaBelova | 16:26 | |
| *** jcooley_ has quit IRC | 16:28 | |
| *** jcooley_ has joined #savanna | 16:33 | |
| openstackgerrit | Trevor McKay proposed a change to openstack/savanna: Move 'main_class' and 'java_opts' into edp.java configs https://review.openstack.org/69982 | 16:40 |
| *** _crobertsrh is now known as crobertsrh | 16:41 | |
| crobertsrh | witlessb: glad you got it figured out! | 16:42 |
| witlessb | that makes two us | 16:42 |
| witlessb | filed a bug report, we'll see what they'll say | 16:42 |
| openstackgerrit | Trevor McKay proposed a change to openstack/savanna: Move 'main_class' and 'java_opts' into edp.java configs https://review.openstack.org/69982 | 16:43 |
| witlessb | crobertsrh: ahh. | 16:44 |
| witlessb | crobertsrh: on this page: https://savanna.readthedocs.org/en/latest/devref/devstack.html | 16:44 |
| witlessb | in the section about localrc, it's probably worth to remove swift | 16:44 |
| witlessb | from ENABLED_SERVICES alltogether? | 16:45 |
| crobertsrh | I actually use swift, savanna also allows for using swift. Not necessarily required, but supported. | 16:45 |
| witlessb | ahh | 16:45 |
| witlessb | sry, I shouldn't have presumed | 16:45 |
| witlessb | then it's probably worth adding s-proxy to that list | 16:46 |
| crobertsrh | Yeah, if that's what saved the day for you, it might be useful. I don't think I've had to have s-proxy in the past, but it's been awhile since I have grabbed the latest and started up a new stack. | 16:47 |
| witlessb | nods; that's what did the trick | 16:47 |
| witlessb | I'm not sure what would be preferred way to fix the issue, as the devstack team seems to be moving away from account creation using files/keystone_data.sh | 16:48 |
| crobertsrh | Hopefully, they will comment on your bug report soon. | 16:50 |
| witlessb | nods | 16:50 |
| witlessb | I'll keep my eye on it | 16:50 |
| *** bogdando has quit IRC | 17:11 | |
| *** jcooley_ has quit IRC | 17:22 | |
| *** jcooley_ has joined #savanna | 17:23 | |
| *** jcooley_ has quit IRC | 17:34 | |
| *** jcooley_ has joined #savanna | 17:34 | |
| *** jcooley_ has quit IRC | 17:41 | |
| *** jcooley_ has joined #savanna | 17:42 | |
| *** dmitryme has quit IRC | 17:45 | |
| openstackgerrit | Andrew Lazarev proposed a change to openstack/savanna: Refactored unit tests structure https://review.openstack.org/70211 | 17:46 |
| *** aignatov_ is now known as aignatov | 17:57 | |
| *** akuznetsov has quit IRC | 17:58 | |
| *** nadya has joined #savanna | 18:00 | |
| *** nadya is now known as Guest83863 | 18:01 | |
| *** IlyaE has quit IRC | 18:19 | |
| *** jcooley_ has quit IRC | 18:19 | |
| *** jcooley_ has joined #savanna | 18:21 | |
| *** jcooley_ has quit IRC | 18:23 | |
| *** jcooley_ has joined #savanna | 18:23 | |
| *** aignatov is now known as aignatov_ | 18:24 | |
| *** aignatov_ is now known as aignatov | 18:30 | |
| *** IlyaE has joined #savanna | 18:38 | |
| *** mst89 has joined #savanna | 18:39 | |
| *** IlyaE has quit IRC | 18:40 | |
| *** Guest83863 is now known as _nadya_ | 18:41 | |
| *** akuznetsov has joined #savanna | 18:43 | |
| *** aignatov is now known as aignatov_ | 18:46 | |
| *** IlyaE has joined #savanna | 18:48 | |
| *** _nadya_ has quit IRC | 18:49 | |
| tmckay | crobertsrh, btw, it looks like we are going to go with dotted type names (MapReduce.Streaming) | 18:52 |
| crobertsrh | Ok, that works just fine for me. | 18:52 |
| tmckay | crobertsrh, I'm going to start working on that as soon as I get my rebase damage sorted out on java jobs. Almost done | 18:53 |
| *** dmitryme has joined #savanna | 18:53 | |
| crobertsrh | Ok, I'll start my tentative UI tweaks. | 18:53 |
| tmckay | hot darn, it works again | 18:58 |
| openstackgerrit | Trevor McKay proposed a change to openstack/savanna: Move 'main_class' and 'java_opts' into edp.java configs https://review.openstack.org/69982 | 19:01 |
| *** jcooley_ has quit IRC | 19:07 | |
| *** jcooley_ has joined #savanna | 19:08 | |
| *** dmitryme has quit IRC | 19:22 | |
| *** mst89 has quit IRC | 19:27 | |
| *** mst89 has joined #savanna | 19:36 | |
| *** akuznetsov has quit IRC | 19:43 | |
| openstackgerrit | Sergey Lukjanov proposed a change to openstack/savanna-dashboard: Sync with global-requirements https://review.openstack.org/71355 | 19:44 |
| openstackgerrit | Sergey Lukjanov proposed a change to openstack/savanna: Sync with global-requirements https://review.openstack.org/71356 | 19:44 |
| openstackgerrit | A change was merged to openstack/savanna: [DOC] Fixed link to oozie in docs https://review.openstack.org/71169 | 19:54 |
| *** mattf is now known as _mattf | 20:18 | |
| *** _mattf is now known as mattf | 20:19 | |
| *** IlyaE has quit IRC | 20:20 | |
| *** DinaBelova is now known as DinaBelova_ | 21:09 | |
| openstackgerrit | Chad Roberts proposed a change to openstack/savanna-dashboard: Adding floating ip pool to node groups details for cluster https://review.openstack.org/71381 | 21:19 |
| mattf | SergeyLukjanov, ping | 21:23 |
| SergeyLukjanov | mattf, pong | 21:23 |
| SergeyLukjanov | mattf, I'm agreed with mostly all of your blueprints about not merging them except cli-itests | 21:24 |
| mattf | i just found myself under a bunch of bp email | 21:24 |
| mattf | i need some help understanding what yuo just did | 21:24 |
| SergeyLukjanov | mattf, all cli integration tests bps was reject, all other accepted | 21:24 |
| mattf | did you just say that it's not important to have integration tests for a bunch of use cases? | 21:24 |
| SergeyLukjanov | probably I missed several more bps | 21:24 |
| SergeyLukjanov | mattf, it should not be tested for cli | 21:25 |
| SergeyLukjanov | mattf, the common way of testing cli is to test how it transforms cli args to api calls or python client calls | 21:25 |
| SergeyLukjanov | mattf, we should have unit tests for client that will check how we generates jsons | 21:26 |
| mattf | for functional or unit tests, yeah. the bps are about integration tests | 21:26 |
| mattf | you don't feel there should be integration tests that work through the cli? | 21:26 |
| mattf | my phrasing may be betraying my opinion | 21:26 |
| mattf | integration tests don't substitute for the other tests you mention, but they also shouldn't be skipped | 21:27 |
| SergeyLukjanov | mattf, yup, cli just a wrapper and could be tested separately | 21:27 |
| *** IlyaE has joined #savanna | 21:27 | |
| mattf | i'm definitely puzzled by the position that adding new integration tests should not be done | 21:28 |
| SergeyLukjanov | they should be added but in other place | 21:28 |
| SergeyLukjanov | let me explain why | 21:28 |
| SergeyLukjanov | let's start from which minimal set of tests we already have and must have | 21:28 |
| SergeyLukjanov | 1) integration tests for all functionality using python client (we already have a bunch of them in savanna repo) | 21:29 |
| mattf | map maybe? user -magic-> cli -python-> client -rest-> savanna-api -> * | 21:30 |
| SergeyLukjanov | 1) == scenarios tests | 21:30 |
| SergeyLukjanov | 2) functional tests for API (in future) that will test mocked world but check how API works fast | 21:31 |
| SergeyLukjanov | why we don't need massive integration tests for cli | 21:31 |
| SergeyLukjanov | because we're using python bindings in many places | 21:31 |
| SergeyLukjanov | cli, horizon, heat | 21:32 |
| SergeyLukjanov | in integration test too | 21:32 |
| SergeyLukjanov | and there is no need to duplicate all of the integration tests from python bindings to cli | 21:32 |
| SergeyLukjanov | we can just unit test that cli correctly transforms cli arguments to python bindings calls | 21:32 |
| mattf | what does it harm? | 21:33 |
| SergeyLukjanov | you can take a look on nova client tests | 21:33 |
| SergeyLukjanov | mattf, IMO integration tests for cli are useless because they will duplicate other integration tests | 21:33 |
| SergeyLukjanov | at least we'll never run them to not duplicate resources usage | 21:34 |
| mattf | i'll argue that we should have integration tests for the dashboard too | 21:34 |
| mattf | the concern is time that the test suite will take to run? | 21:34 |
| SergeyLukjanov | mattf, yup | 21:35 |
| SergeyLukjanov | mattf, because it could be replaced with a fast unit tests | 21:35 |
| mattf | dashboard testing w/ selenium or something similar has value too | 21:35 |
| SergeyLukjanov | mattf, exactly, the reason of writing real tests w/o mocks for horizon is that we don't understand how to correctly mock all the world :( | 21:35 |
| mattf | oh, there's much more you get by using the real world vs mocks | 21:36 |
| mattf | mocks are a narrow snapshot of things understood by a few people and not likely to have real-world issues | 21:36 |
| mattf | they serve a great purpose, but leave quality gaps | 21:37 |
| SergeyLukjanov | mattf, it makes sense for UI that is the end-user part | 21:37 |
| mattf | i can look into getting more hardware to speed things up so we can have more complete test coverage. that's a no brainer $$$ ask. | 21:37 |
| SergeyLukjanov | mattf, there are no strong objections for duplicate integration tests for CLI | 21:38 |
| SergeyLukjanov | not now | 21:38 |
| mattf | cli+ui imho | 21:38 |
| mattf | i was just lazy and had the cli on my mind, so filed re cli | 21:38 |
| SergeyLukjanov | in future we could write main tests in such manner that http calls could be duplicated by cli analogues | 21:38 |
| mattf | i don't understand "duplicated by cli analogues" | 21:39 |
| * mattf may need lunch | 21:40 | |
| SergeyLukjanov | if you'll look at savanna integration tests | 21:40 |
| SergeyLukjanov | you'll find that in fact by replacing http calls with cli calls you will have cli tests | 21:40 |
| SergeyLukjanov | btw I'm still on position that cli integration tests currently absolutely useless, only cli args to python bindings calls transformations should be checked | 21:41 |
| SergeyLukjanov | we could return back to the integrate-test-the-world-through-cli after all other test will be finished | 21:41 |
| mattf | i'm of the opinion that if someone is going to expand our integration test coverage we should be happy. if it may slow things down we prioritize runs or get more hardware. | 21:42 |
| SergeyLukjanov | heh, missed one more big fact - all OpenStack projects following the same approach | 21:42 |
| openstackgerrit | Trevor McKay proposed a change to openstack/savanna: Add utilities for supporting dotted job types https://review.openstack.org/71387 | 21:42 |
| SergeyLukjanov | mattf, it should be expanded in other places | 21:42 |
| mattf | you know what i'm gonna say! | 21:43 |
| mattf | file some bps w/ your ideas on what's missing | 21:43 |
| * mattf smiles | 21:43 | |
| openstackgerrit | Trevor McKay proposed a change to openstack/savanna: Add utilities for supporting dotted job types https://review.openstack.org/71387 | 21:44 |
| tmckay | forgot the unit test, heh | 21:44 |
| mattf | thanks for going over all those bps. i need to run to a meeting (why a 5pm meeting!?). i'll ask about hardware $$$ too. | 21:44 |
| SergeyLukjanov | mattf, heh, it's 1:44 am here ;) | 21:44 |
| mattf | yeah, why are you still up! | 21:45 |
| SergeyLukjanov | mattf, to talk with you about your bps ;) | 21:45 |
| * mattf is dreadfully sorry then | 21:45 | |
| SergeyLukjanov | mattf, np, it should be discussed and I was like to explain my ops | 21:46 |
| mattf | btw, new name suggestion: super awesome sauce | 21:46 |
| tmckay | sas | 21:46 |
| mattf | SergeyLukjanov, i'll be up early tomorrow too | 21:47 |
| tmckay | sass | 21:47 |
| SergeyLukjanov | btw I'll ask our qa guys about add missed blueprints for integration tests | 21:47 |
| SergeyLukjanov | heh, sass is already taken :( | 21:47 |
| mattf | sassy | 21:47 |
| SergeyLukjanov | Sass: Syntactically Awesome Style Sheets | 21:47 |
| tmckay | Sassvanna | 21:47 |
| SergeyLukjanov | SleepyCachalot | 21:48 |
| tmckay | how about StackaDoop? | 21:49 |
| SergeyLukjanov | tmckay, nice :) | 22:06 |
| SergeyLukjanov | tmckay, about https://review.openstack.org/#/c/69712/ | 22:06 |
| SergeyLukjanov | tmckay, will it change REST API calls/responses? | 22:06 |
| openstackgerrit | A change was merged to openstack/python-savannaclient: Fixed issue when savanna url is not provided https://review.openstack.org/70340 | 22:07 |
| tmckay | Sergey, it will affect streaming mapreduce and java jobs. Good point. Not the API so much, but if we have an example JSON in the REST doc it may need to change, yes. | 22:07 |
| tmckay | I'll take a look | 22:07 |
| tmckay | SergeyLukjanov, even | 22:07 |
| SergeyLukjanov | tmckay, ok, thank you, I'll -1 it to prevent merge, please, comment about your research there | 22:09 |
| tmckay | will do. | 22:09 |
| SergeyLukjanov | tmckay, so, it'll only rename specific configs in jobs to edp.XXX, am I right? | 22:09 |
| SergeyLukjanov | only examples or existing integration code could be broken so | 22:10 |
| tmckay | SergeyLukjanov, yes. The only exception is for java jobs, we had "main_class" and "java_opts" at the top level of the JSON (with cluster_id, etc). Those fields go away and move into configs as "edp.java.main_class" and "edp.java.java_opts" | 22:10 |
| tmckay | I fixed the integration test | 22:10 |
| SergeyLukjanov | tmckay, yup, got it finally ;) | 22:11 |
| SergeyLukjanov | could you, please, add a note to docs about this job type - specific behaviour? | 22:11 |
| SergeyLukjanov | if it's the only missed part, it could be done in separated CR to not block this one | 22:11 |
| SergeyLukjanov | tmckay, ^^ | 22:12 |
| tmckay | Yes. looking at execute now. I'll have an answer for you by tomorrow morning, I have a few hours to kill. | 22:12 |
| tmckay | ack on the separate CR | 22:12 |
| SergeyLukjanov | tmckay, thx | 22:14 |
| tmckay | np. Good night! | 22:14 |
| openstackgerrit | Trevor McKay proposed a change to openstack/savanna: Add utilities for supporting dotted job types https://review.openstack.org/71387 | 22:17 |
| *** crobertsrh is now known as _crobertsrh | 22:21 | |
| openstackgerrit | Trevor McKay proposed a change to openstack/savanna: Update the edp user doc to discuss "edp." configs for Java jobs https://review.openstack.org/71403 | 22:50 |
| openstackgerrit | Trevor McKay proposed a change to openstack/savanna-extra: Small tweak to the wordcount example README https://review.openstack.org/71413 | 23:10 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!