| *** IlyaE has joined #savanna | 00:29 | |
| *** NikitaKonovalov has joined #savanna | 00:54 | |
| *** ErikB has joined #savanna | 00:54 | |
| *** NikitaKonovalov has quit IRC | 00:59 | |
| *** ErikB has quit IRC | 00:59 | |
| *** nosnos has joined #savanna | 01:22 | |
| *** IlyaE has quit IRC | 01:44 | |
| *** IlyaE has joined #savanna | 01:54 | |
| *** NikitaKonovalov has joined #savanna | 01:54 | |
| *** ErikB has joined #savanna | 01:55 | |
| *** matsuhashi has joined #savanna | 01:56 | |
| *** NikitaKonovalov has quit IRC | 01:59 | |
| *** ErikB has quit IRC | 02:00 | |
| *** IlyaE has quit IRC | 02:43 | |
| *** NikitaKonovalov has joined #savanna | 02:55 | |
| *** ErikB has joined #savanna | 02:56 | |
| *** NikitaKonovalov has quit IRC | 02:59 | |
| *** ErikB has quit IRC | 03:00 | |
| *** IlyaE has joined #savanna | 03:13 | |
| *** sacharya has quit IRC | 03:30 | |
| *** NikitaKonovalov has joined #savanna | 03:55 | |
| *** ErikB has joined #savanna | 03:56 | |
| *** NikitaKonovalov has quit IRC | 04:00 | |
| *** ErikB has quit IRC | 04:02 | |
| *** asavu has joined #savanna | 04:04 | |
| *** SergeyLukjanov has joined #savanna | 04:17 | |
| *** IlyaE has quit IRC | 04:19 | |
| *** akuznetsov has joined #savanna | 04:22 | |
| *** SergeyLukjanov is now known as SergeyLukjanov_ | 04:31 | |
| *** SergeyLukjanov_ has quit IRC | 04:33 | |
| *** asavu has quit IRC | 04:35 | |
| *** SergeyLukjanov has joined #savanna | 04:41 | |
| *** NikitaKonovalov has joined #savanna | 04:56 | |
| *** ErikB has joined #savanna | 04:57 | |
| *** matsuhas_ has joined #savanna | 05:00 | |
| *** matsuhashi has quit IRC | 05:00 | |
| *** NikitaKonovalov has quit IRC | 05:00 | |
| *** ErikB has quit IRC | 05:02 | |
| *** SergeyLukjanov has quit IRC | 05:04 | |
| *** IlyaE has joined #savanna | 05:26 | |
| *** matsuhas_ has quit IRC | 05:26 | |
| *** matsuhashi has joined #savanna | 05:29 | |
| *** nosnos has quit IRC | 05:32 | |
| *** nosnos has joined #savanna | 05:32 | |
| *** matsuhashi has quit IRC | 05:34 | |
| *** matsuhashi has joined #savanna | 05:39 | |
| *** NikitaKonovalov has joined #savanna | 05:56 | |
| *** ErikB has joined #savanna | 05:58 | |
| *** NikitaKonovalov has quit IRC | 06:01 | |
| *** ErikB has quit IRC | 06:03 | |
| *** SergeyLukjanov has joined #savanna | 06:03 | |
| *** SergeyLukjanov has quit IRC | 06:06 | |
| *** NikitaKonovalov has joined #savanna | 06:49 | |
| *** NikitaKonovalov has quit IRC | 06:51 | |
| *** NikitaKonovalov has joined #savanna | 06:52 | |
| *** matsuhashi has quit IRC | 06:57 | |
| *** ErikB has joined #savanna | 06:59 | |
| *** nosnos_ has joined #savanna | 07:00 | |
| *** nosnos has quit IRC | 07:01 | |
| *** matsuhashi has joined #savanna | 07:01 | |
| *** ErikB has quit IRC | 07:04 | |
| *** SergeyLukjanov has joined #savanna | 07:16 | |
| *** NikitaKonovalov has quit IRC | 07:24 | |
| *** NikitaKonovalov has joined #savanna | 07:31 | |
| *** nprivalova has joined #savanna | 07:32 | |
| openstackgerrit | Nikolay Mahotkin proposed a change to stackforge/savanna: Add /job-configs/<job_type> REST API call https://review.openstack.org/45419 | 07:38 |
|---|---|---|
| *** IlyaE has quit IRC | 07:49 | |
| *** SergeyLukjanov has quit IRC | 07:57 | |
| *** ErikB1 has joined #savanna | 07:59 | |
| *** SergeyLukjanov has joined #savanna | 08:01 | |
| *** ErikB1 has quit IRC | 08:05 | |
| *** SergeyLukjanov has quit IRC | 08:12 | |
| *** SergeyLukjanov has joined #savanna | 08:17 | |
| *** nprivalova has quit IRC | 08:29 | |
| *** nprivalova has joined #savanna | 08:32 | |
| *** SergeyLukjanov has quit IRC | 08:53 | |
| openstackgerrit | Yaroslav Lobankov proposed a change to stackforge/savanna: Integration test refactoring https://review.openstack.org/43925 | 08:54 |
| *** ErikB1 has joined #savanna | 09:00 | |
| *** ErikB1 has quit IRC | 09:05 | |
| openstackgerrit | Yaroslav Lobankov proposed a change to stackforge/savanna: Integration test refactoring https://review.openstack.org/43925 | 09:13 |
| openstackgerrit | Nadya Privalova proposed a change to stackforge/savanna: Add "mains" and "libs" fields to JobOrigins https://review.openstack.org/45129 | 09:23 |
| *** matsuhashi has quit IRC | 09:26 | |
| *** matsuhashi has joined #savanna | 09:26 | |
| *** SergeyLukjanov has joined #savanna | 09:31 | |
| *** bmahe has quit IRC | 09:39 | |
| *** SergeyLukjanov is now known as SergeyLukjanov_ | 09:39 | |
| *** SergeyLukjanov_ is now known as SergeyLukjanov | 09:41 | |
| openstackgerrit | Yaroslav Lobankov proposed a change to stackforge/savanna: Integration test refactoring https://review.openstack.org/43925 | 09:42 |
| *** nprivalova has quit IRC | 09:49 | |
| *** SergeyLukjanov is now known as SergeyLukjanov_ | 09:59 | |
| *** SergeyLukjanov_ is now known as SergeyLukjanov | 10:00 | |
| *** ErikB1 has joined #savanna | 10:01 | |
| *** nprivalova has joined #savanna | 10:05 | |
| *** ErikB1 has quit IRC | 10:06 | |
| openstackgerrit | Nikolay Mahotkin proposed a change to stackforge/savanna: Fix job manager for hive action https://review.openstack.org/45025 | 10:10 |
| *** nprivalova has quit IRC | 10:20 | |
| openstackgerrit | Yaroslav Lobankov proposed a change to stackforge/savanna: Integration test refactoring https://review.openstack.org/43925 | 10:23 |
| *** SergeyLukjanov is now known as SergeyLukjanov_ | 10:29 | |
| *** matsuhashi has quit IRC | 10:30 | |
| *** SergeyLukjanov_ has quit IRC | 10:31 | |
| *** nosnos_ has quit IRC | 10:39 | |
| *** ruhe has joined #savanna | 10:42 | |
| *** NikitaKonovalov has quit IRC | 10:48 | |
| *** nprivalova has joined #savanna | 10:54 | |
| *** _crobertsrh is now known as crobertsrh | 10:57 | |
| *** ruhe has quit IRC | 10:59 | |
| *** SergeyLukjanov has joined #savanna | 11:01 | |
| *** ErikB1 has joined #savanna | 11:02 | |
| *** ErikB1 has quit IRC | 11:07 | |
| openstackgerrit | A change was merged to stackforge/savanna: Fix job manager for hive action https://review.openstack.org/45025 | 11:10 |
| openstackgerrit | Nadya Privalova proposed a change to stackforge/savanna: Add "mains" and "libs" fields to JobOrigins https://review.openstack.org/45129 | 11:12 |
| *** NikitaKonovalov has joined #savanna | 11:19 | |
| *** NikitaKonovalov has quit IRC | 11:24 | |
| *** ruhe has joined #savanna | 11:30 | |
| *** SergeyLukjanov is now known as SergeyLukjanov_ | 11:32 | |
| openstackgerrit | Nadya Privalova proposed a change to stackforge/savanna: Add "mains" and "libs" fields to JobOrigins https://review.openstack.org/45129 | 11:41 |
| *** SergeyLukjanov_ has quit IRC | 11:41 | |
| openstackgerrit | Nadya Privalova proposed a change to stackforge/savanna: Add "mains" and "libs" fields to JobOrigins https://review.openstack.org/45129 | 11:45 |
| openstackgerrit | Vadim Rovachev proposed a change to stackforge/savanna-dashboard: Added UI tests https://review.openstack.org/43442 | 11:47 |
| *** aignatov has joined #savanna | 11:50 | |
| *** asavu has joined #savanna | 11:54 | |
| openstackgerrit | Yaroslav Lobankov proposed a change to stackforge/python-savannaclient: Create methods return object while object creation https://review.openstack.org/45668 | 11:56 |
| openstackgerrit | Nikolay Mahotkin proposed a change to stackforge/savanna: Add /job-configs/<job_type> REST API call https://review.openstack.org/45419 | 11:58 |
| *** nprivalova has quit IRC | 11:58 | |
| *** ruhe has quit IRC | 11:59 | |
| *** nprivalova has joined #savanna | 12:01 | |
| *** SergeyLukjanov has joined #savanna | 12:02 | |
| *** ErikB1 has joined #savanna | 12:02 | |
| *** SergeyLukjanov is now known as SergeyLukjanov_ | 12:06 | |
| *** ErikB1 has quit IRC | 12:07 | |
| *** SergeyLukjanov_ is now known as SergeyLukjanov | 12:08 | |
| openstackgerrit | Nikolay Mahotkin proposed a change to stackforge/savanna: Add /job-configs/<job_type> REST API call https://review.openstack.org/45419 | 12:11 |
| openstackgerrit | Yaroslav Lobankov proposed a change to stackforge/python-savannaclient: Create methods return object while object creation https://review.openstack.org/45668 | 12:15 |
| *** akuznetsov has quit IRC | 12:16 | |
| *** asavu has quit IRC | 12:16 | |
| openstackgerrit | Yaroslav Lobankov proposed a change to stackforge/python-savannaclient: Create methods return object while object creation https://review.openstack.org/45668 | 12:18 |
| *** SergeyLukjanov is now known as SergeyLukjanov_ | 12:19 | |
| *** SergeyLukjanov_ is now known as SergeyLukjanov | 12:24 | |
| *** ErikB1 has joined #savanna | 12:26 | |
| *** NikitaKonovalov has joined #savanna | 12:33 | |
| *** tmckay has joined #savanna | 12:34 | |
| *** SergeyLukjanov is now known as SergeyLukjanov_ | 12:35 | |
| *** NikitaKonovalov has quit IRC | 12:39 | |
| *** NikitaKonovalov has joined #savanna | 12:39 | |
| *** sballe has joined #savanna | 12:40 | |
| *** ErikB1 has quit IRC | 12:41 | |
| tmckay | nprivalova, hi! I was working on Friday afternoon to make JobBinary deletion failed if it's referenced from a JobOrigin. It turns out that a simple ForeignKey is not enough, because the assocation table is automatically cleaned up by sqlalchemy. But, the association table can be queried for any occurrence of the job_binary id, and an exception raised. Finishing up this morning... | 12:41 |
| *** SergeyLukjanov_ has quit IRC | 12:43 | |
| nprivalova | hi tmckay! | 12:43 |
| nprivalova | tmckay, I've resolved several comments during review | 12:44 |
| *** mattf has quit IRC | 12:44 | |
| *** mattf has joined #savanna | 12:44 | |
| tmckay | nprivalova, great, I'll take a look | 12:45 |
| nprivalova | tmckay, and there is no more news from my side :) | 12:45 |
| tmckay | yay, maybe we can get it reviewed soon :) | 12:46 |
| *** ruhe has joined #savanna | 12:46 | |
| *** SergeyLukjanov has joined #savanna | 12:52 | |
| *** SergeyLukjanov is now known as SergeyLukjanov_ | 12:52 | |
| *** SergeyLukjanov_ is now known as SergeyLukjanov | 12:52 | |
| *** akuznetsov has joined #savanna | 12:59 | |
| openstackgerrit | A change was merged to stackforge/python-savannaclient: Create methods return object while object creation https://review.openstack.org/45668 | 13:01 |
| *** ErikB1 has joined #savanna | 13:04 | |
| nprivalova | crobertsrh, hi! | 13:22 |
| crobertsrh | hello | 13:22 |
| nprivalova | I'd like to discuss UI part with you and other EDP-team members. The main question: am I right that there will be 3 separate pages for mr, pig and hive? | 13:25 |
| crobertsrh | I suppose we could do it that way. I was trying to think of a way to integrate all into one page. separate pages would probably be easier | 13:27 |
| nprivalova | I absolutely agree with it | 13:28 |
| crobertsrh | definitely open to any suggestions | 13:29 |
| *** _tstclair has quit IRC | 13:35 | |
| nprivalova | We're thinking about additional rest methods for UI. Did you see https://review.openstack.org/#/c/45419 ? | 13:36 |
| crobertsrh | looking now | 13:38 |
| *** tstclair has joined #savanna | 13:44 | |
| crobertsrh | That change should be fine | 13:48 |
| openstackgerrit | Jonathan Maron proposed a change to stackforge/savanna: Update ambari admin credentials for scaling https://review.openstack.org/45686 | 13:48 |
| crobertsrh | The thought there is that before submitting a job, the UI would make the appropriate call to get the associated config and then pass that along? | 13:49 |
| *** kbroughton has joined #savanna | 13:51 | |
| *** NikitaKonovalov has quit IRC | 13:51 | |
| nprivalova | yes. Chad, the problem here is that for Pig there should be the following fields to be edited: "script-name", "configuration", "params". For mr it is only "configs" | 13:54 |
| nprivalova | so the sets of "changeable" fields depend on job-type | 13:55 |
| nprivalova | There may be the following REST: /job-fields/<job_type> and return value: {"configs": {name:value <=== defaults}, "script-name": "here we can show script name from JobOrigin" , "params": "no defaults" } | 13:58 |
| nprivalova | crobertsrh, akuznetsov, tmckay, aignatov, ping :) | 14:00 |
| tmckay | I'm here. | 14:01 |
| aignatov | pong | 14:02 |
| akuznetsov | pong | 14:02 |
| nprivalova | thoughts? | 14:02 |
| nprivalova | about the REST | 14:03 |
| aignatov | crobertsrh, do you have fresh mock screens for UI? :) | 14:03 |
| tmckay | It makes sense to me, if the UI is context-sensitive based on the job type | 14:04 |
| akuznetsov | For now we have a two places where parameters can insert | 14:04 |
| tmckay | The only other way to do it is encode the set of parameters for each job type in the UI itself. | 14:04 |
| akuznetsov | job creation and job execution | 14:04 |
| crobertsrh | aignatov: No, mock screens are rather stale right now | 14:05 |
| crobertsrh | I can add another "config" tab to the launch workflow where the configs can be edited. | 14:05 |
| *** NikitaKonovalov has joined #savanna | 14:05 | |
| crobertsrh | or rather a new config tab to the job creation itself. | 14:06 |
| akuznetsov | for job creation parameters are not mandatory | 14:06 |
| akuznetsov | it can always set up in job execution | 14:07 |
| crobertsrh | I agree. I'll add it to launch dialog | 14:07 |
| akuznetsov | Some parameters will unknown before job creation e.g. oozie workflows | 14:07 |
| crobertsrh | I thought I was getting fairly close, but it seems like I'm getting farther away :) | 14:08 |
| nprivalova | crobertsrh, we are changing our vision every week but looks like the REST is rather stable. Anyway, maybe it would be easier to collaborate having mocks up-to-date? Just to let us know what is ready and what should not be broken :) | 14:11 |
| *** rnirmal has joined #savanna | 14:13 | |
| akuznetsov | nprivalova, aignatov and tmckay I think that job can define a new parameters e.g. if we have a pig script and it has some parameters in xml we can extract it and show before execution | 14:17 |
| akuznetsov | what do you think? | 14:18 |
| tmckay | Extract from where? :) Something in a JobExecution, or from a JobBinary stored somewhere? | 14:20 |
| *** sacharya has joined #savanna | 14:21 | |
| crobertsrh | whew...found my usb stick with the savanna UI mockups on it :) | 14:21 |
| tmckay | akuznetsov, I am unclear where the "some parameters in xml" would be | 14:22 |
| *** ErikB1 has quit IRC | 14:25 | |
| akuznetsov | tmckay e.g. we have section <param>[PARAM-VALUE]</param> in pig xml for this parameters can be specifies by placeholders which should be specified in job execution | 14:25 |
| tmckay | akuznetsov, okay, so it would be necessary then to read the pig xml from storage (swift, internal db, hdfs, etc) and parse it, and then prompt the user for values? | 14:27 |
| akuznetsov | I think yes before job execution creation | 14:27 |
| nprivalova | I think 'params' block should be in Job as well as 'configs' blocks | 14:27 |
| openstackgerrit | John Speidel proposed a change to stackforge/savanna: Update Ambari repo URL for 0.2.2 release https://review.openstack.org/45692 | 14:30 |
| openstackgerrit | John Speidel proposed a change to stackforge/savanna: Update Ambari repo URL for 0.2.2 release https://review.openstack.org/45692 | 14:31 |
| *** ErikB1 has joined #savanna | 14:32 | |
| tmckay | nprivalova, in that case, it seems like it is up to the user to create the job correctly and the UI forms can be created from the information in the Job. Do we need any extra "helper" functions for a user to create a job with a "params" section? (beyond just retrieving whatever job binaries they want to use?) | 14:32 |
| nprivalova | tmckay, I think we do not need such mechanism for "params" itself. But UI should know that "params" may be asked from user | 14:36 |
| *** asavu has joined #savanna | 14:40 | |
| nprivalova | maybe just add 'extra' to Job and JobExecution. extra:{configs:{name:value}, params: {name:value}} | 14:41 |
| openstackgerrit | Nikita Konovalov proposed a change to stackforge/savanna: Floating ip assignement support https://review.openstack.org/44822 | 14:42 |
| *** SergeyLu_ has joined #savanna | 14:42 | |
| *** ruhe has quit IRC | 14:43 | |
| *** sacharya has quit IRC | 14:43 | |
| *** SergeyLu_ has quit IRC | 14:46 | |
| akuznetsov | nprivalova agree we should made it simple | 14:46 |
| *** ruhe has joined #savanna | 14:54 | |
| openstackgerrit | A change was merged to stackforge/savanna: Update Ambari repo URL for 0.2.2 release https://review.openstack.org/45692 | 14:55 |
| openstackgerrit | Trevor McKay proposed a change to stackforge/savanna: Add "mains" and "libs" fields to JobOrigins https://review.openstack.org/45129 | 14:56 |
| *** SergeyLukjanov is now known as SergeyLukjanov_ | 15:04 | |
| *** SergeyLukjanov_ is now known as SergeyLukjanov | 15:05 | |
| openstackgerrit | Xiang Hui proposed a change to stackforge/savanna: Fix typo https://review.openstack.org/45699 | 15:06 |
| *** nprivalova has quit IRC | 15:07 | |
| *** asavu has quit IRC | 15:09 | |
| *** ErikB1 has quit IRC | 15:13 | |
| openstackgerrit | Xiang Hui proposed a change to stackforge/savanna: Fix typo https://review.openstack.org/45699 | 15:13 |
| *** sacharya has joined #savanna | 15:13 | |
| *** ErikB has joined #savanna | 15:15 | |
| openstackgerrit | A change was merged to stackforge/savanna: Fix typo https://review.openstack.org/45699 | 15:17 |
| openstackgerrit | Jonathan Maron proposed a change to stackforge/savanna: Update ambari admin credentials for scaling https://review.openstack.org/45686 | 15:25 |
| *** IlyaE has joined #savanna | 15:27 | |
| openstackgerrit | Nikita Konovalov proposed a change to stackforge/savanna: Floating ip assignement support https://review.openstack.org/44822 | 15:29 |
| *** dmitryme has joined #savanna | 15:31 | |
| *** nprivalova has joined #savanna | 15:33 | |
| tmckay | nprivalova, ping | 15:49 |
| nprivalova | tmckay, I'm here | 15:49 |
| *** asavu has joined #savanna | 15:50 | |
| openstackgerrit | Sergey Galkin proposed a change to stackforge/python-savannaclient: Added authentication by tenant name https://review.openstack.org/45705 | 15:51 |
| tmckay | Hi. Adding JobBinary tests -- I noticed that many of the "fields" tests could be a single shared test, the basic logic is the same. Is there any convention in testing code that all tests should be standalone? Is it okay to combine them through a utility routine? | 15:51 |
| tmckay | fields test is just "create some sample, compare fields in the object to the sample" | 15:51 |
| tmckay | I suppose maybe different getter names makes it not worth it... | 15:52 |
| tmckay | but, still a general question | 15:52 |
| nprivalova | There is no strict convention. The main goal in really to test features | 15:53 |
| tmckay | okay, thanks | 15:54 |
| openstackgerrit | Sergey Galkin proposed a change to stackforge/python-savannaclient: Added authentication by tenant name https://review.openstack.org/45705 | 15:59 |
| *** ruhe has quit IRC | 16:01 | |
| openstackgerrit | Nikita Konovalov proposed a change to stackforge/savanna: Floating ip assignement support https://review.openstack.org/44822 | 16:02 |
| *** tmckay is now known as tmckay_lunch | 16:04 | |
| *** IlyaE has quit IRC | 16:14 | |
| openstackgerrit | A change was merged to stackforge/python-savannaclient: Added authentication by tenant name https://review.openstack.org/45705 | 16:16 |
| *** NikitaKonovalov has quit IRC | 16:17 | |
| *** nprivalova has quit IRC | 16:19 | |
| *** ruhe has joined #savanna | 16:23 | |
| *** ruhe has quit IRC | 16:24 | |
| *** ruhe has joined #savanna | 16:27 | |
| *** SergeyLukjanov is now known as SergeyLukjanov_ | 16:32 | |
| *** SergeyLukjanov_ is now known as SergeyLukjanov | 16:32 | |
| *** SergeyLukjanov has quit IRC | 16:36 | |
| *** ruhe has quit IRC | 16:39 | |
| *** akuznetsov has quit IRC | 16:41 | |
| *** IlyaE has joined #savanna | 16:44 | |
| *** ruhe has joined #savanna | 16:48 | |
| *** NikitaKonovalov has joined #savanna | 16:52 | |
| *** NikitaKonovalov has quit IRC | 17:01 | |
| *** NikitaKonovalov has joined #savanna | 17:04 | |
| *** openstackgerrit has quit IRC | 17:05 | |
| *** openstackgerrit has joined #savanna | 17:05 | |
| *** akuznetsov has joined #savanna | 17:09 | |
| *** NikitaKonovalov has quit IRC | 17:21 | |
| *** NikitaKonovalov has joined #savanna | 17:21 | |
| *** tmckay_lunch is now known as tmckay | 17:26 | |
| *** SergeyLukjanov has joined #savanna | 17:30 | |
| *** SergeyLukjanov has quit IRC | 17:33 | |
| *** NikitaKonovalov has quit IRC | 17:35 | |
| *** NikitaKonovalov has joined #savanna | 17:36 | |
| openstackgerrit | Trevor McKay proposed a change to stackforge/savanna: Add "mains" and "libs" fields to JobOrigins https://review.openstack.org/45129 | 17:38 |
| *** NikitaKonovalov has quit IRC | 17:38 | |
| *** SergeyLukjanov has joined #savanna | 17:39 | |
| *** NikitaKonovalov has joined #savanna | 17:40 | |
| openstackgerrit | Dmitry Mescheryakov proposed a change to stackforge/savanna: Wrapping ssh calls into subprocesses https://review.openstack.org/45716 | 17:45 |
| *** ruhe has quit IRC | 17:52 | |
| *** dmitryme has quit IRC | 17:54 | |
| *** sballe has quit IRC | 17:55 | |
| *** NikitaKonovalov has quit IRC | 17:55 | |
| *** NikitaKonovalov has joined #savanna | 17:56 | |
| *** NikitaKonovalov has quit IRC | 17:59 | |
| *** NikitaKonovalov has joined #savanna | 18:00 | |
| openstackgerrit | Trevor McKay proposed a change to stackforge/savanna: Add "mains" and "libs" fields to JobOrigins https://review.openstack.org/45129 | 18:06 |
| crobertsrh | Updated set of UI mockups for EDP. https://wiki.openstack.org/wiki/Savanna/UIMockups/JobCreation (a few more still to come) | 18:17 |
| *** akuznetsov has quit IRC | 18:29 | |
| *** IlyaE has quit IRC | 18:31 | |
| *** NikitaKonovalov has quit IRC | 18:31 | |
| *** NikitaKonovalov has joined #savanna | 18:34 | |
| *** ErikB has quit IRC | 18:35 | |
| *** akuznetsov has joined #savanna | 18:35 | |
| *** ErikB has joined #savanna | 18:36 | |
| openstackgerrit | Sergey Lukjanov proposed a change to stackforge/savanna: Use setup.py develop for tox install https://review.openstack.org/45724 | 18:39 |
| openstackgerrit | A change was merged to stackforge/savanna: Update ambari admin credentials for scaling https://review.openstack.org/45686 | 18:40 |
| *** akuznetsov has quit IRC | 18:56 | |
| *** dmitryme has joined #savanna | 19:01 | |
| openstackgerrit | Sergey Lukjanov proposed a change to stackforge/savanna: Sync requirements with os/requirements https://review.openstack.org/45734 | 19:02 |
| openstackgerrit | Sergey Lukjanov proposed a change to stackforge/savanna: Fix AUTHORS file ordering https://review.openstack.org/45735 | 19:04 |
| openstackgerrit | Sergey Lukjanov proposed a change to stackforge/savanna: Sync oslo with os/oslo-incubator https://review.openstack.org/45739 | 19:14 |
| *** dmitryme has quit IRC | 19:16 | |
| *** NikitaKonovalov has quit IRC | 19:16 | |
| *** NikitaKonovalov has joined #savanna | 19:16 | |
| *** ruhe has joined #savanna | 19:16 | |
| openstackgerrit | Sergey Lukjanov proposed a change to stackforge/savanna: Fix AUTHORS file https://review.openstack.org/45735 | 19:16 |
| *** NikitaKonovalov has quit IRC | 19:17 | |
| *** IlyaE has joined #savanna | 19:21 | |
| *** ruhe has quit IRC | 19:58 | |
| crobertsrh | You there tmckay? | 19:58 |
| tmckay | yes | 19:58 |
| crobertsrh | Question on creating a job origin.... | 19:58 |
| crobertsrh | I have a main that I chose from a list of savanna-internal binaries.... | 19:59 |
| *** dmitryme has joined #savanna | 19:59 | |
| crobertsrh | I transform that to savanna-db://{uid} on the create call, but I get a validation error that that uid doesn't exist. | 19:59 |
| crobertsrh | Does that seem wrong? | 19:59 |
| *** NikitaKonovalov has joined #savanna | 19:59 | |
| crobertsrh | If I do a savanna-binary-internals list, I see my uid happily there | 19:59 |
| tmckay | hmm, which branch are you working on? | 20:00 |
| tmckay | There is a CR right now to change the object relationships | 20:00 |
| crobertsrh | master + I cherry picked your review | 20:00 |
| crobertsrh | Ah, maybe there is a missing piece for me | 20:01 |
| tmckay | Okay. job_origin["mains"] holds references to JobBinarys, which point to JobBinaryInternals | 20:01 |
| tmckay | another level of indirection. | 20:01 |
| tmckay | JobBinaryInternals are strictly data blobs | 20:02 |
| tmckay | JobBinarys on the other hand might be ultimately be stored anywhere | 20:02 |
| crobertsrh | Ok, maybe I'm misunderstanding something along the way | 20:02 |
| crobertsrh | Previously, I just stored a job binary (which I think always just put it in the savanna db) | 20:02 |
| crobertsrh | I'm trying to make that happen again. | 20:03 |
| tmckay | right, that thing is now called a JobBinaryInternal | 20:03 |
| crobertsrh | Ok, so I am creating a job-binary-internal | 20:03 |
| crobertsrh | I'm using those to populate a select box | 20:03 |
| tmckay | the api is essentially the same but job-binary in the url has become job-binary-internal | 20:03 |
| crobertsrh | Ok, that is what my working assumption was | 20:03 |
| tmckay | Then, you need to make a JobBinary that points to that internal | 20:04 |
| crobertsrh | Oh | 20:04 |
| tmckay | And a JobOrigin that points to the JobBinary | 20:04 |
| crobertsrh | thanks for spelling it out to me again | 20:04 |
| crobertsrh | Now, just code it for me and we'll be in better shape :) | 20:04 |
| tmckay | the choice came down to making JobBinary smart enough to hold BLOBs or urls in the same object, or to introduce another level | 20:04 |
| crobertsrh | Yeah, I recall seeing that conversation, or at least part of it | 20:05 |
| crobertsrh | Ok, I should be able to make magic happen again. | 20:05 |
| tmckay | Heh. I can probably make you a paste of http calls that sets up something valid (Actually, I haven't tried to link it all the way through) | 20:05 |
| tmckay | Also, the test code might be helpful in showing the relationships | 20:05 |
| tmckay | I've been playing with mains and libs so I just made JobBinary objects that didn't actually point anywhere real. | 20:06 |
| crobertsrh | So to create a job binary that points to a job binary internal, the url needs to be "savanna-db://{uid}", right? | 20:09 |
| tmckay | yes | 20:09 |
| crobertsrh | Ok, success now. | 20:19 |
| tmckay | crobertsrh, great! | 20:24 |
| tmckay | I need to get a full environment set up. Playing with decorators for better exception handling in REST calls. | 20:25 |
| *** NikitaKonovalov has quit IRC | 20:25 | |
| tmckay | It annoys me when I get back "Internal server error" | 20:25 |
| tmckay | bbl | 20:25 |
| *** NikitaKonovalov has joined #savanna | 20:26 | |
| crobertsrh | Yes, "internal server error" doesn't tell us much. Probably better than an "external server error"...I would have no clue at all what that is. | 20:30 |
| dmitryme | hi guys | 20:37 |
| dmitryme | tmckay: what do you mean by "better exception handling in REST calls"? | 20:37 |
| dmitryme | the idea behind "Internal Server Error" message is to hide from client details of an unexpected error | 20:38 |
| dmitryme | since exposing them is a potential threat | 20:39 |
| tmckay | dmitryme, some of them I think are a problem, for instance duplicate record creation | 20:56 |
| dmitryme | agree, that is for sure should be presented clearly to the user | 20:57 |
| tmckay | What I was playing with was a decorator that would grab SavannaException and create a better message. RuntimeError for example could still be "Internal Server Error" | 20:58 |
| tmckay | That way, we can pick and choose what we want to elaborate on. Deletion failure because of constraints might be another one. | 20:58 |
| dmitryme | I see. It just wash't clear from your message if going to show details for _every_ error | 20:59 |
| tmckay | :) agreed, that would be bad, and exceptions can contain security flaws. | 20:59 |
| *** NikitaKonovalov has quit IRC | 21:01 | |
| *** crobertsrh is now known as _crobertsrh | 21:01 | |
| tmckay | dmitryme, ah, hmm, looks like this is easier than I thought. The "route" call already catches SavannaExceptions and handles them. So, RuntimeError from create can just be a SavannaException and it is handled correctly. | 21:05 |
| tmckay | (in the REST api) | 21:05 |
| openstackgerrit | A change was merged to stackforge/savanna: Fix AUTHORS file https://review.openstack.org/45735 | 21:08 |
| dmitryme | I didn't saw that code before, but I knew it was somewhere there just because I've never seen an unhandled error from Savanna | 21:09 |
| tmckay | :) yes, I just stepped through it in the debugger. When I made my exception a Savanna exception the reporting magically changed, haha | 21:10 |
| tmckay | Fixing my bug report | 21:10 |
| tmckay | This is really an RFE for some errors | 21:10 |
| dmitryme | RFE? | 21:11 |
| dmitryme | I mean, I am not familiar with any meaning of that acronym | 21:13 |
| dmitryme | and I don't see anything suitable in http://www.acronymfinder.com/RFE.html | 21:13 |
| tmckay | "request for enchancement" | 21:15 |
| tmckay | When something is maybe not a bug, and is working be design, but could be better :) | 21:15 |
| dmitryme | oh, that one | 21:15 |
| tmckay | some places use it, some don't | 21:16 |
| *** dmitryme has quit IRC | 21:43 | |
| *** ErikB has quit IRC | 21:44 | |
| *** NikitaKonovalov has joined #savanna | 22:01 | |
| *** SergeyLukjanov has quit IRC | 22:01 | |
| *** NikitaKonovalov has quit IRC | 22:06 | |
| *** dmitryme has joined #savanna | 22:17 | |
| *** sacharya has quit IRC | 22:19 | |
| *** ErikB has joined #savanna | 22:37 | |
| *** ErikB has quit IRC | 22:43 | |
| *** dmitryme has quit IRC | 22:44 | |
| *** kbroughton has quit IRC | 22:51 | |
| *** NikitaKonovalov has joined #savanna | 23:02 | |
| *** sacharya has joined #savanna | 23:07 | |
| *** NikitaKonovalov has quit IRC | 23:07 | |
| *** rnirmal has quit IRC | 23:12 | |
| *** IlyaE has quit IRC | 23:17 | |
| *** IlyaE has joined #savanna | 23:18 | |
| *** IlyaE has quit IRC | 23:23 | |
| *** asavu has quit IRC | 23:39 | |
| *** ErikB has joined #savanna | 23:39 | |
| *** ErikB has quit IRC | 23:45 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!