| *** aasthad has quit IRC | 00:02 | |
| *** ntpttr_ has quit IRC | 00:07 | |
| *** yazpik has joined #osic | 00:08 | |
| *** jlopezgu_ has quit IRC | 00:11 | |
| *** yazpik has quit IRC | 00:12 | |
| *** jrobinson has quit IRC | 00:27 | |
| *** csomerville has joined #osic | 00:35 | |
| *** cody-somerville has quit IRC | 00:35 | |
| *** john-davidge has joined #osic | 00:56 | |
| *** MasterOfBugs has quit IRC | 01:01 | |
| *** john-davidge has quit IRC | 01:01 | |
| *** jrobinson has joined #osic | 01:03 | |
| *** yazpik has joined #osic | 01:05 | |
| *** sayantani01 has quit IRC | 01:07 | |
| *** yazpik_ has joined #osic | 01:08 | |
| *** yazpik has quit IRC | 01:09 | |
| *** yazpik_ has quit IRC | 01:13 | |
| *** sayantani01 has joined #osic | 02:06 | |
| *** knangia has quit IRC | 02:11 | |
| *** cathrich_ has joined #osic | 02:47 | |
| *** cathrichardson has quit IRC | 02:47 | |
| *** john-davidge has joined #osic | 02:57 | |
| *** knangia has joined #osic | 03:00 | |
| *** john-davidge has quit IRC | 03:02 | |
| *** yazpik has joined #osic | 03:03 | |
| *** yazpik has quit IRC | 03:07 | |
| *** jrobinson has quit IRC | 03:08 | |
| *** john-davidge has joined #osic | 03:58 | |
| *** john-davidge has quit IRC | 04:02 | |
| *** alex_xu has quit IRC | 04:17 | |
| *** alex_xu has joined #osic | 04:23 | |
| *** sayantani01 has quit IRC | 04:52 | |
| *** cody-somerville has joined #osic | 04:54 | |
| *** csomerville has quit IRC | 04:54 | |
| *** sayantani01 has joined #osic | 04:54 | |
| *** csomerville has joined #osic | 04:58 | |
| *** cody-somerville has quit IRC | 04:58 | |
| *** yazpik has joined #osic | 05:08 | |
| *** csomerville has quit IRC | 05:12 | |
| *** yazpik has quit IRC | 05:12 | |
| *** yazpik has joined #osic | 05:48 | |
| *** rderose has quit IRC | 05:49 | |
| *** yazpik has quit IRC | 05:52 | |
| *** john-davidge has joined #osic | 05:59 | |
| *** john-davidge has quit IRC | 06:03 | |
| *** jascott1- is now known as jascott1 | 06:06 | |
| *** sayantan_ has joined #osic | 06:11 | |
| *** sayantani01 has quit IRC | 06:14 | |
| *** yazpik has joined #osic | 06:17 | |
| *** yazpik has quit IRC | 06:22 | |
| *** yazpik has joined #osic | 06:57 | |
| *** yazpik has quit IRC | 07:01 | |
| *** knangia has quit IRC | 07:11 | |
| *** sayantan_ has quit IRC | 07:15 | |
| *** JayF has quit IRC | 07:20 | |
| *** mrhillsman has quit IRC | 07:20 | |
| *** yazpik has joined #osic | 07:26 | |
| *** yazpik has quit IRC | 07:30 | |
| *** JayF has joined #osic | 07:33 | |
| *** mrhillsman has joined #osic | 07:33 | |
| *** john-davidge has joined #osic | 07:59 | |
| *** john-davidge has quit IRC | 08:04 | |
| *** yazpik has joined #osic | 08:06 | |
| *** yazpik has quit IRC | 08:10 | |
| *** yazpik has joined #osic | 08:55 | |
| *** yazpik has quit IRC | 08:59 | |
| *** john-davidge has joined #osic | 09:13 | |
| *** john-davidge has quit IRC | 10:37 | |
| *** john-dav_ has joined #osic | 10:37 | |
| *** john-dav_ has quit IRC | 10:54 | |
| *** john-davidge has joined #osic | 11:03 | |
| *** yazpik has joined #osic | 13:28 | |
| *** cathrichardson has joined #osic | 13:34 | |
| *** john-davidge has quit IRC | 13:36 | |
| *** cathrich_ has quit IRC | 13:36 | |
| *** john-davidge has joined #osic | 13:36 | |
| *** FrankZhang has joined #osic | 13:53 | |
| *** FrankZhang has quit IRC | 13:58 | |
| *** FrankZhang has joined #osic | 13:58 | |
| *** diltram has quit IRC | 14:05 | |
| *** diltram_ has joined #osic | 14:05 | |
| lbragstad | aunnam I think I figured out why those tests are failing with oslo.policy | 14:26 |
|---|---|---|
| lbragstad | aunnam the tests rely on a method in the enforcer that loads the policy file - https://github.com/openstack/oslo.policy/blob/master/oslo_policy/policy.py#L331-L355 | 14:27 |
| lbragstad | aunnam i think that method makes the assumption that it's suppose to get some sort of json/yaml to parse, which it doesn't, it gets a bunch of comments | 14:28 |
| *** chris_hultin|AWA is now known as chris_hultin | 14:30 | |
| *** sayantani01 has joined #osic | 14:31 | |
| *** cathrichardson has quit IRC | 14:39 | |
| *** cathrichardson has joined #osic | 14:39 | |
| *** rderose has joined #osic | 14:46 | |
| *** raj_sing- is now known as raj_singh | 14:49 | |
| *** aasthad has joined #osic | 15:32 | |
| aunnam | lbragstad, ya that's the problem as it is getting the file from _generate_sample method which generates a complete commented out file | 15:56 |
| aunnam | lbragstad, i had a fix for it | 15:56 |
| aunnam | lbragstad, let me paste the link for patches | 15:56 |
| aunnam | lbragstad, https://review.openstack.org/#/c/447034/ this is to fix tests | 15:57 |
| lbragstad | aunnam here is what i have - i just pushed what i had to do to get the tests to pass | 15:57 |
| lbragstad | https://review.openstack.org/#/c/447042/ | 15:57 |
| aunnam | lbragstad,https://review.openstack.org/#/c/447034/ | 15:57 |
| aunnam | lbragstad, https://review.openstack.org/#/c/447041/ | 15:57 |
| aunnam | lbragstad, oh you had a fix for it too, i did it in a different way | 15:59 |
| *** ntpttr_ has joined #osic | 16:01 | |
| *** chris_hultin is now known as chris_hultin|AWA | 16:07 | |
| *** knangia has joined #osic | 16:12 | |
| lbragstad | aunnam yeah - i think mine is kind of a hack | 16:15 |
| lbragstad | aunnam i just wanted to see what was going on | 16:15 |
| *** MasterOfBugs has joined #osic | 16:17 | |
| *** shananigans has quit IRC | 16:23 | |
| *** zz_pwnall1337 is now known as pwnall1337 | 16:25 | |
| lbragstad | aunnam so - in your patch, the help text can either include the commented out operation or not | 16:26 |
| lbragstad | right? | 16:26 |
| aunnam | lbragstad, so if the include_help=True, it gets all the description, operations and rule as commented, otherwise it gets only the rule which is not commented | 16:29 |
| lbragstad | aunnam nice | 16:29 |
| lbragstad | aunnam that seems better than my hack | 16:29 |
| lbragstad | aunnam and by default it keeps the operation commented out | 16:30 |
| aunnam | lbragstad, yes | 16:30 |
| lbragstad | aunnam it's just that the tests use include_help = False in order to work, right? | 16:30 |
| aunnam | yes only the tests | 16:30 |
| lbragstad | sweet - i'm going to abandon my patch in favor of yours | 16:30 |
| aunnam | lbragstad, so you think that fix is ok? I tried different approaches and finally felt this fix is more reasonable | 16:32 |
| lbragstad | aunnam i think so - because the by default it will be commented out (which is the behavior we have with oslo.config when we generate sample configuration files) | 16:32 |
| lbragstad | aunnam i think your solution is better because it's also not modifying the main code path | 16:33 |
| lbragstad | which is here - https://review.openstack.org/#/c/447042/1/oslo_policy/policy.py | 16:33 |
| lbragstad | aunnam i think your approach is making the tests deal with the difference, instead of making the implementation deal with the tests | 16:34 |
| aunnam | lbragstad, cool, thanks for reviewing those patches | 16:34 |
| lbragstad | aunnam no problem - thanks for working on them | 16:35 |
| aunnam | lbragstad, :) | 16:35 |
| lbragstad | aunnam i'll see if i can get another oslo core to review them, it'd be nice to get them merged so we can propose a release of oslo.policy next week | 16:35 |
| aunnam | lbragstad, so with this change we have everything that we need for the policy spec | 16:35 |
| aunnam | lbragstad, FYI nova spec got approved | 16:36 |
| lbragstad | aunnam i think we also need https://review.openstack.org/#/c/443330/ | 16:36 |
| lbragstad | aunnam sweet | 16:36 |
| aunnam | lbragstad, oh ya we need description support as well | 16:37 |
| lbragstad | aunnam antwash's patch works - i just had a couple minor comments on it | 16:38 |
| lbragstad | aunnam and i only had one comment here - https://review.openstack.org/#/c/447041/1 | 16:39 |
| aunnam | lbragstad nice | 16:39 |
| *** chris_hultin|AWA is now known as chris_hultin | 17:35 | |
| *** csomerville has joined #osic | 17:36 | |
| *** chris_hultin is now known as chris_hultin|AWA | 17:38 | |
| *** csomerville has quit IRC | 17:47 | |
| *** chris_hultin|AWA is now known as chris_hultin | 17:51 | |
| *** shananigans has joined #osic | 17:53 | |
| kencjohnston | o/ | 18:13 |
| kencjohnston | Anyone have thoughts on a way to get an automated list of the core reviewers we have within OSIC? | 18:13 |
| kencjohnston | I can't seem to get gerrit to provide a list of core reviewers across all projects. | 18:13 |
| *** john-davidge has quit IRC | 18:41 | |
| *** joanna is now known as joanna_lunch | 18:50 | |
| *** cody-somerville has joined #osic | 18:57 | |
| *** csomerville has joined #osic | 19:02 | |
| *** cody-somerville has quit IRC | 19:05 | |
| *** joanna_lunch is now known as joanna | 19:41 | |
| *** john-davidge has joined #osic | 19:41 | |
| *** john-davidge has quit IRC | 19:46 | |
| *** john-davidge has joined #osic | 20:34 | |
| *** chris_hultin is now known as chris_hultin|AWA | 20:36 | |
| *** csomerville has quit IRC | 20:50 | |
| *** csomerville has joined #osic | 20:50 | |
| *** john-davidge has quit IRC | 21:09 | |
| *** john-davidge has joined #osic | 21:11 | |
| *** alex_xu has quit IRC | 21:25 | |
| *** alex_xu has joined #osic | 21:28 | |
| *** cody-somerville has joined #osic | 21:49 | |
| *** csomerville has quit IRC | 21:51 | |
| *** yazpik has quit IRC | 22:24 | |
| *** yazpik has joined #osic | 22:25 | |
| *** yazpik has quit IRC | 22:30 | |
| *** aasthad has quit IRC | 22:52 | |
| *** john-dav_ has joined #osic | 22:55 | |
| *** john-davidge has quit IRC | 22:55 | |
| *** john-dav_ has quit IRC | 23:01 | |
| *** yazpik has joined #osic | 23:20 | |
| *** yazpik has quit IRC | 23:24 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!