| *** yanyanhu has joined #openstack-zun | 00:42 | |
| openstackgerrit | feng.shengqin proposed openstack/python-zunclient: Allow zun exec to take arbitrary number of arguments https://review.openstack.org/423789 | 02:04 |
|---|---|---|
| *** vikasc has joined #openstack-zun | 02:54 | |
| *** kevinz has joined #openstack-zun | 03:16 | |
| *** sudipto has joined #openstack-zun | 03:31 | |
| *** sudipto_ has joined #openstack-zun | 03:31 | |
| *** pksingh has joined #openstack-zun | 03:42 | |
| pksingh | kevinz: Hello, Good Morning! | 03:43 |
| openstackgerrit | Merged openstack/python-zunclient: Add container-update command https://review.openstack.org/415099 | 03:49 |
| *** shubhams has joined #openstack-zun | 03:55 | |
| *** jwcroppe has quit IRC | 04:17 | |
| kevinz | pkingh:Hello ~ Good Morning | 04:36 |
| kevinz | pkingh: Sorry I just see your pinging | 04:36 |
| *** gb21 has joined #openstack-zun | 04:37 | |
| *** gbatra_ has joined #openstack-zun | 04:38 | |
| *** gb21 has quit IRC | 04:38 | |
| *** gbatra__ has joined #openstack-zun | 04:38 | |
| *** gbatra__ has quit IRC | 04:39 | |
| *** gbatra_ has quit IRC | 04:39 | |
| *** gb21 has joined #openstack-zun | 04:39 | |
| *** gbatra_ has joined #openstack-zun | 04:39 | |
| *** diga has joined #openstack-zun | 05:15 | |
| kevinz | pksingh:Hello ~ Good Morning | 05:22 |
| pksingh | hello kevinz | 05:22 |
| pksingh | how are you? | 05:22 |
| pksingh | kevinz: hows your day? | 05:23 |
| kevinz | pksingh: I'm fine :-) And you? | 05:23 |
| pksingh | kevinz: i am fine too | 05:23 |
| pksingh | kevinz: are you going to the summit this year? | 05:23 |
| kevinz | pksingh: I'm not sure~ May be not for Boston , all according to my manager.. | 05:24 |
| pksingh | kevinz: ok, | 05:25 |
| kevinz | pksingh: You will go to the summit this year? | 05:25 |
| pksingh | kevinz: its not decided yet | 05:25 |
| kevinz | pksingh: Yeah, the same with you | 05:26 |
| pksingh | kevinz: yes | 05:26 |
| kevinz | pksingh: BTW, thanks for your comments for my patch, really helps me a lot | 05:28 |
| *** hongbin has quit IRC | 05:28 | |
| pksingh | kevinz: np, | 05:30 |
| pksingh | kevinz: i have a question | 05:30 |
| kevinz | pksingh: yeah go ahead | 05:31 |
| pksingh | kevinz: if i send 'true', then what will be stored in db 'true' or True | 05:33 |
| pksingh | kevinz: have you cheked it in past? i am not sure what will be vaue | 05:35 |
| kevinz | pksingh: Ar, jot yet , I will check it now ~ | 05:37 |
| kevinz | not yet | 05:37 |
| pksingh | kevinz: if it works than i am ready with +2 on patch, otherwise you need to convert it to boolean like we did for 'run' parameter. | 05:40 |
| *** janki has joined #openstack-zun | 06:26 | |
| kevinz | pksingh: Hi , I've checked that if I set tty='false' and stdin_open='false', in db the stored value is always True, since the value is Boolean in db | 06:37 |
| pksingh | kevinz: it means we always need to convert it | 06:43 |
| kevinz | pksingh: Yes , or it will go wrong | 06:44 |
| kevinz | pksingh: According to my understanding, I need to convert the string to boolean before write to the db, am I right? | 06:46 |
| pksingh | kevinz: yes, something like https://github.com/openstack/zun/blob/master/zun/api/controllers/v1/containers.py#L191 | 06:48 |
| kevinz | pksingh: Cool , I will do now, thanks | 06:49 |
| pksingh | kevinz: one more thing, if user dont pass tty or stdin then this will fail because zun cli will pass {'tty':'null'} to api, can you handle that if user dont pass tty then please dont pass that to api | 06:49 |
| pksingh | kevinz: got my point? | 06:50 |
| kevinz | pksingh: Yeah I see, but I've tried that pass tty and stdin_open as null to api will not affect the container creation. | 06:52 |
| kevinz | You mean the "fail" is creating container failing or another thing? | 06:52 |
| pksingh | kevinz: i think validation should fail when you pass tty as null? | 06:55 |
| pksingh | kevinz: http://paste.openstack.org/show/595996/, going for luch, will discuss later | 06:57 |
| kevinz | pksingh: OK. I will see the log | 06:57 |
| *** gbatra_ has quit IRC | 06:59 | |
| *** gb21 has quit IRC | 06:59 | |
| *** pksingh has quit IRC | 07:30 | |
| *** pksingh has joined #openstack-zun | 07:34 | |
| openstackgerrit | feng.shengqin proposed openstack/zun: Support the command "zun top" https://review.openstack.org/423971 | 07:53 |
| kevinz | pksingh: Hi , I suddenly remember that , in the client side, when set '-i -t' , tty will be set to True, and stdin_open will be set to True also. User just need to add parameters "-i -t" https://github.com/openstack/python-zunclient/blob/master/zunclient/v1/containers_shell.py#L101 | 07:55 |
| pksingh | kevinz: if they dont set then what will happen | 07:56 |
| pksingh | if i run 'zun run --name test nginx' then i dont think you are setting false to tty and stdin, correct? | 07:57 |
| openstackgerrit | feng.shengqin proposed openstack/python-zunclient: Support the command "zun top" https://review.openstack.org/423974 | 07:57 |
| kevinz | pksingh: Yeah that will be error as http://paste.openstack.org/show/595996/, I will correct here | 07:58 |
| pksingh | kevinz: i have one suggestion, can you please do me a favour | 07:58 |
| kevinz | OK, go ahead:-) | 07:59 |
| pksingh | kevinz: currently in client when we dont pass a specified parameter suppose 'tty', then it passes 'tty:null' to api, can we implement something like if user dont pass that parameter then dont pass it to api | 08:00 |
| pksingh | kevinz: may be you can log a bug, and fix that all parameters instead of for just tty? | 08:01 |
| kevinz | pksingh: Cool. It's a good solution. I will do this | 08:05 |
| kevinz | pksingh: Thanks a lot | 08:05 |
| *** pksingh has quit IRC | 08:12 | |
| openstackgerrit | Kevin Zhao proposed openstack/zun: Add stdin_open tty flags to container https://review.openstack.org/422524 | 08:58 |
| openstackgerrit | Kevin Zhao proposed openstack/zun: [WIP]Add support for zun attach/resize in server https://review.openstack.org/422525 | 08:58 |
| openstackgerrit | Cao Xuan Hoang proposed openstack/python-zunclient: Remove support for py33 https://review.openstack.org/423998 | 09:01 |
| *** gb21 has joined #openstack-zun | 09:07 | |
| *** gbatra_ has joined #openstack-zun | 09:07 | |
| openstackgerrit | feng.shengqin proposed openstack/zun: Container create failed on horizon plugin https://review.openstack.org/424012 | 09:22 |
| *** yanyanhu has quit IRC | 09:37 | |
| *** pksingh has joined #openstack-zun | 09:40 | |
| pksingh | kevinz: u there? | 09:41 |
| kevinz | kevinz: yes | 09:41 |
| pksingh | kevinz: i think container_dict['tty'] in strutils.bool_from_string(container_dict['tty'], strict=True) will generate exception if field is not provided correct? | 09:42 |
| kevinz | pksingh: Yeah I see that error | 09:43 |
| kevinz | pksingh: maybe I need to add the judgement before bool_from_string? | 09:44 |
| pksingh | kevinz: container_dict.get('tty', False)? | 09:45 |
| pksingh | kevinz: will it work? | 09:45 |
| kevinz | pksingh: I will try this, thanks | 09:55 |
| kevinz | pksingh: after a meeting | 09:55 |
| pksingh | kevinz: its ok, i have no problem, do it at your time | 09:55 |
| kevinz | pksingh: OK thanks~ | 09:56 |
| kevinz | :-) | 09:56 |
| openstackgerrit | feng.shengqin proposed openstack/zun: Support the command "zun top" https://review.openstack.org/423971 | 10:00 |
| *** gbatra_ has quit IRC | 10:14 | |
| *** kevinz has quit IRC | 10:17 | |
| *** trinaths has joined #openstack-zun | 10:19 | |
| *** jchhatbar has joined #openstack-zun | 10:43 | |
| *** janki has quit IRC | 10:45 | |
| *** shubhams has quit IRC | 11:05 | |
| *** pksingh has quit IRC | 11:26 | |
| openstackgerrit | feng.shengqin proposed openstack/python-zunclient: Support the command "zun top" https://review.openstack.org/423974 | 11:48 |
| *** kevinz has joined #openstack-zun | 11:52 | |
| openstackgerrit | feng.shengqin proposed openstack/zun: Support the command "zun top" https://review.openstack.org/423971 | 12:02 |
| *** diga has quit IRC | 12:09 | |
| *** jchhatbar_ has joined #openstack-zun | 12:10 | |
| *** jchhatbar_ is now known as janki | 12:10 | |
| *** jchhatbar has quit IRC | 12:13 | |
| *** shu-mutou is now known as shu-mutou-AWAY | 12:17 | |
| *** gb21 has quit IRC | 12:20 | |
| *** diga has joined #openstack-zun | 12:36 | |
| *** prameswar has joined #openstack-zun | 12:37 | |
| *** trinaths has left #openstack-zun | 12:43 | |
| *** catintheroof has joined #openstack-zun | 12:45 | |
| *** catintheroof has quit IRC | 12:50 | |
| *** catintheroof has joined #openstack-zun | 12:58 | |
| *** jwcroppe has joined #openstack-zun | 13:25 | |
| *** kevinz has quit IRC | 14:00 | |
| openstackgerrit | prameswar proposed openstack/python-zunclient: Changed Optional to Positional arg in zun pull https://review.openstack.org/424130 | 14:06 |
| openstackgerrit | prameswar proposed openstack/python-zunclient: Changed Optional to Positional arg in zun pull https://review.openstack.org/424130 | 14:10 |
| *** hongbin has joined #openstack-zun | 14:20 | |
| *** catinthe_ has joined #openstack-zun | 14:29 | |
| *** catintheroof has quit IRC | 14:32 | |
| *** diga has quit IRC | 14:36 | |
| *** hongbin has quit IRC | 14:39 | |
| *** hongbin has joined #openstack-zun | 14:40 | |
| *** hongbin has quit IRC | 15:00 | |
| *** hongbin_ has joined #openstack-zun | 15:00 | |
| *** hongbin_ has quit IRC | 15:08 | |
| *** janki has quit IRC | 15:33 | |
| *** trinaths1 has joined #openstack-zun | 15:49 | |
| *** hongbin has joined #openstack-zun | 15:56 | |
| *** prameswar has quit IRC | 16:31 | |
| *** trinaths1 has left #openstack-zun | 16:47 | |
| *** lakerzhou has joined #openstack-zun | 17:07 | |
| *** sudipto has quit IRC | 17:30 | |
| *** sudipto_ has quit IRC | 17:30 | |
| *** sudipto_ has joined #openstack-zun | 17:31 | |
| *** sudipto has joined #openstack-zun | 17:31 | |
| *** sudipto has quit IRC | 17:31 | |
| *** sudipto_ has quit IRC | 17:31 | |
| *** catintheroof has joined #openstack-zun | 18:45 | |
| *** catinthe_ has quit IRC | 18:47 | |
| *** manikanta_tadi has joined #openstack-zun | 18:59 | |
| *** catinthe_ has joined #openstack-zun | 19:03 | |
| *** catintheroof has quit IRC | 19:06 | |
| *** strigazi is now known as strigazi_AFK | 19:30 | |
| *** manikanta_tadi has quit IRC | 20:27 | |
| *** irenab has quit IRC | 21:10 | |
| *** irenab has joined #openstack-zun | 21:30 | |
| *** anush has quit IRC | 21:48 | |
| *** harlowja has quit IRC | 22:03 | |
| *** lakerzhou has quit IRC | 22:10 | |
| *** catinthe_ has quit IRC | 23:23 | |
| *** harlowja has joined #openstack-zun | 23:34 | |
| *** harlowja has quit IRC | 23:35 | |
| *** harlowja has joined #openstack-zun | 23:48 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!