Wednesday, 2016-12-07

*** yuanying_ has joined #openstack-zun00:03
*** yuanying has quit IRC00:06
*** yuanying_ has quit IRC00:07
*** catintheroof has quit IRC00:23
*** catintheroof has joined #openstack-zun00:24
*** catintheroof has quit IRC00:28
*** devlaps has quit IRC00:37
*** devlaps has joined #openstack-zun00:39
*** hongbin has quit IRC01:00
*** yuanying has joined #openstack-zun01:04
*** zhangjl has joined #openstack-zun01:14
*** zhurong has joined #openstack-zun01:14
*** zhangjl has quit IRC01:24
*** zhurong has quit IRC01:25
*** zhurong has joined #openstack-zun01:26
*** kevinz has joined #openstack-zun01:28
*** zhurong has quit IRC01:34
*** zhurong has joined #openstack-zun01:35
*** prameswar has joined #openstack-zun01:44
*** yanyanhu has joined #openstack-zun01:48
*** shu-mutou-AWAY is now known as shu-mutou02:01
*** zhangjl has joined #openstack-zun02:22
*** hongbin has joined #openstack-zun02:46
*** yuanying has quit IRC02:58
*** zhangjl has quit IRC03:02
*** gyx has joined #openstack-zun03:05
*** zhangjl has joined #openstack-zun03:17
*** gyx has quit IRC03:22
*** GB21 has joined #openstack-zun03:29
*** GB21 has quit IRC03:36
*** yuanying has joined #openstack-zun03:43
*** yuanying has quit IRC03:48
*** yuanying has joined #openstack-zun03:49
*** yuanying has quit IRC03:53
*** devlaps has quit IRC03:58
*** pksingh has joined #openstack-zun04:03
*** gyx has joined #openstack-zun04:18
*** prameswar has quit IRC04:24
*** zhurong has quit IRC04:27
*** tbh has joined #openstack-zun04:28
pksinghhongbin: Hey, are u there?04:29
*** yuanying has joined #openstack-zun04:40
hongbinpksingh: hey04:45
pksinghhongbin: fixing https://bugs.launchpad.net/zun/+bug/164457004:45
openstackLaunchpad bug 1644570 in Zun "Stop sandbox if container is not running" [Wishlist,In progress] - Assigned to Pradeep Kumar Singh (pradeep-singh-u)04:45
pksinghso need to implement stop sandbox in nova driver04:45
hongbinyes, it is needed04:46
pksinghshould i use stop server call from nova client04:46
pksinghor some other interface04:46
hongbini think you can call nova to stop it04:46
pksinghhttp://docs.openstack.org/developer/python-novaclient/ref/v2/servers.html04:46
pksinghstop call in above document?04:47
pksingham i right?04:47
hongbinthere is a stop()04:47
pksinghyes, i should use that?04:47
hongbini think you can04:48
pksinghok thank you very much, help me in review of the same once i am done04:48
hongbinsure04:49
pksinghhongbin: should i stop the sandbox when container stop api is called?04:49
hongbinthis is an option to fix it04:50
pksinghno there are two issues,04:50
pksingh1) stop the sandbox when container create fails04:51
pksingh2) stop the sandbox when container stop is called04:51
pksingham i right?04:51
hongbini think it is right, fixing this bug is not trivial04:51
hongbinfrankly, leaving the sandbox running is much easier04:52
hongbinwhat do you think?04:52
pksinghwill try to fix it, and lets put openions on review04:53
hongbinok, i can do that04:53
hongbinyes, the bug can be fixed by synchronize the starting and stopping of container and sandbox04:53
pksinghi was thinking container and sandbox operations should be atomic04:54
pksinghlets take other peoples openion04:54
hongbinok04:54
hongbindiscuss it at the next team meeting if you want04:54
pksinghthankyou, it must be late night for u, i would not disturb you more04:54
*** GB21 has joined #openstack-zun04:55
hongbini am ok to fix it or leave it as is04:55
hongbinnp04:55
pksinghok, i have almost fixed it, will discuss in next meeting04:55
hongbinthx04:55
*** hongbin has quit IRC04:58
openstackgerritPradeep Kumar Singh proposed openstack/zun: Stop sandbox when container create fails  https://review.openstack.org/40785005:06
*** yuanying has quit IRC05:13
*** yuanying has joined #openstack-zun05:13
*** GB21 has quit IRC05:13
*** zhenguo_ has joined #openstack-zun05:14
*** zhenguo has quit IRC05:15
*** zhenguo_ is now known as zhenguo05:15
*** coolsvap has joined #openstack-zun05:19
*** zhurong has joined #openstack-zun05:27
*** zhurong has quit IRC05:30
*** zhurong has joined #openstack-zun05:31
*** gyx has quit IRC05:32
*** gyx has joined #openstack-zun05:33
*** GB21 has joined #openstack-zun05:33
*** pksingh has quit IRC05:37
*** pksingh has joined #openstack-zun05:53
*** pksingh has quit IRC06:03
*** pksingh has joined #openstack-zun06:04
*** sudipto has joined #openstack-zun06:08
*** sudipto_ has joined #openstack-zun06:08
openstackgerritWenzhi Yu proposed openstack/zun: Implement etcd db API for image  https://review.openstack.org/40673006:09
*** Wenzhi has joined #openstack-zun06:11
pksingheliqiao_: hello06:17
pksinghWenzhi: u there?06:20
Wenzhipksngh: ye06:21
Wenzhisorry06:21
Wenzhipksingh06:21
Wenzhijust left some comment on your patch 40785006:24
pksinghthanks :)06:26
Wenzhiwelcome06:26
pksinghWenzhi: do you have any idea how ids are generated , https://github.com/openstack/zun/blob/master/zun/tests/tempest/api/test_containers.py#L108,06:27
Wenzhipksingh: please refer to http://docs.openstack.org/developer/tempest/HACKING.html#test-identification-with-idempotent-id06:29
pksinghWenzhi: how can i generate one, is there any tool for that in tempest?06:31
Wenzhiyes06:31
Wenzhijust run check-uuid --fix06:31
Wenzhiit will generate the uuids for you06:32
pksinghfor that i need to setup tempest right?06:32
Wenzhiyes, I think so06:33
pksinghok thanks a lot :)06:34
Wenzhi:)06:34
*** janki has joined #openstack-zun06:35
*** sudipto has quit IRC06:37
*** sudipto_ has quit IRC06:37
*** diga has joined #openstack-zun06:38
pksinghWenzhi: could you plz suggest what do you mean by this comment, "These code would never been called, seems you should move them into the try block?"06:48
Wenzhihttps://review.openstack.org/#/c/407850/1/zun/compute/manager.py line 268-27406:50
Wenzhiwhen would these code been called?06:50
pksinghWenzhi: thanks, i got it06:50
pksinghWenzhi: function is returning from try block06:51
pksinghWenzhi: my bad :(06:51
pksinghWenzhi: nice catch06:51
Wenzhi:)06:51
*** pksingh has quit IRC06:55
*** zhurong has quit IRC07:01
*** zhurong has joined #openstack-zun07:02
*** yuanying has quit IRC07:05
*** yuanying has joined #openstack-zun07:17
*** pksingh has joined #openstack-zun07:19
openstackgerritPradeep Kumar Singh proposed openstack/zun: Stop sandbox when container create fails  https://review.openstack.org/40785007:25
*** zhangjl1 has joined #openstack-zun07:27
*** zhangjl has quit IRC07:28
*** pksingh has quit IRC07:29
*** pksingh has joined #openstack-zun07:30
*** zhangjl1 has quit IRC07:31
*** zhangjl has joined #openstack-zun07:32
*** exploreshaifali has joined #openstack-zun07:39
*** gyx has quit IRC07:48
*** zhurong has quit IRC08:00
*** zhurong has joined #openstack-zun08:01
*** pksingh_ has joined #openstack-zun08:02
*** pksingh has quit IRC08:04
*** irenab has quit IRC08:04
*** irenab has joined #openstack-zun08:05
*** yuanying has quit IRC08:08
*** exploreshaifali has quit IRC08:08
*** irenab has quit IRC08:18
*** irenab has joined #openstack-zun08:18
openstackgerritPradeep Kumar Singh proposed openstack/zun: Delete sandbox when container create fails  https://review.openstack.org/40785008:19
openstackgerritPradeep Kumar Singh proposed openstack/zun: Delete sandbox when container create fails  https://review.openstack.org/40785008:24
*** eliqiao_ has quit IRC08:41
*** pksingh_ has quit IRC08:43
*** pksingh_ has joined #openstack-zun08:46
*** exploreshaifali has joined #openstack-zun08:51
*** yuanying has joined #openstack-zun08:59
*** eliqiao has joined #openstack-zun09:01
openstackgerritguo yunxian proposed openstack/zun: Modify something in types.py  https://review.openstack.org/40794509:07
*** eliqiao has quit IRC09:11
*** Wenzhi has quit IRC09:15
*** zhangjl1 has joined #openstack-zun09:17
*** sudipto has joined #openstack-zun09:19
*** sudipto_ has joined #openstack-zun09:19
*** zhangjl has quit IRC09:20
*** tbh has quit IRC09:21
*** pksingh_ has quit IRC09:27
*** pksingh_ has joined #openstack-zun09:28
*** sudipto has quit IRC09:31
*** sudipto_ has quit IRC09:31
*** shubhams has quit IRC09:33
*** GB21 has quit IRC09:55
*** zhurong has quit IRC10:03
*** irenab has quit IRC10:09
*** irenab has joined #openstack-zun10:09
*** prameswar has joined #openstack-zun10:14
pksingh_diga: hey, r u there?10:17
*** GB21 has joined #openstack-zun10:19
digapksingh_: hi10:29
pksingh_diga: its regarding https://review.openstack.org/#/c/407850/10:29
digayes10:30
pksingh_diga: your first comment, what do you want to say, client is method https://github.com/openstack/zun/blob/master/zun/common/nova.py#L5210:31
pksingh_diga: am i missing something?10:31
digapksingh_: if this is the think already followed, then I will talk to mkrai on this10:33
digapksingh_: you should provide exception thing10:33
digas/provide/fix10:33
digamkrai: Hi10:35
pksingh_diga: i totally agree with you, currently exception handling is not robust in compute service , i am working on that, you can find the same pattern at many places.10:36
pksingh_diga: i will fix that when i will fix https://bugs.launchpad.net/zun/+bug/163933310:36
openstackLaunchpad bug 1639333 in Zun "Remove Docker-specific code from manager" [Medium,Triaged] - Assigned to Pradeep Kumar Singh (pradeep-singh-u)10:36
*** prameswar has quit IRC10:37
*** prameswar has joined #openstack-zun10:37
*** prameswar has quit IRC10:38
*** prameswar has joined #openstack-zun10:38
pksingh_diga: what do you think about client method implementation? is any thing wrong there?10:43
digapksingh_: just import exception in https://github.com/openstack/zun/blob/master/zun/common/exception.py10:43
digapksingh_: client looks good I guess if such code practice is followed in10:45
pksingh_diga: i totally get your point thay we should handle specific exceptions not generic ones,10:45
digapksingh_: need change, but will do it later on10:45
*** yanyanhu has quit IRC10:46
*** sudipto has joined #openstack-zun10:46
*** sudipto_ has joined #openstack-zun10:46
pksingh_diga: but currently exceptions are not good specially in container drivers10:46
pksingh_diga: we need to add some more exception class, once i add those i willl handle in same patch10:47
pksingh_diga: it is planned for next week :)10:47
*** pksingh_ has quit IRC10:53
openstackgerritguo yunxian proposed openstack/zun: Delete unreachable code and use cls in classmethod  https://review.openstack.org/40794511:01
*** pksingh_ has joined #openstack-zun11:03
*** GB21 has quit IRC11:10
*** zhangjl1 has quit IRC11:14
*** pksingh_ has quit IRC11:17
*** GB21 has joined #openstack-zun11:24
*** openstackgerrit has quit IRC11:32
*** sudipto_ has quit IRC11:36
*** sudipto has quit IRC11:36
*** exploreshaifali has quit IRC11:45
*** shu-mutou is now known as shu-mutou-AWAY11:47
*** catintheroof has joined #openstack-zun11:55
*** irenab has quit IRC12:18
*** irenab has joined #openstack-zun12:18
*** GB21 has quit IRC12:28
*** catintheroof has quit IRC12:32
*** catintheroof has joined #openstack-zun12:32
*** catintheroof has quit IRC12:37
*** catintheroof has joined #openstack-zun12:54
*** kevinz has quit IRC12:59
*** catinthe_ has joined #openstack-zun13:14
*** catintheroof has quit IRC13:16
*** kevinz has joined #openstack-zun13:28
*** sudipto has joined #openstack-zun13:38
*** sudipto_ has joined #openstack-zun13:38
*** openstackgerrit has joined #openstack-zun13:41
*** catintheroof has joined #openstack-zun14:02
*** exploreshaifali has joined #openstack-zun14:04
*** catinthe_ has quit IRC14:04
sudiptomkrai, if i don't configure glance, i can't use zun right now?14:06
*** tbh has joined #openstack-zun14:14
*** diga has quit IRC14:20
*** lakerzhou_ has joined #openstack-zun14:20
*** coolsvap has quit IRC14:27
mkraisudipto: it should run14:31
mkraiIt is configurable14:31
sudiptomkrai, for me it does not.14:31
mkraiYou can either use docker or glance to manage your images or use both14:31
sudiptoi will show you the error14:31
sudiptoand you can help me...14:32
mkraiI read the bug14:32
mkraiWhat's the image14:32
mkraiSorry14:32
sudiptoubuntu14:32
mkraiWhat's the image_driver in your zun.conf?14:32
sudiptomkrai, none.14:32
sudiptoi don't even have that parameter in zun.conf14:33
mkraigive me a min14:33
mkraiIts an error14:33
mkraiLook here14:33
mkraihttps://github.com/openstack/zun/blob/master/zun/conf/image_driver.py#L2114:33
mkraiThe default value has glance14:34
mkraiglance should not be in default value IMO14:34
mkraisudipto: What do you think?14:34
sudiptohttps://github.com/openstack/zun/blob/1c2a8c37a42eee41adf7d8effe69b2e3161a3baa/zun/conf/image_driver.py#L2114:34
sudiptosigh, same line :D14:35
sudiptointeresting...give me few mins...basically i would not want glance to be there, but i remember, we decided to look at glance first...and then look at docker.14:35
mkraiyes14:36
sudiptoso the code seems to be behaving as expected.14:36
mkraiyes as discussed14:36
sudiptolet's discuss this once with hongbin when he is online...14:36
sudiptoand if you are around :)14:36
mkraiok14:37
mkraiI will be around14:37
mkraiYou have got one bug :)14:37
sudiptothe all-tenants one?14:37
mkraino this one14:38
mkraimay be ;)14:38
sudiptolol14:38
sudiptoyeah sure14:38
sudiptoi started playing with zun today...spotted that we are using dictcompat for all objects, remember nova getting rid of them (i did few patches there) - wonder if we need them in zun14:39
sudiptobrb14:39
mkraisure14:41
mkraiCan you share link?14:41
*** irenab has quit IRC14:56
*** exploreshaifali has quit IRC14:58
*** irenab has joined #openstack-zun14:59
*** irenab has quit IRC15:06
*** hongbin has joined #openstack-zun15:07
*** irenab has joined #openstack-zun15:14
*** irenab has quit IRC15:21
*** catintheroof has quit IRC15:26
*** catintheroof has joined #openstack-zun15:26
*** irenab has joined #openstack-zun15:28
*** catintheroof has quit IRC15:31
*** irenab has quit IRC15:35
*** exploreshaifali has joined #openstack-zun15:36
openstackgerritMerged openstack/zun: Updated from global requirements  https://review.openstack.org/40812315:38
*** irenab has joined #openstack-zun15:39
*** irenab has quit IRC15:42
sudiptomkrai, https://blueprints.launchpad.net/nova/+spec/rm-object-dict-compat15:43
sudiptohongbin, ^15:44
sudiptothink we need a bug for that?15:44
*** janki has quit IRC15:45
hongbinsudipto: ok, let me create a bp for that15:46
sudiptohongbin, you can assign that BP to me, or i can assign it to myself once done...15:46
*** irenab has joined #openstack-zun15:49
hongbinsudipto: assigned it to you15:49
sudiptohongbin, thanks!15:50
hongbinsudipto: mkrai : btw, i raised a ML to continue the k8s discussion: http://lists.openstack.org/pipermail/openstack-dev/2016-December/108569.html . chime in to thread once you have a chance (not urgent)15:51
*** kevinz has quit IRC15:55
sudiptohongbin, sure15:57
*** catintheroof has joined #openstack-zun15:57
*** irenab has quit IRC15:57
*** diga has joined #openstack-zun16:00
*** irenab has joined #openstack-zun16:08
*** irenab has quit IRC16:12
*** irenab has joined #openstack-zun16:23
*** irenab has quit IRC16:30
*** irenab has joined #openstack-zun16:38
*** exploreshaifali has quit IRC16:41
*** devlaps has joined #openstack-zun16:43
*** irenab has quit IRC16:49
*** diga has quit IRC16:50
*** tbh has quit IRC16:53
mkraihongbin: sure.16:55
mkraiThanks!16:55
*** prameswar has quit IRC17:33
*** prameswar has joined #openstack-zun17:39
*** sudipto_ has quit IRC17:42
*** sudipto has quit IRC17:42
*** strigazi is now known as strigazi_AFK17:46
*** tbh has joined #openstack-zun17:47
*** prameswar has quit IRC18:20
*** exploreshaifali has joined #openstack-zun18:25
*** irenab has joined #openstack-zun18:45
*** tbh has quit IRC18:50
*** irenab has quit IRC19:28
*** irenab has joined #openstack-zun19:30
*** tbh has joined #openstack-zun19:42
*** irenab has quit IRC19:44
*** irenab has joined #openstack-zun19:52
*** tbh has quit IRC19:52
*** exploreshaifali has quit IRC19:55
*** irenab has quit IRC20:00
*** irenab has joined #openstack-zun20:08
*** irenab has quit IRC20:20
*** irenab has joined #openstack-zun20:27
*** irenab has quit IRC20:38
*** harlowja has quit IRC20:41
flwanghongbin: sorry for the late response. re your question about PTG, no, i won't be there due to limited budget20:43
flwangP.S. i was in vacation for the last week20:43
hongbinflwang: ack20:43
hongbinflwang: good for you :)20:44
hongbinenjoy20:44
flwanghongbin: TBH, I still think the PTG isn't a good idea20:44
flwangat least it doesn't work for AP people20:44
hongbini feel the same :)20:44
hongbini actually wrote an email in openstack-dev when they were discussing it20:45
*** irenab has joined #openstack-zun20:46
hongbinhowever, it still happens...20:46
flwanganyway, i won't be there, unless it happens in AP :)20:49
flwanghongbin: btw, congrats for the big tent20:49
flwangthough some people is talking about bull shit as a service somewhere :D20:50
hongbinflwang: well congrats to everyone (including you :) )20:50
hongbin....20:50
flwanghah20:50
flwangdon't mind20:50
flwangi'm going to contribute magnum/zun with some code instead of just reading the code :D20:51
*** irenab has quit IRC20:54
hongbingood to hear20:59
*** irenab has joined #openstack-zun21:01
*** irenab has quit IRC21:10
*** irenab has joined #openstack-zun21:21
*** irenab has quit IRC21:31
*** catintheroof has quit IRC21:37
*** catintheroof has joined #openstack-zun21:38
*** irenab has joined #openstack-zun21:38
*** harlowja has joined #openstack-zun21:41
*** catintheroof has quit IRC21:42
*** irenab has quit IRC21:48
*** irenab has joined #openstack-zun21:59
*** irenab has quit IRC22:07
*** irenab has joined #openstack-zun22:14
*** irenab has quit IRC22:19
*** lakerzhou_ has quit IRC22:21
openstackgerritHongbin Lu proposed openstack/zun: Be robust on deleting a non-existing sandbox  https://review.openstack.org/40834223:02
*** harlowja has quit IRC23:16
openstackgerritMerged openstack/zun: Delete sandbox when container create fails  https://review.openstack.org/40785023:38

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!