| *** iceyao has joined #openstack-zun | 00:35 | |
| *** yanyanhu has joined #openstack-zun | 01:24 | |
| *** sudipto has joined #openstack-zun | 03:03 | |
| *** sheel has joined #openstack-zun | 03:10 | |
| *** sudipto has quit IRC | 03:24 | |
| *** GB21 has joined #openstack-zun | 04:37 | |
| *** mkrai has joined #openstack-zun | 04:37 | |
| *** GB21 has quit IRC | 04:42 | |
| *** sheel has quit IRC | 05:20 | |
| *** mkrai has quit IRC | 05:26 | |
| *** GB21 has joined #openstack-zun | 05:56 | |
| *** pksingh has joined #openstack-zun | 06:36 | |
| *** GB21 has quit IRC | 06:47 | |
| *** zhurong has joined #openstack-zun | 06:57 | |
| *** GB21 has joined #openstack-zun | 06:59 | |
| *** coolsvap has joined #openstack-zun | 06:59 | |
| *** zhurong_ has joined #openstack-zun | 06:59 | |
| *** zhurong has quit IRC | 07:02 | |
| *** zhurong_ has quit IRC | 07:03 | |
| *** shubhams has left #openstack-zun | 07:05 | |
| *** pksingh has quit IRC | 07:14 | |
| *** harlowja has joined #openstack-zun | 07:17 | |
| *** GB21 has quit IRC | 07:19 | |
| *** GB21 has joined #openstack-zun | 07:33 | |
| eliqiao | mkrai, sure, I commented on it. | 07:50 |
|---|---|---|
| openstackgerrit | Pradeep Kumar Singh proposed openstack/zun: Add status_reason column to 'container' table https://review.openstack.org/391366 | 08:05 |
| *** sheel has joined #openstack-zun | 08:40 | |
| *** vikasc has quit IRC | 08:42 | |
| openstackgerrit | Deepak proposed openstack/zun-ui: Enable DeprecationWarning in test environments https://review.openstack.org/390757 | 08:48 |
| *** iceyao has quit IRC | 08:57 | |
| *** iceyao has joined #openstack-zun | 08:57 | |
| *** janki has joined #openstack-zun | 09:04 | |
| *** iceyao_ has joined #openstack-zun | 09:21 | |
| *** iceyao has quit IRC | 09:25 | |
| *** GB21 has quit IRC | 09:29 | |
| *** pksingh has joined #openstack-zun | 09:34 | |
| pksingh | eliqiao: Hi , are u there? | 09:35 |
| eliqiao | yes pksingh | 09:44 |
| eliqiao | what can I help? | 09:44 |
| pksingh | eliqiao: its about https://review.openstack.org/#/c/391366/ | 09:45 |
| pksingh | eliqiao: so you want me to write the UTs, correct | 09:45 |
| *** yanyanhu has quit IRC | 09:46 | |
| eliqiao | pksingh: yes. and I don't think you finish that bug | 09:46 |
| eliqiao | which is reported by myself, right? | 09:46 |
| eliqiao | do you have following patches ? | 09:46 |
| pksingh | yes, https://bugs.launchpad.net/zun/+bug/1634760 | 09:46 |
| openstack | Launchpad bug 1634760 in Zun "Add fail reason to container object" [Wishlist,In progress] - Assigned to Pradeep Kumar Singh (pradeep-singh-u) | 09:46 |
| pksingh | eliqiao: will fix above bug in next patch | 09:46 |
| pksingh | eliqiao: is it ok? | 09:47 |
| *** yanyanhu has joined #openstack-zun | 09:47 | |
| eliqiao | okay, so please don't use closes-bug, you can use partial(something like this) | 09:47 |
| pksingh | eliqiao: i mentioned the same in commit message | 09:47 |
| eliqiao | pksingh: okay feel free to split patches. | 09:47 |
| pksingh | eliqiao: there are two bugs for the same | 09:48 |
| pksingh | eliqiao: so i thought to submit two patches | 09:48 |
| eliqiao | sure, I see. but closes-bugs tag is not corrext. | 09:48 |
| *** yanyanhu has quit IRC | 09:48 | |
| eliqiao | 2 bugs? | 09:48 |
| eliqiao | really? | 09:48 |
| pksingh | https://bugs.launchpad.net/zun/+bug/1634760 | 09:49 |
| openstack | Launchpad bug 1634760 in Zun "Add fail reason to container object" [Wishlist,In progress] - Assigned to Pradeep Kumar Singh (pradeep-singh-u) | 09:49 |
| pksingh | https://bugs.launchpad.net/zun/+bug/1614398 | 09:49 |
| openstack | Launchpad bug 1614398 in Zun "Show status reason for container" [High,In progress] - Assigned to Pradeep Kumar Singh (pradeep-singh-u) | 09:49 |
| pksingh | eliqiao: so do you feel it ok? i will add unit test to patch | 09:51 |
| eliqiao | pksingh: this patch https://review.openstack.org/#/c/391366/ should closes bug 1634760, not 1614398 | 09:51 |
| openstack | bug 1634760 in Zun "Add fail reason to container object" [Wishlist,In progress] https://launchpad.net/bugs/1634760 - Assigned to Pradeep Kumar Singh (pradeep-singh-u) | 09:51 |
| eliqiao | okay, correct closes-bug and add more ut for this patch, then submit another patch on top of this one to closes 1614398 | 09:52 |
| pksingh | eliqiao: ok sure thanks :) | 09:52 |
| eliqiao | pksingh: thanks the the ping :) | 09:54 |
| *** harlowja has quit IRC | 09:55 | |
| *** harlowja has joined #openstack-zun | 09:55 | |
| openstackgerrit | Pradeep Kumar Singh proposed openstack/zun: Add status_reason column to 'container' table https://review.openstack.org/391366 | 09:56 |
| *** vikasc has joined #openstack-zun | 10:00 | |
| *** pksingh has quit IRC | 10:08 | |
| *** zhurong has joined #openstack-zun | 10:10 | |
| *** zhurong has quit IRC | 10:12 | |
| *** iceyao_ has quit IRC | 10:12 | |
| *** zhurong_ has joined #openstack-zun | 10:16 | |
| *** janki has quit IRC | 10:30 | |
| *** zhurong_ has quit IRC | 10:45 | |
| *** zhurong has joined #openstack-zun | 10:45 | |
| *** zhurong has quit IRC | 10:50 | |
| *** harlowja has quit IRC | 11:04 | |
| *** GB21 has joined #openstack-zun | 11:59 | |
| *** harlowja has joined #openstack-zun | 12:08 | |
| openstackgerrit | Pradeep Kumar Singh proposed openstack/zun: Add status_reason column to 'container' table https://review.openstack.org/391366 | 12:12 |
| *** vikasc has quit IRC | 12:20 | |
| *** hehx has quit IRC | 12:20 | |
| *** harlowja has quit IRC | 12:33 | |
| *** hehx has joined #openstack-zun | 12:36 | |
| *** janki has joined #openstack-zun | 12:36 | |
| *** vikasc has joined #openstack-zun | 12:36 | |
| *** iceyao has joined #openstack-zun | 12:48 | |
| *** GB21 has quit IRC | 12:55 | |
| *** janki has quit IRC | 13:11 | |
| *** harlowja has joined #openstack-zun | 13:26 | |
| openstackgerrit | abdul nizamuddin proposed openstack/zun-ui: Drop MANIFEST.in - it's not needed by pbr https://review.openstack.org/391475 | 13:39 |
| openstackgerrit | abdul nizamuddin proposed openstack/zun-ui: Don't include openstack/common in flake8 exclude list https://review.openstack.org/391488 | 14:02 |
| *** sheel has quit IRC | 14:10 | |
| *** harlowja has quit IRC | 14:22 | |
| *** harlowja has joined #openstack-zun | 14:33 | |
| *** harlowja has quit IRC | 14:35 | |
| *** harlowja has joined #openstack-zun | 14:38 | |
| *** harlowja has quit IRC | 14:42 | |
| *** harlowja has joined #openstack-zun | 15:01 | |
| *** harlowja has quit IRC | 15:07 | |
| *** zhurong has joined #openstack-zun | 16:00 | |
| *** zhurong has quit IRC | 16:04 | |
| *** iceyao has quit IRC | 17:06 | |
| *** iceyao has joined #openstack-zun | 17:07 | |
| *** pksingh has joined #openstack-zun | 17:13 | |
| *** pksingh has quit IRC | 17:14 | |
| *** pksingh has joined #openstack-zun | 17:15 | |
| *** pksingh has left #openstack-zun | 17:16 | |
| *** pksingh has joined #openstack-zun | 17:17 | |
| *** pksingh has quit IRC | 17:20 | |
| *** pksingh has joined #openstack-zun | 17:21 | |
| *** pksingh has quit IRC | 17:22 | |
| *** coolsvap has quit IRC | 17:46 | |
| *** iceyao has quit IRC | 17:52 | |
| *** sheel has joined #openstack-zun | 18:09 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!