| *** david-lyle has joined #openstack-zaqar | 00:09 | |
| *** david-lyle has quit IRC | 00:20 | |
| *** wanghao has joined #openstack-zaqar | 00:52 | |
| *** zhurong has joined #openstack-zaqar | 01:13 | |
| openstackgerrit | Feilong Wang proposed openstack/zaqar master: Support cold migration https://review.openstack.org/426943 | 01:19 |
|---|---|---|
| *** tqtran has quit IRC | 01:23 | |
| wanghao | flwang: wxy: hi, guys, about this patch: https://review.openstack.org/#/c/430530/3. For backward compatibility, I transform the keys before sending it to user. Any better idea? | 01:27 |
| wanghao | or we shouldn't change the code? | 01:27 |
| *** yanyanhu has joined #openstack-zaqar | 01:31 | |
| flwang | wanghao: can you reminder me that if user can see these headers? | 01:31 |
| wanghao | flwang: at least developers can see these headers, since Zaqar send the confirmation reqeust to webhook endpoint. | 01:33 |
| wanghao | flwang: those headers which we changed now are in the request body. | 01:34 |
| flwang | developers are our users :) | 01:34 |
| wanghao | flwang: yes | 01:34 |
| flwang | the only problem is we're using those headers to generate the signature? | 01:35 |
| wanghao | flwang: yes, users should use those header in request body to make a request to Zaqar to confirm the subscription. | 01:37 |
| wanghao | flwang: the flow is: Zaqar send those headers to user, user uses those header to make a pre-singed url request to Zaqar for confirming the subscription. | 01:38 |
| flwang | but technically, user's script/app won't hardcode those headers, but getting and forwarding | 01:39 |
| *** vsv has quit IRC | 01:39 | |
| flwang | so even if we changed them, it shouldn't break the compatibility, thoughts? | 01:40 |
| wanghao | flwang: it should, but since we changed the key in dict of request, so script/app should have a little changed too. | 01:40 |
| flwang | this is the sample we have https://github.com/openstack/zaqar/blob/master/samples/zaqar/subscriber_service_sample.py | 01:42 |
| flwang | i can't see those headers are hardcode | 01:42 |
| flwang | wait | 01:43 |
| wanghao | flwang: for example, if app get the project_id value by using 'X-Project-Id' key now, after this patch, they need to change by using 'x-project-id'. | 01:43 |
| wanghao | flwang: we have hardcode in example. | 01:43 |
| flwang | yep, i saw that | 01:43 |
| flwang | it's hard | 01:46 |
| wxy | flwang: wanghao :So if we change to lowercase, it will break backward compatibility | 01:50 |
| wxy | leave as it is. Or ignore this small incompatibility. | 01:50 |
| flwang | yep, i know | 01:50 |
| wanghao | flwang: seems yes, or we send the low case and capital case both now, and deprecate the capitalcase in sometime. | 01:51 |
| wxy | wanghao: it's a way. But a little heavy. Does it worth? | 01:51 |
| *** zhurong has quit IRC | 01:52 | |
| wanghao | wxy: a little heavy indeed. If we decide to change it, it could be worked. | 01:53 |
| wxy | wanghao: It's the only way I can see. | 01:58 |
| wxy | flwang: any idea? | 01:58 |
| flwang | i'm recalling why i approved it before :) | 01:58 |
| flwang | in other words | 01:58 |
| flwang | i'm thinking if it's so terrible | 01:59 |
| flwang | as wxy said above: 1. fix it, and we can backport it to Newton, technically | 02:00 |
| flwang | 2. leave it as it's | 02:00 |
| wxy | I used capital in this feature just because pre-sign request used it. https://github.com/openstack/zaqar/blob/master/zaqar/common/transport/wsgi/helpers.py#L36-L40 | 02:00 |
| flwang | wxy: yep, that's a good point | 02:03 |
| flwang | and i'm thinking developers, especially java developers may be like this | 02:04 |
| wxy | I used capital in this feature just because pre-sign request used it. https://github.com/openstack/zaqar/blob/master/zaqar/common/transport/wsgi/helpers.py#L36-L40 | 02:05 |
| wxy | sorry.. | 02:05 |
| wxy | So fix it and backup port it? | 02:05 |
| wxy | backport | 02:06 |
| flwang | ok, let me make the decision, let's keep it as it's | 02:06 |
| flwang | until we really get a complain | 02:06 |
| flwang | before that, let's don't annoy ourselves | 02:06 |
| wxy | flwang: +1 | 02:07 |
| wanghao | flwang: sound great | 02:07 |
| flwang | thank you, guys | 02:07 |
| flwang | i'm running into some problems to setup the devstack to test wanghao's email confirmation patch | 02:08 |
| flwang | we need to get it done before 16th | 02:08 |
| wanghao | flwang: yes, I prepare to build web server to test it too. | 02:09 |
| wxy | So we really need some one to test it with real env. | 02:10 |
| flwang | wxy: i'm going to do that | 02:11 |
| *** zhurong has joined #openstack-zaqar | 02:12 | |
| openstackgerrit | Feilong Wang proposed openstack/zaqar master: Support cold migration https://review.openstack.org/426943 | 02:15 |
| wanghao | flwang: wxy: thanks guys for testing this feature. | 02:17 |
| wanghao | flwang: BTW, will abandon the lowcase patch. | 02:18 |
| *** wanghao_ has joined #openstack-zaqar | 02:19 | |
| *** wanghao has quit IRC | 02:22 | |
| *** zhurong has quit IRC | 02:25 | |
| *** zhurong has joined #openstack-zaqar | 02:29 | |
| *** zhurong has quit IRC | 02:38 | |
| flwang | wxy: wanghao_: did you see 500 error when using latest devstack for zaqar? | 02:38 |
| wxy | flwang: I use the latest Zaqar code. It works well. I did not use the latest devstack. | 02:40 |
| flwang | wxy: ok | 02:42 |
| flwang | thanks | 02:42 |
| flwang1 | wxy: i'm seeing this http://paste.openstack.org/show/598329/ | 02:43 |
| flwang1 | wxy: what's your keystoneauth version? | 02:43 |
| wxy | 2.18.0 | 02:44 |
| wxy | is the "auth_url" option correct in your zaqar.conf? | 02:45 |
| wxy | and my keystonemiddleware is 4.13.0 | 02:46 |
| flwang | got, thanks | 02:46 |
| *** zhurong has joined #openstack-zaqar | 02:50 | |
| *** harlowja has quit IRC | 02:53 | |
| flwang | wanghao_: wxy: https://review.openstack.org/#/c/426943/ | 02:57 |
| wxy | flwang: cool! | 02:58 |
| wxy | flwang: Jenkins happy now. I'd like to review it right now.:) | 02:58 |
| *** zhurong has quit IRC | 02:59 | |
| flwang | wxy: it's not perfect. but the whole flow works now | 02:59 |
| flwang | and we can polish it later | 03:00 |
| flwang | wanghao_: ping | 03:10 |
| flwang | did you ever tried SNS? | 03:11 |
| flwang | if not, i would like to suggest give it a try | 03:11 |
| flwang | so that you can understand the whole process better? | 03:11 |
| wxy | flwang: for the cold migration patch, As i know, it tests sqlalchemy migration. Right? | 03:12 |
| flwang | for example, the config for emails | 03:12 |
| flwang | after my previous comment, you added a email body for unsubsribe | 03:12 |
| flwang | but meanwhile, the unsubscribe email could has different topic and sender as well | 03:13 |
| flwang | wxy: it's mainly testing the config and db | 03:13 |
| flwang | but we haven't done the work for mysql yet | 03:13 |
| flwang | i will have to work out another patch to do that | 03:13 |
| flwang | because in our test, mongo+mongo is fine | 03:14 |
| flwang | sql+redis, we need some work | 03:14 |
| flwang | sql+swift, need some work | 03:14 |
| wxy | flwang: both mongodb CI and redis CI uses mongoDB as the backend. | 03:14 |
| flwang | wxy: you mean redis CI is using mongDB as the management store? | 03:15 |
| flwang | i can't remember it clearly, TBH | 03:15 |
| wxy | flwang: yes | 03:15 |
| flwang | let me check | 03:15 |
| wxy | flwang: redis CI use mongoDB as management_store and message_store | 03:16 |
| flwang | wxy: https://github.com/openstack/zaqar/blob/master/devstack/plugin.sh#L126 | 03:16 |
| flwang | wxy: are you sure? can you show me the code? | 03:17 |
| wxy | flwang: you can see the CI log which is strange | 03:17 |
| wxy | http://logs.openstack.org/43/426943/11/check/gate-grenade-dsvm-redis-zaqar-ubuntu-xenial-nv/5cdb892/logs/etc/zaqar/ | 03:17 |
| flwang | wxy: oh, you mean this one | 03:17 |
| wxy | So we missed ZAQAR_BACKEND env | 03:18 |
| flwang | i was thinking you're talking about current tempest CI | 03:18 |
| wxy | :) | 03:18 |
| flwang | for this one, could be a bug | 03:18 |
| wxy | Ok, I guess we missed ZAQAR_BACKEND=redis in project-config | 03:19 |
| wxy | flwang: we set ZAQAR_BACKEND in zaqar.devstack.gate.gate_hook.sh | 03:26 |
| wxy | flwang: but we missed to call it in project-config | 03:26 |
| wxy | flwang: called pre_test_hook.sh | 03:27 |
| wxy | So you should init ZAQAR_BACKEND there. | 03:27 |
| flwang | yep, i know. i'm thinking a way to avoid change project-config code | 03:31 |
| wxy | flwang: Maybe we can't. Because we can't know which is mongo and which is redis. | 03:35 |
| wxy | the "backend" at here https://github.com/openstack-infra/project-config/blob/master/jenkins/jobs/zaqar.yaml#L129 didn't be used anywhere. | 03:36 |
| *** flwang1 has quit IRC | 03:37 | |
| *** lhx__ has joined #openstack-zaqar | 04:00 | |
| *** lhx__ has quit IRC | 04:07 | |
| *** lhx__ has joined #openstack-zaqar | 04:07 | |
| *** shu-mutou has joined #openstack-zaqar | 04:27 | |
| *** shu-mutou-AWAY has quit IRC | 04:29 | |
| *** lhx__ has quit IRC | 04:40 | |
| *** lhx__ has joined #openstack-zaqar | 04:51 | |
| *** mpanetta_ has joined #openstack-zaqar | 04:53 | |
| *** mpanetta has quit IRC | 04:53 | |
| *** lhx__ has quit IRC | 05:06 | |
| *** lhx__ has joined #openstack-zaqar | 05:06 | |
| *** wanghao_ has quit IRC | 05:47 | |
| *** wanghao has joined #openstack-zaqar | 05:48 | |
| *** lhx__ has quit IRC | 05:50 | |
| wanghao | flwang: yes, I tried SNS, it has different topic for subscription and unsubscribe confirmation, but have same email sender. | 06:01 |
| wanghao | flwang: I will update the patch better. | 06:02 |
| *** nadya has joined #openstack-zaqar | 06:04 | |
| *** tqtran has joined #openstack-zaqar | 06:05 | |
| *** nadya has quit IRC | 06:08 | |
| *** tqtran has quit IRC | 06:10 | |
| *** wanghao_ has joined #openstack-zaqar | 06:15 | |
| *** wanghao has quit IRC | 06:17 | |
| *** nadya has joined #openstack-zaqar | 06:19 | |
| openstackgerrit | wanghao proposed openstack/zaqar master: Subscription Confirmation Support-3 https://review.openstack.org/389473 | 06:27 |
| *** wanghao has joined #openstack-zaqar | 06:36 | |
| *** wanghao__ has joined #openstack-zaqar | 06:38 | |
| *** wanghao_ has quit IRC | 06:40 | |
| *** wanghao has quit IRC | 06:41 | |
| *** lhx__ has joined #openstack-zaqar | 06:50 | |
| openstackgerrit | Merged openstack/zaqar-ui master: Updated from global requirements https://review.openstack.org/432125 | 06:56 |
| *** rcernin has joined #openstack-zaqar | 07:03 | |
| *** pcaruana has joined #openstack-zaqar | 07:30 | |
| *** yanyanhu has quit IRC | 09:08 | |
| *** wanghao__ has quit IRC | 09:59 | |
| *** tqtran has joined #openstack-zaqar | 10:08 | |
| *** tqtran has quit IRC | 10:12 | |
| *** openstackgerrit has quit IRC | 10:18 | |
| *** tesseract has joined #openstack-zaqar | 11:50 | |
| *** amoralej has joined #openstack-zaqar | 12:13 | |
| amoralej | hi zaqar, i've observed that zaqarclient doesn't have stable/ocata branch, any plan to create it? | 12:15 |
| amoralej | and there will be new release in ocata? | 12:16 |
| *** nadya has quit IRC | 12:51 | |
| *** lhx__ has quit IRC | 13:00 | |
| *** lhx__ has joined #openstack-zaqar | 13:38 | |
| *** amoralej is now known as amoralej|lunch | 14:19 | |
| *** amoralej|lunch is now known as amoralej | 14:46 | |
| *** nadya has joined #openstack-zaqar | 15:42 | |
| *** nadya has quit IRC | 15:46 | |
| *** rbrady is now known as rbrady-afk | 16:05 | |
| *** rcernin has quit IRC | 16:06 | |
| *** lhx__ has quit IRC | 16:35 | |
| *** tesseract has quit IRC | 16:45 | |
| *** pcaruana has quit IRC | 16:53 | |
| *** nadya has joined #openstack-zaqar | 16:59 | |
| *** nadya has quit IRC | 16:59 | |
| *** harlowja has joined #openstack-zaqar | 17:05 | |
| *** harlowja has quit IRC | 17:05 | |
| *** harlowja has joined #openstack-zaqar | 17:05 | |
| *** AAzza has quit IRC | 17:37 | |
| *** AAzza has joined #openstack-zaqar | 17:39 | |
| *** nadya has joined #openstack-zaqar | 17:47 | |
| *** AAzza has quit IRC | 17:58 | |
| *** AAzza has joined #openstack-zaqar | 17:58 | |
| *** tqtran has joined #openstack-zaqar | 18:03 | |
| *** nadya has quit IRC | 18:05 | |
| *** nadya has joined #openstack-zaqar | 18:06 | |
| *** AAzza has quit IRC | 18:16 | |
| *** AAzza has joined #openstack-zaqar | 18:17 | |
| *** AAzza has quit IRC | 18:23 | |
| *** AAzza has joined #openstack-zaqar | 18:24 | |
| *** AAzza has quit IRC | 18:32 | |
| *** AAzza has joined #openstack-zaqar | 18:33 | |
| *** rbrady-afk is now known as rbrady | 20:26 | |
| *** amoralej is now known as amoralej|off | 20:26 | |
| *** nadya has quit IRC | 20:34 | |
| *** nadya has joined #openstack-zaqar | 20:38 | |
| *** nadya has quit IRC | 20:43 | |
| *** nadya has joined #openstack-zaqar | 21:39 | |
| *** nadya has quit IRC | 21:44 | |
| *** rbrady is now known as rbrady-afk | 22:29 | |
| *** jtomasek has quit IRC | 22:43 | |
| *** jtomasek has joined #openstack-zaqar | 23:12 | |
| *** nadya has joined #openstack-zaqar | 23:40 | |
| *** nadya has quit IRC | 23:44 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!