| shu-mutou | flwang: sure! (^o^)/ | 00:00 |
|---|---|---|
| openstackgerrit | Merged openstack/zaqar-ui: Remove obsolote pot files https://review.openstack.org/323753 | 00:04 |
| shu-mutou | Hi everyone, now we can translate Zaqar-UI on Zanata, please translate Zaqar-UI into your native language!! see also https://wiki.openstack.org/wiki/I18nTeam | 00:26 |
| openstackgerrit | Shu Muto proposed openstack/zaqar-ui: Fix typo https://review.openstack.org/326188 | 00:34 |
| *** jasondotstar has quit IRC | 01:18 | |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Make the notifier max_workers configurable https://review.openstack.org/308443 | 01:18 |
| *** tqtran has quit IRC | 01:19 | |
| *** Qiming_ has joined #openstack-zaqar | 01:34 | |
| flwang | shu-mutou: awesome, thank you :) | 01:41 |
| shu-mutou | flwang: my pleasure. (^o^)/ | 01:44 |
| openstackgerrit | wangxiyuan proposed openstack/python-zaqarclient: Add update queue function in v2 https://review.openstack.org/294368 | 01:45 |
| *** Qiming_ has quit IRC | 01:46 | |
| openstackgerrit | Eva Balycheva proposed openstack/zaqar: Make queues lazy in subscriptions https://review.openstack.org/320749 | 01:47 |
| flwang | wow, two new important patch sets :) | 01:48 |
| Eva-i | =) | 02:02 |
| wxy | june 9-11 is the Chinese Dragon Boat Festival. Wanghao and I will be away from keyboard for 3 days. | 02:14 |
| wxy | flwang: Happy Dragon Boat Festival! | 02:15 |
| flwang | wxy: hah, thanks, are you guys in holiday? | 02:18 |
| openstackgerrit | Merged openstack/zaqar: Show 'age' field in subscriptions (mongodb) https://review.openstack.org/288907 | 02:21 |
| wxy | flwang: from Thursday this week | 02:21 |
| openstackgerrit | Merged openstack/zaqar: Show 'age' field in subscriptions (redis) https://review.openstack.org/288908 | 02:21 |
| flwang | wxy: ah, cool, we have brought some zongzi ;) | 02:25 |
| wxy | flwang: cool. Maybe Eva-i can have a try, zongzi is a kind of delicious chinese festival food. :) | 02:34 |
| flwang | wxy: i'm sure it's hard to get in Russia | 02:35 |
| flwang | Eva-i: wxy: did you guys notice the issue reported by tripleO team? | 02:37 |
| flwang | (04:30:33) jtomasek: Hi, I have a question. I am connecting to a zaqar queue with web client using websockets. After connecting to socket, I authenticate, create queue and subscribe to it. Then when there is more than 10 subscriptions, the messages suddenly stop coming to the client. I can see them by calling zaqar api, but client won't receive them. Anone seen this? | 02:37 |
| wxy | Eva-i: yes, could it be solved by this patch? https://review.openstack.org/#/c/308443/ | 02:39 |
| flwang | wxy: nope, i don't think they're related | 02:41 |
| flwang | in other words, even there is only 1 or 2 workers, it should work | 02:41 |
| flwang | if it's a bug, then i don't think adding more workers is the solution | 02:41 |
| wxy | flwang: Eva-i: OK, I'll look into it today. | 02:45 |
| openstackgerrit | Merged openstack/zaqar: Make the notifier max_workers configurable https://review.openstack.org/308443 | 02:45 |
| flwang | wxy: i'm trying to reproduce it and will update status here if there is any progress | 02:45 |
| flwang | just a reminder since it may block tripleO's work | 02:46 |
| Eva-i | flwang: wxy: I know a restaurant nearby filled with chineze people. Maybe there I can find zongzi here. =) | 02:46 |
| Eva-i | wxy: I haven't inspected this problem, may look tomorrow | 02:46 |
| Eva-i | wxy: would be glad if you find something today | 02:47 |
| wxy | Eva-i: If you can't find one. I can send you some by international express.:) | 02:47 |
| wxy | Eva-i: flwang: OK, I'm try to reprodcue now. | 02:48 |
| *** pcaruana has joined #openstack-zaqar | 04:11 | |
| *** pcaruana has quit IRC | 04:24 | |
| *** pcaruana has joined #openstack-zaqar | 04:34 | |
| *** pcaruana has quit IRC | 04:40 | |
| *** GB21 has joined #openstack-zaqar | 04:53 | |
| flwang | wxy: any progress? | 04:54 |
| *** flwang1 has quit IRC | 05:00 | |
| *** GB21 has quit IRC | 05:12 | |
| flaper87 | flwang: hey, apparently there are some issues in liberty with Zaqar because it's installing latest falcon | 05:20 |
| flaper87 | http://logs.openstack.org/periodic-stable/periodic-zaqar-python27-liberty/2a60d92/console.html | 05:20 |
| *** pt_15 has quit IRC | 05:26 | |
| *** itisha has quit IRC | 05:30 | |
| *** GB21 has joined #openstack-zaqar | 05:31 | |
| *** rcernin has joined #openstack-zaqar | 05:36 | |
| wxy | flwang: I can't reproduce. I set max_notifier_workers=2, created 12 subscriptions for a queue. Then pose some messages to the queue. But everything works well. | 06:14 |
| wxy | flwang: used websocket | 06:16 |
| wxy | flwang: jomasek: I need more detail, a bug description on launchpd is better. | 06:17 |
| wxy | flaper87: https://review.openstack.org/#/c/320190/ I guess this patch could solve the problem. | 06:23 |
| flaper87 | wxy: looking | 06:27 |
| flaper87 | wxy: I don't think it will, tbh. I think the open cap on falcon's requirement is the issue | 06:27 |
| wxy | flaper87: emm, we fixed the falcon's issue at master branch by this patch: https://review.openstack.org/#/c/318529/ then should we cherry-pick it to liberty? or just update the liberty's requirement? | 06:30 |
| flaper87 | wxy: lemme try to backport it | 06:30 |
| flaper87 | wxy: did we backport that one to mitaka? | 06:31 |
| flaper87 | yeah, it's invasive | 06:31 |
| flaper87 | I'd prolly just cap it | 06:31 |
| wxy | flaper87: No, the only patch for mitaka is https://review.openstack.org/#/c/320193/ | 06:34 |
| flaper87 | wxy: I approved the one for liberty | 06:35 |
| *** jtomasek has joined #openstack-zaqar | 06:48 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/zaqar-ui: Imported Translations from Zanata https://review.openstack.org/326264 | 07:09 |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Clean the auth app after authentication failure https://review.openstack.org/326272 | 07:31 |
| *** mpanetta has joined #openstack-zaqar | 08:09 | |
| *** mpanetta has quit IRC | 08:13 | |
| *** tesseract has joined #openstack-zaqar | 08:50 | |
| openstackgerrit | wanghao proposed openstack/zaqar: Fix fail of getting claim after claim expire(Redis) https://review.openstack.org/326287 | 09:06 |
| therve | jtomasek, FWIW I tested 10 subscription over websocket and it seems to work fine for me | 09:41 |
| therve | jtomasek, Do you have a simple reproducer? | 09:41 |
| jtomasek | therve: I don't unfortunately. I'll try to provide one, eventually. Can you test more than 10, my webclient stops receiving messages when the subscriptions count is 11 and more | 09:42 |
| therve | jtomasek, Right I mean for than 10 | 09:43 |
| therve | jtomasek, At that point you don't get any message at all, or not just the > 10 ones? | 09:43 |
| jtomasek | therve: ok, do you have a code example which you're using? I am doing this: https://review.openstack.org/#/c/319070/9/src/js/services/ZaqarWebSocketService.js | 09:44 |
| therve | Ah, hum | 09:45 |
| *** AAzza has quit IRC | 09:45 | |
| therve | jtomasek, Do you use a browser as client? | 09:45 |
| jtomasek | therve: at that point I don't receive any messages at all (except for the messages from zaqar saying that authentication, queue creation and subscription has been created) | 09:45 |
| jtomasek | therve: yes | 09:45 |
| therve | jtomasek, it looks like this lib may create a connection per queue, no? | 09:45 |
| *** AAzza has joined #openstack-zaqar | 09:46 | |
| jtomasek | therve: init is used only once in the client lifetime (precisely when user logs in with keystone) | 09:46 |
| therve | Okay | 09:46 |
| therve | I use a python client FWIW | 09:46 |
| jtomasek | therve: if there is another instance of the client the client will create it's own connection, create/connec to queue, subscribe and will receive the same messages, so all client instances are in sync | 09:47 |
| therve | jtomasek, I was just wondering if you opened 10 connections to zaqar from the brower you may hit some limit | 09:48 |
| jtomasek | therve: I wonder how I could debug why the client does not receive the message. But I can safely say it starts happening when there is 11 and more subscriptions | 09:48 |
| jtomasek | therve: is it possible to list connections somehow? | 09:48 |
| therve | jtomasek, netstat on the server? | 09:49 |
| jtomasek | therve: hmm, only case I can think of is that if browser refreshed, the original connection would not terminate, but it seems improbable to me | 09:51 |
| therve | jtomasek, http://paste.openstack.org/show/508568/ is the script I used | 09:54 |
| *** shu-mutou is now known as shu-mutou-AFK | 09:54 | |
| therve | jtomasek, Also, do you use zaqar master? | 09:56 |
| *** AAzza has quit IRC | 09:57 | |
| jtomasek | therve: not master, It is version from RDO, ti believe it is mitaka based | 09:57 |
| therve | Okay | 09:58 |
| jtomasek | therve: anything to watch out for? | 09:58 |
| therve | jtomasek, The number 10 may come from https://github.com/openstack/zaqar/blob/master/zaqar/notification/notifier.py#L36 | 09:58 |
| therve | Though it shouldn't and doesn't from my test | 09:58 |
| jtomasek | therve: I'll try to play with worker count and see if the behavior changes | 10:00 |
| therve | jtomasek, Note that this flag is not available in mitaka, you'll need to change the code | 10:01 |
| *** AAzza has joined #openstack-zaqar | 10:01 | |
| jtomasek | therve: yeah, looking at the code now, it still has TODO in it | 10:01 |
| therve | jtomasek, Let me know if there is anything I can try too | 10:05 |
| jtomasek | therve: thanks! | 10:05 |
| jtomasek | therve: is there a docs for message actions I can send from client? | 10:26 |
| *** mdnadeem_ has joined #openstack-zaqar | 10:28 | |
| *** mdnadeem has quit IRC | 10:31 | |
| *** GB21 has quit IRC | 10:45 | |
| *** GB21 has joined #openstack-zaqar | 10:52 | |
| *** GB21 has quit IRC | 12:23 | |
| openstackgerrit | Flavio Percoco proposed openstack/zaqar: Move CLI options to cmd.server https://review.openstack.org/326421 | 12:25 |
| *** AAzza_ has joined #openstack-zaqar | 12:28 | |
| *** AAzza- has joined #openstack-zaqar | 12:29 | |
| *** AAzza has quit IRC | 12:30 | |
| *** AAzza_ has quit IRC | 12:32 | |
| therve | jtomasek, Not that I know about. https://github.com/openstack/zaqar/blob/master/zaqar/api/v1/request.py#L33 contains the actions | 12:33 |
| *** AAzza- has quit IRC | 12:34 | |
| therve | Plus what's in v2 | 12:34 |
| *** AAzza has joined #openstack-zaqar | 12:34 | |
| *** Ravikiran_K has joined #openstack-zaqar | 12:54 | |
| *** ametts has joined #openstack-zaqar | 13:53 | |
| *** mpanetta has joined #openstack-zaqar | 13:56 | |
| *** mpanetta has quit IRC | 13:56 | |
| *** mpanetta has joined #openstack-zaqar | 13:57 | |
| jtomasek | therve: thanks | 14:07 |
| *** mpanetta_ has joined #openstack-zaqar | 14:20 | |
| *** mpanetta has quit IRC | 14:20 | |
| *** mpanetta_ is now known as mpanetta | 14:22 | |
| jtomasek | wxy: Hi, thanks for a review, I've been following this example http://git.openstack.org/cgit/openstack/zaqar/tree/samples/javascript/websocket.html and it does not specify subscriber either. looking at the code https://github.com/openstack/zaqar/commit/13ffa248a19e3b1062f6025fb2dc8f8293abf8b7 I am not much smarter about what subscriber is... | 14:31 |
| therve | jtomasek, IIRC, on websocket subscriber is the connection itself by default | 14:54 |
| wxy | jtomasek: thanks for the link. | 14:59 |
| therve | https://github.com/openstack/zaqar/blob/master/zaqar/api/handler.py#L52 there you go | 15:01 |
| wxy | jtomasek: subscriber is the destination where the messages notify to. | 15:01 |
| wxy | therve: Thanks. I missed it. | 15:01 |
| therve | That's somewhat a trick | 15:02 |
| *** rcernin has quit IRC | 15:17 | |
| *** itisha has joined #openstack-zaqar | 15:20 | |
| *** GB21 has joined #openstack-zaqar | 15:45 | |
| jtomasek | therve: this is how I can reproduce my issue: http://paste.openstack.org/show/508707/ | 15:54 |
| jtomasek | therve: 2 clients, create 11 subscriptions by running and closing the first script. check subscriptions count by 'openstack subscription list tripleo --limit 20' | 15:55 |
| jtomasek | therve: then run the first script and second script to send a message. the first one will not receive any message | 15:56 |
| jtomasek | therve: if you delete the subscriptions to get less than 11 subscriptions, the runng clients will immediately start receiving incoming messages again | 15:57 |
| *** GB21 has quit IRC | 16:01 | |
| *** tesseract has quit IRC | 16:13 | |
| *** flwang1 has joined #openstack-zaqar | 16:58 | |
| flwang1 | flaper87: around? | 17:09 |
| therve | jtomasek, Cool, will have a look | 18:20 |
| *** ametts has quit IRC | 18:27 | |
| flwang1 | therve: can you show me the the chat log between jtomasek and you? | 18:27 |
| flwang1 | i'm working on the issue reported by jtomasek yesterday | 18:27 |
| jtomasek | <jtomasek> therve: this is how I can reproduce my issue: http://paste.openstack.org/show/508707/ | 18:27 |
| jtomasek | <jtomasek> therve: 2 clients, create 11 subscriptions by running and closing the first script. check subscriptions count by 'openstack subscription list tripleo --limit 20' | 18:27 |
| jtomasek | <jtomasek> therve: then run the first script and second script to send a message. the first one will not receive any message | 18:27 |
| jtomasek | <jtomasek> therve: if you delete the subscriptions to get less than 11 subscriptions, the runng clients will immediately start receiving incoming messages again | 18:27 |
| therve | flwang, http://eavesdrop.openstack.org/irclogs/%23openstack-zaqar/latest.log.html | 18:28 |
| flwang1 | cool, thanks | 18:28 |
| jtomasek | flwang, therve: sorry that script is not very nice, but does the job | 18:29 |
| flwang1 | jtomasek: no problem. so what's the zaqar version you're using? | 18:30 |
| flwang1 | master? | 18:30 |
| flwang1 | jtomasek: and can you reproduce it with wsgi? | 18:31 |
| jtomasek | flwang: openstack-zaqar package from here: http://trunk.rdoproject.org/centos7/current-passed-ci/ | 18:32 |
| jtomasek | flwang: not sure if it is helpful | 18:32 |
| jtomasek | flwang1: I am not that knowlegeable about zaqar, so I am not sure how to reproduce it using wsgi | 18:33 |
| *** Ravikiran_K has quit IRC | 18:34 | |
| flwang1 | jtomasek: ok, it's master branch | 18:35 |
| *** Eva-i has quit IRC | 18:36 | |
| flwang1 | jtomasek: so you start two processes of your script http://paste.openstack.org/show/508707/ | 18:36 |
| *** Eva-i has joined #openstack-zaqar | 18:36 | |
| *** Eva-i has quit IRC | 18:36 | |
| flwang1 | with ws_test.py, you created 11 subscriptions | 18:37 |
| flwang1 | then stop it | 18:37 |
| *** Eva-i has joined #openstack-zaqar | 18:37 | |
| *** Eva-i has quit IRC | 18:37 | |
| *** Eva-i has joined #openstack-zaqar | 18:37 | |
| jtomasek | flwang: I've updated the scripts here: http://paste.openstack.org/show/508744/ | 18:38 |
| jtomasek | flwang: the first script creates the connection and subscription 10 times and closes the connection every time. then it connects (11th time) and stays connected | 18:39 |
| jtomasek | flwang: the second script then just sends the message to the same queue | 18:39 |
| jtomasek | flwang: the first script should receive that message, but does not | 18:39 |
| flwang1 | and it works if the subscription's number < 11? | 18:40 |
| jtomasek | yes | 18:40 |
| *** ametts has joined #openstack-zaqar | 18:40 | |
| flwang1 | jtomasek: cool, then it should be related to the max workers, but i don't understand why | 18:41 |
| jtomasek | if some of those stays connected (e.g. I have my webclient as one of the first 10 subscriptions, then it receives the message fine, just not the 11 and up subscriptor | 18:41 |
| flwang1 | jtomasek: would you mind opening a bug to track it? | 18:41 |
| jtomasek | flwang: I can, but I've tried to lowe the number of max workers to 5 and the behavior was the same | 18:41 |
| jtomasek | 11th was not workning | 18:41 |
| flwang1 | ha, interesting | 18:42 |
| jtomasek | flwang: if you then remove some subscription using 'openstack subscription delete tripleo <subs_id> then the originally eleventh starts working again | 18:42 |
| jtomasek | flwang: problem is that the subscription is not removed when the connection is closed. there is no way I can do that on browser refresh. Imo it needs to be done on server side - detect that connection has closed and remove that subscription too | 18:43 |
| jtomasek | flwang: or maybe there is more sofisticated solution, I am not sure | 18:43 |
| jtomasek | flwang: interesting discussion on the topic is here http://stackoverflow.com/questions/4812686/closing-websocket-correctly-html5-javascript | 18:44 |
| jtomasek | flwang: I'll open the bug tomorrow morning | 18:46 |
| flwang1 | jtomasek: yep, i see. that's a known issue. the subscription can't be deleted after refresh | 18:46 |
| flwang1 | but i don't understand why the old connection will impact the others | 18:46 |
| flwang1 | jtomasek: is it possible to create a subscription with a known subscriber in your case? | 18:47 |
| jtomasek | flwang: I probably don't fully understand the subscriber concept, but if you tell me what would be the subscriber in my code, I can try to pass it to queue_subscribe message https://review.openstack.org/#/c/319070/9/src/js/services/ZaqarWebSocketService.js | 18:49 |
| flwang1 | jtomasek: generally, subscriber could be a url | 18:50 |
| jtomasek | flwang1: oh, I see it now it is in the subscription list | 18:53 |
| jtomasek | flwang1: is this going to change anything? I'll still need to generate unique subscriber for every browser refresh | 18:53 |
| flwang1 | jtomasek: yes, if you don't specify the subscriber in websocket, zaqar will use the default connection string/url | 18:54 |
| flwang1 | jtomasek: yep, but that means you know what's the subscriber and then in close() you can delete the subscription | 18:54 |
| jtomasek | flwang1: because if I wouldn't then if user opened the web client twice in 2 tabs for example, then the subscriber would be the same... hmm I wonder if it is a problem or not | 18:54 |
| flwang1 | though we still need to figure out why the 11th doesn't work | 18:54 |
| flwang1 | jtomasek: i can see your point | 18:55 |
| jtomasek | flwang1: I see | 18:55 |
| flwang1 | ok, we still need to figure out what's the magic 10 or 11 | 18:55 |
| jtomasek | flwang1: I'll try the subscriber workaround in the meantime | 18:56 |
| flwang1 | maybe it's a default max connection number of the websocket lib using in zaqar | 18:56 |
| flwang1 | jtomasek: keep in touch | 18:56 |
| jtomasek | flwang1: maybe, but the problem must come from the subscriptions, because I am sure that the connection count is less than 10 | 18:56 |
| jtomasek | flwang1: something probably thinks that the old connections are still active because their subscriptions still exist | 18:57 |
| jtomasek | :) | 18:57 |
| flwang1 | jtomasek: oh, so you mean even the coonnection's number less than 10, you will still see the issue? | 18:57 |
| jtomasek | flwang: see the script. I open, subscribe and close 10 connections. I expect that the result is 0 connections and 10 obsolete but still existent subscriptions | 18:58 |
| jtomasek | flwang: then I create 11th connection and subscription and leave that open | 18:59 |
| jtomasek | flwang: then I send a message. the only running connected client (11th subscriber) never receives the message | 18:59 |
| flwang1 | jtomasek: i see | 19:00 |
| jtomasek | when subscriptions number lower (they timeout or are removed manually), then the 11th subscriber will start receiving messages | 19:01 |
| jtomasek | flwang: so it seems that only 10 subscriptions per queue are possible. that is fine, but the subscriptions without connection need to get removed because otherwise they block the communication | 19:02 |
| flwang1 | jtomasek: so if there are more than 11 subscriptions and all of them are active, we will see run into problems | 19:03 |
| flwang1 | that said, we still need to figure out what's the root cause, and yes, we need to detect the websocket close request can remove the subscription on server side | 19:03 |
| jtomasek | flwang: if by active you mean existent then yes (with or without connection) | 19:04 |
| jtomasek | sounds good, thanks! I'll try to cover it in bug report tomorrow | 19:05 |
| flwang1 | jtomasek: cool, thank you | 19:07 |
| flwang1 | jtomasek: btw, i'm opening the bug | 19:07 |
| jtomasek | flwang: even better | 19:07 |
| flwang1 | and will add you as subscriber, feel free add comments | 19:07 |
| jtomasek | ok | 19:07 |
| flwang1 | jtomasek: thank you | 19:08 |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Add release notes https://review.openstack.org/326704 | 19:11 |
| therve | flwang1, jtomasek https://github.com/openstack/zaqar/blob/master/zaqar/storage/base.py#L37 | 19:18 |
| therve | Sadness | 19:18 |
| jtomasek | dang | 19:19 |
| flwang1 | therve: why will it impact? | 19:19 |
| therve | flwang1, Because that's the default limit when we do a list | 19:20 |
| jtomasek | hm, isn't it just for listing the subscriptions? | 19:20 |
| flwang1 | therve: ah | 19:20 |
| flwang1 | i see | 19:20 |
| therve | Yeah we list them when we notify a queue | 19:20 |
| therve | https://github.com/openstack/zaqar/blob/master/zaqar/notification/notifier.py#L43 | 19:20 |
| jtomasek | aha | 19:21 |
| flwang1 | https://github.com/openstack/zaqar/blob/master/zaqar/notification/notifier.py#L43 | 19:21 |
| flwang1 | jtomasek: you will get a quick fix | 19:21 |
| flwang1 | therve: thanks for the heads up | 19:21 |
| flwang1 | but yep, we still need to fix the subscription delete issue | 19:22 |
| flwang1 | when the connection closed | 19:22 |
| jtomasek | flwang1: max limit is 20, right? that will help just a bit | 19:22 |
| jtomasek | yeah | 19:22 |
| flwang1 | jtomasek: we will provide a way to get all | 19:22 |
| flwang1 | for sure :) | 19:22 |
| jtomasek | flwang: ah, cool | 19:22 |
| jtomasek | :) | 19:22 |
| jtomasek | thank you both! | 19:24 |
| flwang1 | jtomasek: no problem, shame for the bug :D | 19:24 |
| * flwang1 is thinking to nominate therve as Zaqar core again | 19:25 | |
| flwang1 | or a Honorary Zaqar Core degree to therve | 19:26 |
| flwang1 | if he refused :) | 19:26 |
| openstackgerrit | Thomas Herve proposed openstack/zaqar: WIP: Fix subscription limit per queue https://review.openstack.org/326710 | 19:28 |
| therve | I wouldn't :) | 19:28 |
| therve | jtomasek, ^^^ I think that should do the trick | 19:29 |
| jtomasek | therve: thanks, will test it as first thing tomorrow | 19:30 |
| flwang1 | therve: i prefer to use limit=0 | 19:35 |
| flwang1 | therve: would you mind me posting patch set on your patch? | 19:35 |
| therve | flwang1, Kinda? :) | 19:35 |
| therve | I mean if you're going to put limit=0 you can recreate one patch | 19:36 |
| flwang1 | therve: ok, i will add comments :D | 19:36 |
| flwang1 | i'm investigating if redis respect limit=0 and i'm sure it's not :) | 19:37 |
| flwang1 | with that, you may need a small change in redis driver https://github.com/openstack/zaqar/blob/master/zaqar/storage/redis/subscriptions.py#L70 | 19:39 |
| flwang1 | and we need a follow up patch to support this for all the other resources | 19:39 |
| openstackgerrit | Thai Tran proposed openstack/zaqar-ui: Ability to add and remove subscriptions https://review.openstack.org/311852 | 19:41 |
| therve | If that's the case, that reinforces me into thinking my approach is better :) | 19:50 |
| *** tqtran has joined #openstack-zaqar | 19:51 | |
| flwang1 | hmm... limit=0 maybe not the good idea | 19:56 |
| flwang1 | if there are too much subscriptions | 19:56 |
| flwang1 | maybe a bigger limit per page | 19:56 |
| therve | That just pushes the problem though | 19:57 |
| flwang1 | therve: ok, are you going to add an unit test today? i would like to merge it asap | 19:58 |
| therve | Not tonight no | 19:58 |
| flwang1 | therve: mind me adding it? | 19:59 |
| therve | Not at all :) | 19:59 |
| flwang1 | therve: awesome | 19:59 |
| flwang1 | i will send the core nomination letter tomorrow | 19:59 |
| openstackgerrit | Merged openstack/zaqar-ui: Fix typo https://review.openstack.org/326188 | 20:11 |
| openstackgerrit | Merged openstack/python-zaqarclient: Add update queue function in v2 https://review.openstack.org/294368 | 20:17 |
| *** mpanetta has quit IRC | 21:50 | |
| openstackgerrit | Merged openstack/zaqar-ui: Imported Translations from Zanata https://review.openstack.org/326264 | 22:15 |
| *** itisha has quit IRC | 22:30 | |
| *** ametts has quit IRC | 22:30 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!