| *** achanda has quit IRC | 00:02 | |
| *** kgriffs is now known as kgriffs|afk | 00:03 | |
| openstackgerrit | Victoria MartÃnez de la Cruz proposed openstack/zaqar: Update json schema for API v1_1 https://review.openstack.org/148414 | 00:37 |
|---|---|---|
| openstackgerrit | Flavio Percoco proposed openstack/zaqar: Adds message processing to WebSockets driver https://review.openstack.org/144803 | 00:52 |
| *** achanda has joined #openstack-zaqar | 00:56 | |
| *** akanksha has quit IRC | 01:07 | |
| *** amitgandhinz has joined #openstack-zaqar | 01:23 | |
| *** amitgandhinz has quit IRC | 01:28 | |
| *** amitgandhinz has joined #openstack-zaqar | 01:29 | |
| *** amitgandhinz has quit IRC | 02:29 | |
| *** boris-42 has quit IRC | 02:52 | |
| *** achanda has quit IRC | 03:19 | |
| *** achanda has joined #openstack-zaqar | 03:19 | |
| *** achanda has quit IRC | 03:24 | |
| *** achanda has joined #openstack-zaqar | 03:36 | |
| *** achanda has quit IRC | 03:40 | |
| *** reed has quit IRC | 05:06 | |
| *** exploreshaifali has joined #openstack-zaqar | 07:11 | |
| *** echevemaster has quit IRC | 07:13 | |
| *** achanda has joined #openstack-zaqar | 07:33 | |
| *** exploreshaifali has quit IRC | 07:47 | |
| *** akanksha has joined #openstack-zaqar | 07:59 | |
| *** achanda has quit IRC | 08:02 | |
| *** achanda has joined #openstack-zaqar | 08:17 | |
| *** achanda has quit IRC | 08:38 | |
| *** chandankumar has joined #openstack-zaqar | 08:39 | |
| *** achanda has joined #openstack-zaqar | 08:43 | |
| *** achanda has quit IRC | 08:56 | |
| *** chandankumar has quit IRC | 09:25 | |
| *** exploreshaifali has joined #openstack-zaqar | 09:25 | |
| *** akanksha has quit IRC | 10:27 | |
| *** boris-42 has joined #openstack-zaqar | 12:50 | |
| *** exploreshaifali has quit IRC | 13:30 | |
| *** pcaruana has joined #openstack-zaqar | 13:55 | |
| *** akanksha has joined #openstack-zaqar | 14:06 | |
| *** exploreshaifali has joined #openstack-zaqar | 15:38 | |
| akanksha | Hello. | 15:40 |
| exploreshaifali | akanksha, hello | 15:43 |
| exploreshaifali | what's up? | 15:43 |
| akanksha | Hey | 15:46 |
| *** ekarlso has quit IRC | 15:50 | |
| *** ekarlso has joined #openstack-zaqar | 15:50 | |
| akanksha | I have been trying to work on the redis uuid validation bug | 15:52 |
| akanksha | I have a doubt regarding the function calls | 15:52 |
| akanksha | So whenever the functions which use messageids and client_ids and claims are called are they called as keyword arguments or as positional arguments | 15:53 |
| exploreshaifali | akanksha, please can you give me link of code/function/method you are talking about | 16:02 |
| akanksha | https://github.com/openstack/zaqar/blob/master/zaqar/storage/redis/messages.py#L372 | 16:03 |
| akanksha | Some function like this? | 16:03 |
| exploreshaifali | akanksha, in that method - queue and mehtod_id will be passed as positional args | 16:04 |
| exploreshaifali | like --> .get('queue', 'msg_id') | 16:04 |
| exploreshaifali | then *project* is optional argument | 16:05 |
| exploreshaifali | if we want we can pass its value in any of the 2 ways: | 16:05 |
| exploreshaifali | .get('q', 'm', 'p') or .get('q', 'm', project='p') | 16:06 |
| akanksha | Hmm. Okay. That complicates things a bit for me. Lemme see what I can do with this | 16:06 |
| exploreshaifali | akanksha, is that waht you are asking? | 16:06 |
| akanksha | Yeah thats what I was asking | 16:06 |
| exploreshaifali | akanksha, it depends on method/function declaration(signature) wether they should be called as keyword args or as positional args | 16:07 |
| akanksha | Oh I just found something new that I can use as a workaround. I needed the names of the parameters that I use in a function so I am going to use the inspect module now | 16:08 |
| *** reed has joined #openstack-zaqar | 16:16 | |
| *** chandankumar has joined #openstack-zaqar | 16:28 | |
| *** boris-42 has quit IRC | 16:32 | |
| *** chandankumar has quit IRC | 16:38 | |
| *** pcaruana has quit IRC | 16:38 | |
| *** chandankumar has joined #openstack-zaqar | 16:53 | |
| *** chandankumar has quit IRC | 17:01 | |
| *** reed has quit IRC | 17:09 | |
| *** exploreshaifali has quit IRC | 17:26 | |
| *** achanda has joined #openstack-zaqar | 18:21 | |
| *** exploreshaifali has joined #openstack-zaqar | 18:41 | |
| *** achanda has quit IRC | 19:22 | |
| *** achanda has joined #openstack-zaqar | 20:11 | |
| *** achanda has quit IRC | 20:32 | |
| akanksha | vkmc, there? | 20:46 |
| akanksha | exploreshaifali, ping? | 20:55 |
| exploreshaifali | akanksha, pong! | 20:57 |
| akanksha | I wrote a decorator which could possibly solve this bug and I want to improve it. https://bugs.launchpad.net/zaqar/+bug/1367024 | 20:59 |
| openstack | Launchpad bug 1367024 in zaqar "Redis driver doesn't explicitly validate UUIDs" [Low,Confirmed] - Assigned to Doraly Navarro (doralynavarro) | 20:59 |
| akanksha | Can you help me out? | 21:00 |
| akanksha | I am not sure I followed the design principles as required by zaqar | 21:00 |
| * exploreshaifali looking at bug | 21:00 | |
| akanksha | https://www.irccloud.com/pastebin/39jWURbd/test.py | 21:01 |
| exploreshaifali | akanksha, that bug is assigned to Doraly Navarro, have you talked to her? | 21:03 |
| akanksha | Yeah. She said she is not working on it | 21:03 |
| exploreshaifali | ok | 21:03 |
| exploreshaifali | please can you tell me in which file you are making this modification? | 21:04 |
| akanksha | I havent made the modification yet because I am not sure of where to put this. This is my test. I will have to make changes in several files. Since its a decorator I am guessing it will have go here https://github.com/openstack/zaqar/blob/master/zaqar/common/decorators.py | 21:06 |
| akanksha | Then since I need an error it will go here https://github.com/openstack/zaqar/blob/master/zaqar/common/errors.py | 21:06 |
| *** achanda has joined #openstack-zaqar | 21:07 | |
| akanksha | It was supposed to be used as a function decorator around functions that use client | 21:07 |
| akanksha | _id message_id and claim as arguments so basically it will be wrapped around functions like these in the redis driver | 21:07 |
| akanksha | https://github.com/openstack/zaqar/blob/master/zaqar/storage/redis/messages.py#L372 | 21:08 |
| akanksha | Thats all that I assumed. | 21:08 |
| akanksha | Please correct me wherever I have gone wrong | 21:09 |
| exploreshaifali | akanksha, as per the files that need modification llike decorator.py and errors.py that seems correct to me | 21:11 |
| akanksha | okay :) | 21:11 |
| exploreshaifali | then about the logic you put in the new decorator you wrote, I am also not sure about it | 21:12 |
| akanksha | Hmm | 21:12 |
| exploreshaifali | but lets discuss about it line by line | 21:12 |
| akanksha | Okay so I started by getting all the argument names and values and putting them into a dictionary. | 21:13 |
| exploreshaifali | so if we are using that decorator for function wit signature - *def get(self, queue, message_id, project=None)* | 21:13 |
| exploreshaifali | yes so inside frame we will have - {'self':'self_value, 'queue':'queue_value' and so on}? | 21:14 |
| akanksha | yeah so when the function is called it will make a dictionary like {'self':something , 'queue':something , 'message_id' : something etc} and store it in variable argval | 21:14 |
| akanksha | then the next part will go through the pre-made list of uuid type arguments that exist in the code and then it will verify only those | 21:15 |
| exploreshaifali | akanksha, it looks correct to me | 21:16 |
| akanksha | yay :) So should I implement it in all the files that i talked about. Also I was planning that the error message that I will give will be something like "(argument that went wrong) is an invalid uuid type" and thats what i ll add in the errors file. | 21:18 |
| exploreshaifali | akanksha, yes | 21:20 |
| exploreshaifali | but are you sure how to access frame that you have defined in decorator? as per https://docs.python.org/2/library/inspect.html#inspect.getargspec it says the getargsspec will return tuple | 21:21 |
| exploreshaifali | and you are accessing it as - frame.args[i] | 21:21 |
| akanksha | I will try it out first. I did try it out with normal numbers | 21:22 |
| akanksha | frame.arg is a list | 21:22 |
| exploreshaifali | if it is working with dumy values that its fine :) | 21:23 |
| exploreshaifali | frame is a tuple? | 21:23 |
| akanksha | yeah frame is a tuple with (args, varargs, keywords, defaults) | 21:24 |
| akanksha | Each of these are lists which can be accessed by names frame.args frame.defaults etc | 21:24 |
| exploreshaifali | yeh so how can you access a tuple with "." | 21:24 |
| akanksha | I dont know but its working that way. | 21:25 |
| exploreshaifali | rather it should be frame[0][i] | 21:25 |
| akanksha | Lemme check that out once more | 21:25 |
| exploreshaifali | hahaha | 21:25 |
| exploreshaifali | yup and also check it with frame[0][i] | 21:25 |
| akanksha | https://www.irccloud.com/pastebin/XuIEAQWB | 21:25 |
| akanksha | This is what it returns | 21:26 |
| akanksha | Its some sort of an object | 21:26 |
| akanksha | :\ | 21:26 |
| akanksha | I gave the function as func(a,b,c=2,d=3,e=5) | 21:26 |
| exploreshaifali | so let it be, if it is working | 21:28 |
| exploreshaifali | though I think others can have some better idea to achieve same | 21:29 |
| exploreshaifali | but for now its better to move forward | 21:29 |
| akanksha | Okay so I'll make the changes and get back to you with updates | 21:29 |
| akanksha | ? | 21:29 |
| exploreshaifali | akanksha, yup :) | 21:30 |
| akanksha | thanks a lot :) | 21:30 |
| akanksha | BTW I also had a question about Outreachy. | 21:30 |
| akanksha | I want to work on the zaqar api conversion from v1 to v1.1 project | 21:31 |
| akanksha | So I need to discuss the project before I can write a proposal | 21:31 |
| exploreshaifali | okay | 21:31 |
| exploreshaifali | yes of course | 21:33 |
| exploreshaifali | and you are lucky - vkmc is the mentor | 21:33 |
| exploreshaifali | :D | 21:33 |
| *** achanda has quit IRC | 21:33 | |
| exploreshaifali | akanksha, discuss with her all doubts you have | 21:33 |
| akanksha | Okay, :) | 21:33 |
| *** achanda has joined #openstack-zaqar | 21:34 | |
| akanksha | And any general advice you can give me having been an applicant before? | 21:34 |
| exploreshaifali | and since saturday and sunday its weekend.... so till than you can cover other parts of application | 21:34 |
| akanksha | vkmc wont be available for the weekend? | 21:34 |
| *** achanda has quit IRC | 21:34 | |
| exploreshaifali | akanksha, just keep digging, don't stop in between | 21:35 |
| exploreshaifali | no, no one will | 21:35 |
| akanksha | Oh. Okay. So till then I will concentrate on the bug | 21:35 |
| exploreshaifali | we should respect their personal lives as well! | 21:35 |
| akanksha | :) | 21:35 |
| exploreshaifali | yes! | 21:35 |
| akanksha | Yeah right :) | 21:35 |
| exploreshaifali | akanksha, thank you! | 21:35 |
| akanksha | Actually thank you :) | 21:36 |
| exploreshaifali | :) | 21:36 |
| exploreshaifali | np | 21:36 |
| *** exploreshaifali has quit IRC | 21:48 | |
| *** achanda has joined #openstack-zaqar | 22:03 | |
| *** achanda has quit IRC | 22:08 | |
| *** achanda has joined #openstack-zaqar | 22:39 | |
| *** achanda has quit IRC | 22:47 | |
| *** achanda has joined #openstack-zaqar | 23:01 | |
| *** achanda has quit IRC | 23:47 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!